New icon view

[Gilles Caulier-4]

> 32) A tag "Test 3" has exactly two images assigned.
>        Go to tags view and select this tag. Two images are shown, the counter is 2.
>        Delete one of them to trash. Shortly afterwards, one image is shown,
>        the counter is 1.

No, it doesn't work. it still 2 items in counter from Tags folder view
from the left and right side panels. Restarting digiKam fix the
problem.

When deletion is done, i can see these messages :

digikam(12484)/digikam (core) Digikam::DeleteDialog::accept:
setShowTrashDeleteDialog  true
digikam(12484)/digikam (core)
Digikam::AlbumManager::slotKioFilesAdded:
"/mnt/data/.Trash-500/files/IMG_2266.JPG"
digikam(12484)/digikam (core) Digikam::AlbumManager::slotKioFileMoved:
"file:///mnt/data/photo/test/IMG_2266.JPG" "trash:/IMG_2266.JPG"
digikam(12484) Digikam::AlbumManager::handleKioNotification:
KDirNotify detected file change at "/mnt/data/photo/test"
digikam(12484)/digikam (core)
Digikam::AlbumManager::slotKioFilesAdded: "trash:/"
digikam(12484)/digikam (core)
Digikam::AlbumManager::slotKioFilesDeleted:
("file:///mnt/data/photo/test/IMG_2266.JPG")
digikam(12484) Digikam::AlbumManager::handleKioNotification:
KDirNotify detected file change at "/mnt/data/photo/test"
digikam(12484)/digikam (core)
Digikam::AlbumManager::slotDirWatchDirty: KDirWatch detected change at
"/mnt/data/photo"
digikam(12484)/digikam (core)
Digikam::AlbumManager::slotDirWatchDirty: KDirWatch detected change at
"/mnt/data/photo/test"
timeChanged

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

> 8) Go to an album containing at least one JPEG and at least one PNG file.
>  Click on the thumbnail of the first image (a JPEG) to show the preview.
>  Now change imagetype filter to PNG.
>        -> a PNG image should be shown as preview
>  Now change imagetype filter to JPEG
>        -> the first image should be selected again.
>  Change filter to PNG. Change filter to All Files.
>        -> PNG should remain selected, but all images are found in thumbnail bar.

All work fine for this one here...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

> 31) Consider these albums:
>        Test Empty
>                \- Test 1
>                \- Test 2
>        "Test Empty" contains no pictures.
>        "Test 1" contains one image rated with one stars
>        "Test 2" contains one image rated with one star.
>        Recursive listing of albums is enabled.
>        Select "Test 2". Set rating filter to "Two stars"
>                -> empty view. LED red
>        Select "Empty"
>                -> one image from Test 1 shown. LED green.

Well it's impossible if :

>        "Test 1" contains one image rated with _one_ stars         <====
>        "Test 2" contains one image rated with one star.

If i set "Test 1" image with 2 stars, yes, it work... (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Wednesday 03 June 2009 21:22:33 Marcel Wiesweg wrote:
> 8) Go to an album containing at least one JPEG and at least one PNG file.
>   Click on the thumbnail of the first image (a JPEG) to show the preview.
>   Now change imagetype filter to PNG.
> -> a PNG image should be shown as preview
>  Now change imagetype filter to JPEG
> -> the first image should be selected again.
>   Change filter to PNG. Change filter to All Files.
> -> PNG should remain selected, but all images are found in thumbnail bar.

Seems to work now... I don't know anymore when the problem actually occurred.
But right now I can't reproduce it so I would say it is fixed.

> 14) Go to another album
> -> the first image should be selected. The right arrow at the right side
> of the status bar should be enabled.
> Click on right arrow
> -> the second image should be selected

Like Gilles said: I need to press the right arrow twice.

> 31) Consider these albums:
> Test Empty
> \- Test 1
> \- Test 2
> "Test Empty" contains no pictures.
> "Test 1" contains one image rated with one stars
> "Test 2" contains one image rated with one star.
> Recursive listing of albums is enabled.
> Select "Test 2". Set rating filter to "Two stars"
> -> empty view. LED red
> Select "Empty"
> -> one image from Test 1 shown. LED green.

I still can confirm this, not for all album, but some. I have not found a
pattern yet.

> 32) A tag "Test 3" has exactly two images assigned.
> Go to tags view and select this tag. Two images are shown, the counter is
> 2. Delete one of them to trash. Shortly afterwards, one image is shown, the
> counter is 1.

Still not working here.

Also I seem to have found another issue, but I don't know when it is
happening. Sometimes not all items are shown, as if there was some filtering
turned on.
Then after switching to another album and back all items are visible.

Andi

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Wednesday 03 June 2009 21:22:33 Marcel Wiesweg wrote:

> Btw, I still dont know what problem 33) wants to tell me.

I don't know, I just copied all those issues from this thread. Someone
mentioned it in here, so I added it to the spreadsheet.

Andi

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > 32) A tag "Test 3" has exactly two images assigned.
> >        Go to tags view and select this tag. Two images are shown, the
> > counter is 2. Delete one of them to trash. Shortly afterwards, one image
> > is shown, the counter is 1.
>
> No, it doesn't work. it still 2 items in counter from Tags folder view
> from the left and right side panels. Restarting digiKam fix the
> problem.

Ah this is about the counter in the sidebars?
I am looking at the counter in the category banner in the view.
I can confirm the problem in the sidebars. But the icon view does not touch
this. IIRC it's AlbumManager collecting this information and sending out
signals to the album tree views.

Marcel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > 14) Go to another album
> > -> the first image should be selected. The right arrow at the right side
> > of the status bar should be enabled.
> > Click on right arrow
> > -> the second image should be selected
>
> Like Gilles said: I need to press the right arrow twice.

Yes I can confirm this now.


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/6/4 Marcel Wiesweg <[hidden email]>:

>> > 32) A tag "Test 3" has exactly two images assigned.
>> >        Go to tags view and select this tag. Two images are shown, the
>> > counter is 2. Delete one of them to trash. Shortly afterwards, one image
>> > is shown, the counter is 1.
>>
>> No, it doesn't work. it still 2 items in counter from Tags folder view
>> from the left and right side panels. Restarting digiKam fix the
>> problem.
>
> Ah this is about the counter in the sidebars?

yes, it is..

Gilles

> I am looking at the counter in the category banner in the view.
> I can confirm the problem in the sidebars. But the icon view does not touch
> this. IIRC it's AlbumManager collecting this information and sending out
> signals to the album tree views.
>
> Marcel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

A new bug found : Sometimes, zoom doesn't work on preview mode :

1/ Go in album.
2/ Press F3 to switch in preview mode.
3/ Now try to zoom in/out :

   * CTRL + mouse wheel doesn't work.
   * On right of status bar, zoom + and zoom - button doesn't work
   * On right of status bar, zoom slider work.

4/ After to play with zoom slider, zoom button and mouse wheel work fine.

This problem do not exist with all images. sound like relevant of
image dimensions

Gilles

2009/6/3 Andi Clemens <[hidden email]>:

>
> On Wednesday 03 June 2009 21:22:33 Marcel Wiesweg wrote:
>
>> Btw, I still dont know what problem 33) wants to tell me.
>
> I don't know, I just copied all those issues from this thread. Someone
> mentioned it in here, so I added it to the spreadsheet.
>
> Andi
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Marcel,

New bug. very simple to reproduce :

go to and album, focus is on specific item. Choose another one, and
run pop-up menu to switch in preview mode. New item is selected and
focus back to previous item !

video demo : http://digikam3rdparty.free.fr/bugs/wrongfocusoniconview.ogv

Gilles

2009/5/16 Marcel Wiesweg <[hidden email]>:

> Hi,
>
> as of today the main icon view has been replaced with the new implementation
> that has been under development for quite some time.
> I have taken care to go through the old code and port every single feature,
> but there is a lot of new code, so expect bugs and regressions.
> If you are running from current svn and find such a bug until beta1, please
> report it here shortly by mail, no need to flood b.k.o. I have not yet
> tested the majority of features, but will do in the next days.
>
> Issues:
> - Speed. (Talking about the 25000 pictures in the view situation). The idea
> is to make things faster. May things have become slower? They may. I have
> already eliminated performance issues with KCategorizedView. More to come.
> It seems that the view is the limiting factor and the model is well
> optimized.
> - The rate-on-hover feature is waiting to be ported
> - When new images are added in the background, currently the whole album is
> reloaded - incremental update is a missing feature.
>
> Marcel
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Marcel, another one, probably relevant to icon-view focus pb.

Look like in this video demo that i cannot select an item from
thumbbar. It switch back to another one :

http://digikam3rdparty.free.fr/bugs/wrongfocusonthumbbar.ogv

As thumbbar and icon-view focus are sync, i think this bug will be
fixed when icon view focus bug will be fixed...

Gilles


2009/6/8 Gilles Caulier <[hidden email]>:

> Marcel,
>
> New bug. very simple to reproduce :
>
> go to and album, focus is on specific item. Choose another one, and
> run pop-up menu to switch in preview mode. New item is selected and
> focus back to previous item !
>
> video demo : http://digikam3rdparty.free.fr/bugs/wrongfocusoniconview.ogv
>
> Gilles
>
> 2009/5/16 Marcel Wiesweg <[hidden email]>:
>> Hi,
>>
>> as of today the main icon view has been replaced with the new implementation
>> that has been under development for quite some time.
>> I have taken care to go through the old code and port every single feature,
>> but there is a lot of new code, so expect bugs and regressions.
>> If you are running from current svn and find such a bug until beta1, please
>> report it here shortly by mail, no need to flood b.k.o. I have not yet
>> tested the majority of features, but will do in the next days.
>>
>> Issues:
>> - Speed. (Talking about the 25000 pictures in the view situation). The idea
>> is to make things faster. May things have become slower? They may. I have
>> already eliminated performance issues with KCategorizedView. More to come.
>> It seems that the view is the limiting factor and the model is well
>> optimized.
>> - The rate-on-hover feature is waiting to be ported
>> - When new images are added in the background, currently the whole album is
>> reloaded - incremental update is a missing feature.
>>
>> Marcel
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Andi, Marcel,

Look this one. very nice. Certainly something is wrong with zoom
slider value dispatched to preview widget. At a specific value, image
disappear...

http://digikam3rdparty.free.fr/bugs/zoompreviewbug.ogv

Gilles

2009/6/8 Gilles Caulier <[hidden email]>:

> Marcel, another one, probably relevant to icon-view focus pb.
>
> Look like in this video demo that i cannot select an item from
> thumbbar. It switch back to another one :
>
> http://digikam3rdparty.free.fr/bugs/wrongfocusonthumbbar.ogv
>
> As thumbbar and icon-view focus are sync, i think this bug will be
> fixed when icon view focus bug will be fixed...
>
> Gilles
>
>
> 2009/6/8 Gilles Caulier <[hidden email]>:
>> Marcel,
>>
>> New bug. very simple to reproduce :
>>
>> go to and album, focus is on specific item. Choose another one, and
>> run pop-up menu to switch in preview mode. New item is selected and
>> focus back to previous item !
>>
>> video demo : http://digikam3rdparty.free.fr/bugs/wrongfocusoniconview.ogv
>>
>> Gilles
>>
>> 2009/5/16 Marcel Wiesweg <[hidden email]>:
>>> Hi,
>>>
>>> as of today the main icon view has been replaced with the new implementation
>>> that has been under development for quite some time.
>>> I have taken care to go through the old code and port every single feature,
>>> but there is a lot of new code, so expect bugs and regressions.
>>> If you are running from current svn and find such a bug until beta1, please
>>> report it here shortly by mail, no need to flood b.k.o. I have not yet
>>> tested the majority of features, but will do in the next days.
>>>
>>> Issues:
>>> - Speed. (Talking about the 25000 pictures in the view situation). The idea
>>> is to make things faster. May things have become slower? They may. I have
>>> already eliminated performance issues with KCategorizedView. More to come.
>>> It seems that the view is the limiting factor and the model is well
>>> optimized.
>>> - The rate-on-hover feature is waiting to be ported
>>> - When new images are added in the background, currently the whole album is
>>> reloaded - incremental update is a missing feature.
>>>
>>> Marcel
>>> _______________________________________________
>>> Digikam-devel mailing list
>>> [hidden email]
>>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>>
>>>
>>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

The specific zoom value seems to be 100%? but why?

Can't reproduce this right now.

Andi

On Monday 08 June 2009 18:23:10 Gilles Caulier wrote:

> Andi, Marcel,
>
> Look this one. very nice. Certainly something is wrong with zoom
> slider value dispatched to preview widget. At a specific value, image
> disappear...
>
> http://digikam3rdparty.free.fr/bugs/zoompreviewbug.ogv
>
> Gilles
>
> 2009/6/8 Gilles Caulier <[hidden email]>:
> > Marcel, another one, probably relevant to icon-view focus pb.
> >
> > Look like in this video demo that i cannot select an item from
> > thumbbar. It switch back to another one :
> >
> > http://digikam3rdparty.free.fr/bugs/wrongfocusonthumbbar.ogv
> >
> > As thumbbar and icon-view focus are sync, i think this bug will be
> > fixed when icon view focus bug will be fixed...
> >
> > Gilles
> >
> > 2009/6/8 Gilles Caulier <[hidden email]>:
> >> Marcel,
> >>
> >> New bug. very simple to reproduce :
> >>
> >> go to and album, focus is on specific item. Choose another one, and
> >> run pop-up menu to switch in preview mode. New item is selected and
> >> focus back to previous item !
> >>
> >> video demo :
> >> http://digikam3rdparty.free.fr/bugs/wrongfocusoniconview.ogv
> >>
> >> Gilles
> >>
> >> 2009/5/16 Marcel Wiesweg <[hidden email]>:
> >>> Hi,
> >>>
> >>> as of today the main icon view has been replaced with the new
> >>> implementation that has been under development for quite some time.
> >>> I have taken care to go through the old code and port every single
> >>> feature, but there is a lot of new code, so expect bugs and
> >>> regressions. If you are running from current svn and find such a bug
> >>> until beta1, please report it here shortly by mail, no need to flood
> >>> b.k.o. I have not yet tested the majority of features, but will do in
> >>> the next days.
> >>>
> >>> Issues:
> >>> - Speed. (Talking about the 25000 pictures in the view situation). The
> >>> idea is to make things faster. May things have become slower? They may.
> >>> I have already eliminated performance issues with KCategorizedView.
> >>> More to come. It seems that the view is the limiting factor and the
> >>> model is well optimized.
> >>> - The rate-on-hover feature is waiting to be ported
> >>> - When new images are added in the background, currently the whole
> >>> album is reloaded - incremental update is a missing feature.
> >>>
> >>> Marcel
> >>> _______________________________________________
> >>> Digikam-devel mailing list
> >>> [hidden email]
> >>> https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Marcel,
>
> New bug. very simple to reproduce :
>
> go to and album, focus is on specific item. Choose another one, and
> run pop-up menu to switch in preview mode. New item is selected and
> focus back to previous item !
>
> video demo : http://digikam3rdparty.free.fr/bugs/wrongfocusoniconview.ogv
>

It's not simple for me to reproduce ;-) It doesnt occur for me in fact.

It's a bit difficult to judge from the video with all the files derived from
the same photograph: Is the image shown in the preview the correct one or the
one wrongly selected in the view?
Does it make a difference when you, in DigikamView::slotImageSelected(), call
slotDispatchImageSelected() directly instead of starting the timer there?

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/6/9 Marcel Wiesweg <[hidden email]>:

>> Marcel,
>>
>> New bug. very simple to reproduce :
>>
>> go to and album, focus is on specific item. Choose another one, and
>> run pop-up menu to switch in preview mode. New item is selected and
>> focus back to previous item !
>>
>> video demo : http://digikam3rdparty.free.fr/bugs/wrongfocusoniconview.ogv
>>
>
> It's not simple for me to reproduce ;-) It doesnt occur for me in fact.
>
> It's a bit difficult to judge from the video with all the files derived from
> the same photograph: Is the image shown in the preview the correct one or the
> one wrongly selected in the view?

yes, it's the wrong selected image. Look the file name on the bottom left.

> Does it make a difference when you, in DigikamView::slotImageSelected(), call
> slotDispatchImageSelected() directly instead of starting the timer there?

I will check that...


Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> >> go to and album, focus is on specific item. Choose another one, and
> >> run pop-up menu to switch in preview mode. New item is selected and
> >> focus back to previous item !
> >>
> >> video demo :
> >> http://digikam3rdparty.free.fr/bugs/wrongfocusoniconview.ogv
> >
> > It's not simple for me to reproduce ;-) It doesnt occur for me in fact.
> >
> > It's a bit difficult to judge from the video with all the files derived
> > from the same photograph: Is the image shown in the preview the correct
> > one or the one wrongly selected in the view?
>
> yes, it's the wrong selected image. Look the file name on the bottom left.

Maybe this was also related to the bug I fixed last night after the crash
reported by Andi. There was a similar behavior of jumping selection after an
image was added or deleted.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/6/13 Marcel Wiesweg <[hidden email]>:

>
>> >> go to and album, focus is on specific item. Choose another one, and
>> >> run pop-up menu to switch in preview mode. New item is selected and
>> >> focus back to previous item !
>> >>
>> >> video demo :
>> >> http://digikam3rdparty.free.fr/bugs/wrongfocusoniconview.ogv
>> >
>> > It's not simple for me to reproduce ;-) It doesnt occur for me in fact.
>> >
>> > It's a bit difficult to judge from the video with all the files derived
>> > from the same photograph: Is the image shown in the preview the correct
>> > one or the one wrongly selected in the view?
>>
>> yes, it's the wrong selected image. Look the file name on the bottom left.
>
> Maybe this was also related to the bug I fixed last night after the crash
> reported by Andi. There was a similar behavior of jumping selection after an
> image was added or deleted.

Ok, i will try again

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

A new selection bug:

Select an image on the right side, shift click somewhere else. The thumbs are
not selected as they should.
But this only happens when you select the right-most thumb in iconview.

I can create a video if you need to see it "in action" :D

Andi

On Saturday 16 May 2009 18:00:23 Marcel Wiesweg wrote:

> Hi,
>
> as of today the main icon view has been replaced with the new
> implementation that has been under development for quite some time.
> I have taken care to go through the old code and port every single feature,
> but there is a lot of new code, so expect bugs and regressions.
> If you are running from current svn and find such a bug until beta1, please
> report it here shortly by mail, no need to flood b.k.o. I have not yet
> tested the majority of features, but will do in the next days.
>
> Issues:
> - Speed. (Talking about the 25000 pictures in the view situation). The idea
> is to make things faster. May things have become slower? They may. I have
> already eliminated performance issues with KCategorizedView. More to come.
> It seems that the view is the limiting factor and the model is well
> optimized. - The rate-on-hover feature is waiting to be ported
> - When new images are added in the background, currently the whole album is
> reloaded - incremental update is a missing feature.
>
> Marcel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> A new selection bug:
>
> Select an image on the right side, shift click somewhere else. The thumbs
> are not selected as they should.
> But this only happens when you select the right-most thumb in iconview.
>
> I can create a video if you need to see it "in action" :D

No need, I am aware of this for quite some time. It is a bug in
KCategorizedView - there was a first bug preventing that the right code path
was ever taken, and there is a second bug in this code given the result that
you see.
But I was not absolutely sure if this is a bug or intended behavior. Could you
imagine it is intended?

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Intended? No way! This is a stupid behavior :-)
Maybe we are talking about something else?
I will make a video... because keyboard selecting is even worse, this can't be
intended.

Andi

On Sunday 14 June 2009 15:07:51 Marcel Wiesweg wrote:

> > A new selection bug:
> >
> > Select an image on the right side, shift click somewhere else. The thumbs
> > are not selected as they should.
> > But this only happens when you select the right-most thumb in iconview.
> >
> > I can create a video if you need to see it "in action" :D
>
> No need, I am aware of this for quite some time. It is a bug in
> KCategorizedView - there was a first bug preventing that the right code
> path was ever taken, and there is a second bug in this code given the
> result that you see.
> But I was not absolutely sure if this is a bug or intended behavior. Could
> you imagine it is intended?
>
> Marcel
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel