New icon view

[Marcel Wiesweg]

Hi,

as of today the main icon view has been replaced with the new implementation that has been under development for quite some time.
I have taken care to go through the old code and port every single feature,
but there is a lot of new code, so expect bugs and regressions.
If you are running from current svn and find such a bug until beta1, please report it here shortly by mail, no need to flood b.k.o. I have not yet tested the majority of features, but will do in the next days.

Issues:
- Speed. (Talking about the 25000 pictures in the view situation). The idea is to make things faster. May things have become slower? They may. I have already eliminated performance issues with KCategorizedView. More to come.
It seems that the view is the limiting factor and the model is well optimized.
- The rate-on-hover feature is waiting to be ported
- When new images are added in the background, currently the whole album is reloaded - incremental update is a missing feature.

Marcel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Works fine here so far, yippie!
The only thing that is not working (maybe you are already working on it) is
the navigation panel in the bottom right corner. The arrows are all greyed out
here.



Andi

On Saturday 16 May 2009 18:00:23 Marcel Wiesweg wrote:

> Hi,
>
> as of today the main icon view has been replaced with the new
> implementation that has been under development for quite some time.
> I have taken care to go through the old code and port every single feature,
> but there is a lot of new code, so expect bugs and regressions.
> If you are running from current svn and find such a bug until beta1, please
> report it here shortly by mail, no need to flood b.k.o. I have not yet
> tested the majority of features, but will do in the next days.
>
> Issues:
> - Speed. (Talking about the 25000 pictures in the view situation). The idea
> is to make things faster. May things have become slower? They may. I have
> already eliminated performance issues with KCategorizedView. More to come.
> It seems that the view is the limiting factor and the model is well
> optimized. - The rate-on-hover feature is waiting to be ported
> - When new images are added in the background, currently the whole album is
> reloaded - incremental update is a missing feature.
>
> Marcel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Ok some more issues, just for the record:

- navigating by key shortcuts (space, backspace) is not working
- clicking on the thumbnail in the thumbbar is not working

Andi


On Saturday 16 May 2009 20:22:47 Andi Clemens wrote:

> Works fine here so far, yippie!
> The only thing that is not working (maybe you are already working on it) is
> the navigation panel in the bottom right corner. The arrows are all greyed
> out here.
>
>
>
> Andi
>
> On Saturday 16 May 2009 18:00:23 Marcel Wiesweg wrote:
> > Hi,
> >
> > as of today the main icon view has been replaced with the new
> > implementation that has been under development for quite some time.
> > I have taken care to go through the old code and port every single
> > feature, but there is a lot of new code, so expect bugs and regressions.
> > If you are running from current svn and find such a bug until beta1,
> > please report it here shortly by mail, no need to flood b.k.o. I have not
> > yet tested the majority of features, but will do in the next days.
> >
> > Issues:
> > - Speed. (Talking about the 25000 pictures in the view situation). The
> > idea is to make things faster. May things have become slower? They may. I
> > have already eliminated performance issues with KCategorizedView. More to
> > come. It seems that the view is the limiting factor and the model is well
> > optimized. - The rate-on-hover feature is waiting to be ported
> > - When new images are added in the background, currently the whole album
> > is reloaded - incremental update is a missing feature.
> >
> > Marcel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/5/16 Andi Clemens <[hidden email]>:
> Works fine here so far, yippie!
> The only thing that is not working (maybe you are already working on it) is
> the navigation panel in the bottom right corner. The arrows are all greyed out
> here.

Confirmed.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/5/16 Andi Clemens <[hidden email]>:
> Ok some more issues, just for the record:
>
> - navigating by key shortcuts (space, backspace) is not working

work fine here

> - clicking on the thumbnail in the thumbbar is not working

work fine here. Editor is open

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

and in AlbumUI?
On Saturday 16 May 2009 21:01:38 Gilles Caulier wrote:

> 2009/5/16 Andi Clemens <[hidden email]>:
> > Ok some more issues, just for the record:
> >
> > - navigating by key shortcuts (space, backspace) is not working
>
> work fine here
>
> > - clicking on the thumbnail in the thumbbar is not working
>
> work fine here. Editor is open
>
> Gilles
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Compilation is broken under Vista using MinGW (not yet tested with XP,
but it will be a similar pb):

[ 27%] Building CXX object
digikam/digikam/CMakeFiles/digikam.dir/kcategorizedview.obj
C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:1510:
warning: non-inline function 'virtual void KCategorizedView::r
owsInsertedArtifficial(const QModelIndex&, int, int)' is defined after
prior declaration as dllimport: attribute ignored
C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:1610:
warning: non-inline function 'virtual void KCategorizedView::u
pdateGeometries()' is defined after prior declaration as dllimport:
attribute ignored
In file included from
C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:1689:
C:\temp\devel\graphics\digikam\digikam\kcategorizedview.moc:55: error:
definition of static data member 'KCategorizedView::stati
cMetaObject' of dllimport'd class
C:\temp\devel\graphics\digikam\digikam\kcategorizedview.moc:55:
warning: 'KCategorizedView::staticMetaObject' defined locally af
ter being referenced with dllimport linkage
C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp: In
destructor `virtual KCategorizedView::~KCategorizedView()':
C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:543:
warning: non-inline function 'virtual KCategorizedView::~KCateg
orizedView()' is defined after prior declaration as dllimport: attribute ignored
make[2]: *** [digikam/digikam/CMakeFiles/digikam.dir/kcategorizedview.obj]
Error 1
make[1]: *** [digikam/digikam/CMakeFiles/digikam.dir/all] Error 2
make: *** [all] Error 2

Gilles

2009/5/16 Marcel Wiesweg <[hidden email]>:

> Hi,
>
> as of today the main icon view has been replaced with the new implementation
> that has been under development for quite some time.
> I have taken care to go through the old code and port every single feature,
> but there is a lot of new code, so expect bugs and regressions.
> If you are running from current svn and find such a bug until beta1, please
> report it here shortly by mail, no need to flood b.k.o. I have not yet
> tested the majority of features, but will do in the next days.
>
> Issues:
> - Speed. (Talking about the 25000 pictures in the view situation). The idea
> is to make things faster. May things have become slower? They may. I have
> already eliminated performance issues with KCategorizedView. More to come.
> It seems that the view is the limiting factor and the model is well
> optimized.
> - The rate-on-hover feature is waiting to be ported
> - When new images are added in the background, currently the whole album is
> reloaded - incremental update is a missing feature.
>
> Marcel
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

2009/5/16 Andi Clemens <[hidden email]>:
> and in AlbumUI?

yes, all work fine here...

Gilles

> On Saturday 16 May 2009 21:01:38 Gilles Caulier wrote:
>> 2009/5/16 Andi Clemens <[hidden email]>:
>> > Ok some more issues, just for the record:
>> >
>> > - navigating by key shortcuts (space, backspace) is not working
>>
>> work fine here
>>
>> > - clicking on the thumbnail in the thumbbar is not working
>>
>> work fine here. Editor is open
>>
>> Gilles
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hmm not working here... I deleted everything, even my ccache, I can't navigate
by key shortcuts.
Also clicking on thumbnails is not working.
I restarted my system, too (although normally not needed).

Andi


On Saturday 16 May 2009 22:31:44 Gilles Caulier wrote:

> 2009/5/16 Andi Clemens <[hidden email]>:
> > and in AlbumUI?
>
> yes, all work fine here...
>
> Gilles
>
> > On Saturday 16 May 2009 21:01:38 Gilles Caulier wrote:
> >> 2009/5/16 Andi Clemens <[hidden email]>:
> >> > Ok some more issues, just for the record:
> >> >
> >> > - navigating by key shortcuts (space, backspace) is not working
> >>
> >> work fine here
> >>
> >> > - clicking on the thumbnail in the thumbbar is not working
> >>
> >> work fine here. Editor is open
> >>
> >> Gilles
> >> _______________________________________________
> >> Digikam-devel mailing list
> >> [hidden email]
> >> https://mail.kde.org/mailman/listinfo/digikam-devel
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Sunday 17 May 2009 00:17:37 Andi Clemens wrote:
> Hmm not working here... I deleted everything, even my ccache, I can't
> navigate by key shortcuts.
> Also clicking on thumbnails is not working.

I mean the thumbnails in the thumbbar (albumUI).

Andi

> I restarted my system, too (although normally not needed).
>
> Andi
>
> On Saturday 16 May 2009 22:31:44 Gilles Caulier wrote:
> > 2009/5/16 Andi Clemens <[hidden email]>:
> > > and in AlbumUI?
> >
> > yes, all work fine here...
> >
> > Gilles
> >
> > > On Saturday 16 May 2009 21:01:38 Gilles Caulier wrote:
> > >> 2009/5/16 Andi Clemens <[hidden email]>:
> > >> > Ok some more issues, just for the record:
> > >> >
> > >> > - navigating by key shortcuts (space, backspace) is not working
> > >>
> > >> work fine here
> > >>
> > >> > - clicking on the thumbnail in the thumbbar is not working
> > >>
> > >> work fine here. Editor is open
> > >>
> > >> Gilles
> > >> _______________________________________________
> > >> Digikam-devel mailing list
> > >> [hidden email]
> > >> https://mail.kde.org/mailman/listinfo/digikam-devel
> > >
> > > _______________________________________________
> > > Digikam-devel mailing list
> > > [hidden email]
> > > https://mail.kde.org/mailman/listinfo/digikam-devel
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > Hmm not working here... I deleted everything, even my ccache, I can't
> > navigate by key shortcuts.
> > Also clicking on thumbnails is not working.
>
> I mean the thumbnails in the thumbbar (albumUI).

Do you mean the thumbbar at the bottom in ImagePreviewView? Or which thumbbar?
I can click on a thumbnail there and it is shown as preview; no keyboard navigation, but I dont have it in the image editor's thumbbar either. Thumbbar itself is not touched by my patches.

Marcel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Marcel,

All compile fine now. Great...

Gilles

2009/5/16 Gilles Caulier <[hidden email]>:

> Compilation is broken under Vista using MinGW (not yet tested with XP,
> but it will be a similar pb):
>
> [ 27%] Building CXX object
> digikam/digikam/CMakeFiles/digikam.dir/kcategorizedview.obj
> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:1510:
> warning: non-inline function 'virtual void KCategorizedView::r
> owsInsertedArtifficial(const QModelIndex&, int, int)' is defined after
> prior declaration as dllimport: attribute ignored
> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:1610:
> warning: non-inline function 'virtual void KCategorizedView::u
> pdateGeometries()' is defined after prior declaration as dllimport:
> attribute ignored
> In file included from
> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:1689:
> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.moc:55: error:
> definition of static data member 'KCategorizedView::stati
> cMetaObject' of dllimport'd class
> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.moc:55:
> warning: 'KCategorizedView::staticMetaObject' defined locally af
> ter being referenced with dllimport linkage
> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp: In
> destructor `virtual KCategorizedView::~KCategorizedView()':
> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:543:
> warning: non-inline function 'virtual KCategorizedView::~KCateg
> orizedView()' is defined after prior declaration as dllimport: attribute ignored
> make[2]: *** [digikam/digikam/CMakeFiles/digikam.dir/kcategorizedview.obj]
> Error 1
> make[1]: *** [digikam/digikam/CMakeFiles/digikam.dir/all] Error 2
> make: *** [all] Error 2
>
> Gilles
>
> 2009/5/16 Marcel Wiesweg <[hidden email]>:
>> Hi,
>>
>> as of today the main icon view has been replaced with the new implementation
>> that has been under development for quite some time.
>> I have taken care to go through the old code and port every single feature,
>> but there is a lot of new code, so expect bugs and regressions.
>> If you are running from current svn and find such a bug until beta1, please
>> report it here shortly by mail, no need to flood b.k.o. I have not yet
>> tested the majority of features, but will do in the next days.
>>
>> Issues:
>> - Speed. (Talking about the 25000 pictures in the view situation). The idea
>> is to make things faster. May things have become slower? They may. I have
>> already eliminated performance issues with KCategorizedView. More to come.
>> It seems that the view is the limiting factor and the model is well
>> optimized.
>> - The rate-on-hover feature is waiting to be ported
>> - When new images are added in the background, currently the whole album is
>> reloaded - incremental update is a missing feature.
>>
>> Marcel
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

A sode effect under windows only :

- Starting digiKam. icon view show dates rating, tags and comments
under icons. thumbs size is 96.
- There is null space between icons.
- I change thumb sizes to 140.
- Space between icons appears as under Linux.

Sound like an init race condition somewhere.

Gilles

2009/5/17 Gilles Caulier <[hidden email]>:

> Marcel,
>
> All compile fine now. Great...
>
> Gilles
>
> 2009/5/16 Gilles Caulier <[hidden email]>:
>> Compilation is broken under Vista using MinGW (not yet tested with XP,
>> but it will be a similar pb):
>>
>> [ 27%] Building CXX object
>> digikam/digikam/CMakeFiles/digikam.dir/kcategorizedview.obj
>> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:1510:
>> warning: non-inline function 'virtual void KCategorizedView::r
>> owsInsertedArtifficial(const QModelIndex&, int, int)' is defined after
>> prior declaration as dllimport: attribute ignored
>> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:1610:
>> warning: non-inline function 'virtual void KCategorizedView::u
>> pdateGeometries()' is defined after prior declaration as dllimport:
>> attribute ignored
>> In file included from
>> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:1689:
>> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.moc:55: error:
>> definition of static data member 'KCategorizedView::stati
>> cMetaObject' of dllimport'd class
>> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.moc:55:
>> warning: 'KCategorizedView::staticMetaObject' defined locally af
>> ter being referenced with dllimport linkage
>> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp: In
>> destructor `virtual KCategorizedView::~KCategorizedView()':
>> C:\temp\devel\graphics\digikam\digikam\kcategorizedview.cpp:543:
>> warning: non-inline function 'virtual KCategorizedView::~KCateg
>> orizedView()' is defined after prior declaration as dllimport: attribute ignored
>> make[2]: *** [digikam/digikam/CMakeFiles/digikam.dir/kcategorizedview.obj]
>> Error 1
>> make[1]: *** [digikam/digikam/CMakeFiles/digikam.dir/all] Error 2
>> make: *** [all] Error 2
>>
>> Gilles
>>
>> 2009/5/16 Marcel Wiesweg <[hidden email]>:
>>> Hi,
>>>
>>> as of today the main icon view has been replaced with the new implementation
>>> that has been under development for quite some time.
>>> I have taken care to go through the old code and port every single feature,
>>> but there is a lot of new code, so expect bugs and regressions.
>>> If you are running from current svn and find such a bug until beta1, please
>>> report it here shortly by mail, no need to flood b.k.o. I have not yet
>>> tested the majority of features, but will do in the next days.
>>>
>>> Issues:
>>> - Speed. (Talking about the 25000 pictures in the view situation). The idea
>>> is to make things faster. May things have become slower? They may. I have
>>> already eliminated performance issues with KCategorizedView. More to come.
>>> It seems that the view is the limiting factor and the model is well
>>> optimized.
>>> - The rate-on-hover feature is waiting to be ported
>>> - When new images are added in the background, currently the whole album is
>>> reloaded - incremental update is a missing feature.
>>>
>>> Marcel
>>> _______________________________________________
>>> Digikam-devel mailing list
>>> [hidden email]
>>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>>
>>>
>>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Yes, the thumbbar at the bottom in the albumUI. I click on a thumb in there,
but nothing happens.
And SPACE+BACKSPACE is not working, too.
Console doesn't show any debugging info, no signal / slots errors etc.

Andi

On Sunday 17 May 2009 10:24:06 Marcel Wiesweg wrote:

> > > Hmm not working here... I deleted everything, even my ccache, I can't
> > > navigate by key shortcuts.
> > > Also clicking on thumbnails is not working.
> >
> > I mean the thumbnails in the thumbbar (albumUI).
>
> Do you mean the thumbbar at the bottom in ImagePreviewView? Or which
> thumbbar? I can click on a thumbnail there and it is shown as preview; no
> keyboard navigation, but I dont have it in the image editor's thumbbar
> either. Thumbbar itself is not touched by my patches.
>
> Marcel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Matthias Welwarsky]

On Saturday 16 May 2009 18:00:23 Marcel Wiesweg wrote:

> Hi,
>
> as of today the main icon view has been replaced with the new
> implementation that has been under development for quite some time.
> I have taken care to go through the old code and port every single feature,
> but there is a lot of new code, so expect bugs and regressions.
> If you are running from current svn and find such a bug until beta1, please
> report it here shortly by mail, no need to flood b.k.o. I have not yet
> tested the majority of features, but will do in the next days.
>
> Issues:
> - Speed. (Talking about the 25000 pictures in the view situation). The idea
> is to make things faster. May things have become slower? They may. I have
> already eliminated performance issues with KCategorizedView. More to come.
> It seems that the view is the limiting factor and the model is well
> optimized. - The rate-on-hover feature is waiting to be ported
> - When new images are added in the background, currently the whole album is
> reloaded - incremental update is a missing feature.
>
> Marcel

Some problems here navigating the view with Arrow buttons: If you select
images with Shift plus Arrow buttons, you cannot cross the end of a row with
left/right arrows. Up/Down arrows seem to work.

Deleted images sometimes don't disappear from the view.

Metadata update when navigating pictures is slower than before and seems to
block the navigation. Is this now handled synchronously?

Lots of flickering when deleting images (full repaints, view is erased and then
completely redrawn).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

With icon view pop-up menu, click right and look that menu is a
reduced version where Edit action do not appears.

Close pop-up menu with ESC and re-open it : now it's the full version...

Gilles

2009/5/17 Matthias Welwarsky <[hidden email]>:

> On Saturday 16 May 2009 18:00:23 Marcel Wiesweg wrote:
>> Hi,
>>
>> as of today the main icon view has been replaced with the new
>> implementation that has been under development for quite some time.
>> I have taken care to go through the old code and port every single feature,
>> but there is a lot of new code, so expect bugs and regressions.
>> If you are running from current svn and find such a bug until beta1, please
>> report it here shortly by mail, no need to flood b.k.o. I have not yet
>> tested the majority of features, but will do in the next days.
>>
>> Issues:
>> - Speed. (Talking about the 25000 pictures in the view situation). The idea
>> is to make things faster. May things have become slower? They may. I have
>> already eliminated performance issues with KCategorizedView. More to come.
>> It seems that the view is the limiting factor and the model is well
>> optimized. - The rate-on-hover feature is waiting to be ported
>> - When new images are added in the background, currently the whole album is
>> reloaded - incremental update is a missing feature.
>>
>> Marcel
>
> Some problems here navigating the view with Arrow buttons: If you select
> images with Shift plus Arrow buttons, you cannot cross the end of a row with
> left/right arrows. Up/Down arrows seem to work.
>
> Deleted images sometimes don't disappear from the view.
>
> Metadata update when navigating pictures is slower than before and seems to
> block the navigation. Is this now handled synchronously?
>
> Lots of flickering when deleting images (full repaints, view is erased and then
> completely redrawn).
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Hmm last update I did (2 minutes ago) seems to have fixed the iconview. I can
navigate by keys, thumbbar and arrows in the bottom right.

Andi

On Sunday 17 May 2009 11:22:40 Andi Clemens wrote:

> Yes, the thumbbar at the bottom in the albumUI. I click on a thumb in
> there, but nothing happens.
> And SPACE+BACKSPACE is not working, too.
> Console doesn't show any debugging info, no signal / slots errors etc.
>
> Andi
>
> On Sunday 17 May 2009 10:24:06 Marcel Wiesweg wrote:
> > > > Hmm not working here... I deleted everything, even my ccache, I can't
> > > > navigate by key shortcuts.
> > > > Also clicking on thumbnails is not working.
> > >
> > > I mean the thumbnails in the thumbbar (albumUI).
> >
> > Do you mean the thumbbar at the bottom in ImagePreviewView? Or which
> > thumbbar? I can click on a thumbnail there and it is shown as preview; no
> > keyboard navigation, but I dont have it in the image editor's thumbbar
> > either. Thumbbar itself is not touched by my patches.
> >
> > Marcel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Matthias Welwarsky]

On Sunday 17 May 2009 12:05:04 Matthias Welwarsky wrote:

> On Saturday 16 May 2009 18:00:23 Marcel Wiesweg wrote:
> > Hi,
> >
> > as of today the main icon view has been replaced with the new
> > implementation that has been under development for quite some time.
> > I have taken care to go through the old code and port every single
> > feature, but there is a lot of new code, so expect bugs and regressions.
> > If you are running from current svn and find such a bug until beta1,
> > please report it here shortly by mail, no need to flood b.k.o. I have not
> > yet tested the majority of features, but will do in the next days.
> >
> > Issues:
> > - Speed. (Talking about the 25000 pictures in the view situation). The
> > idea is to make things faster. May things have become slower? They may. I
> > have already eliminated performance issues with KCategorizedView. More to
> > come. It seems that the view is the limiting factor and the model is well
> > optimized. - The rate-on-hover feature is waiting to be ported
> > - When new images are added in the background, currently the whole album
> > is reloaded - incremental update is a missing feature.
> >
> > Marcel
>
> Some problems here navigating the view with Arrow buttons: If you select
> images with Shift plus Arrow buttons, you cannot cross the end of a row
> with left/right arrows. Up/Down arrows seem to work.
>
> Deleted images sometimes don't disappear from the view.
>
> Metadata update when navigating pictures is slower than before and seems to
> block the navigation. Is this now handled synchronously?
>
> Lots of flickering when deleting images (full repaints, view is erased and
> then completely redrawn).

Another bug, (maybe more related to database model?):
Trying to adjust EXIF orientation brings up progress bar saying: "Updating
orientation in database..." or similar, then nothing. Thumbnail rotation does
not change. Progress bar never goes away, but application is still responding.
On next start, thumbnail still shows same orientation.

> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Saturday 16 May 2009 18:00:23 Marcel Wiesweg wrote:
> Issues:
> - Speed. (Talking about the 25000 pictures in the view situation). The idea
> is to make things faster. May things have become slower? They may. I have
> already eliminated performance issues with KCategorizedView. More to come.
> It seems that the view is the limiting factor and the model is well
> optimized. - The rate-on-hover feature is waiting to be ported

Just my guts - is faster but I cannot test on more than 2000 images in album
because "Show sub-albums" option isn't working.

Confirming issue with greyed out arrows in b-r corner.

m.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Confirmed. Same to assign Rating... In fact there is a lock somewhere.
look in console :

digikam(4251)/digikam (core) Digikam::DeleteDialog::accept:
setShowTrashDeleteDialog  true
timeChanged
digikam(4251)/digikam (core) Digikam::AlbumManager::slotKioFilesAdded:
"/mnt/data/.Trash-501/files/PICT0001.JPG"
digikam(4251)/digikam (core) Digikam::AlbumManager::slotKioFileMoved:
"file:///mnt/data/photos/test/batch%20queue%20tests/PICT0001.JPG"
"trash:/PICT0001.JPG"
digikam(4251) Digikam::AlbumManager::handleKioNotification: KDirNotify
detected file change at "/mnt/data/photos/test/batch queue tests"
digikam(4251)/digikam (core) Digikam::AlbumManager::slotKioFilesAdded:
"trash:/"
digikam(4251)/digikam (core)
Digikam::AlbumManager::slotKioFilesDeleted:
("file:///mnt/data/photos/test/batch%20queue%20tests/PICT0001.JPG")
digikam(4251) Digikam::AlbumManager::handleKioNotification: KDirNotify
detected file change at "/mnt/data/photos/test/batch queue tests"
digikam(4251)/digikam (core): Detected an active database transaction
when starting a collection scan. Please report this error.
digikam(4251)/digikam (core) Digikam::AlbumManager::slotDirWatchDirty:
KDirWatch detected change at "/mnt/data/photos/test/batch queue tests"
digikam(4251)/digikam (core): Detected an active database transaction
when starting a collection scan. Please report this error.

Here, after to rate a picture, i reove another one in same album.

Gilles


2009/5/17 Matthias Welwarsky <[hidden email]>:

> On Sunday 17 May 2009 12:05:04 Matthias Welwarsky wrote:
>> On Saturday 16 May 2009 18:00:23 Marcel Wiesweg wrote:
>> > Hi,
>> >
>> > as of today the main icon view has been replaced with the new
>> > implementation that has been under development for quite some time.
>> > I have taken care to go through the old code and port every single
>> > feature, but there is a lot of new code, so expect bugs and regressions.
>> > If you are running from current svn and find such a bug until beta1,
>> > please report it here shortly by mail, no need to flood b.k.o. I have not
>> > yet tested the majority of features, but will do in the next days.
>> >
>> > Issues:
>> > - Speed. (Talking about the 25000 pictures in the view situation). The
>> > idea is to make things faster. May things have become slower? They may. I
>> > have already eliminated performance issues with KCategorizedView. More to
>> > come. It seems that the view is the limiting factor and the model is well
>> > optimized. - The rate-on-hover feature is waiting to be ported
>> > - When new images are added in the background, currently the whole album
>> > is reloaded - incremental update is a missing feature.
>> >
>> > Marcel
>>
>> Some problems here navigating the view with Arrow buttons: If you select
>> images with Shift plus Arrow buttons, you cannot cross the end of a row
>> with left/right arrows. Up/Down arrows seem to work.
>>
>> Deleted images sometimes don't disappear from the view.
>>
>> Metadata update when navigating pictures is slower than before and seems to
>> block the navigation. Is this now handled synchronously?
>>
>> Lots of flickering when deleting images (full repaints, view is erased and
>> then completely redrawn).
>
> Another bug, (maybe more related to database model?):
> Trying to adjust EXIF orientation brings up progress bar saying: "Updating
> orientation in database..." or similar, then nothing. Thumbnail rotation does
> not change. Progress bar never goes away, but application is still responding.
> On next start, thumbnail still shows same orientation.
>
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel