[Bug 267789] New: Make face detection (kface) and geo tagging (kmap) optional features

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=267789

           Summary: Make face detection (kface) and geo tagging (kmap)
                    optional features
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: wishlist
          Priority: NOR
         Component: Face Detection
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           unspecified (using Devel)
OS:                Linux

digiKam/master now requires the kface and kmap libraries together with its
dependencies (notably the OpenCV library and Marble) to be installed. The
dependencies are rather heavy compared to other optional dependencies (the
OpenCV package has 29 MB here). Those dependencies have been optional in
kipi-plugins.

If possible, I would like to continue to be able to reduce the weight of the
digiKam suite by reducing its feature set, so it would be nice if the kface and
kmap dependencies were optional.

Reproducible: Didn't try

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-06 14:19:52 ---
Both libraries were developed to implemented important features wished for a
long time, and are integrated closely into digikam.
I dont see the value to cut newly developed features and ship a disabled
version for the sake of what?
Marble is in my understanding a pillar of KDE.
We could talk about making face detection, thus libkface optional, but dont
expect any work from me in that direction.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Face Detection              |general
            Version|unspecified                 |2.0.0




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2011-03-06 14:52:31 ---
My viewpoint : set these dependencies optional will be complex (but not
impossible)

I let's Marcel choose for libkface.
I let's Micheal choose for libkmap.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #3 from Christoph Feck <christoph maxiom de>  2011-03-06 15:04:47 ---
If it is too much of a hassle, please close as wontfix. I was mainly thinking
of Live CDs and users who don't collect images of persons they know ;)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-06 15:10:14 ---
For libface, we need the haarcascades at 19MB. If these files are not present,
face detection will fail silently, but digikam will not crash.
Regarding Marble, we mainly need the library. I dont know what happens if the
basic map data is not present - marble should be able to cope with running
without offline data. Loading maps from OSM or Google Maps gives much better
results anyway, requires network of course.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #5 from Christoph Feck <christoph maxiom de>  2011-03-06 15:23:11 ---
You are right, the Haar data is indeed optional, so 66% of the "OpenCV problem"
is already solved. I guess the other third is not worth the hassle. Thanks.
Feel free to reopen if someone wants to take the challenge.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2011-03-06 15:41:04 ---
Marcel,

Note that with current stable libface 0.2.0, libkface do not compile...

Current libkface include libface 0.1.0 source code...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2011-03-06 18:12:28 ---
Alex, Can you comment my previous post please ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[alexjironkin]

Hi Giles,

Sorry I haven't commented before. I have slightly changed the interface, all in the effort of bug fixing and plugging memory leaks. So the change is actually not that big, e.g. instead of vectors pointers to the vectors are returned. I was waiting for the move to git to be done and finalised because I didn't really know where best  to submit change to libkface.


On 6 Mar 2011, at 17:12, Gilles Caulier wrote:

> https://bugs.kde.org/show_bug.cgi?id=267789
>
>
> Gilles Caulier <[hidden email]> changed:
>
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                 CC|                            |[hidden email]
>
>
>
>
> --- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2011-03-06 18:12:28 ---
> Alex, Can you comment my previous post please ?
>
> Gilles Caulier
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein



_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[alexjironkin]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #8 from Alex <alexjironkin gmail com>  2011-03-06 18:20:10 ---
Hi Giles,

Sorry I haven't commented before. I have slightly changed the interface, all in
the effort of bug fixing and plugging memory leaks. So the change is actually
not that big, e.g. instead of vectors pointers to the vectors are returned. I
was waiting for the move to git to be done and finalised because I didn't
really know where best  to submit change to libkface.


On 6 Mar 2011, at 17:12, Gilles Caulier wrote:

> https://bugs.kde.org/show_bug.cgi?id=267789
>
>
> Gilles Caulier <[hidden email]> changed:
>
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                 CC|                            |[hidden email]
>
>
>
>
> --- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2011-03-06 18:12:28 ---
> Alex, Can you comment my previous post please ?
>
> Gilles Caulier
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2011-03-06 18:25:57 ---
Alex,

Thanks for your response. Libkface code is here in KDE Git repository:

https://projects.kde.org/projects/kdereview/libkface

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2011-03-06 18:28:30 ---
Micheal,

Your comment about optional libkmap dependency ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #11 from Michael G. Hansen <mike mghansen de>  2011-03-07 20:08:12 ---
Hi,

- one option is making Marble an optional compile-time or even run-time
dependency, however this is not easy because we use some geodata-classes from
Marble in the core of libkmap. But in principle, it could be done. Without
Marble, libkmap can still run using Google Maps.

- compiling digikam without libkmap: Should be doable using ifdef and CMake,
and simply make the map search, gps properties tab and central map view
unavailable.

However, I share Marcel's feeling about removing these features: For 2.0, they
were heavily advertised. Now if some user fears compiling digikam, and instead
try out a live cd, they might be disappointed to find a digikam without the
features they anticipated.

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #12 from Gert Kello <gert kello gmail com>  2011-03-08 06:52:45 ---
Hi,

The digikam memory usage is a bit too high for my taste, so ability to disable
some parts I'm not using would be quit nice feature

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-08 21:03:11 ---
Face detection does not use memory if you dont need it.
There have been memory issues with marble, did not benchmark with 4.6 yet.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #14 from Michael G. Hansen <mike mghansen de>  2011-03-08 21:27:13 ---
KMap instances also only create MarbleWidget or KHTML instances when they are
activated, like when a tab containing them is opened. When inactive, their only
footprint should be some UI elements and the code size of libmarble. I plan to
investigate how much progress has been made in Marble to reuse parts of the
memory between MarbleWidget instances. We can also still optimize when KMap
instances are seen to be 'active' in digikam, like only when you actually open
a tab.

Off-topic: Marcel, I think we currently pre-created the editor and the
lighttable - maybe we can add an option to not pre-create them?

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #15 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-08 22:03:19 ---
> Off-topic: Marcel, I think we currently pre-created the editor and the
> lighttable - maybe we can add an option to not pre-create them?

Yes we precreate lighttable, batch queue manager and image editor. I didnt do
any memory benchmarks about that as well.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[alexjironkin]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #16 from Alex <alexjironkin gmail com>  2011-03-09 10:05:34 ---
In the 0.1 version of libface there is a memory leak in detection, I think it
will get more noticeable once you have you start going through a lot of faces.
There is also a trick one can/has to do when dealing with the vector of faces
from detection. Although the actual objects are stored in that array, they need
to be accessed using pointers. Otherwise there when the Face/KFace class
retrieved and destroyed in the local scope the Pointer to the actual data in
the class will be released and later down the line it will segfault. I haven't
figured if I should change from vector of Face's to vector of pointers to
faces.


Alex

On 8 Mar 2011, at 20:03, Marcel Wiesweg wrote:

> https://bugs.kde.org/show_bug.cgi?id=267789
>
>
>
>
>
> --- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-08 21:03:11 ---
> Face detection does not use memory if you dont need it.
> There have been memory issues with marble, did not benchmark with 4.6 yet.
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2011-03-09 10:35:17 ---
Alex,

Did you manage all changes in libkface to compile fine against libface 0.2.0 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[alexjironkin]

Not yet sorry, I am going to do it this afternoon.


Alex

On 9 Mar 2011, at 09:35, Gilles Caulier wrote:

> https://bugs.kde.org/show_bug.cgi?id=267789
>
>
>
>
>
> --- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2011-03-09 10:35:17 ---
> Alex,
>
> Did you manage all changes in libkface to compile fine against libface 0.2.0 ?
>
> Gilles Caulier
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein



_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel