[Bug 267789] New: Make face detection (kface) and geo tagging (kmap) optional features

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #41 from  <kgw mineralien-verkauf de>  2011-07-19 13:39:25 ---
(In reply to comment #40)
> 1- there is no plan to make' these depencies as optional. this will make  big
> puzzle i source code, and will take a while.
It just changes about 10 files - if that's a big puzzle for you... You'd only
need to make the interface conditional and take the face detection specific
files out of the CMakeFile.txt, that's 3-4 includes and about as many interface
.cpp - not a big deal as I said you could have the patch tonight, it barely
took two hours to completely remove the dependency on the face detection
framework altogether and that was without knowing which components needed to be
touched - just letting the compiler complain about missing dependencies after
removing the kface dependencies from the build system - so it's quite easy and
not very time consuming making this component a compile time option - if the
necessary dependencies are there compile it, if not then don't bother...
> 2- if you cannot build under your linux, check your system
My systems are perfectly fine, they just need libraries that are in conflict
with OpenCV (or one of it's dependencies) thus OpenCV can't be built and thus
in the end digikam can't because of the dependency on this...
> 3- 2.0.0 will be released in a few day. you can wait for a packaging solution.
Even then the library dependency still won't get away, I'm on a gentoo source
distribution and even if that were to work the interface still will be
cluttered.
> 6- and finally, if you want to ask something to an open source team, you must
> ask it properly, whitout to be nervous.
I asked about it months ago - I just restated the question because nothing was
happening but discussion about build issues which were basically off topic.
Back then I told you that I managed to rip it out and thus I could have
provided a patch and even today I could do a patch (which is only half as
invasive as you make it sound)...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #42 from Gilles Caulier <caulier gilles gmail com>  2011-07-19 17:12:11 ---
marcel use gentoo too and he has no problem to compile digikam & co. so ask to
him...
gilles caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Andreas K. Huettel]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #43 from Andreas K. Huettel <dilfridge gentoo org>  2011-07-19 18:21:13 ---
(In reply to comment #41)
> > 2- if you cannot build under your linux, check your system
> My systems are perfectly fine, they just need libraries that are in conflict
> with OpenCV (or one of it's dependencies) thus OpenCV can't be built and thus
> in the end digikam can't because of the dependency on this...

Could you please tell me what exactly the problem is? Even better, file a
Gentoo bug (because Gentoo library interactions are not really on-topic
here...)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #44 from  <kgw mineralien-verkauf de>  2011-07-19 22:36:41 ---
> Could you please tell me what exactly the problem is? Even better, file a
> Gentoo bug (because Gentoo library interactions are not really on-topic
> here...)
I can't compile some of the required libraries because of use flags I have set
for other libraries to be able to get certain non-gentoo libraries to be usable
that I need for my daily work! Since I don't care about face detection (in fact
I despise the function and the implications it has regarding identity theft and
web stalking with face detection creeping up all over the place) I'll simply
continue to rip it out of digikam, it's only a few minutes once you know what
to look for...
It would have been nice to have the option out of the box to run digikam
without face detection, especially as the change is well localized (15 cpp and
include files in total plus small changes to the CMakeFile.txt) and not at all
invasive.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #45 from Michael G. Hansen <mike mghansen de>  2011-07-21 03:36:22 ---
As for geolocation, I agree with Gilles' viewpoint about not making it
optional. It was optional some time ago, but it was the hell to work with to
make sure that after every change it would still compile with and without
Marble. Also, the geotagging UI elements are only two tabs, which have always
been there, and a new toolbar button, which you can easily hide. Separating the
Marble dependency out of libkgeomap will again lead to lots of code
duplication, which is to be avoided.

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #46 from Christoph Feck <christoph maxiom de>  2011-07-23 11:31:40 ---
Interestingly, this bug is mentioned (presumably as fixed) in the NEWS file (No
222). While you are at it, remove the trailing "r" from No 223.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #47 from  <kgw mineralien-verkauf de>  2012-01-21 11:39:26 ---
Created an attachment (id=68068)
 --> (http://bugs.kde.org/attachment.cgi?id=68068)
Patch to remove any Face-Detection and Face-Tagging from digikam

I still despise this abhorrent function - and I can't understand why this still
isn't optional for those that have no interest in feeding the big brother sites
like Facebook or similar with even more tags to reduce our freedom.
So I took an hour today to rip that junk from digikam in hope that it will help
people that don't want to have this feature! If interested I could make all
these changes dependent on a define to be evaluated during cmake but for the
moment complete and utter removal (which was quite easy contrary to some
developers claiming it was impossible) has to do.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
            Version|2.0.0                       |2.5.0
         Resolution|WONTFIX                     |
            Summary|Make face detection (kface) |Make face detection (kface)
                   |and geo tagging (kmap)      |and geo tagging (kmap)
                   |optional features           |optional features [patch]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Portability




--- Comment #48 from Gilles Caulier <caulier gilles gmail com>  2012-01-21 13:00:22 ---
It's possible to make 2 patches : one for face detection, one for geolocation.

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #49 from  <kgw mineralien-verkauf de>  2012-01-21 13:37:53 ---
@#48 Should I take the change in status as signal to proceed in reworking my
patch to make face detection a compile time optional component?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #50 from Gilles Caulier <caulier gilles gmail com>  2012-01-21 13:55:56 ---
i take a look in your patch.

Only libkface is managed. In fact not managed really, because you drop library
check and code relevant.

This is not optional. You drop feature. It's not acceptable. Please revise your
patch...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #51 from  <kgw mineralien-verkauf de>  2012-01-21 14:04:58 ---
@#50, it was was a proof of concept patch as a developer once told me that
making face detection was impossible to remove. Of course I will resubmit in
due time if the patch has any chance of making it into the mainstream version,
that's why I am asking if it makes sense to put in the work...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #52 from Gilles Caulier <caulier gilles gmail com>  2012-01-21 14:08:43 ---
yes. If patch make libkface purely optional, it will be accepted...

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=267789


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68068|0                           |1
        is obsolete|                            |




--- Comment #53 from  <kgw mineralien-verkauf de>  2012-01-21 22:32:04 ---
Created an attachment (id=68077)
 --> (http://bugs.kde.org/attachment.cgi?id=68077)
Patch making libkface fully and properly optional.

Here is my revised patch. It builds properly without libkface, it's use now not
only is a build time detected option, it can be disabled via a CMake option
even if libkface should be available.
libkgeomap unfortunately is another matter as it encompasses a rather massive
GUI adaptation (it embeds the location view) which I personally don't feel
competent enough to remove.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789

--- Comment #54 from Gilles Caulier <[hidden email]> ---
kgw,

Your patch cannot be applied against git/master :

[gilles@localhost core]$ patch -p1 < digikam-no-faces-proper.diff
patching file CMakeLists.txt
Hunk #1 FAILED at 9.
Hunk #2 FAILED at 149.
Hunk #3 succeeded at 369 (offset 102 lines).
Hunk #4 succeeded at 432 with fuzz 2 (offset 134 lines).
Hunk #5 FAILED at 359.
Hunk #6 succeeded at 548 with fuzz 2 (offset 140 lines).
Hunk #7 succeeded at 619 with fuzz 2 (offset 155 lines).
Hunk #8 FAILED at 1158.
Hunk #9 FAILED at 1200.
Hunk #10 FAILED at 1398.
6 out of 10 hunks FAILED -- saving rejects to file CMakeLists.txt.rej
patching file digikam/album/albummanager.cpp
Hunk #3 succeeded at 198 (offset -1 lines).
Hunk #7 succeeded at 2331 (offset 32 lines).
Hunk #8 succeeded at 2505 (offset 38 lines).
Hunk #9 succeeded at 2827 (offset 39 lines).
Hunk #10 succeeded at 3000 (offset 43 lines).
Hunk #11 succeeded at 3040 (offset 43 lines).
patching file digikam/album/albummanager.h
Hunk #1 succeeded at 587 (offset -6 lines).
Hunk #2 succeeded at 595 (offset -6 lines).
Hunk #3 succeeded at 638 (offset -6 lines).
Hunk #4 succeeded at 653 (offset -6 lines).
patching file digikam/items/digikamimageview.cpp
Hunk #1 FAILED at 62.
Hunk #2 FAILED at 87.
Hunk #3 succeeded at 120 (offset 4 lines).
Hunk #4 succeeded at 132 (offset 4 lines).
Hunk #5 FAILED at 189.
Hunk #6 FAILED at 197.
Hunk #7 succeeded at 198 (offset -11 lines).
Hunk #8 succeeded at 228 (offset -8 lines).
Hunk #9 succeeded at 242 (offset -8 lines).
Hunk #10 succeeded at 306 (offset -6 lines).
4 out of 10 hunks FAILED -- saving rejects to file
digikam/items/digikamimageview.cpp.rej
patching file digikam/items/digikamimageview.h
Hunk #1 succeeded at 79 (offset -8 lines).
patching file digikam/items/digikamimageview_p.cpp
patching file digikam/items/digikamimageview_p.h
patching file digikam/main/digikamapp.cpp
Hunk #1 FAILED at 95.
Hunk #2 FAILED at 120.
Hunk #3 FAILED at 144.
Hunk #4 FAILED at 3047.
Hunk #5 succeeded at 3055 with fuzz 2 (offset -1 lines).
Hunk #6 FAILED at 3067.
Hunk #7 FAILED at 3074.
6 out of 7 hunks FAILED -- saving rejects to file
digikam/main/digikamapp.cpp.rej
patching file digikam/main/digikamapp.h
Hunk #1 succeeded at 59 (offset 2 lines).
Hunk #2 FAILED at 163.
Hunk #3 FAILED at 230.
2 out of 3 hunks FAILED -- saving rejects to file digikam/main/digikamapp.h.rej
patching file digikam/utils/componentsinfo.h
Hunk #1 FAILED at 38.
Hunk #2 FAILED at 74.
2 out of 2 hunks FAILED -- saving rejects to file
digikam/utils/componentsinfo.h.rej
patching file digikam/views/imagepreviewview.cpp
Hunk #1 succeeded at 57 (offset -4 lines).
Hunk #2 FAILED at 74.
Hunk #3 FAILED at 84.
Hunk #4 succeeded at 102 (offset -5 lines).
Hunk #5 succeeded at 129 (offset -5 lines).
Hunk #6 FAILED at 159.
Hunk #7 succeeded at 176 with fuzz 1 (offset -3 lines).
Hunk #8 succeeded at 195 (offset -3 lines).
Hunk #9 succeeded at 224 (offset -3 lines).
Hunk #10 succeeded at 242 (offset -3 lines).
Hunk #11 succeeded at 262 (offset -3 lines).
Hunk #12 succeeded at 271 (offset -3 lines).
Hunk #13 FAILED at 313.
Hunk #14 succeeded at 323 (offset 2 lines).
Hunk #15 succeeded at 365 (offset 2 lines).
Hunk #16 succeeded at 430 with fuzz 1 (offset 14 lines).
4 out of 16 hunks FAILED -- saving rejects to file
digikam/views/imagepreviewview.cpp.rej
patching file libs/database/imagescanner.cpp
Hunk #1 succeeded at 43 (offset 1 line).
Hunk #2 FAILED at 260.
Hunk #3 succeeded at 459 with fuzz 1 (offset 181 lines).
Hunk #4 succeeded at 856 with fuzz 1 (offset 272 lines).
Hunk #5 succeeded at 906 with fuzz 1 (offset 284 lines).
1 out of 5 hunks FAILED -- saving rejects to file
libs/database/imagescanner.cpp.rej
patching file libs/database/imagescanner.h
Hunk #1 FAILED at 226.
1 out of 1 hunk FAILED -- saving rejects to file
libs/database/imagescanner.h.rej
patching file libs/imageproperties/imagedescedittab.cpp
Hunk #1 FAILED at 442.
1 out of 1 hunk FAILED -- saving rejects to file
libs/imageproperties/imagedescedittab.cpp.rej
patching file libs/models/albummodel.cpp
patching file libs/models/imagealbummodel.cpp
Hunk #1 succeeded at 37 with fuzz 2.
Hunk #2 succeeded at 374 (offset 30 lines).

Please update it if you want to see Face management become optional for next
4.0.0 release.

Best

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789

--- Comment #55 from Gilles Caulier <[hidden email]> ---
kgw,

Do you see my previous message ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |WAITINGFORINFO

--- Comment #56 from Gilles Caulier <[hidden email]> ---
we wait a revised patch again current git/master, please

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WAITINGFORINFO              |---
     Ever confirmed|1                           |0
             Status|RESOLVED                    |UNCONFIRMED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=267789

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.5.0                       |4.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel