[Bug 267789] New: Make face detection (kface) and geo tagging (kmap) optional features

classic Classic list List threaded Threaded
85 messages Options
12345
Reply | Threaded
Open this post in threaded view
|

[Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #33 from Gilles Caulier <caulier gilles gmail com>  2011-03-11 17:21:20 ---
Alex,

I forget to said that Accuracy value is default 0.8. So it's fine normally for
libface.

Note : i use libface from trunk. It certainly more recent than official 0.2
release...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

alexjironkin
Yeah I saw that there log there. It looks like for some reason it has found the config, and then went on to create a new one. Will check it out later on this evening.


Alex

On 11 Mar 2011, at 16:21, Gilles Caulier wrote:

> https://bugs.kde.org/show_bug.cgi?id=267789
>
>
>
>
>
> --- Comment #33 from Gilles Caulier <caulier gilles gmail com>  2011-03-11 17:21:20 ---
> Alex,
>
> I forget to said that Accuracy value is default 0.8. So it's fine normally for
> libface.
>
> Note : i use libface from trunk. It certainly more recent than official 0.2
> release...
>
> Gilles Caulier
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein



_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

alexjironkin
In reply to this post by Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #34 from Alex <alexjironkin gmail com>  2011-03-11 17:26:54 ---
Yeah I saw that there log there. It looks like for some reason it has found the
config, and then went on to create a new one. Will check it out later on this
evening.


Alex

On 11 Mar 2011, at 16:21, Gilles Caulier wrote:

> https://bugs.kde.org/show_bug.cgi?id=267789
>
>
>
>
>
> --- Comment #33 from Gilles Caulier <caulier gilles gmail com>  2011-03-11 17:21:20 ---
> Alex,
>
> I forget to said that Accuracy value is default 0.8. So it's fine normally for
> libface.
>
> Note : i use libface from trunk. It certainly more recent than official 0.2
> release...
>
> Gilles Caulier
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Matthias Welwarsky
In reply to this post by Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=267789


Matthias Welwarsky <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #35 from Matthias Welwarsky <matze welwarsky de>  2011-03-12 10:11:18 ---
Digikam still doesn't compile?

/home/matze/Sources/digikam-software-compilation/extra/libkface/libkface/database.cpp:
In member function ‘QList<KFaceIface::Face>
KFaceIface::Database::detectFaces(const KFaceIface::Image&)’:
/home/matze/Sources/digikam-software-compilation/extra/libkface/libkface/database.cpp:184:
error: no matching function for call to ‘libface::LibFace::detectFaces(const
IplImage*&)’
/home/matze/Sources/digikam-software-compilation/extra/libkface/libface/LibFace.h:85:
note: candidates are: std::vector<libface::Face, std::allocator<libface::Face>
> libface::LibFace::detectFaces(const IplImage*, const CvSize&)
/home/matze/Sources/digikam-software-compilation/extra/libkface/libface/LibFace.h:100:
note:                 std::vector<libface::Face, std::allocator<libface::Face>
> libface::LibFace::detectFaces(const std::string&, int)
/home/matze/Sources/digikam-software-compilation/extra/libkface/libface/LibFace.h:101:
note:                 std::vector<libface::Face, std::allocator<libface::Face>
> libface::LibFace::detectFaces(const char*, int, int, int, int, int, int)
/home/matze/Sources/digikam-software-compilation/extra/libkface/libkface/database.cpp:
In member function ‘QList<double>
KFaceIface::Database::recognizeFaces(QList<KFaceIface::Face>&)’:
/home/matze/Sources/digikam-software-compilation/extra/libkface/libkface/database.cpp:272:
error: no match for ‘operator=’ in ‘result =
libface::LibFace::recognise(std::vector<libface::Face,
std::allocator<libface::Face> >*, int)((& faceVec), 1)’
/usr/include/c++/4.4/bits/vector.tcc:156: note: candidates are:
std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(const
std::vector<_Tp, _Alloc>&) [with _Tp = std::pair<int, float>, _Alloc =
std::allocator<std::pair<int, float> >]

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

alexjironkin
LibKFace is broken for now. I am trying to fix this.


Alex


On 12 Mar 2011, at 09:11, Matthias Welwarsky wrote:

> https://bugs.kde.org/show_bug.cgi?id=267789
>
>
> Matthias Welwarsky <[hidden email]> changed:
>
>           What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                 CC|                            |[hidden email]
>
>
>
>
> --- Comment #35 from Matthias Welwarsky <matze welwarsky de>  2011-03-12 10:11:18 ---
> Digikam still doesn't compile?
>
> /home/matze/Sources/digikam-software-compilation/extra/libkface/libkface/database.cpp:
> In member function ‘QList<KFaceIface::Face>
> KFaceIface::Database::detectFaces(const KFaceIface::Image&)’:
> /home/matze/Sources/digikam-software-compilation/extra/libkface/libkface/database.cpp:184:
> error: no matching function for call to ‘libface::LibFace::detectFaces(const
> IplImage*&)’
> /home/matze/Sources/digikam-software-compilation/extra/libkface/libface/LibFace.h:85:
> note: candidates are: std::vector<libface::Face, std::allocator<libface::Face>
>> libface::LibFace::detectFaces(const IplImage*, const CvSize&)
> /home/matze/Sources/digikam-software-compilation/extra/libkface/libface/LibFace.h:100:
> note:                 std::vector<libface::Face, std::allocator<libface::Face>
>> libface::LibFace::detectFaces(const std::string&, int)
> /home/matze/Sources/digikam-software-compilation/extra/libkface/libface/LibFace.h:101:
> note:                 std::vector<libface::Face, std::allocator<libface::Face>
>> libface::LibFace::detectFaces(const char*, int, int, int, int, int, int)
> /home/matze/Sources/digikam-software-compilation/extra/libkface/libkface/database.cpp:
> In member function ‘QList<double>
> KFaceIface::Database::recognizeFaces(QList<KFaceIface::Face>&)’:
> /home/matze/Sources/digikam-software-compilation/extra/libkface/libkface/database.cpp:272:
> error: no match for ‘operator=’ in ‘result =
> libface::LibFace::recognise(std::vector<libface::Face,
> std::allocator<libface::Face> >*, int)((& faceVec), 1)’
> /usr/include/c++/4.4/bits/vector.tcc:156: note: candidates are:
> std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(const
> std::vector<_Tp, _Alloc>&) [with _Tp = std::pair<int, float>, _Alloc =
> std::allocator<std::pair<int, float> >]
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein



_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Michael G. Hansen
In reply to this post by Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #36 from Michael G. Hansen <mike mghansen de>  2011-03-12 21:07:17 ---
Git commit db7a9b586de971f756daf3addb494f2e6020f964 by Michael Georg Hansen.
Committed on 12/03/2011 at 21:06.
Pushed by mghansen into branch 'master'.

Fix building against newer libface version.

CCBUG: 267789

M  +7    -6    libkface/database.cpp    

http://commits.kde.org/libkface/db7a9b586de971f756daf3addb494f2e6020f964

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

alexjironkin
I have made necessary changes to the libkface to compile with libface trunk. However, when I ran the GUI to test if everything was working, I found there was a segfault, coming from QList which I haven't figured out why yet. Do you want me to submit the latest change with new internal version of libface that builds but won't work?

Alex

On 12 Mar 2011, at 20:07, Michael G.Hansen wrote:

> https://bugs.kde.org/show_bug.cgi?id=267789
>
>
>
>
>
> --- Comment #36 from Michael G. Hansen <mike mghansen de>  2011-03-12 21:07:17 ---
> Git commit db7a9b586de971f756daf3addb494f2e6020f964 by Michael Georg Hansen.
> Committed on 12/03/2011 at 21:06.
> Pushed by mghansen into branch 'master'.
>
> Fix building against newer libface version.
>
> CCBUG: 267789
>
> M  +7    -6    libkface/database.cpp    
>
> http://commits.kde.org/libkface/db7a9b586de971f756daf3addb494f2e6020f964
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein



_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Marcel Wiesweg

> I have made necessary changes to the libkface to compile with libface
> trunk. However, when I ran the GUI to test if everything was working, I
> found there was a segfault, coming from QList which I haven't figured out
> why yet. Do you want me to submit the latest change with new internal
> version of libface that builds but won't work?

No don't commit something that crashes ;-)
You could post the patch here.

See also the commit by Michael yesterday.
Your work is about using libkface with the new libface 0.2 API, right?

Btw I would prefer to keep specificity in the libkface API, in case we support
that again in the future. For me, it is orthogonal to the speed setting.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Gilles Caulier-4
Alex,

I compiled and installes libface from svn trunk and tried to compile
libkface. It doesn't work :

[gilles@localhost libface]$ svn up
À la révision 286.

[gilles@localhost libface]$
[gilles@localhost libkface]$ make
[  0%] Built target kface_automoc
Scanning dependencies of target kface
[  0%] Building CXX object
extra/libkface/libkface/CMakeFiles/kface.dir/kface_automoc.cpp.o
[  0%] Building CXX object
extra/libkface/libkface/CMakeFiles/kface.dir/database.cpp.o
/mnt/data/devel/GIT/2.x/extra/libkface/libkface/database.cpp: In
member function ‘QList<KFaceIface::Face>
KFaceIface::Database::detectFaces(const KFaceIface::Image&)’:
/mnt/data/devel/GIT/2.x/extra/libkface/libkface/database.cpp:185:
erreur: no matching function for call to
‘libface::LibFace::detectFaces(const IplImage* const&, CvSize)’
/usr/include/libface/LibFace.h:98: note: candidats sont:
std::vector<libface::Face*, std::allocator<libface::Face*> >*
libface::LibFace::detectFaces(const IplImage*)
/usr/include/libface/LibFace.h:112: note:
std::vector<libface::Face*, std::allocator<libface::Face*> >*
libface::LibFace::detectFaces(const std::string&, int)
/usr/include/libface/LibFace.h:129: note:
std::vector<libface::Face*, std::allocator<libface::Face*> >*
libface::LibFace::detectFaces(const char*, int, int, int, int, int,
int)
/mnt/data/devel/GIT/2.x/extra/libkface/libkface/database.cpp: In
member function ‘bool
KFaceIface::Database::updateFaces(QList<KFaceIface::Face>&)’:
/mnt/data/devel/GIT/2.x/extra/libkface/libkface/database.cpp:226:
erreur: no matching function for call to
‘libface::LibFace::update(std::vector<libface::Face,
std::allocator<libface::Face> >*)’
/usr/include/libface/LibFace.h:252: note: candidats sont: int
libface::LibFace::update(const std::string&,
std::vector<libface::Face*, std::allocator<libface::Face*> >*, int)
/usr/include/libface/LibFace.h:268: note:                 int
libface::LibFace::update(const char*, std::vector<libface::Face*,
std::allocator<libface::Face*> >*, int, int, int, int, int, int)
/usr/include/libface/LibFace.h:279: note:                 int
libface::LibFace::update(std::vector<libface::Face*,
std::allocator<libface::Face*> >*, int)
/usr/include/libface/LibFace.h:289: note:                 int
libface::LibFace::update(const IplImage*, std::vector<libface::Face*,
std::allocator<libface::Face*> >*, int)
/mnt/data/devel/GIT/2.x/extra/libkface/libkface/database.cpp: In
member function ‘QList<double>
KFaceIface::Database::recognizeFaces(QList<KFaceIface::Face>&)’:
/mnt/data/devel/GIT/2.x/extra/libkface/libkface/database.cpp:273:
erreur: no matching function for call to
‘libface::LibFace::recognise(std::vector<libface::Face,
std::allocator<libface::Face> >*)’
/usr/include/libface/LibFace.h:186: note: candidats sont:
std::vector<std::pair<int, float>, std::allocator<std::pair<int,
float> > > libface::LibFace::recognise(const IplImage*,
std::vector<libface::Face*, std::allocator<libface::Face*> >*, int)
/usr/include/libface/LibFace.h:199: note:
std::vector<std::pair<int, float>, std::allocator<std::pair<int,
float> > > libface::LibFace::recognise(const std::string&,
std::vector<libface::Face*, std::allocator<libface::Face*> >*, int)
/usr/include/libface/LibFace.h:211: note:
std::vector<std::pair<int, float>, std::allocator<std::pair<int,
float> > > libface::LibFace::recognise(const char*,
std::vector<libface::Face*, std::allocator<libface::Face*> >*, int,
int, int, int, int, int)
/usr/include/libface/LibFace.h:222: note:
std::vector<std::pair<int, float>, std::allocator<std::pair<int,
float> > > libface::LibFace::recognise(std::vector<libface::Face*,
std::allocator<libface::Face*> >*, int)
make[2]: *** [extra/libkface/libkface/CMakeFiles/kface.dir/database.cpp.o]
Erreur 1
make[1]: *** [extra/libkface/libkface/CMakeFiles/kface.dir/all] Erreur 2
make: *** [all] Erreur 2

Gilles Caulier

2011/3/13 Marcel Wiesweg <[hidden email]>:

>
>> I have made necessary changes to the libkface to compile with libface
>> trunk. However, when I ran the GUI to test if everything was working, I
>> found there was a segfault, coming from QList which I haven't figured out
>> why yet. Do you want me to submit the latest change with new internal
>> version of libface that builds but won't work?
>
> No don't commit something that crashes ;-)
> You could post the patch here.
>
> See also the commit by Michael yesterday.
> Your work is about using libkface with the new libface 0.2 API, right?
>
> Btw I would prefer to keep specificity in the libkface API, in case we support
> that again in the future. For me, it is orthogonal to the speed setting.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Marcel Wiesweg
In reply to this post by Marcel Wiesweg

Please

1) Use the libface-0.2 branch from now to continue work on libface-0.2:
git checkout -b libface-0.2 origin/libface-0.2
master has been reverted and will use the local copy until work has come to a
conclusion.

2) Let us continue the discussion in a dedicated mailing list thread

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Marcel Wiesweg

> 1) Use the libface-0.2 branch from now to continue work on libface-0.2:
> git checkout -b libface-0.2 origin/libface-0.2

Alex, as you have local changes: Do not git pull --rebase first. Store the
changes with git stash, then checkout the branch as above, then reapply with
git stash pop.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

alexjironkin
K, So here is a quick low down on what I did and why. There was a memory leak as the pointer wasn't released when libface::Face was destroyed. So I have added that, which ultimately meant that no Face objects could be on stack, as they would be destroyed and subsequently pointer released. So I have changed the vectors to only contain pointers to the Face objects, meaning pointer wasn't released unnecessary, and would also cut down on amount of memory allocated.

This has resulted in downstream changes to interface. Subsequently some changes had to be made in libkface to accommodate for the same reasons. So I have changed a lot of QList<Face> references internally to QList<Face*> . I have made all necessary changes to the libkface and everything compiles fine. Except as I have described before there is a segfault in detection, which I haven't figured out yet. The patch is rather large to submit here because of all the changes, none the less I can still make it and post it here so everyone can patch it up.

On the different note I have merged the 0.2 branch with trunk so the latest copy is there. There is a 0.1 folder in the tags, if anyone needs the 0.1 copy.


Alex

On 13 Mar 2011, at 21:44, Marcel Wiesweg wrote:

>
>> 1) Use the libface-0.2 branch from now to continue work on libface-0.2:
>> git checkout -b libface-0.2 origin/libface-0.2
>
> Alex, as you have local changes: Do not git pull --rebase first. Store the
> changes with git stash, then checkout the branch as above, then reapply with
> git stash pop.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein



_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Marcel Wiesweg

> K, So here is a quick low down on what I did and why. There was a memory
> leak as the pointer wasn't released when libface::Face was destroyed. So I
> have added that, which ultimately meant that no Face objects could be on
> stack, as they would be destroyed and subsequently pointer released. So I
> have changed the vectors to only contain pointers to the Face objects,
> meaning pointer wasn't released unnecessary, and would also cut down on
> amount of memory allocated.

Yes, I think this is a good thing to do. With Qt, we are used not to worry
about this stuff, but with STL we need to worry.

>
> This has resulted in downstream changes to interface. Subsequently some
> changes had to be made in libkface to accommodate for the same reasons. So
> I have changed a lot of QList<Face> references internally to QList<Face*>
> . I have made all necessary changes to the libkface and everything
> compiles fine. Except as I have described before there is a segfault in
> detection, which I haven't figured out yet. The patch is rather large to
> submit here because of all the changes, none the less I can still make it
> and post it here so everyone can patch it up.

Just commit to the libface-2.0 branch of libkface. It's all right to have a
crash in there. Now that we are on git, we need to take the benefit of easy
branching ;-)
If you have your changes as normal local changes in your libkface clone, just
proceed with
git stash
git checkout -b libface-0.2 origin/libface-0.2
git stash pop
git commit ...
git push

>
> On the different note I have merged the 0.2 branch with trunk so the latest
> copy is there. There is a 0.1 folder in the tags, if anyone needs the 0.1
> copy.

Ok
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

alexjironkin
K I have just pushed my copy. Everything compiles but still crashes.
To reproduce is simple: just try running face detection from test GUI.


Alex


On Mon, Mar 14, 2011 at 6:37 PM, Marcel Wiesweg <[hidden email]> wrote:

>
>> K, So here is a quick low down on what I did and why. There was a memory
>> leak as the pointer wasn't released when libface::Face was destroyed. So I
>> have added that, which ultimately meant that no Face objects could be on
>> stack, as they would be destroyed and subsequently pointer released. So I
>> have changed the vectors to only contain pointers to the Face objects,
>> meaning pointer wasn't released unnecessary, and would also cut down on
>> amount of memory allocated.
>
> Yes, I think this is a good thing to do. With Qt, we are used not to worry
> about this stuff, but with STL we need to worry.
>
>>
>> This has resulted in downstream changes to interface. Subsequently some
>> changes had to be made in libkface to accommodate for the same reasons. So
>> I have changed a lot of QList<Face> references internally to QList<Face*>
>> . I have made all necessary changes to the libkface and everything
>> compiles fine. Except as I have described before there is a segfault in
>> detection, which I haven't figured out yet. The patch is rather large to
>> submit here because of all the changes, none the less I can still make it
>> and post it here so everyone can patch it up.
>
> Just commit to the libface-2.0 branch of libkface. It's all right to have a
> crash in there. Now that we are on git, we need to take the benefit of easy
> branching ;-)
> If you have your changes as normal local changes in your libkface clone, just
> proceed with
> git stash
> git checkout -b libface-0.2 origin/libface-0.2
> git stash pop
> git commit ...
> git push
>
>>
>> On the different note I have merged the 0.2 branch with trunk so the latest
>> copy is there. There is a 0.1 folder in the tags, if anyone needs the 0.1
>> copy.
>
> Ok
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>



--
"The generation of random numbers is too important to be left to
chance" - Robert R. Coveyou
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

alexjironkin
Just made another push of all the changes I have. I have no idea why
there is a segfault. It occurs on line 114 in face.cpp when detecting
faces.

Sorry

Alex


On Tue, Mar 15, 2011 at 10:45 PM, Alex Jironkin <[hidden email]> wrote:

> K I have just pushed my copy. Everything compiles but still crashes.
> To reproduce is simple: just try running face detection from test GUI.
>
>
> Alex
>
>
> On Mon, Mar 14, 2011 at 6:37 PM, Marcel Wiesweg <[hidden email]> wrote:
>>
>>> K, So here is a quick low down on what I did and why. There was a memory
>>> leak as the pointer wasn't released when libface::Face was destroyed. So I
>>> have added that, which ultimately meant that no Face objects could be on
>>> stack, as they would be destroyed and subsequently pointer released. So I
>>> have changed the vectors to only contain pointers to the Face objects,
>>> meaning pointer wasn't released unnecessary, and would also cut down on
>>> amount of memory allocated.
>>
>> Yes, I think this is a good thing to do. With Qt, we are used not to worry
>> about this stuff, but with STL we need to worry.
>>
>>>
>>> This has resulted in downstream changes to interface. Subsequently some
>>> changes had to be made in libkface to accommodate for the same reasons. So
>>> I have changed a lot of QList<Face> references internally to QList<Face*>
>>> . I have made all necessary changes to the libkface and everything
>>> compiles fine. Except as I have described before there is a segfault in
>>> detection, which I haven't figured out yet. The patch is rather large to
>>> submit here because of all the changes, none the less I can still make it
>>> and post it here so everyone can patch it up.
>>
>> Just commit to the libface-2.0 branch of libkface. It's all right to have a
>> crash in there. Now that we are on git, we need to take the benefit of easy
>> branching ;-)
>> If you have your changes as normal local changes in your libkface clone, just
>> proceed with
>> git stash
>> git checkout -b libface-0.2 origin/libface-0.2
>> git stash pop
>> git commit ...
>> git push
>>
>>>
>>> On the different note I have merged the 0.2 branch with trunk so the latest
>>> copy is there. There is a 0.1 folder in the tags, if anyone needs the 0.1
>>> copy.
>>
>> Ok
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>
>
>
> --
> "The generation of random numbers is too important to be left to
> chance" - Robert R. Coveyou
>



--
"The generation of random numbers is too important to be left to
chance" - Robert R. Coveyou
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Marcel Wiesweg

> Just made another push of all the changes I have. I have no idea why
> there is a segfault. It occurs on line 114 in face.cpp when detecting
> faces.

Thanks.
I'll need some time to look through this (which I dont have too much at the
moment.)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Karl Günter Wünsch
In reply to this post by Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #37 from  <kgw mineralien-verkauf de>  2011-07-17 13:51:43 ---
I'm still waiting for the face detection to become an optional component, it
doesn't make sense for me or anybody I know so it has no place cluttering the
interface!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Gilles Caulier-4
In reply to this post by Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #38 from Gilles Caulier <caulier gilles gmail com>  2011-07-19 09:56:59 ---
libkface and libkmap cannot be optional for 2.0.0.

My viewpoint is to not make it as optional for the future...

Marcel, Michael ? Fine for you ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Karl Günter Wünsch
In reply to this post by Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=267789





--- Comment #39 from  <kgw mineralien-verkauf de>  2011-07-19 10:12:02 ---
(In reply to comment #38)
> libkface and libkmap cannot be optional for 2.0.0.
But a "cannot" is simply not true.
I have made it optional (by removing it completely) in about 2 hours of my time
on sunday. If you want the diff you can have it later this evening - simply add
a config option to switch these things off and it's gone (like it should).
As for the reason I did this: For one I can't get the face detection framework
running (I tried for weeks but it will not compile in my environment on Linux)
and for the other I don't care one iota for the excessive clutter it produces
in the UI for something I have no use whatsoever for - have you ever clicked on
the wrong button and the wretched thing starts scanning 100.000+ images for
faces that don't exist - everything grinds to a halt...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

Gilles Caulier-4
In reply to this post by Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=267789


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX




--- Comment #40 from Gilles Caulier <caulier gilles gmail com>  2011-07-19 12:16:50 ---
i will be more precise :
1- there is no plan to make' these depencies as optional. this will make  big
puzzle i source code, and will take a while.
2- if you cannot build under your linux, check your system and ask to your
distro team (or change for a better distro). 2.0.0 compilie fine here under
mandriva. mageia, macosx, and win7. just check properlies depencies listed on
README files.
3- 2.0.0 will be released in a few day. you can wait for a packaging solution.
4- we have work indeep on these features which are ask as top of whishes from
users through kde bugzilla. this is ot to remove it as well because one user
don't care or don't need.
5- if you start by error a face detection (which work perfectly here), just
press cancel button it just too simple to understand...
6- and finally, if you want to ask something to an open source team, you must
ask it properly, whitout to be nervous. ther is some respect against team to
have
gilles caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12345