[Bug 114465] New: Wish: simpler entry of tags

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From mikmach wp pl  2008-03-29 11:41 -------
1. Julien is right: When I create tag One<Enter>, digiKam creates tag
   One and focus on it. It means if I type Two<Enter> Two will be
   created as subtag of One - in other words it will create hierarchy
   One->Two. Not necessarily bad thing but:

   Problem is not with high level tags at root hierarchy but with those
   nested deeper. Solution would be introduction of basic keyboard
   navigation for tag tree *without leaving focus of text widget*. For
   example Alt-Left is moving focus one level up, Alt-Up moves one tag up,
   Alt-Down moves focus one tag down.

2. This is keyboard driven widget, there must be a way for giving focus
   to it with keyboard. Label (one letter would be enough) with hotkey
   is obvious solution.

3. When I enter tag which already exists digiKam gives me message "Tag
   name already exists". a) I think this widget should also assign
   already existing tags b) if there is was given more than one tag eg,
   "One, Two, Three" there is no way to tell which tag wasn't assigned.
   Message should be changed to "Tags already exist: <tagnames>"

4. When I have tag "/One" (in root level) and want to create new subtag
   with command "/One/Two" digiKam refuses with "Tag name already
   exists".

Very good feature but it requires a bit of polish :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-29 12:36 -------
With revision #791391, new tag created do not take focus.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From Julien narboux fr  2008-03-29 14:11 -------
Tested revision #791391, this solved the problem of the focus.

There is a small issue about tag unselect.
Scenario:
click on a tag -> the tag is selected.
click on the white space under the tag tree -> the tag is unselected but has focus
click on the tag text edit -> the text edit gets the focus
type a tag name
the tag is created has child of a tag which does not appear to be selected.

I think there is a confusion between "focus" and "selection" the tag creation mechanism takes into account focus.

Julien
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24111|0                           |1
        is obsolete|                            |



------- Additional Comments From caulier.gilles gmail com  2008-03-29 15:09 -------
(From update of attachment 24111)
code is now in svn
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-29 15:12 -------
To julien #79 => fixed with rev. #791417

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From arnd.baecker web de  2008-03-29 15:55 -------
Two more points about the new tag entry field:
a) For /known_tag
   /kno<TAB> should complete to /known_tag.
   It would be even better, if for

     /tag1
     /tag2
     /tag3
   
   typing /t<TAB> will show  /tag
   and another TAB will show /tag1
   and another TAB will show /tag2
   and another TAB will show /tag3
   (i.e. cycling through the tags which are available)
   (This is a bit in spirit of c#32).
   Is this something which in princple could be done with the
   completer?

b) After adding a new tag,
   "Revert all changes" only unticks newly created tags,
   but it does not remove them.
   Well, it was never the case so far, and it is disputable, if
   we want to do this.
   However, with the new mechanism it is pretty easy to add
   several tags in one go, and maybe accidentally at the wrong place.
   So a quick undo might be more necessary than before?
   ((For me this is not a show-stopper, but I wanted to at least
   mention it ;-))
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-29 21:20 -------
SVN commit 791545 by cgilles:

digiKam from KDE3 branch : Captions & Tags: Create New Tags line edit now support auto-completion.
CCBUGS: 114465


 M  +4 -0      imagedescedittab.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=791545
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-29 22:04 -------
SVN commit 791558 by cgilles:

digiKam from KDE3 branch : Caption & Tags: Create New Tags text field :
- support tags path as with autocompletion (not only tags name)
- new rule in tag hiearchy parser to do not show an error message if tag already exist.
CCBUGS: 114465


 M  +25 -4     imagedescedittab.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=791558
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-29 22:45 -------
Mik,

Can you test current svn implementation ?

- Auto-completion is supported for tags creation.
- if tags already exist, now error message is show... but tag is set to current image selection.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From mikmach wp pl  2008-03-29 23:30 -------
> - if tags already exist, now error message is show... but tag is set to
> current image selection.


Don't understand you here. It works as I dreamed :) New tags are
created, existing ones assigned. Great!

OK, there is bug:

/Europe  is created
/Europe/France is created

but

/Europe/France/Paris isn't created while if it already exists only
/Europe is assigned. Completion works, so digiKam is "aware" of
existence of complete hierarchy.

also

/Europe/France isn't assigned if it already exists - only /Europe.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-30 10:54 -------
Mik,

> - if tags already exist, now error message is show... but tag is set to
> current image selection.

==> no error message is show... i want mean. I'm a little bit tired

I will take a look about others point that you have just reported.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-30 12:03 -------
Mik,

Fixed with rev. #791762. Try again (:=)))...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> Fixed with rev. #791762. Try again (:=)))...

Works as charm :)

*cough* small interface issue: when leaving tagging widget with tab
after writing in some text this text isn't removed. Works OK if nothing
was written. It works properly of course not assigning/creating any tags
just this small usability problem.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-31 12:48 -------
SVN commit 792122 by cgilles:

digiKam from KDE3 branch : Tag Edit Dialog is now the common implementation for simpler and fast Tags hierarchies entry.
- Dialog is now redesigned. There is new text to guide user for fast tagging creation.
- In this dialog, the rules are the same than Caption & Tags create new tags field.
- Dialog includes several static methods to create TAlbums and show errors if creation fail.
- Tags Folder View, Tags Filter View and Tags pop-up menu use these new static methods.
CCBUGS: 114465



 M  +163 -15   digikam/tageditdlg.cpp  
 M  +17 -1     digikam/tageditdlg.h  
 M  +7 -10     digikam/tagfilterview.cpp  
 M  +7 -8      digikam/tagfolderview.cpp  
 M  +5 -9      digikam/tagspopupmenu.cpp  
 M  +25 -80    libs/imageproperties/imagedescedittab.cpp  
 M  +2 -4      libs/imageproperties/imagedescedittab.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=792122
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-31 12:51 -------
Mik, Gerhard, Arnd, Fabien,

To simplify source code, i have factorized several parts with commit #792122 and redesigned the Tag Creation dialog used everywhere.

Please tests tags creation in all possible cases, especially from Tags Folder View, Tags Filter View, and Tags pop-up menu.

Thanks in advance

Gilles Caulier

TODO: Next stage is about to use keyboard shortcuts with Tags. After that, i will close this file...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-31 13:00 -------
Created an attachment (id=24136)
 --> (http://bugs.kde.org/attachment.cgi?id=24136&action=view)
New Tags creation dialog
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From Julien narboux fr  2008-03-31 13:26 -------
Great Gilles ! you program almost quicker than I can compile...

Tested revision 792130 :

- the completion does not take into account the current selection, completion is always computed with regard to the root

- completion proposes a solution even if it is not unique (it gives the first solution), I think it should wait to have enough letters

- pressing the tab key does not complete current word but move to the next widget, maybe it shouldn't ?

Best,

Julien
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-31 13:47 -------
To Julien #92,

>- the completion does not take into account the current selection, completion is >always computed with regard to the root

yes. more complicated to do. in my TODO list.

>- completion proposes a solution even if it is not unique (it gives the first >solution), I think it should wait to have enough letters

yes. idem.

>- pressing the tab key does not complete current word but move to the next >widget, maybe it shouldn't ?

For this point, the issue come from KDELibs KLineEdit API which only support "end" key to complete strings (i'm not sure, but i haven't found explanation in KDE source code).

Also, unforget than TAB is used in GUI to change widget focus. It's incompatible with shell auto-completion rule.

Try to change auto-completion mode by line edit pop-up menu. There is combo box mode which is interesting to use.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From Julien narboux fr  2008-03-31 13:58 -------
>Try to change auto-completion mode by line edit pop-up menu. There is combo box mode which is interesting to use.

Ok thanks I was not aware of this menu.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[krienke]

Am Montag, 31. März 2008 13:00:02 schrieb Gilles Caulier:

I just tried the new tag creation  dialog. Tag creation is really nice now. I
have however one comments for this new feature:

- When creating new tags I am unsure if autocompletion in the last stage of
the tagname (i.e. the last existing child, a leaf) is really useful. This
would only be the case if a new tag or the root of a new hierarchy would in
many cases be based on an existing tag name. So this would be only then be
helpful if you want to create tags like  /parent/blue and
then   /parent/bluewater, /parent/bluesea/fish. I think in most cases you
want to create tags
like /parent/red, /parent/green, /parent/water, /parent/sky. In these cases
the leaf-autocompletion is puzzling the user because I do not search a tag
but want to enter a new one but the system gives me a "proposal":  If I have
a minimal hierarchy like "/parent/a" and then want to enter a new
tag "/parent/b". If I just type "/parent/" then autocompletion shows
me "/parent/a" which is the point I found confusing. I know I can simply go
on typing but the point is if autocompletion really does make sense here.

Please note: Whereever I search photos having certing tags leaf-autocompletion
is of course very useful. However when entering a new tag I think a leaf in
the tag hierarchy tree like described above should not be shown by
autocompletion.

Rainer
--
Rainer Krienke, Uni Koblenz, Rechenzentrum, A22, Universitaetsstrasse  1
56070 Koblenz, http://www.uni-koblenz.de/~krienke, Tel: [phone]
PGP: http://www.uni-koblenz.de/~krienke/mypgp.html,Fax: [phone]

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel