[Bug 114465] New: Wish: simpler entry of tags

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-28 17:49 -------
Created an attachment (id=24107)
 --> (http://bugs.kde.org/attachment.cgi?id=24107&action=view)
kmail folder/shorcut assignement screenshot
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24106|0                           |1
        is obsolete|                            |



------- Additional Comments From caulier.gilles gmail com  2008-03-28 20:56 -------
Created an attachment (id=24109)
 --> (http://bugs.kde.org/attachment.cgi?id=24109&action=view)
Tag creation from Caption & Tags sidebar (patch #2)

2nd version of patch against KDE3 svn implementation to solve this issue.

There is a new tag text field parser to handle tag hierarchy delimited with
"/".

Note: if hierarchy start with "/", tags hierarchy is created from root tag
album, else current tag selected in folder view is used instead.

TODO : to be able to create multiple tags hierarchy at the same time using " "
separator.

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-28 21:01 -------
To all in this room,

If i use ' ' (space) as tags hierarchy separator, we will have a problem with tag names composed by more than one words.

As Mik said previously, it will be more fine to use another special character, like ','. So if we enter this string :

"/France/City/Paris,/GB/City/London"

... we will have 2 hierarchy created from tag root album : one starting by France and another one by GB.

Your viewpoints ?

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From kde-2 dotancohen com  2008-03-28 21:17 -------
Instead of "," as a deliminator, I propose ", ". This will be consistent with email address delimination.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-28 21:29 -------
Mik, Arnd, Gerahrd, Julien, Fabien,

What do you think about Dotan proposal ?

What other photo-management programs use ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24109|0                           |1
        is obsolete|                            |



------- Additional Comments From caulier.gilles gmail com  2008-03-28 21:33 -------
Created an attachment (id=24111)
 --> (http://bugs.kde.org/attachment.cgi?id=24111&action=view)
Tag creation from Caption & Tags sidebar (patch #3)

3th version of patch against KDE3 svn implementation to solve this issue.

Text field parser now can handle multiple tag hierarchies delimited with
",".

Please test this patch indeep before than i apply it to svn...

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From mikmach wp pl  2008-03-28 22:45 -------
No comments on patch itself, still compiling.

1. Don't agree with Dotan's proposal. ", " is too strict, requiring of
   whitespace for such casual thing is hard to remember.
2. I think that this field should be used also for assigning of existing
   tags. We have 3 possible scenarios:

   a) user wants to create new tags; focus onto new widget, type
      string of tags, all are created - wonderful
   b) user wants to only assign existing tags; uses shortcuts or dialog
      like as message moving in KMail - wonderful (with caveat*)
   c) user wants to create new tags AND assign existing - for such basic
      functionality (s)he has to perform functions in two different
      interfaces - not so wonderful, frankly - far from it; with use of
      new widget for both actions it will be simple and fast

   * caveat for KMail moving dialog - only one tag at the moment; for me
   it is major one - for whole time evolution in tag assignment was
   going to speed up assignation of multiple tags, now we are
   introducing completely new interface which is committed for doing one
   thing at the time

   Judging by myself, after several months of use, there will be core
   foundation of tags used very often and probably one or two new for
   importing session of describing of 100-200 pictures.

One comment about shortcuts. Yes they are theoretically unlimited, but
practically they are *very* limited. Many Ctrl-x (x as "something", not
literally) are reserved for global actions, many Alt-x are reserved for
hotkeys or even input of regular charactes (think AltGr), besides
- together with Ctrl-Fx and Alt-Fx will be probably reserved for custom
global task of user (and last two are not very convenient).
Alt-Ctrl-x shortcus are only for people with big hands.  So, practical
reserve of keyboard shortcuts is limited.

If digiKam migrate to system of one key shortcuts (like GIMP, Inkscape)
it would change situation but only marginally. With one key shortcuts
modus operandi is: one hand on keyboard, one hand on mouse. With such
setup number of combined shortcuts you can comfortably execute with one
hand also isn't big.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-28 23:01 -------
Thanks for the feedback Mik. I will commit my patch to svn.

I have take a look into KMail to see how folder shortcuts is implemented: it's not too complicated and i will do a similar implementation into digiKam core.

About one key shortcut for tag, are you sure than it's currently impossible to do it with KDE3 applications ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-28 23:04 -------
SVN commit 791266 by cgilles:

digiKam from KDE3 branch : Caption & Tags sidebar tab : add new text edit field to create new tags in database
CCBUGS: 114465
TODO: KDE4PORT


 M  +88 -11    imagedescedittab.cpp  
 M  +2 -1      imagedescedittab.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=791266
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-28 23:27 -------
SVN commit 791285 by cgilles:

backport commit #791266 from KDE3 branch
CCBUGS: 114465


 M  +92 -13    imagedescedittab.cpp  
 M  +2 -1      imagedescedittab.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=791285
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From mikmach wp pl  2008-03-28 23:41 -------
> About one key shortcut for tag, are you sure than it's currently
> impossible to do it with KDE3 applications ?


I can easily assign any KAction in shortcuts configure dialog to single
letter and it works. For hardcoded shortcuts try jk and JK in Konq :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-28 23:43 -------
Mik,

Then, for me, there is no limitation to use Keyboard shortcuts with Tags as well...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From Julien narboux fr  2008-03-29 10:11 -------
I tested the new text edit field. It works nicely, thanks Gilles.

Except this :

if you type tag1, tag2 it creates a tag2 with a space in front, I think the space should be ignored.

Concerning the syntax for multiple tags entry there are several options :

#1 : Use ',' as a separator, assuming ',' is forbidden in tags. I think the spaces after each ',' should be ignored.

Example:
tag1, the tag2

produces "tag1" and "the tag2"

#2 : Use ' ' as a separator, assuming that if the user wants a space inside a tag, he puts the tag between quotes.

Example:
tag1 "the tag2"

produces "tag1" and "the tag2"


Arguments:

#1 one does not have to know about the quote trick
#2 one does not have to know about the ','

Flickr use #2.



Concerning where the tags are created in the tag tree:

Currently the tags are created as a child of current selection.
This means that if you type tag1 enter then tag2 enter you get tag2 as a child of tag1.

I am not sure that this behaviour should be kept.

There are several possibilities :

#t1 Create tag as a child of current selection, newly created tag gets the selection. (Currently implemented).

This means that if you type tag1 enter then tag2 enter you get tag2 as a child of tag1.

#t2 Create tag as a child of current selection, assign the tag but do not change the selection

Example: if you type tag1 enter and tag2 enter, it creates two tags as child of the current selection.

#t3 Create tag as a child of root by default. If one wants to create a tag in a subtree he has to use the "/tag1/tag2/tag3" syntax. We could also invent a syntax to mean current selection, for instance  /tag1 would create a child of current selection.

Example: if you type tag1 enter and tag2 enter, it creates two tags at the root level.


#t3 seems to be a good option because it is easy to grasp for first time users.
Tags are created at root level, if one want to organize them in the hierarchy one can use the mouse.

#t2 is easier to use for doing complex thing

Best,

Julien
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From arnd.baecker web de  2008-03-29 10:32 -------
> if you type tag1, tag2 it creates a tag2 with a space in front, I
> think the space should be ignored.

Yes, leading and trailing spaces should be ignored.

About "," vs. " " as separator:
maybe one could use both at the same time, i.e.:
if a "," is detected: #1 applies. If a "
is detected, #2 applies?
(Or make this configurable?)

Concerning the place where tags are created:
The advantage of #t1 is that one visually sees
where a new tag is created.

I don't like variant #t3, but this
could be made a configuration option?

(BTW: Excellent overview, Julien!)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From Julien narboux fr  2008-03-29 10:34 -------
Concerning tag assignment using text field, consider the following tag tree:

people -> family -> peter jane bob
       -> friend -> bob alice


I think if one types a tag which appears already in the tag tree and which appears only one time (example: alice) it should be assigned even if one did not type the full path.

I am concerned about tags which appear at two places (example: bob).

Then what should be done ?
- ask the user which "bob" ?
- assign both ?
- ... ?

I suppose if the text field is used for both tag assignment and creation then a different color should be used for existing tags and newly created.

Julien
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From Julien narboux fr  2008-03-29 10:40 -------
> About "," vs. " " as separator:
> maybe one could use both at the same time, i.e.:
> if a "," is detected: #1 applies. If a "
> is detected, #2 applies?
>(Or make this configurable?)

These two option are not really  deeply different, so I think this should not be an option.

From usability point of view it is better IMHO not to have too many options.
From implementation point of view as well ;-)

>Concerning the place where tags are created:
>The advantage of #t1 is that one visually sees
>where a new tag is created.

I think in #t2 one visually sees as well because the selection is still displayed, it is just that the selection is not moved to the newly created tag.

I guess the current behavior #t1 (vs #t2) is just a random consequence of the implementation.

Julien
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-29 10:42 -------
To Julien #69:

>Concerning where the tags are created in the tag tree:

>Currently the tags are created as a child of current selection.
>This means that if you type tag1 enter then tag2 enter you get tag2 as a child of >tag1.

No.

- If no tag album is selected in tree view root tag album is used as parent.
- If root tag album is selected in tree view root tag album is used as parent.
- If a sub-tag album is selected in tree view this tag album is used as parent.
- And the most important : if you use a '/' as first char of a tags hierarchy, root tag album is used as parent.
- If there no '/' as first char, current tag album is used as parent.

Ex: "/Country/City/Paris" ==> will be created using root tag album as parent.
    "This/is/Another/one" ==> will be created using current selected album in tree-view as parent.

Like this, all cases can be done from user to create new tag hierarchy.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-29 10:50 -------
SVN commit 791367 by cgilles:

strip white-space at bigen/end of tag
CCBUGS:114465


 M  +1 -1      imagedescedittab.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=791367
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From caulier.gilles gmail com  2008-03-29 11:11 -------
Julien,

Checkout svn. white-space are stripped at beginning and end of tag strings...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=114465         




------- Additional Comments From arnd.baecker web de  2008-03-29 11:38 -------
To Gilles in #73: Julien is right:
if you type (any place, root or sub-tag, does not matter):
tag1 <return>
tag2 <return>
you get
  - selected_tag_when_you_start_adding_tag1_and_tag2
    - tag1
      - tag2
I.e. tag2 is a subtag of tag1 and not of selected_tag_...
(i.e. case #1 above)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel