[digikam] [Bug 363859] New: digiKam core port from QWebKit to QWebEngine [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

            Bug ID: 363859
           Summary: digiKam core port from QWebKit to QWebEngine [patch]
           Product: digikam
           Version: 5.0.0
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Geolocation
          Assignee: [hidden email]
          Reporter: [hidden email]

I made a first patch porting QWebkit to QWebEngine of digiKam core. There are 2
part to port :

- welcomepageview : easy. no problem here.
- htmlwidget from Geolocation tool : not simple.

This last one do not well :

- The javascript scan done in background do not work very well. Search tool is
broken : try to select an area over the map with CTRL+left mouse button :
nothing happen.

- The central map view do not show geolocated item from current album.

- Same problem with geolocation view from right side bar.

Note that items from map search tool are displayed... Strange. This is not
homogeneous with the 2 last points...

Tests and improvements are welcome...

Gilles Caulier

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #1 from [hidden email] ---
Created attachment 99331
  --> https://bugs.kde.org/attachment.cgi?id=99331&action=edit
patch version 1

first version of patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Created attachment 100912
  --> https://bugs.kde.org/attachment.cgi?id=100912&action=edit
portWebEngine.2patch

Updated patch. Not yet ready for production use. QWebEngineView crashes with
Nouveau driver (I use the NVidia driver for testing). Update items still not
perfect, only after clicking in the view.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99331|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #100912|0                           |1
        is obsolete|                            |

--- Comment #3 from Maik Qualmann <[hidden email]> ---
Created attachment 102076
  --> https://bugs.kde.org/attachment.cgi?id=102076&action=edit
portWebEngine3.patch

Updated patch. Full working Google Maps with QWebEngine now. Problem with
Nouveau driver remains.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #4 from [hidden email] ---
As i use NVIDIA card GeForce 750 with Nouveau driver, i can check if problem is
reproducible here.

Q : This problem remain if Qt5 with OpenGL effect is compiled ? Or it's only a
dysfunction from QtWebEngine framework ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #5 from Maik Qualmann <[hidden email]> ---
I do not know. KMail with Nouveau driver crashes here as well. It could be due
to hardware acceleration. I currently use the NVidia driver. You can enabled
for test the line 127 in htmlwidget.cpp. Qt-5.7.0 is minimum for disable WebGL.

https://bugreports.qt.io/browse/QTBUG-41242

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #6 from [hidden email] ---
MAik,

Qt 5.8 have new Chrome engine version included. Perhaps the port will be better
with this new release of Qt WebEngine. See release announcement for details :

https://wiki.qt.io/New_Features_in_Qt_5.8

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102076|0                           |1
        is obsolete|                            |

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Created attachment 105300
  --> https://bugs.kde.org/attachment.cgi?id=105300&action=edit
portWebEngine4.patch

Update patch to current git/master.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #8 from [hidden email] ---
Maik,

I will include this patch in git /master with a dedicated compilation flag in
cmake. Like this we will able to deploy an experimental version as AppImage
soon...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #9 from [hidden email] ---
Maik,

The patch version 4 include minimal changes in backend-googlemaps-js Javascript
file, which sound like to be compatible with QWebView and QWebEngine. Do you
confirm that file can be patched as well without any side effect for QWebView ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #10 from Maik Qualmann <[hidden email]> ---
No, the file only works after the patch with QWebEngine. QWebEngine does not
support read status bar messages anymore. Everything now runs over Javascript
messages.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #11 from [hidden email] ---
So you mean that we need 2 javascript files, one for QWebView, one for
QWebEngine ? If yes, the googlemaps backend from geolocation code need to load
right file depending of cmake configuration. Typically, as i can see in
backendgooglemaps.cpp::line 208.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105300|0                           |1
        is obsolete|                            |

--- Comment #12 from [hidden email] ---
Created attachment 105493
  --> https://bugs.kde.org/attachment.cgi?id=105493&action=edit
updated patch with git/master code. no changes introduced...

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #13 from Maik Qualmann <[hidden email]> ---
Yes, we need 2 files.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #14 from Maik Qualmann <[hidden email]> ---
The backend-googlemaps-js.js is loaded by the backend-googlemaps.html. We need
a second backend-googlemaps.html and load into backendgooglemaps.cpp the right
file.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #15 from [hidden email] ---
Maik,

Can you update the patch with last current changes from git/master about
GeoIface namespace which have been dropped from digiKam core ?

No need to have QWebKit and QWebEngine support. The last one must be enough and
is more powerful than QWebkit. To be honest, I see the code from this
framework, mostly written by Apple, and it don't very well designed. I
understand with Qt team switch to QWebEngine forever...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105493|0                           |1
        is obsolete|                            |

--- Comment #16 from Maik Qualmann <[hidden email]> ---
Created attachment 106199
  --> https://bugs.kde.org/attachment.cgi?id=106199&action=edit
portWebEngine6.patch

updated patch with git/master code.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #17 from [hidden email] ---
Ok thanks i test this evening and i give you a feedback

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #18 from [hidden email] ---
Maik,

I tried the GoogleMaps view with your patch.

I found a dysfunction (i don't tested all possibilities yet). It's simple :
GoogleMaps work everywhere, excepted on central view when you switch from
thumbs view to map view. The view is a google html view as expected but without
the map tiles. There is no error on the console.

In fact the dysfonction appear only if you is centered on north pole. Switching
to marble map, panning a little bit, and go back again to google, fix the
problem.

Can you reproduce ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.