[digikam] [Bug 363859] New: digiKam core port from QWebKit to QWebEngine [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #19 from Maik Qualmann <[hidden email]> ---
Gilles,

Can you make a screencast? Which graphic driver do you use? I can not reproduce
it.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #20 from Maik Qualmann <[hidden email]> ---
I can reproduce something, it is possible to move the map down out. Then it is
no longer visible.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #21 from [hidden email] ---
The graphic card is a Virtual Box one. Nothing special here, just a basic one.

I tried and to problem is difficult to reproduce in fact. It happen when the
coordinates are located to north pole on an image. And it's reproducible on all
maps view. And also, it's reproducible with QWebKit engine. So it's not a
QWebEngine problem in fact.

The drag and drop of image in GPS editor work perfectly with GoogleMaps and
QWebEngine. Good point.

On Search Map view, the region selection tool do not work with GoogleMap and
QWebEngine, but it's fine with Marble. The region is draw, but when selection
is completed, nothing happen. Can you reproduce ?

Excepted for this dysfunction, all work as expected.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #22 from [hidden email] ---
MAik,

I can confirm that QWebEngine+Mapsearch tool is broken is selection mode. I
reverted to QWebKit, and it work fine.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #23 from Maik Qualmann <[hidden email]> ---
I just compile again because of a big update of my distribution. But the region
selection tool works very well. I will take a look at it.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106199|0                           |1
        is obsolete|                            |

--- Comment #24 from Maik Qualmann <[hidden email]> ---
Created attachment 106207
  --> https://bugs.kde.org/attachment.cgi?id=106207&action=edit
portWebEngine7.patch

The problem was in the selectionHasBeenMade() signal (GeoIface -> Digikam).

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #25 from [hidden email] ---
Maik,

I just tested.

It work better now. Please commit the patch, we will continue to finalize and
hack with git/master until 5.7.0. We have plenty of time while this summer...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.7.0
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/a2cbf0bbf27793f9d83ff8
                   |                            |6917e6301b3842eb15
         Resolution|---                         |FIXED

--- Comment #26 from Maik Qualmann <[hidden email]> ---
Git commit a2cbf0bbf27793f9d83ff86917e6301b3842eb15 by Maik Qualmann.
Committed on 21/06/2017 at 10:21.
Pushed by mqualmann into branch 'master'.

apply patch #106207 to port QWebKit to QWebEngine
FIXED-IN: 5.7.0

M  +1    -1    CMakeLists.txt
M  +2    -1    NEWS
M  +3    -3    app/CMakeLists.txt
M  +28   -5    app/views/welcomepageview.cpp
M  +22   -2    app/views/welcomepageview.h
M  +5    -15   data/geolocation/geoiface/backend-googlemaps-js.js
M  +2    -1    utilities/geolocation/geoiface/CMakeLists.txt
M  +35   -35   utilities/geolocation/geoiface/backends/backendgooglemaps.cpp
M  +222  -167  utilities/geolocation/geoiface/widgets/htmlwidget.cpp
M  +44   -14   utilities/geolocation/geoiface/widgets/htmlwidget.h

https://commits.kde.org/digikam/a2cbf0bbf27793f9d83ff86917e6301b3842eb15

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED
     Ever confirmed|0                           |1
   Version Fixed In|5.7.0                       |
      Latest Commit|https://commits.kde.org/dig |
                   |ikam/a2cbf0bbf27793f9d83ff8 |
                   |6917e6301b3842eb15          |

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363859

--- Comment #27 from [hidden email] ---
Some details about the problem seen with QtWebEngine port :

1/ The DK bundles explode. It's increased to 100Mb. QWebEngine
need to be optimized at compilation time. There are a lots of
possibilities due to the huge dependencies list. Also, QWebkit use 5
.pak files with binary data. It's not a negligible size. Why ? I don't
know yet.

2/ QWebEngine use a run time dependency and... dbus. This is really
weird. There is a stand alone executable dedicated to preload pages in
memory (if i well understand). This make AppImage not really easy to
run. I found a solution but i'm not happy with it. It's not really
optimum. I'm not alone with this problem. I'm in contact with AppImage
lead developer who maintain a CI suite to package application as
bundle, and most of Qt5 applications have a problem with this
QWebEngine dependency. The quick solution is to remove this dependency
and make code optional. This is not acceptable for digiKam. As i
understand, a call to Qt to make this framework better compatible with
bundle solutions was reported.

3/ There is a crash in QWebEngine when digiKam is closed. It's inside
libudev. I don't know why yet...

4/ Marble is not yet ported to QWebEngine and still use QWebkit to
render some parts inside. This will cut Marble features, and we don't want to
include both framework in the bundles.

5/ The time to compile Qt explode with QWebEngine : 1h36 with QWebkit, 3h15
with QWebEngine. Same VM under Centos 6.8 running on same computer.

So i must conclude that we need more time before to use QWebEngine
inside digiKam. The best solution is to provide code for both QWebkit
and QWebengine and to create a switch between both frameworks at
compilation time. QWebkit must be the default one.

I propose to make another try with Qt 5.10 and DK 6.0.0

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.