[Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

[Rainer Krienke-2]

Hello,

I recently turned digikams Metadata setting the option "save tags to IPTC" on.
Then I wondered if there is any option in digikam that helps me to save all
the tags already set before this option was turned on als IPTC tags into the
image files?

Else the images metadata will become kind of inconsitent since newer files
will have IPTC tags set that represent digikam tags other older images  will
not.

Thanks
Rainer  

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Hello,
>
> I recently turned digikams Metadata setting the option "save tags to IPTC"
> on. Then I wondered if there is any option in digikam that helps me to save
> all the tags already set before this option was turned on als IPTC tags
> into the image files?
>
> Else the images metadata will become kind of inconsitent since newer files
> will have IPTC tags set that represent digikam tags other older images
> will not.

Only in SVN since a few days:
Select all affected pictures in main view.
Comments/Tags sidebar, "More"->"Write metadata to each file"

We should also provide a batch operation accessible from the menu which does
this for all files, but implementing this option in the right side bar was
very easy, whereas the general tool requires more coding.

And note that this feature has not yet been widely tested.

>
> Thanks
> Rainer
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Samedi 20 Janvier 2007 14:25, Marcel Wiesweg a écrit :

> > Hello,
> >
> > I recently turned digikams Metadata setting the option "save tags to
> > IPTC" on. Then I wondered if there is any option in digikam that helps me
> > to save all the tags already set before this option was turned on als
> > IPTC tags into the image files?
> >
> > Else the images metadata will become kind of inconsitent since newer
> > files will have IPTC tags set that represent digikam tags other older
> > images will not.
>
> Only in SVN since a few days:
> Select all affected pictures in main view.
> Comments/Tags sidebar, "More"->"Write metadata to each file"
>
> We should also provide a batch operation accessible from the menu which
> does this for all files

Marcel,

There is a file in B.K.O about. I can do this tool if you want... excepted if
you have already started an implementation in your computer...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > We should also provide a batch operation accessible from the menu which
> > does this for all files
>
> Marcel,
>
> There is a file in B.K.O about. I can do this tool if you want... excepted
> if you have already started an implementation in your computer...

No I have not started such a tool.
It was very easy from the sidebar when I have the ImageInfo objects, so it was
only a few lines of code.

>
> Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Samedi 20 Janvier 2007 20:17, Marcel Wiesweg a écrit :

> > > We should also provide a batch operation accessible from the menu which
> > > does this for all files
> >
> > Marcel,
> >
> > There is a file in B.K.O about. I can do this tool if you want...
> > excepted if you have already started an implementation in your
> > computer...
>
> No I have not started such a tool.
> It was very easy from the sidebar when I have the ImageInfo objects, so it
> was only a few lines of code.
>

Ok. I will take a look in your code and build a batch tool.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

Hello,

Rainer Krienke wrote:

> I recently turned digikams Metadata setting the option "save tags to IPTC" on.
> Then I wondered if there is any option in digikam that helps me to save all
> the tags already set before this option was turned on als IPTC tags into the
> image files?
>
> Else the images metadata will become kind of inconsitent since newer files
> will have IPTC tags set that represent digikam tags other older images  will
> not.

Before there's the batch tool to do that, somebody suggested a trick to
do that :
<http://linuxappfinder.com/blog/digikam_lets_you_take_your_tags_with_you>

<<
It doesn't appear as if a batch processing mode exists to automatically
update the existing tags, however, I discovered a simple workaround that
will do it for you.

Step 1: Create a new tag called "temp". You can do this be selecting
Comments/Tags from the right sidebar, then right-clicking in the My Tags
section. An image must be selected for the menu to appear.

Step 2: Select Tag Filters from the right sidebar and check all of the
tags except "temp". This will only select pictures that already have a tag.

Step 3: Select all images. Right-click on one of them and pick "temp"
from the Assign Tag menu. This step will add all assigned tags each
file's IPTC data. With a large number of photos it could take a while
for everything to complete.

Step 4: Cleanup. Repeat the previous step by selecting all images, but
this time pick "temp" from the Remove Tag menu. Now you can delete the
"temp" tag and you are done.
 >>

Note: I never tested this trick myself :)
Use at your own risk...

--
Fabien

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Fabien,

The Batch tool is under construction on my computer. Waitting one day is
enought. I finalize it today (normaly... (:=)))

Gilles

Le lundi 22 janvier 2007 14:23, Fabien a écrit :

> Hello,
>
> Rainer Krienke wrote:
> > I recently turned digikams Metadata setting the option "save tags to
> > IPTC" on. Then I wondered if there is any option in digikam that helps me
> > to save all the tags already set before this option was turned on als
> > IPTC tags into the image files?
> >
> > Else the images metadata will become kind of inconsitent since newer
> > files will have IPTC tags set that represent digikam tags other older
> > images  will not.
>
> Before there's the batch tool to do that, somebody suggested a trick to
> do that :
> <http://linuxappfinder.com/blog/digikam_lets_you_take_your_tags_with_you>
>
> <<
> It doesn't appear as if a batch processing mode exists to automatically
> update the existing tags, however, I discovered a simple workaround that
> will do it for you.
>
> Step 1: Create a new tag called "temp". You can do this be selecting
> Comments/Tags from the right sidebar, then right-clicking in the My Tags
> section. An image must be selected for the menu to appear.
>
> Step 2: Select Tag Filters from the right sidebar and check all of the
> tags except "temp". This will only select pictures that already have a tag.
>
> Step 3: Select all images. Right-click on one of them and pick "temp"
> from the Assign Tag menu. This step will add all assigned tags each
> file's IPTC data. With a large number of photos it could take a while
> for everything to complete.
>
> Step 4: Cleanup. Repeat the previous step by selecting all images, but
> this time pick "temp" from the Remove Tag menu. Now you can delete the
> "temp" tag and you are done.
>
>
> Note: I never tested this trick myself :)
> Use at your own risk...
>
> --
> Fabien
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Hey guy !

The new Batch tool to sync all pictures metadata with digiKam database is in
svn (:=)))...

Please test it and give me a feedback.

I recommend to use a test pictures repository in case of something is wrong...

I have tested it in my computer and all work fine here...

Note : duing of a limitation of Exiv2 library, only JPEG file are updated.
Andreas work to TIFF writting codec and me into PNG codec. This is want mean
than later you can sync too TIFF and PNG images with this tool...

Gilles.

Le Lundi 22 Janvier 2007 15:56, Caulier Gilles(UNTRUSTED, sender is
<digikam-devel-bounces-+caulier.gilles=[hidden email]>) a écrit :

> Fabien,
>
> The Batch tool is under construction on my computer. Waitting one day is
> enought. I finalize it today (normaly... (:=)))
>
> Gilles
>
> Le lundi 22 janvier 2007 14:23, Fabien a écrit :
> > Hello,
> >
> > Rainer Krienke wrote:
> > > I recently turned digikams Metadata setting the option "save tags to
> > > IPTC" on. Then I wondered if there is any option in digikam that helps
> > > me to save all the tags already set before this option was turned on
> > > als IPTC tags into the image files?
> > >
> > > Else the images metadata will become kind of inconsitent since newer
> > > files will have IPTC tags set that represent digikam tags other older
> > > images  will not.
> >
> > Before there's the batch tool to do that, somebody suggested a trick to
> > do that :
> > <http://linuxappfinder.com/blog/digikam_lets_you_take_your_tags_with_you>
> >
> > <<
> > It doesn't appear as if a batch processing mode exists to automatically
> > update the existing tags, however, I discovered a simple workaround that
> > will do it for you.
> >
> > Step 1: Create a new tag called "temp". You can do this be selecting
> > Comments/Tags from the right sidebar, then right-clicking in the My Tags
> > section. An image must be selected for the menu to appear.
> >
> > Step 2: Select Tag Filters from the right sidebar and check all of the
> > tags except "temp". This will only select pictures that already have a
> > tag.
> >
> > Step 3: Select all images. Right-click on one of them and pick "temp"
> > from the Assign Tag menu. This step will add all assigned tags each
> > file's IPTC data. With a large number of photos it could take a while
> > for everything to complete.
> >
> > Step 4: Cleanup. Repeat the previous step by selecting all images, but
> > this time pick "temp" from the Remove Tag menu. Now you can delete the
> > "temp" tag and you are done.
> >
> >
> > Note: I never tested this trick myself :)
> > Use at your own risk...
> >
> > --
> > Fabien
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Daniel Bauer-2]

On Monday 22 January 2007 21:20, Caulier Gilles wrote:
> Hey guy !
>
> The new Batch tool to sync all pictures metadata with digiKam database is
> in svn (:=)))...
>
> Please test it and give me a feedback.

Good morning,

I'd like to, but I havn't tested the batch tool yet because it is not clear to
me what it is intended to do...

Can I please have a description of the intended functions, so that I can test
if it does what it should? (Sorry if I'm a bit slow on the uptake, but I
don't want to eventually report "errors" which maybe in fact are intended
features :-) )

How and what does it sync? Does it...
- write all IPTC/EXIF info into the database?
- or write all infos from the database into IPTC/EXIF?
- add database content to IPTC/EXIF (or vice versa?)?
- or overwrite the existing?
- remove (for example) keywords from IPTC/EXIF if not tagged in database (or
vice versa?)?
- etc?

thanks,

Daniel
--
Daniel Bauer photographer Basel Switzerland
professional photography: http://www.daniel-bauer.com
Madagascar special: http://www.sanic.ch
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le mardi 23 janvier 2007 10:02, Daniel Bauer a écrit :

> On Monday 22 January 2007 21:20, Caulier Gilles wrote:
> > Hey guy !
> >
> > The new Batch tool to sync all pictures metadata with digiKam database is
> > in svn (:=)))...
> >
> > Please test it and give me a feedback.
>
> Good morning,
>
> I'd like to, but I havn't tested the batch tool yet because it is not clear
> to me what it is intended to do...
>
> Can I please have a description of the intended functions, so that I can
> test if it does what it should? (Sorry if I'm a bit slow on the uptake, but
> I don't want to eventually report "errors" which maybe in fact are intended
> features :-) )
>
> How and what does it sync? Does it...
> - write all IPTC/EXIF info into the database?

no. this task is dedicaced to another part.

> - or write all infos from the database into IPTC/EXIF?

yes

> - add database content to IPTC/EXIF (or vice versa?)?

yes, from DB to metadata

> - or overwrite the existing?
> - remove (for example) keywords from IPTC/EXIF if not tagged in database
> (or vice versa?)?

This must be tested. normally yes. The function is the same than Comments &
Tags metadata update functions. It just do the same thing but on all albums
at the same time.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Daniel Bauer-2]

On Tuesday 23 January 2007 11:24, Caulier Gilles wrote:

> Le mardi 23 janvier 2007 10:02, Daniel Bauer a écrit :
> > On Monday 22 January 2007 21:20, Caulier Gilles wrote:
> > > Hey guy !
> > >
> > > The new Batch tool to sync all pictures metadata with digiKam database
> > > is in svn (:=)))...
> > >
> > > Please test it and give me a feedback.
> >
> > How and what does it sync? Does it...
> > - write all IPTC/EXIF info into the database?
>
> no. this task is dedicaced to another part.
>
> > - or write all infos from the database into IPTC/EXIF?
>
> yes
>
> > - add database content to IPTC/EXIF (or vice versa?)?
>
> yes, from DB to metadata
>
> > - or overwrite the existing?

After a few short tests I see some inconsistency here:

- it *overwrites* IPTC Copyright, Credit, Byline, Byline Title (don't know if
also other fields) with info from database
- it *adds* tags to IPTC keywords

(see my suggestions below)

> > - remove (for example) keywords from IPTC/EXIF if not tagged in database
> > (or vice versa?)?
>
> This must be tested. normally yes. The function is the same than Comments &
> Tags metadata update functions. It just do the same thing but on all albums
> at the same time.

it does *not* remove "untagged keywords"

I tested it like this:
- added tags/keywords to a file
- outside digikam: saved a copy of that file to another directory
- removed the tags/keywords within digikam from that file
- closed digikam, overwrote the file with the previously backed-up one
- opened digikam again
- now the Metadata was here again of course, but the tags were not checked
- run the sync tool - keywords remained untouched in Metadata

So, this is not a "real synchronisation", because there still remain
differences between database contents and metadata...

I think these are very complicated tasks, and this is why I still really,
really think, that the "advanced metadata handling" should be swapped out
completely from the sidebar options, so that they can be left simple and easy
and usable by "everybody", while the complicated stuff will be in a
independend tool. Then this tool can be developped further without changing
the behaviour of digiKam itself. It would also make it much easier to achieve
and maintain a consistent behaviour thruout the sidebars because added
functionalities in the "advanced tool" don't have to be in the sidebars too
and they can be left untouched even if fantastic new options are added to
the "advanced tools" in future.

- - - - - - -

For the sync tool, I would suggest some options that the user can choose from
before starting it:

- overwrite Metadata with the values, that are set in digiKam settings (like
Copyright etc.)
- OR leave these Metadata unchanged

- overwrite keywords in Metadata with tags from database (which also means,
keywords will be removed/overwritten with empty space when there are no tags)
-- OR add tags to existing keywords (as it does now)

Then, when choosing "overwrite mode" for both options there will be a
complete, real synchronisation between database and metadata. On the other
hand the user can decide to leave some inconsistency if this better suits
his/her needs.

If it's possible, I'd also wish an option:
- apply to all images in all albums (as is)
- only to actually displayed album
- eventually: only to selected images

- - - - - - -

during these tests I also (re-)found some other stuff, don't know if already
mentioned in bugs/wishes:

- when a file is copied into an album folder and that file contains Metadata
keywords that do not exist as tags yet, then digiKam creates tags for these
keywords, but the tags are not checked
- if you then check those tags, the keywords get duplicated
(this also happens with the new sync tool, because it adds tags to the
Metadata even if they same tags already exist as keywords - could be solved
with the "overwrite"-option suggested above)

- when Metadata is changed by applying/removing a tag in the Comments/Tags
sidebar and you then open the Metadata sidebar you still see the old,
unchanged Metadata. The Metadata display is only updated after clicking in
another image and back again. This is confusing, because actually the
Metadata *has* been changed, but when you look at it, you think it remained
unchanged.

- When deleting a tag in the Comments/Tags sidebar the sidebar gets greyed out
and remains greyed out even if you click into it. You have to click in the
album preview again (like select the already selected picture again).

Sorry for the long letter, tried to be as short as I can ;-)

Daniel
--
Daniel Bauer photographer Basel Switzerland
professional photography: http://www.daniel-bauer.com
Madagascar special: http://www.sanic.ch
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le mardi 23 janvier 2007 13:18, Daniel Bauer a écrit :

> On Tuesday 23 January 2007 11:24, Caulier Gilles wrote:
> > Le mardi 23 janvier 2007 10:02, Daniel Bauer a écrit :
> > > On Monday 22 January 2007 21:20, Caulier Gilles wrote:
> > > > Hey guy !
> > > >
> > > > The new Batch tool to sync all pictures metadata with digiKam
> > > > database is in svn (:=)))...
> > > >
> > > > Please test it and give me a feedback.
> > >
> > > How and what does it sync? Does it...
> > > - write all IPTC/EXIF info into the database?
> >
> > no. this task is dedicaced to another part.
> >
> > > - or write all infos from the database into IPTC/EXIF?
> >
> > yes
> >
> > > - add database content to IPTC/EXIF (or vice versa?)?
> >
> > yes, from DB to metadata
> >
> > > - or overwrite the existing?
>
> After a few short tests I see some inconsistency here:
>
> - it *overwrites* IPTC Copyright, Credit, Byline, Byline Title (don't know
> if also other fields) with info from database
> - it *adds* tags to IPTC keywords
>
> (see my suggestions below)
>
> > > - remove (for example) keywords from IPTC/EXIF if not tagged in
> > > database (or vice versa?)?
> >
> > This must be tested. normally yes. The function is the same than Comments
> > & Tags metadata update functions. It just do the same thing but on all
> > albums at the same time.
>
> it does *not* remove "untagged keywords"
>
> I tested it like this:
> - added tags/keywords to a file
> - outside digikam: saved a copy of that file to another directory
> - removed the tags/keywords within digikam from that file
> - closed digikam, overwrote the file with the previously backed-up one
> - opened digikam again
> - now the Metadata was here again of course, but the tags were not checked
> - run the sync tool - keywords remained untouched in Metadata
>
> So, this is not a "real synchronisation", because there still remain
> differences between database contents and metadata...

The sync depend of Metadata settings from digiKam config pannel. This problem
can be a bug or uncomplete code in new MetadataHub class from Marcel. Need to
investiguate.

>
> I think these are very complicated tasks, and this is why I still really,
> really think, that the "advanced metadata handling" should be swapped out
> completely from the sidebar options, so that they can be left simple and
> easy and usable by "everybody", while the complicated stuff will be in a
> independend tool. Then this tool can be developped further without changing
> the behaviour of digiKam itself. It would also make it much easier to
> achieve and maintain a consistent behaviour thruout the sidebars because
> added functionalities in the "advanced tool" don't have to be in the
> sidebars too and they can be left untouched even if fantastic new options
> are added to the "advanced tools" in future.
>
> - - - - - - -
>
> For the sync tool, I would suggest some options that the user can choose
> from before starting it:
>
> - overwrite Metadata with the values, that are set in digiKam settings
> (like Copyright etc.)
> - OR leave these Metadata unchanged
>
> - overwrite keywords in Metadata with tags from database (which also means,
> keywords will be removed/overwritten with empty space when there are no
> tags) -- OR add tags to existing keywords (as it does now)
>
> Then, when choosing "overwrite mode" for both options there will be a
> complete, real synchronisation between database and metadata. On the other
> hand the user can decide to leave some inconsistency if this better suits
> his/her needs.

Hum, Marcel give me your viewpoint... Personally, I prefer a simple tool where
picture metadata are exactly the same than DB content, following setup of
course.

>
> If it's possible, I'd also wish an option:
> - apply to all images in all albums (as is)

done

> - only to actually displayed album

done (today (:=))). checkout svn...

> - eventually: only to selected images

yes. the code is ready to be used.

Marcel, you just need to call the new class :

BatchSyncMetadata(QWidget* parent, const ImageInfoList& list)

... with the current selected images list from album, and the dialog will
appear. I think than this dialog is mandatory if more than one image is
selected to be synced because it can take a while. Without the dialog, the
user don't have any progress feedback...

>
> - - - - - - -
>
> during these tests I also (re-)found some other stuff, don't know if
> already mentioned in bugs/wishes:
>
> - when a file is copied into an album folder and that file contains
> Metadata keywords that do not exist as tags yet, then digiKam creates tags
> for these keywords, but the tags are not checked
> - if you then check those tags, the keywords get duplicated
> (this also happens with the new sync tool, because it adds tags to the
> Metadata even if they same tags already exist as keywords - could be solved
> with the "overwrite"-option suggested above)

For these one, this can be a bug in KIO-Slave. Right Marcel ?

>
> - when Metadata is changed by applying/removing a tag in the Comments/Tags
> sidebar and you then open the Metadata sidebar you still see the old,
> unchanged Metadata. The Metadata display is only updated after clicking in
> another image and back again. This is confusing, because actually the
> Metadata *has* been changed, but when you look at it, you think it remained
> unchanged.

A signal is missing to handle the gui.

>
> - When deleting a tag in the Comments/Tags sidebar the sidebar gets greyed
> out and remains greyed out even if you click into it. You have to click in
> the album preview again (like select the already selected picture again).

probably the same than previous one.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I tested it like this:
> - added tags/keywords to a file
> - outside digikam: saved a copy of that file to another directory
> - removed the tags/keywords within digikam from that file
> - closed digikam, overwrote the file with the previously backed-up one
> - opened digikam again
> - now the Metadata was here again of course, but the tags were not checked
> - run the sync tool - keywords remained untouched in Metadata
>
> So, this is not a "real synchronisation", because there still remain
> differences between database contents and metadata...

Yes there are two different modes of operation:
- Don't touch what you don't know of - preserve tags possibly from other
applications
- replace everything with your data

>
> I think these are very complicated tasks, and this is why I still really,
> really think, that the "advanced metadata handling" should be swapped out
> completely from the sidebar options, so that they can be left simple and
> easy and usable by "everybody", while the complicated stuff will be in a
> independend tool. Then this tool can be developped further without changing
> the behaviour of digiKam itself. It would also make it much easier to
> achieve and maintain a consistent behaviour thruout the sidebars because
> added functionalities in the "advanced tool" don't have to be in the
> sidebars too and they can be left untouched even if fantastic new options
> are added to the "advanced tools" in future.
>
> - - - - - - -
>
> For the sync tool, I would suggest some options that the user can choose
> from before starting it:
>
> - overwrite Metadata with the values, that are set in digiKam settings
> (like Copyright etc.)
> - OR leave these Metadata unchanged

What's the difference to the IPTC options in the configuration dialog?

>
> - overwrite keywords in Metadata with tags from database (which also means,
> keywords will be removed/overwritten with empty space when there are no
> tags) -- OR add tags to existing keywords (as it does now)

Such setting could be added to the setup dialog?

Or do you need to change these options very frequently?

>
> Then, when choosing "overwrite mode" for both options there will be a
> complete, real synchronisation between database and metadata. On the other
> hand the user can decide to leave some inconsistency if this better suits
> his/her needs.
>
> If it's possible, I'd also wish an option:
> - apply to all images in all albums (as is)
> - only to actually displayed album
> - eventually: only to selected images

Comments/tags sidebar, button "More".

>
> - - - - - - -
>
> during these tests I also (re-)found some other stuff, don't know if
> already mentioned in bugs/wishes:
>
> - when a file is copied into an album folder and that file contains
> Metadata keywords that do not exist as tags yet, then digiKam creates tags
> for these keywords, but the tags are not checked

Yes this is a bug which I noticed. I need to investigate further.

> - if you then check those tags, the keywords get duplicated
> (this also happens with the new sync tool, because it adds tags to the
> Metadata even if they same tags already exist as keywords - could be solved
> with the "overwrite"-option suggested above)

That's also simply a bug, duplicates should be removed.

>
> - when Metadata is changed by applying/removing a tag in the Comments/Tags
> sidebar and you then open the Metadata sidebar you still see the old,
> unchanged Metadata. The Metadata display is only updated after clicking in
> another image and back again. This is confusing, because actually the
> Metadata *has* been changed, but when you look at it, you think it remained
> unchanged.
>
> - When deleting a tag in the Comments/Tags sidebar the sidebar gets greyed
> out and remains greyed out even if you click into it. You have to click in
> the album preview again (like select the already selected picture again).

Yes, this is also bug I noticed, I investatigated this. There is a chain of
signals resulting from the deletion of the album which ends in
DigikamView::slot_albumSelected. I have to find out why this happens only
with Comments/Tags sidebar.

>
> Sorry for the long letter, tried to be as short as I can ;-)
>
> Daniel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > So, this is not a "real synchronisation", because there still remain
> > differences between database contents and metadata...
>
> The sync depend of Metadata settings from digiKam config pannel. This
> problem can be a bug or uncomplete code in new MetadataHub class from
> Marcel. Need to investiguate.
>
> > I think these are very complicated tasks, and this is why I still really,
> > really think, that the "advanced metadata handling" should be swapped out
> > completely from the sidebar options, so that they can be left simple and
> > easy and usable by "everybody", while the complicated stuff will be in a
> > independend tool. Then this tool can be developped further without
> > changing the behaviour of digiKam itself. It would also make it much
> > easier to achieve and maintain a consistent behaviour thruout the
> > sidebars because added functionalities in the "advanced tool" don't have
> > to be in the sidebars too and they can be left untouched even if
> > fantastic new options are added to the "advanced tools" in future.
> >
> > - - - - - - -
> >
> > For the sync tool, I would suggest some options that the user can choose
> > from before starting it:
> >
> > - overwrite Metadata with the values, that are set in digiKam settings
> > (like Copyright etc.)
> > - OR leave these Metadata unchanged
> >
> > - overwrite keywords in Metadata with tags from database (which also
> > means, keywords will be removed/overwritten with empty space when there
> > are no tags) -- OR add tags to existing keywords (as it does now)
> >
> > Then, when choosing "overwrite mode" for both options there will be a
> > complete, real synchronisation between database and metadata. On the
> > other hand the user can decide to leave some inconsistency if this better
> > suits his/her needs.
>
> Hum, Marcel give me your viewpoint... Personally, I prefer a simple tool
> where picture metadata are exactly the same than DB content, following
> setup of course.

See my other mail

>
> > - eventually: only to selected images
>
> yes. the code is ready to be used.
>
> Marcel, you just need to call the new class :
>
> BatchSyncMetadata(QWidget* parent, const ImageInfoList& list)
>
> ... with the current selected images list from album, and the dialog will
> appear. I think than this dialog is mandatory if more than one image is
> selected to be synced because it can take a while. Without the dialog, the
> user don't have any progress feedback...

Yes I will add that if more than one, two?, five? images are selected

>
> > - - - - - - -
> >
> > during these tests I also (re-)found some other stuff, don't know if
> > already mentioned in bugs/wishes:
> >
> > - when a file is copied into an album folder and that file contains
> > Metadata keywords that do not exist as tags yet, then digiKam creates
> > tags for these keywords, but the tags are not checked

Confirmed, I need to investigate

> > - if you then check those tags, the keywords get duplicated
> > (this also happens with the new sync tool, because it adds tags to the
> > Metadata even if they same tags already exist as keywords - could be
> > solved with the "overwrite"-option suggested above)
>
> For these one, this can be a bug in KIO-Slave. Right Marcel ?


The duplicate keywords:
For DMetadata::setImageKeywords, all tags contained in newKeywords should
probably be included in oldKeywords as well, so that they are removed first,
and there are no duplicates?
One line of code, but where, in DMetadata or in the code that calls
DMetadata::setImageKeywords?

>
> > - when Metadata is changed by applying/removing a tag in the
> > Comments/Tags sidebar and you then open the Metadata sidebar you still
> > see the old, unchanged Metadata. The Metadata display is only updated
> > after clicking in another image and back again. This is confusing,
> > because actually the Metadata *has* been changed, but when you look at
> > it, you think it remained unchanged.
>
> A signal is missing to handle the gui.

Hm, MetadataHub::write(QString) call the ImageAttributesWatch, and the signal
is received by ImagePropertiesSidebarDB.

It seems to me the problem is different: The changes are not applied at all:
1) Select an image
2) Change anything: comment, tags
3) move to another tab (say, Metadata)
4) Select another image
The changes from (2) are lost.

Yes, sure, because slotChangedTab only takes care for the currently selected
tab.
But why could this slip our attention, am I missing something?
Attention: Trying this will cause crashes, see #140417

>
> > - When deleting a tag in the Comments/Tags sidebar the sidebar gets
> > greyed out and remains greyed out even if you click into it. You have to
> > click in the album preview again (like select the already selected
> > picture again).
>
> probably the same than previous one.

Confirmed, need to investigate.

>
> Gilles
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Daniel Bauer-2]

On Tuesday 23 January 2007 17:35, Marcel Wiesweg wrote:

> > I tested it like this:
> > - added tags/keywords to a file
> > - outside digikam: saved a copy of that file to another directory
> > - removed the tags/keywords within digikam from that file
> > - closed digikam, overwrote the file with the previously backed-up one
> > - opened digikam again
> > - now the Metadata was here again of course, but the tags were not
> > checked - run the sync tool - keywords remained untouched in Metadata
> >
> > So, this is not a "real synchronisation", because there still remain
> > differences between database contents and metadata...
>
> Yes there are two different modes of operation:
> - Don't touch what you don't know of - preserve tags possibly from other
> applications
> - replace everything with your data

I understand. But actually it is a mix of both ways: copyright etc. is
replaced, keywords are preserved.

> >
> > For the sync tool, I would suggest some options that the user can choose
> > from before starting it:
> >
> > - overwrite Metadata with the values, that are set in digiKam settings
> > (like Copyright etc.)
> > - OR leave these Metadata unchanged
>
> What's the difference to the IPTC options in the configuration dialog?

sorry, I wasn't aware that these settings overwrite existing photographer
identity, credit and copyright metadata...

hmmm...

I thought, these Metadata parts will only be written to pictures that do not
have them yet. In this case I think, to make it clearer, in the settings it
should be "Save/overwrite existing".

Even better: an additional option like "automatically overwrite if existing?"

Or: asking before overwriting, like "should copyright etc. be overwritten with
defaults?", eventually with "don't ask again", and a setting "ask before
overwriting?".

Why:
for example, in some pictures I want to have "Credit A" and in others "Credit
B". If I have "A" in the settings and add a tag to a "B"-picture, it will
have "A" afterwards.

> > - overwrite keywords in Metadata with tags from database (which also
> > means, keywords will be removed/overwritten with empty space when there
> > are no tags) -- OR add tags to existing keywords (as it does now)
>
> Such setting could be added to the setup dialog?

Yes, but if I may place a wish, I'd like the possibility to have the option to
choose different from case to case.
>
> Or do you need to change these options very frequently?

Me not :-)

I see (and understand) that Gilles would like to have this tool simple and
just for really synchronising IPTC to database/settings. So IMO there are two
ways:

a) the tool simply overwrites *all* relevant Metadata with the contents from
database and settings. In this case I think it needs a warning like "if you
continue all existing Metadata will be overwritten and cannot be restored. Do
you want to continue?"

b) the tool offers options as suggested. Then we have something like "full
sync" (overwrite everything) or "update". Personally I'd prefer this, but I
can live with a) too ;-)

>
> > Then, when choosing "overwrite mode" for both options there will be a
> > complete, real synchronisation between database and metadata. On the
> > other hand the user can decide to leave some inconsistency if this better
> > suits his/her needs.
> >
> > If it's possible, I'd also wish an option:
> > - apply to all images in all albums (as is)
> > - only to actually displayed album
> > - eventually: only to selected images
>
> Comments/tags sidebar, button "More".

I don't understand this one. There I have "read metadata from file to
database", but nothing concerning to which pictures sync should be applied...

kind regards

Daniel
--
Daniel Bauer photographer Basel Switzerland
professional photography: http://www.daniel-bauer.com
Madagascar special: http://www.sanic.ch
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mardi 23 Janvier 2007 18:58, Daniel Bauer a écrit :

> sorry, I wasn't aware that these settings overwrite existing photographer
> identity, credit and copyright metadata...
>
> hmmm...
>
> I thought, these Metadata parts will only be written to pictures that do
> not have them yet. In this case I think, to make it clearer, in the
> settings it should be "Save/overwrite existing".
>
> Even better: an additional option like "automatically overwrite if
> existing?"
>
> Or: asking before overwriting, like "should copyright etc. be overwritten
> with defaults?", eventually with "don't ask again", and a setting "ask
> before overwriting?".
>
> Why:
> for example, in some pictures I want to have "Credit A" and in others
> "Credit B". If I have "A" in the settings and add a tag to a "B"-picture,
> it will have "A" afterwards.

No need to overwrite something with existing Copyright IPTC tags : these tags
can be redondant (like IPTC keywords). In fact, we can have multiple
copyright for a same image...

The metadata rule must be fixed to preserve existing tags witch can be
redondant. For other one, question stil open : settings or not settings ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le Mardi 23 Janvier 2007 17:58, Marcel Wiesweg a écrit :

> > > So, this is not a "real synchronisation", because there still remain
> > > differences between database contents and metadata...
> >
> > The sync depend of Metadata settings from digiKam config pannel. This
> > problem can be a bug or uncomplete code in new MetadataHub class from
> > Marcel. Need to investiguate.
> >
> > > I think these are very complicated tasks, and this is why I still
> > > really, really think, that the "advanced metadata handling" should be
> > > swapped out completely from the sidebar options, so that they can be
> > > left simple and easy and usable by "everybody", while the complicated
> > > stuff will be in a independend tool. Then this tool can be developped
> > > further without changing the behaviour of digiKam itself. It would also
> > > make it much easier to achieve and maintain a consistent behaviour
> > > thruout the sidebars because added functionalities in the "advanced
> > > tool" don't have to be in the sidebars too and they can be left
> > > untouched even if fantastic new options are added to the "advanced
> > > tools" in future.
> > >
> > > - - - - - - -
> > >
> > > For the sync tool, I would suggest some options that the user can
> > > choose from before starting it:
> > >
> > > - overwrite Metadata with the values, that are set in digiKam settings
> > > (like Copyright etc.)
> > > - OR leave these Metadata unchanged
> > >
> > > - overwrite keywords in Metadata with tags from database (which also
> > > means, keywords will be removed/overwritten with empty space when there
> > > are no tags) -- OR add tags to existing keywords (as it does now)
> > >
> > > Then, when choosing "overwrite mode" for both options there will be a
> > > complete, real synchronisation between database and metadata. On the
> > > other hand the user can decide to leave some inconsistency if this
> > > better suits his/her needs.
> >
> > Hum, Marcel give me your viewpoint... Personally, I prefer a simple tool
> > where picture metadata are exactly the same than DB content, following
> > setup of course.
>
> See my other mail
>
> > > - eventually: only to selected images
> >
> > yes. the code is ready to be used.
> >
> > Marcel, you just need to call the new class :
> >
> > BatchSyncMetadata(QWidget* parent, const ImageInfoList& list)
> >
> > ... with the current selected images list from album, and the dialog will
> > appear. I think than this dialog is mandatory if more than one image is
> > selected to be synced because it can take a while. Without the dialog,
> > the user don't have any progress feedback...
>
> Yes I will add that if more than one, two?, five? images are selected

Well, if you only show the progress dialog if you have more than 10 pictures
selected (for example) and you don't show it with 9 pictures, the users will
be confused... and certainly an Usability report will do in B.K.O. I
recommend you to :

- not show the dialog if one image is selected.
- show the dialog if more than one image is selected.

... and we will see the users feedback after beta1.

>
> > > - - - - - - -
> > >
> > > during these tests I also (re-)found some other stuff, don't know if
> > > already mentioned in bugs/wishes:
> > >
> > > - when a file is copied into an album folder and that file contains
> > > Metadata keywords that do not exist as tags yet, then digiKam creates
> > > tags for these keywords, but the tags are not checked
>
> Confirmed, I need to investigate
>
> > > - if you then check those tags, the keywords get duplicated
> > > (this also happens with the new sync tool, because it adds tags to the
> > > Metadata even if they same tags already exist as keywords - could be
> > > solved with the "overwrite"-option suggested above)
> >
> > For these one, this can be a bug in KIO-Slave. Right Marcel ?
>
> The duplicate keywords:
> For DMetadata::setImageKeywords, all tags contained in newKeywords should
> probably be included in oldKeywords as well, so that they are removed
> first, and there are no duplicates?
> One line of code, but where, in DMetadata or in the code that calls
> DMetadata::setImageKeywords?

everywhere. Use grep to find each occurence, or Find in File with KDevelop.

Also there is a non-solved problem in all drag & drop stuff with don't use
MetadataHub class. Your new class must be used instead to call directly
DMetadata class. Like this all will be homogenous.

Other important task TODO :

Also, when kipi-plugins 0.1.3 will be released, a new common implementation
shared between kipi-plugins and digiKam must be done about the Exiv2
interface.

A new libkexiv2 library must be done, merging kipi-plugins/Exiv2Iface and
digiKam/DMetadata.

In fact:

- In kipi-plugins, the Exiv2Iface must be remplaced by the new shared library.

- In digiKam, DMetadata must be derived of libkexiv2. Some usual methods of
DMetadata (dupplicated in kipi-plugins/Exiv2Iface) will be provided by
libkexiv2. All others methods, more dedicaced to digiKam core must be
implemented to DMetadata.

The question is : digiKam 0.9.1 must be depand of future libkexiv2 ? I think
no. We release 0.9.1 and after we change the DMetadata class...

Fine for you ?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> > Yes I will add that if more than one, two?, five? images are selected
>
> Well, if you only show the progress dialog if you have more than 10
> pictures selected (for example) and you don't show it with 9 pictures, the
> users will be confused... and certainly an Usability report will do in
> B.K.O. I recommend you to :
>
> - not show the dialog if one image is selected.
> - show the dialog if more than one image is selected.
>
> ... and we will see the users feedback after beta1.
>

Ok, I will do it.

> In fact:
>
> - In kipi-plugins, the Exiv2Iface must be remplaced by the new shared
> library.
>
> - In digiKam, DMetadata must be derived of libkexiv2. Some usual methods of
> DMetadata (dupplicated in kipi-plugins/Exiv2Iface) will be provided by
> libkexiv2. All others methods, more dedicaced to digiKam core must be
> implemented to DMetadata.
>
> The question is : digiKam 0.9.1 must be depand of future libkexiv2 ? I
> think no. We release 0.9.1 and after we change the DMetadata class...
>
> Fine for you ?

Yes sure, thats all right for me.

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le mercredi 24 janvier 2007 22:27, Marcel Wiesweg a écrit :

> > > Yes I will add that if more than one, two?, five? images are selected
> >
> > Well, if you only show the progress dialog if you have more than 10
> > pictures selected (for example) and you don't show it with 9 pictures,
> > the users will be confused... and certainly an Usability report will do
> > in B.K.O. I recommend you to :
> >
> > - not show the dialog if one image is selected.
> > - show the dialog if more than one image is selected.
> >
> > ... and we will see the users feedback after beta1.
>
> Ok, I will do it.

Ok i have seen your implementation.

Something is wrong about behaviour of Comments & Tags with multiple
selections :

- If you use "More" button options, the Batch dialog appears. it fine.
- If you use "Apply" button nothing appear. It trouble me (:=)))
- If you D&D Tags from side bar to image selection nothing appear. It trouble
me again...

This is my proposal with Comment & Tags :

- Forget Batch dialog.
- Add a small (like IE loading/Save progress bar) and hidden progress bar in
the top of side bar, just under the title "Editing n pictures". You just need
to add the progress bar to the layout hosted by the QWidgetStack
- When "Apply" button or "More" button or D&D are used, show the progress bar
during processing.
- When process is complete, hide the progress bar.

What do you think about ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

Le mercredi 24 janvier 2007 22:27, Marcel Wiesweg a écrit :

> > > Yes I will add that if more than one, two?, five? images are selected
> >
> > Well, if you only show the progress dialog if you have more than 10
> > pictures selected (for example) and you don't show it with 9 pictures,
> > the users will be confused... and certainly an Usability report will do
> > in B.K.O. I recommend you to :
> >
> > - not show the dialog if one image is selected.
> > - show the dialog if more than one image is selected.
> >
> > ... and we will see the users feedback after beta1.
>
> Ok, I will do it.

Marcel,

In MetadataHub, the methods load() and save() must return a boollean value to
see if something is wrong. DMetadata return a bool value with load and save
methods. I think i easy to following it in MetadataHub.

I will use this bool value in Batch dialog to show if pictures have been
touched or not (file format supported for ex.). Actually the dialog give the
files list without more feedback.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel