[Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

classic Classic list List threaded Threaded
30 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Marcel Wiesweg
> Marcel,
>
> In MetadataHub, the methods load() and save() must return a boollean value
> to see if something is wrong. DMetadata return a bool value with load and
> save methods. I think i easy to following it in MetadataHub.
>
> I will use this bool value in Batch dialog to show if pictures have been
> touched or not (file format supported for ex.). Actually the dialog give
> the files list without more feedback.

I have added bool values all write methods and for the load method that loads
a DMetadata.
As to your other mail, I will find some time at the weekend to remove the
dialog and add a progress bar. It's really better, I agree.

Marcel

>
> Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Gilles Caulier-2
Le Jeudi 25 Janvier 2007 22:37, Marcel Wiesweg a écrit :

> > In MetadataHub, the methods load() and save() must return a boollean
> > value to see if something is wrong. DMetadata return a bool value with
> > load and save methods. I think i easy to following it in MetadataHub.
> >
> > I will use this bool value in Batch dialog to show if pictures have been
> > touched or not (file format supported for ex.). Actually the dialog give
> > the files list without more feedback.
>
> I have added bool values all write methods and for the load method that
> loads a DMetadata.

Done in svn .Fixed a little bug in MetadataHub to handle properly the
DMetadata bool value returned when something is dirty in picture metadata.

The Batch sync metadata picture tool is fixed, but still a problem with
current implementation of Exiv2. There is no exception generated by all RAW
file format supported in read only (TIFF, MRW, NEF, CR2 etc...)

http://digikam3rdparty.free.fr/Screenshots/syncmetadatatofile.png

Feedback reported to Andreas. wait and see...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Gilles Caulier-2
In reply to this post by Marcel Wiesweg
Le Jeudi 25 Janvier 2007 22:37, Marcel Wiesweg a écrit :
> As to your other mail, I will find some time at the weekend to remove the
> dialog and add a progress bar. It's really better, I agree.

A patch to do it is here :

http://digikam3rdparty.free.fr/misc.tarballs/commentstagsprogress.patch

This one include to run a progress bar on the top of sidebar when :

- Apply button is pressed
- More button options are used.

TODO : handle Tags drag & drop.

...but, there is a problem with this solution...

We need to fix all DMetadata call everywhere in digiKam to used MetadataHub
instead. This not yet done for example with all Drag and drop actions from
others sidebar (TagsFilter for example)

... and we need to give a progress feedback everywhere, because metadata to
write in pictures can take a while with huge selection.

I think than an ultimate solution is to use a _Status Bar_ on the bottom of
Album gui.

What do you think about ?

Nota : Image editor is not affected here because it work only on a single
image.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Gilles Caulier-2
In reply to this post by Marcel Wiesweg
Le Jeudi 25 Janvier 2007 22:37, Marcel Wiesweg a écrit :
> As to your other mail, I will find some time at the weekend to remove the
> dialog and add a progress bar. It's really better, I agree.

Screenshot of my patch in action :

http://digikam3rdparty.free.fr/Screenshots/commentstagsprogress.png

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Gilles Caulier-2
In reply to this post by Marcel Wiesweg
Le Mercredi 24 Janvier 2007 22:27, Marcel Wiesweg a écrit :
> > In fact:
> >
> > - In kipi-plugins, the Exiv2Iface must be remplaced by the new shared
> > library.

TODO (in first ==> can be done now)

> >
> > - In digiKam, DMetadata must be derived of libkexiv2. Some usual methods
> > of DMetadata (dupplicated in kipi-plugins/Exiv2Iface) will be provided by
> > libkexiv2. All others methods, more dedicaced to digiKam core must be
> > implemented to DMetadata.

TODO (in second, perhaps later than 0.9.1 ==> your viewpoints).

> >
> > The question is : digiKam 0.9.1 must be depand of future libkexiv2 ? I
> > think no. We release 0.9.1 and after we change the DMetadata class...
> >
> > Fine for you ?
>
> Yes sure, thats all right for me.

libkexiv2 is now in svn in extragear/libs. It just a copy of
Kipi-Plugins::Exiv2Iface class.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Bugzilla from ach@mpe.mpg.de
In reply to this post by Gilles Caulier-2
On Friday, 26. January 2007 12:10, Caulier Gilles wrote:
> Le Jeudi 25 Janvier 2007 22:37, Marcel Wiesweg a écrit :
> > As to your other mail, I will find some time at the weekend to remove the
> > dialog and add a progress bar. It's really better, I agree.
>
> Screenshot of my patch in action :
>
> http://digikam3rdparty.free.fr/Screenshots/commentstagsprogress.png

I the feeling the progressbar, should not be in the right side bar.

I would favour for progress bar below the thumbnail view.

We should also move the first/prev/next/last buttons there because
they operate on the  pictures displayed too. (E.g. click betwen
thumbnails and buttons get disbled).

Additional advantages of button below thumbnail view are:
        o always visible, not only when ride side bar is
          open. (ah, tags filter has no prev/next... buttons at all)
        o Can be used in view mode too
          and camera download

Achim
>
> Gilles
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

--
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- [hidden email]
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Marcel Wiesweg
In reply to this post by Gilles Caulier-2
> A patch to do it is here :
>
> http://digikam3rdparty.free.fr/misc.tarballs/commentstagsprogress.patch
>
> This one include to run a progress bar on the top of sidebar when :
>
> - Apply button is pressed
> - More button options are used.
>
> TODO : handle Tags drag & drop.
>
> ...but, there is a problem with this solution...
>
> We need to fix all DMetadata call everywhere in digiKam to used MetadataHub
> instead. This not yet done for example with all Drag and drop actions from
> others sidebar (TagsFilter for example)
>
> ... and we need to give a progress feedback everywhere, because metadata to
> write in pictures can take a while with huge selection.
>
> I think than an ultimate solution is to use a _Status Bar_ on the bottom of
> Album gui.
>
> What do you think about ?

Yes the progress bar in the status bar is better. Especially if we also write
metadata when assigning with drag and drop, the status bar is the right
place.

It seems we have once again opened a box which proves to be much larger than
it appeared ;-)

For the ultimate solution, I have two more requirements:

1) When a user assigns tag A to 1500 images it takes some time to write the
DMetadata. After that, he wants to assign another tag to the same images.
Again, it takes considerable time. This means users will wish to temporally
disable writing.
An elegant solution is to implement (2).

2) Do the whole thing multithreaded. This solves (1).
Implementing this when we have ported to KDE4/Qt4 will be much easier. So I
would prefer to delay this.

For now, the solution can be:
- the right side bar emits progress signals (similar to the methods you added
to NavigateBarTab)
- DigikamView connects to these signals, manages the progress bar
- if we write metadata after drag&drop/context menu assignment, the
AlbumIconView can emit the same signals

Marcel

>
> Nota : Image editor is not affected here because it work only on a single
> image.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Heiner Lamprecht
In reply to this post by Bugzilla from ach@mpe.mpg.de
On Friday 26 January 2007 17:00, Achim Bohnet wrote:
>
> I the feeling the progressbar, should not be in the right side
> bar.
>
> I would favour for progress bar below the thumbnail view.
>
> We should also move the first/prev/next/last buttons there
> because they operate on the  pictures displayed too. (E.g. click
> betwen thumbnails and buttons get disbled).

I agree, and we can also display the number of images of the album
there.  Having it at the top of the thumbnails is not the best,
it's not visible anymore, when you scroll down.


    Heiner

--
    heiner at heiner-lamprecht dot net    GnuPG - Key: 9859E373
  Fingerprint:  3770 7947 F917 94EF 8717 BADB 0139 7554 9859 E373
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Gilles Caulier-2
In reply to this post by Marcel Wiesweg
Le Samedi 27 Janvier 2007 15:25, Marcel Wiesweg a écrit :

> > A patch to do it is here :
> >
> > http://digikam3rdparty.free.fr/misc.tarballs/commentstagsprogress.patch
> >
> > This one include to run a progress bar on the top of sidebar when :
> >
> > - Apply button is pressed
> > - More button options are used.
> >
> > TODO : handle Tags drag & drop.
> >
> > ...but, there is a problem with this solution...
> >
> > We need to fix all DMetadata call everywhere in digiKam to used
> > MetadataHub instead. This not yet done for example with all Drag and drop
> > actions from others sidebar (TagsFilter for example)
> >
> > ... and we need to give a progress feedback everywhere, because metadata
> > to write in pictures can take a while with huge selection.
> >
> > I think than an ultimate solution is to use a _Status Bar_ on the bottom
> > of Album gui.
> >
> > What do you think about ?
>
> Yes the progress bar in the status bar is better. Especially if we also
> write metadata when assigning with drag and drop, the status bar is the
> right place.

ok. I will fix my patch in this way and add a status bar in to bottom of album
gui.

>
> It seems we have once again opened a box which proves to be much larger
> than it appeared ;-)
>
> For the ultimate solution, I have two more requirements:
>
> 1) When a user assigns tag A to 1500 images it takes some time to write the
> DMetadata. After that, he wants to assign another tag to the same images.
> Again, it takes considerable time. This means users will wish to temporally
> disable writing.
> An elegant solution is to implement (2).
>
> 2) Do the whole thing multithreaded.

Yes, multithreading is fine, but take a care than DB interface is not yet
thread-safe, in the case of pictures metadata and digiKAm metadata must be
sync at the same time...

> This solves (1).
> Implementing this when we have ported to KDE4/Qt4 will be much easier. So I
> would prefer to delay this.

Absolutly. and with the Qt4.0 port, we need to plan to do the DB interface
thread-safe.

>
> For now, the solution can be:
> - the right side bar emits progress signals (similar to the methods you
> added to NavigateBarTab)

yes. I will do it

> - DigikamView connects to these signals, manages the progress bar

... and report it to status bar.

> - if we write metadata after drag&drop/context menu assignment, the
> AlbumIconView can emit the same signals

yes.

Gilles

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Digikam-devel] How to apply changes in digikams IPTC settings to all tagged photos?

Bugzilla from lure@kubuntu.org
On Saturday 27. of January 2007 18:20:40 Caulier Gilles wrote:

> > 1) When a user assigns tag A to 1500 images it takes some time to write
> > the DMetadata. After that, he wants to assign another tag to the same
> > images. Again, it takes considerable time. This means users will wish to
> > temporally disable writing.
> > An elegant solution is to implement (2).
> >
> > 2) Do the whole thing multithreaded.
>
> Yes, multithreading is fine, but take a care than DB interface is not yet
> thread-safe, in the case of pictures metadata and digiKAm metadata must be
> sync at the same time...

Or make one DMetadata update worker thread which gets assigned jobs to do and
is execute in sequence...

Regards,
Luka
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12