------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 Summary: tag hierarchy automatic fill Product: digikam Version: 0.9.0 Platform: unspecified OS/Version: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general AssignedTo: digikam-devel kde org ReportedBy: juergen.flosbach bigfoot com Version: 0.9.0 (using KDE 3.5.5 "release 45.1" , openSUSE ) Compiler: Target: x86_64-suse-linux OS: Linux (x86_64) release 2.6.13-15.13-default What I wish for is the automatic selection of parent tags in the tag hierarchy. See right side the comments/tags tag. Example : Tags > People Tags > People > Children Tags > People > Children > Boy If I set tag "Boy" I also have to set all higher tags manually. Because a boy is a child and also belongs to people. This could be dont automatically. I select Boy and the tags Children and People are selected by digikam. I deselect Boy only this tag gets deselected because all other tags may still be true. Juergen Flosbach juergen.flosbach bigfoot com _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 caulier.gilles kdemail net changed: What |Removed |Added ---------------------------------------------------------------------------- Component|general |Tags ------- Additional Comments From caulier.gilles kdemail net 2007-01-03 12:44 ------- Hi Juergen, Because i'm actually lost in Tags management implementation, I can said than it can be easy to implement this option (technically of course). But before to do something in this way, i would to have the feedback from others users about this point... Also, to do it, i think we need 2 new options in pop-up menu : - Select parents. - Deselect parents. What do you think about ? Gilles Caulier _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
Do you need this for usage outside of digikam?
E.g., if you use the Tag-Filter on the left hand side and select "People", also all those with "Boy" will be displayed. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From arnd.baecker web de 2007-01-03 13:03 ------- Do you need this for usage outside of digikam? E.g., if you use the Tag-Filter on the left hand side and select "People", also all those with "Boy" will be displayed. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From linux daniel-bauer com 2007-01-03 13:53 ------- I'd vote for this. For the options - Select parents. - Deselect parents. they could also be set/unset in settings->metadata, so they don't need space in the sidebar/menu (I guess most people will not change these options frequently). If settings->metadata is not the right place, it would be comfortable if the chosen options remain remembered until one changes them. ...ehm, is it clear what happens to the children then? To explain: When there is a picture tagged: People > Children > Boy and option "Select parents" is checked and I want to deselect "Children" what happens to the "Boy"? proposals: a) deselect a parent tag when the picture has cild-tags of this parent is not possible (warning like "you have to deselect all child-tags of this tag for this picture before you can deselect this tag"), or b) extend option to "Deselect parents/children", or c) add third option "Deselect children if parent is deselected" (I'd prefer a) Finally, so that people don't get afraid that they loose their children or parents, I'd name the options "parent tags" and "child tags" instead of just parents/children :-) Daniel _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From caulier.gilles kdemail net 2007-01-03 14:14 ------- Daniel, The 'Select/Deselect Parents' options will not be settings, but actions options, running like current 'Select All/Deselect/Invert Selection' options. Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From juergen.flosbach bigfoot com 2007-01-03 14:19 ------- Answer to Arnd Baecker "Do you need this for usage outside of digikam?" If I leave it like it is and forget to select the children tag in my example than, if I use the left side tags filter, I don't see this picture if I select children as filter. But, my boy is a child. So I would expect him to show up. Juergen _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From linux daniel-bauer com 2007-01-03 14:53 ------- Hi Gilles, oh, I see... So, then you'll have to right-click to deselect parents? Or did I understand wrong again? As this is a wish-list, I'd wish to have it SET somehow, so that when one deselects a tag the rest is done automatically without the need for right-clicking. That would enhance comfort substantially (I think). Daniel _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From caulier.gilles kdemail net 2007-01-03 15:03 ------- Yes Daniel, My idea is when you right clic on a tag from treeview, when you choose the "Deselect Parents" option, all parents from this tag (and only this one) will be deselected. Same way for 'Select Parents' stuff. Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From linux daniel-bauer com 2007-01-03 15:35 ------- ok, that's not bad and adds some comfort. However, my wish (for christmas 07? :-)) ) is maybe a bit different: In my *personal* view a tag-tree makes only sense, if it is used hierarchical, i.e. (in the example here) a "boy" MUST be "children" which MUST be a "people". If a "boy" can also exist without beeing "children" it makes no sense to make "boy" a sub-tag of "children". So my wish would be a setting, like maybe: - use strict tag hierarchy (that implies tagging parents automatically when a child-tag is checked) - use free tag hierarchy (that means, you can have "boys" which are no "children") What do you think? Too complicated? Daniel _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From juergen.flosbach bigfoot com 2007-01-03 15:37 ------- I have always to refrence the english documentation. To make sure that I say it right ( I have the german version ). I don't think that this feature will be changed constantly. So I would think that in the tags pop-up menue would be the best place for it. -----------------------------------------+ x autoselect parents ( feature enabled ) | -----------------------------------------+ Juergen _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From juergen.flosbach bigfoot com 2007-01-03 15:41 ------- It took me to long to write my last comment. Daniel, you just past me on the left lane and said what I was thinking. Juergen _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From caulier.gilles kdemail net 2007-01-03 16:33 ------- Created an attachment (id=19092) --> (http://bugs.kde.org/attachment.cgi?id=19092&action=view) Parents & Childs tags selection/deselection Hi guy... try this first patch to apply against current svn implementation... It re-factorize the pop-up menu from Tags treeview of Comments & Tags sidebar using child new pop-up menu and add new options like this : - All Tags / Select - All Tags / Deselect - All Tags / Invert - Child Tags / Select - Child Tags / Deselect - Parent Tags / Select - Parent Tags / Deselect This is the first approach. It not exactly like you want Juergen, because you would to set a settings to select automaticly all parent tags (or childrens eventually if the idea is right for you) In fact the patch give the core implementation to perform parent/child tags. To do later an automatic stuff is simple using it (:=))) Gilles _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From caulier.gilles kdemail net 2007-01-03 16:39 ------- Created an attachment (id=19093) --> (http://bugs.kde.org/attachment.cgi?id=19093&action=view) Screenshot of pop-up menu Tags treeview from Comments & tags sidebar _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From juergen.flosbach bigfoot com 2007-01-03 19:19 ------- Hey Gilles you are fast. I can not be so fast because I got the tar ball not the svn sources. And maybe I have to try that out sometime towards the weekend. But not today. But it looks good for the first shot. I'll let you know when I have tested your patch. Juergen _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From caulier.gilles kdemail net 2007-01-04 10:14 ------- SVN commit 619739 by cgilles: digiKam from trunk : Improvment of Selection/Deselection of Tags in tree list view from Comments & Tags sidebar : add 2 new options sub popup-menu to Select/Deselect All/Parents/Childs tags. Refactoring of pop-up menu. CCBUGS: 139547 M +26 -27 imagedescedittab.cpp --- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #619738:619739 @ -59,13 +59,13 @ #include "albumdb.h" #include "album.h" #include "albumsettings.h" +#include "albumthumbnailloader.h" #include "tagcreatedlg.h" #include "navigatebarwidget.h" -#include "imageinfo.h" #include "ratingwidget.h" -#include "imageattributeswatch.h" -#include "albumthumbnailloader.h" #include "talbumlistview.h" +#include "imageinfo.h" +#include "imageattributeswatch.h" #include "imagedescedittab.h" #include "imagedescedittab.moc" @ -632,43 +632,42 @ popmenu.insertSeparator(-1); - QPopupMenu allTagsMenu; - allTagsMenu.insertItem(i18n("Select "), 14); - allTagsMenu.insertItem(i18n("Deselect"), 15); - allTagsMenu.insertItem(i18n("Invert"), 16); - popmenu.insertItem(i18n("All Tags"), &allTagsMenu); + QPopupMenu selectTagsMenu; + selectTagsMenu.insertItem(i18n("All"), 14); + selectTagsMenu.insertItem(i18n("Childs"), 17); + selectTagsMenu.insertItem(i18n("Parents"), 19); + popmenu.insertItem(i18n("Select"), &selectTagsMenu); - QPopupMenu childTagsMenu; - childTagsMenu.insertItem(i18n("Select"), 17); - childTagsMenu.insertItem(i18n("Deselect"), 18); - popmenu.insertItem(i18n("Childs Tags"), &childTagsMenu); + QPopupMenu deselectTagsMenu; + deselectTagsMenu.insertItem(i18n("All"), 15); + deselectTagsMenu.insertItem(i18n("Childs"), 18); + deselectTagsMenu.insertItem(i18n("Parents"), 20); + popmenu.insertItem(i18n("Deselect"), &deselectTagsMenu); - QPopupMenu parentTagsMenu; - parentTagsMenu.insertItem(i18n("Select"), 19); - parentTagsMenu.insertItem(i18n("Deselect"), 20); - popmenu.insertItem(i18n("Parent Tags"), &parentTagsMenu); - + + popmenu.insertItem(i18n("Invert Selection"), 16); + int choice = popmenu.exec((QCursor::pos())); switch( choice ) { - case 10: + case 10: // New Tag. { tagNew(album); break; } - case 11: + case 11: // Edit Tag Properties. { if (!album->isRoot()) tagEdit(album); break; } - case 12: + case 12: // Delete Tag. { if (!album->isRoot()) tagDelete(album); break; } - case 13: + case 13: // Reset Tag Icon. { QString errMsg; AlbumManager::instance()->updateTAlbumIcon(album, QString("tag"), 0, errMsg); @ -698,7 +697,7 @ } break; } - case 16: // Invert All Tags Selection. + case 16: // Invert All Tags Selection. { QListViewItemIterator it(d->tagsView); while (it.current()) @ -715,22 +714,22 @ } break; } - case 17: // Select Child Tags. + case 17: // Select Child Tags. { toggleChildTags(album, true); break; } - case 18: // Deselect Child Tags. + case 18: // Deselect Child Tags. { toggleChildTags(album, false); break; } - case 19: // Select Parent Tags. + case 19: // Select Parent Tags. { toggleParentTags(album, true); break; } - case 20: // Deselect Parent Tags. + case 20: // Deselect Parent Tags. { toggleParentTags(album, false); break; @ -822,7 +821,7 @ { KMessageBox::error(this, i18n("You are currently viewing items in the " "tag '%1' that you are about to delete. " - "You will need to close this dialog first " + "You will need to apply change first " "if you want to delete the tag." ) .arg(album->title())); return; _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
I followed all the discussion string. What I don't understand is, that digiKam
works already as you wish it to work. If boy is set and not child and then you select child on the left sidebar the whole hierarchy comes up child->boy and whatever else is under child. Or do I understand your wish wrongly? Gerhard Am Mittwoch, 3. Januar 2007 12:16 schrieb Juergen Flosbach: > ------- You are receiving this mail because: ------- > You are the assignee for the bug, or are watching the assignee. > > http://bugs.kde.org/show_bug.cgi?id=139547 > Summary: tag hierarchy automatic fill > Product: digikam > Version: 0.9.0 > Platform: unspecified > OS/Version: Linux > Status: UNCONFIRMED > Severity: wishlist > Priority: NOR > Component: general > AssignedTo: digikam-devel kde org > ReportedBy: juergen.flosbach bigfoot com > > > Version: 0.9.0 (using KDE 3.5.5 "release 45.1" , openSUSE ) > Compiler: Target: x86_64-suse-linux > OS: Linux (x86_64) release 2.6.13-15.13-default > > What I wish for is the automatic selection of parent tags in the tag > hierarchy. See right side the comments/tags tag. > Example : > Tags > People > Tags > People > Children > Tags > People > Children > Boy > > If I set tag "Boy" I also have to set all higher tags manually. Because a > boy is a child and also belongs to people. This could be dont > automatically. > I select Boy and the tags Children and People are selected by digikam. > I deselect Boy only this tag gets deselected because all other tags may > still be true. > > Juergen Flosbach > juergen.flosbach bigfoot com > _______________________________________________ > Digikam-devel mailing list > [hidden email] > https://mail.kde.org/mailman/listinfo/digikam-devel -- http://www.gerhard.fr _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From gerhard kulzer net 2007-01-04 11:55 ------- I followed all the discussion string. What I don't understand is, that digiKam works already as you wish it to work. If boy is set and not child and then you select child on the left sidebar the whole hierarchy comes up child->boy and whatever else is under child. Or do I understand your wish wrongly? Gerhard Am Mittwoch, 3. Januar 2007 12:16 schrieb Juergen Flosbach: [bugs.kde.org quoted mail] _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
In reply to this post by Jürgen Flosbach dk
Here's a screen shot to explain my point in the previous mail. THis is from
0.9.0 with Gilles patch of this morning. Gerhard tag-tree.png (60K) Download Attachment |
In reply to this post by Jürgen Flosbach dk
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=139547 ------- Additional Comments From gerhard kulzer net 2007-01-04 11:58 ------- Here's a screen shot to explain my point in the previous mail. THis is from 0.9.0 with Gilles patch of this morning. Gerhard Created an attachment (id=19099) --> (http://bugs.kde.org/attachment.cgi?id=19099&action=view) tag-tree.png _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
Free forum by Nabble | Edit this page |