digiKam › digikam-devel

[Digikam-devel] [Bug 139547] New: tag hierarchy automatic fill

Classic

List

87 messages Options

Options

12345

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-08 09:04 -------
Juergen,

> - Right side tags filter
> -- Select one tag
> -- Deselct the same tag
> -- > digikam crashes.

Not reproductible here. Please give me a gdb backtrace. Look here for more informations :
http://www.digikam.org/?q=contrib

> - Comments/tags tab
> -- during my test I missed in the tags pop-up > autotoggle menue
> -- the item "non".
> -- Once you select one item there you seem to stick with it. You
> -- can not go back to "non".

I can understand what you mean...

>- Comments/tags tab
> - the tags pop-up menu
> -- I don't think that's good to have the "all tags" item as the
> -- first. Who wants to selct "ALL" tags ? Maybe deselect. But not
> -- select. What do you think?

I'm agree with you. But this option have been ask by another user during 0.9.0 development on B.K.O. I would to have more feedback...

>- Comments/tags tab
> -- I was more than one time surprised when I had the mousecursor
> -- over one tags checkbox and pressed the right mouse button. The
> -- tags pop-up menue appeared AND the box was checked.
> -- I would assume that I can only with the left mouse button select
> -- a tag.

The behaviour is not same if you clik on the cross area or on the Tags name to get the pop-up menu with the right mouse button. I will take a look...

>- Album view
> - all right/left side tabs are closed.
> - select one image and type in a letter ( any letter ).
> - It appears as comment. Was that intentional ?

This problem is know. there is a B.K.O file about. This is relevant of Comments caption focus stuff. Marcel working on...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From linux daniel-bauer com 2007-01-08 10:41 -------
> > - Right side tags filter
> > -- Select one tag
> > -- Deselct the same tag
> > -- > digikam crashes.

> Not reproductible here. Please give me a gdb backtrace. Look here for more
> informations : http://www.digikam.org/?q=contrib

no such problem here, too

> > - Comments/tags tab
> > -- during my test I missed in the tags pop-up > autotoggle menue
> > -- the item "non".
> > -- Once you select one item there you seem to stick with it. You
> > -- can not go back to "non".

> I can understand what you mean...

Yes, once selected it cannot be deselected (except selecting another option, but not none). Should be fixed.

> >- Comments/tags tab
> > - the tags pop-up menu
> > -- I don't think that's good to have the "all tags" item as the
> > -- first. Who wants to selct "ALL" tags ? Maybe deselect. But not
> > -- select. What do you think?

> I'm agree with you. But this option have been ask by another user during
> 0.9.0 development on B.K.O. I would to have more feedback...

"deselect all" seems useful to revert to a "clean" starting stage.

In "select all" I would change the action to *not* also select "Not Tagged" but only select real tags, so that "all tags" would show all images with any tag, but not those without a tag. I think "no tag" is not a tag and therefor it should not be considered as part of "all tags".

If "not tagged" would *not* be included in "all" one could use these options to fastly toggle between tagged and untagged pictures. As it is now, "deselect all" and "select all" give the same selection.

> >- Comments/tags tab
> > -- I was more than one time surprised when I had the mousecursor
> > -- over one tags checkbox and pressed the right mouse button. The
> > -- tags pop-up menue appeared AND the box was checked.
> > -- I would assume that I can only with the left mouse button select
> > -- a tag.
>
> The behaviour is not same if you clik on the cross area or on the Tags
> name to get the pop-up menu with the right mouse button. I will take a
> look...

I'd also prefer if right-clicking would consequently *not* directly change any settings/selections anywhere in digiKam. In my view right-clicking should always just get contextual menues, help etc., but not do any other action.
This is what I ment in my Comment #20 here.

But maybe this is "programming style philosophy" (I've been stumbling across similar behaviour in other apps, too) and as I have no clue about that I don't insist on this, although I'd prefer it the other way :-)

Daniel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Jürgen Flosbach dk

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From juergen.flosbach bigfoot com 2007-01-08 13:52 -------
Hi Gilles

I got my backtrace ( with a bit in front of it )

My actions where :
start digikam ( I'm now in an image directory )
open right side tags-filter tab
click one tag
click the same tag again

Backtrace :
digikam: ImagePluginLoader: Loaded plugin ImagePlugin_ChannelMixer
digikam: ImagePlugin_Charcoal plugin loaded
digikam: ImagePluginLoader: Loaded plugin ImagePlugin_Charcoal

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 46912601770720 (LWP 4555)]
0x00002aaaaaeec905 in Digikam::NavigateBarWidget::setButtonsState (this=0xffffffffffffffff, itemType=1) at navigatebarwidget.cpp:133
133 d->itemType = itemType;
(gdb) bt
#0 0x00002aaaaaeec905 in Digikam::NavigateBarWidget::setButtonsState (this=0xffffffffffffffff, itemType=1) at navigatebarwidget.cpp:133
#1 0x00002aaaaaef5a11 in Digikam::NavigateBarTab::setNavigateBarState (this=0x984140, hasPrevious=false, hasNext=true) at navigatebartab.cpp:77
#2 0x00002aaaaaedf2ba in Digikam::ImagePropertiesSideBarDB::setPreviousNextState (this=0x7fbbc0, hasPrevious=false, hasNext=true)
at imagepropertiessidebardb.cpp:181
#3 0x00002aaaaadd206f in Digikam::DigikamView::slotDispatchImageSelected (this=0x730ac0) at digikamview.cpp:629
#4 0x00002aaaaadd370b in Digikam::DigikamView::qt_invoke (this=0x730ac0, _id=95, _o=0x7fffffab5e70) at digikamview.moc:333
#5 0x00002aaaae756448 in QObject::activate_signal () from /usr/lib/qt3/lib64/libqt-mt.so.3
#6 0x00002aaaae75687d in QObject::activate_signal () from /usr/lib/qt3/lib64/libqt-mt.so.3
#7 0x00002aaaae776385 in QTimer::event () from /usr/lib/qt3/lib64/libqt-mt.so.3
#8 0x00002aaaae6fe8b3 in QApplication::internalNotify () from /usr/lib/qt3/lib64/libqt-mt.so.3
#9 0x00002aaaae6ff347 in QApplication::notify () from /usr/lib/qt3/lib64/libqt-mt.so.3
#10 0x00002aaaadb5018e in KApplication::notify () from /opt/kde3/lib64/libkdecore.so.4
#11 0x00002aaaae6f4877 in QEventLoop::activateTimers () from /usr/lib/qt3/lib64/libqt-mt.so.3
#12 0x00002aaaae6b3f73 in QEventLoop::processEvents () from /usr/lib/qt3/lib64/libqt-mt.so.3
#13 0x00002aaaae713771 in QEventLoop::enterLoop () from /usr/lib/qt3/lib64/libqt-mt.so.3
#14 0x00002aaaae713672 in QEventLoop::exec () from /usr/lib/qt3/lib64/libqt-mt.so.3
#15 0x000000000040307b in main (argc=1, argv=0x7fffffab6858) at main.cpp:270
(gdb)

END

Hope that helps.

Juergen
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Jürgen Flosbach dk

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From juergen.flosbach bigfoot com 2007-01-08 13:58 -------
Created an attachment (id=19194)
--> (http://bugs.kde.org/attachment.cgi?id=19194&action=view)
Backtrace crash on tags toggle

Digikam chrashes when tag in tags filter tab gets clicked twice.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-08 15:53 -------
SVN commit 621274 by cgilles:

digiKam from trunk : Comments & Tags pop-up menu : add missing option to disable 'Toggle Auto' of Tags option.

CCBUGS: 139547

M +14 -8 imagedescedittab.cpp

--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #621273:621274
@ -670,11 +670,12 @

QPopupMenu toggleAutoMenu;
toggleAutoMenu.setCheckable(true);
- toggleAutoMenu.insertItem(i18n("Childs"), 21);
- toggleAutoMenu.insertItem(i18n("Parents"), 22);
- toggleAutoMenu.insertItem(i18n("Both"), 23);
- if (d->toggleAutoTags != TagFilterView::NoToggleAuto)
- toggleAutoMenu.setItemChecked(20 + d->toggleAutoTags, true);
+ toggleAutoMenu.insertItem(i18n("None"), 21);
+ toggleAutoMenu.insertSeparator(-1);
+ toggleAutoMenu.insertItem(i18n("Childs"), 22);
+ toggleAutoMenu.insertItem(i18n("Parents"), 23);
+ toggleAutoMenu.insertItem(i18n("Both"), 24);
+ toggleAutoMenu.setItemChecked(21 + d->toggleAutoTags, true);
popmenu.insertItem(i18n("Toogle Auto"), &toggleAutoMenu);

int choice = popmenu.exec((QCursor::pos()));
@ -772,17 +773,22 @
item->setOn(false);
break;
}
- case 21: // Toggle auto Childs tags.
+ case 21: // No toggle auto tags.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
+ break;
+ }
+ case 22: // Toggle auto Childs tags.
+ {
d->toggleAutoTags = TagFilterView::Childs;
break;
}
- case 22: // Toggle auto Parents tags.
+ case 23: // Toggle auto Parents tags.
{
d->toggleAutoTags = TagFilterView::Parents;
break;
}
- case 23: // Toggle auto Childs and Parents tags.
+ case 24: // Toggle auto Childs and Parents tags.
{
d->toggleAutoTags = TagFilterView::ChildsAndParents;
break;
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-08 16:46 -------
SVN commit 621305 by cgilles:

digiKam from trunk : Comments & Tags pop-up menu : disable Toogle Auto Tags option if user perform Select/Deselect of parents/childs.

CCBUGS: 139547

M +13 -1 imagedescedittab.cpp

--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #621304:621305
@ -120,7 +120,7 @

RatingWidget *ratingWidget;

- TagFilterView::ToggleAutoTags toggleAutoTags;
+ TagFilterView::ToggleAutoTags toggleAutoTags;
};

ImageDescEditTab::ImageDescEditTab(QWidget *parent, bool navBar)
@ -678,6 +678,8 @
toggleAutoMenu.setItemChecked(21 + d->toggleAutoTags, true);
popmenu.insertItem(i18n("Toogle Auto"), &toggleAutoMenu);

+ TagFilterView::ToggleAutoTags oldAutoTags = d->toggleAutoTags;
+
int choice = popmenu.exec((QCursor::pos()));
switch( choice )
{
@ -730,6 +732,7 @
}
case 16: // Invert All Tags Selection.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
QListViewItemIterator it(d->tagsView);
while (it.current())
{
@ -743,34 +746,43 @
}
++it;
}
+ d->toggleAutoTags = oldAutoTags;
break;
}
case 17: // Select Child Tags.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleChildTags(album, true);
TAlbumCheckListItem *item = (TAlbumCheckListItem*)album->extraData(this);
item->setOn(true);
+ d->toggleAutoTags = oldAutoTags;
break;
}
case 18: // Deselect Child Tags.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleChildTags(album, false);
TAlbumCheckListItem *item = (TAlbumCheckListItem*)album->extraData(this);
item->setOn(false);
+ d->toggleAutoTags = oldAutoTags;
break;
}
case 19: // Select Parent Tags.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleParentTags(album, true);
TAlbumCheckListItem *item = (TAlbumCheckListItem*)album->extraData(this);
item->setOn(true);
+ d->toggleAutoTags = oldAutoTags;
break;
}
case 20: // Deselect Parent Tags.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleParentTags(album, false);
TAlbumCheckListItem *item = (TAlbumCheckListItem*)album->extraData(this);
item->setOn(false);
+ d->toggleAutoTags = oldAutoTags;
break;
}
case 21: // No toggle auto tags.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-08 17:18 -------
SVN commit 621319 by cgilles:

digiKam from trunk : Comments & Tags pop-up menu : fix behaviour if Toggle Auto Tags == "Childs and Parents"

CCBUGS: 139547

M +8 -2 imagedescedittab.cpp

--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #621318:621319
@ -521,17 +521,23 @

void ImageDescEditTab::slotItemStateChanged(TAlbumCheckListItem *item)
{
+ TagFilterView::ToggleAutoTags oldAutoTags = d->toggleAutoTags;
+
switch(d->toggleAutoTags)
{
case TagFilterView::Childs:
- toggleChildTags(item->m_album, item->isOn());
+ d->toggleAutoTags = TagFilterView::NoToggleAuto; toggleChildTags(item->m_album, item->isOn());
+ d->toggleAutoTags = oldAutoTags;
break;
case TagFilterView::Parents:
- toggleParentTags(item->m_album, item->isOn());
+ d->toggleAutoTags = TagFilterView::NoToggleAuto; toggleParentTags(item->m_album, item->isOn());
+ d->toggleAutoTags = oldAutoTags;
break;
case TagFilterView::ChildsAndParents:
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleChildTags(item->m_album, item->isOn());
toggleParentTags(item->m_album, item->isOn());
+ d->toggleAutoTags = oldAutoTags;
break;
default:
break;
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-08 17:22 -------
SVN commit 621321 by cgilles:

digiKam from trunk : Tags Filter View pop-up menu : Backport all rencent changes from Comments & Tags po-up menu.

Note : TagFilterViewItem class use QCheckListItem::CheckBox instead QCheckListItem::CheckBoxController. Regression tests require.

Please give me a feedback if Tags Filter view work fine for you

CCBUGS: 139547

M +47 -15 tagfilterview.cpp

--- trunk/extragear/graphics/digikam/digikam/tagfilterview.cpp #621320:621321
@ -73,7 +73,7 @

TagFilterViewItem(QListView* parent, TAlbum* tag, bool untagged=false)
: FolderCheckListItem(parent, tag ? tag->title() : i18n("Not Tagged"),
- QCheckListItem::CheckBoxController)
+ QCheckListItem::CheckBox/*Controller*/)
{
m_tag = tag;
m_untagged = untagged;
@ -84,7 +84,8 @
}

TagFilterViewItem(QListViewItem* parent, TAlbum* tag)
- : FolderCheckListItem(parent, tag->title(), QCheckListItem::CheckBoxController)
+ : FolderCheckListItem(parent, tag->title(),
+ QCheckListItem::CheckBox/*Controller*/)
{
m_tag = tag;
m_untagged = false;
@ -98,6 +99,10 @
{
QCheckListItem::stateChange(val);

+/* NOTE G.Caulier 2007/01/08: this code is now disable because TagFilterViewItem
+ have been changed from QCheckListItem::CheckBoxController
+ to QCheckListItem::CheckBox.
+
// All TagFilterViewItems are CheckBoxControllers. If they have no children,
// they should be of type CheckBox, but that is not possible with our way of adding items.
// When clicked, children-less items first change to the NoChange state, and a second
@ -107,6 +112,7 @
{
setState(On);
}
+*/

((TagFilterView*)listView())->stateChanged(this);
}
@ -249,17 +255,25 @

void TagFilterView::stateChanged(TagFilterViewItem* item)
{
+ ToggleAutoTags oldAutoTags = d->toggleAutoTags;
+
switch(d->toggleAutoTags)
{
case Childs:
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleChildTags(item, item->isOn());
+ d->toggleAutoTags = oldAutoTags;
break;
case Parents:
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleParentTags(item, item->isOn());
+ d->toggleAutoTags = oldAutoTags;
break;
case ChildsAndParents:
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleChildTags(item, item->isOn());
toggleParentTags(item, item->isOn());
+ d->toggleAutoTags = oldAutoTags;
break;
default:
break;
@ -626,20 +640,23 @

QPopupMenu toggleAutoMenu;
toggleAutoMenu.setCheckable(true);
- toggleAutoMenu.insertItem(i18n("Childs"), 21);
- toggleAutoMenu.insertItem(i18n("Parents"), 22);
- toggleAutoMenu.insertItem(i18n("Both"), 23);
- if (d->toggleAutoTags != None)
- toggleAutoMenu.setItemChecked(20 + d->toggleAutoTags, true);
+ toggleAutoMenu.insertItem(i18n("None"), 21);
+ toggleAutoMenu.insertSeparator(-1);
+ toggleAutoMenu.insertItem(i18n("Childs"), 22);
+ toggleAutoMenu.insertItem(i18n("Parents"), 23);
+ toggleAutoMenu.insertItem(i18n("Both"), 24);
+ toggleAutoMenu.setItemChecked(21 + d->toggleAutoTags, true);
popmenu.insertItem(i18n("Toogle Auto"), &toggleAutoMenu);

QPopupMenu matchingCongMenu;
matchingCongMenu.setCheckable(true);
- matchingCongMenu.insertItem(i18n("Or Between Tags"), 24);
- matchingCongMenu.insertItem(i18n("And Between Tags"), 25);
- matchingCongMenu.setItemChecked((d->matchingCond == AlbumLister::OrCondition) ? 24 : 25, true);
+ matchingCongMenu.insertItem(i18n("Or Between Tags"), 25);
+ matchingCongMenu.insertItem(i18n("And Between Tags"), 26);
+ matchingCongMenu.setItemChecked((d->matchingCond == AlbumLister::OrCondition) ? 25 : 26, true);
popmenu.insertItem(i18n("Matching Condition"), &matchingCongMenu);

+ ToggleAutoTags oldAutoTags = d->toggleAutoTags;
+
int choice = popmenu.exec((QCursor::pos()));
switch( choice )
{
@ -690,6 +707,7 @
}
case 16: // Invert All Tags Selection.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
QListViewItemIterator it(this);
while (it.current())
{
@ -708,58 +726,72 @
++it;
}
triggerChange();
+ d->toggleAutoTags = oldAutoTags;
break;
}
case 17: // Select Child Tags.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleChildTags(item, true);
TagFilterViewItem *tItem = (TagFilterViewItem*)item->m_tag->extraData(this);
tItem->setOn(true);
+ d->toggleAutoTags = oldAutoTags;
break;
}
case 18: // Deselect Child Tags.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleChildTags(item, false);
TagFilterViewItem *tItem = (TagFilterViewItem*)item->m_tag->extraData(this);
tItem->setOn(false);
+ d->toggleAutoTags = oldAutoTags;
break;
}
case 19: // Select Parent Tags.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleParentTags(item, true);
TagFilterViewItem *tItem = (TagFilterViewItem*)item->m_tag->extraData(this);
tItem->setOn(true);
+ d->toggleAutoTags = oldAutoTags;
break;
}
case 20: // Deselect Parent Tags.
{
+ d->toggleAutoTags = TagFilterView::NoToggleAuto;
toggleParentTags(item, false);
TagFilterViewItem *tItem = (TagFilterViewItem*)item->m_tag->extraData(this);
tItem->setOn(false);
+ d->toggleAutoTags = oldAutoTags;
break;
}
- case 21: // Toggle auto Childs tags.
+ case 21: // No toggle auto tags.
{
+ d->toggleAutoTags = NoToggleAuto;
+ break;
+ }
+ case 22: // Toggle auto Childs tags.
+ {
d->toggleAutoTags = Childs;
break;
}
- case 22: // Toggle auto Parents tags.
+ case 23: // Toggle auto Parents tags.
{
d->toggleAutoTags = Parents;
break;
}
- case 23: // Toggle auto Childs and Parents tags.
+ case 24: // Toggle auto Childs and Parents tags.
{
d->toggleAutoTags = ChildsAndParents;
break;
}
- case 24: // Or Between Tags.
+ case 25: // Or Between Tags.
{
d->matchingCond = AlbumLister::OrCondition;
triggerChange();
break;
}
- case 25: // And Between Tags.
+ case 26: // And Between Tags.
{
d->matchingCond = AlbumLister::AndCondition;
triggerChange();
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Jürgen Flosbach dk

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547
juergen.flosbach bigfoot com changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #19194|0 |1
is obsolete| |

------- Additional Comments From juergen.flosbach bigfoot com 2007-01-08 18:06 -------
Created an attachment (id=19197)
--> (http://bugs.kde.org/attachment.cgi?id=19197&action=view)
New backtrace

Hi Gilles

Last time I've send the backtrace in I generated this backtrace
according to "If you are experiencing crashes with digiKam"
information with gdb.
I'm not shure if this was something usefull when I compare it
with what I got now.
This time when digikam crashed I recognized the KDE crash
monitor.
This one generated the attached backtrace.

Source was this time the last svn with your new menue
entry in the comments/tags tab. The one with the "non"
entry in the tags pop-up menu.

That looks good.

Juergen
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-08 18:49 -------
Juergen,

Your previous bactrace is good, the new one is unsuitable. Please revert the obsolete attachement.

Also, the crash is not relevant of my changes in Comments & Tags pop-up menu. I suspect than the cras is relevant of the sidebar management from digiKam core where Marcel is under working to support multiple pictures selection with Comments & Tags. In some conditions, i can reproduce it, but it difficult to hack...

Marcel, please give me a feedback

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from owner@bugs.kde.org

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547
juergen.flosbach bigfoot com changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #19194|1 |0
is obsolete| |

------- Additional Comments From juergen.flosbach bigfoot com 2007-01-08 19:41 -------
(From update of attachment 19194)
This is the good backtrace, the next one the unusable one.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from owner@bugs.kde.org

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547
juergen.flosbach bigfoot com changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #19197|0 |1
is obsolete| |

------- Additional Comments From juergen.flosbach bigfoot com 2007-01-08 19:43 -------
(From update of attachment 19197)
The last backtrace was good. This one is unusable.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-08 21:37 -------
SVN commit 621450 by cgilles:

digikam from trunk : Comments & Tags popup menu behaviours. Do not toogle the current Tags checkbox from treeview when user click with right mouse button to get popup menu.
CCBUGS: 139547

M +12 -2 talbumlistview.cpp

--- trunk/extragear/graphics/digikam/libs/imageproperties/talbumlistview.cpp #621449:621450
@ -166,15 +166,25 @

void TAlbumListView::contentsMousePressEvent(QMouseEvent *e)
{
- QListView::contentsMousePressEvent(e);
QPoint vp = contentsToViewport(e->pos());
TAlbumCheckListItem *item = dynamic_cast<TAlbumCheckListItem*>(itemAt(vp));
+
+ if(item && e->button() == RightButton)
+ {
+ bool isOn = item->isOn();
+ QListView::contentsMousePressEvent(e);
+ // Restore the status of checkbox.
+ item->setOn(isOn);
+ return;
+ }
+
if(item && e->button() == LeftButton)
{
m_dragStartPos = e->pos();
m_dragItem = item;
- return;
}
+
+ QListView::contentsMousePressEvent(e);
}

void TAlbumListView::contentsMouseReleaseEvent(QMouseEvent *e)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-08 21:46 -------
SVN commit 621456 by cgilles:

digikam from trunk : Tags Filter View popup menu behaviours. Do not toogle the current Tags checkbox from treeview when user click with right mouse button to get popup menu.
CCBUGS: 139547

M +17 -0 tagfilterview.cpp
M +1 -0 tagfilterview.h

--- trunk/extragear/graphics/digikam/digikam/tagfilterview.cpp #621455:621456
@ -287,6 +287,23 @
d->timer->start(50, true);
}

+void TagFilterView::contentsMousePressEvent(QMouseEvent *e)
+{
+ QPoint vp = contentsToViewport(e->pos());
+ TagFilterViewItem *item = dynamic_cast<TagFilterViewItem*>(itemAt(vp));
+
+ if(item && e->button() == RightButton)
+ {
+ bool isOn = item->isOn();
+ QListView::contentsMousePressEvent(e);
+ // Restore the status of checkbox.
+ item->setOn(isOn);
+ return;
+ }
+
+ QListView::contentsMousePressEvent(e);
+}
+
QDragObject* TagFilterView::dragObject()
{
QValueList<int> dragTagIDs;
--- trunk/extragear/graphics/digikam/digikam/tagfilterview.h #621455:621456
@ -60,6 +60,7 @
QDragObject* dragObject();
bool acceptDrop(const QDropEvent *e) const;
void contentsDropEvent(QDropEvent *e);
+ void contentsMousePressEvent(QMouseEvent *e);

private slots:
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From marcel.wiesweg gmx de 2007-01-08 23:28 -------
SVN commit 621508 by mwiesweg:

Attempt to fix the crash:
Use dynamic_cast here as well, the assumption that all tabs are known was wrong (and fixed in other places)

CCBUG: 139547

M +1 -1 imagepropertiessidebardb.cpp

--- trunk/extragear/graphics/digikam/libs/imageproperties/imagepropertiessidebardb.cpp #621507:621508
@ -175,7 +175,7 @
d->hasPrevious = hasPrevious;
d->hasNext = hasNext;

- NavigateBarTab *navtab = static_cast<NavigateBarTab *>(getActiveTab());
+ NavigateBarTab *navtab = dynamic_cast<NavigateBarTab *>(getActiveTab());
if (navtab)
{
navtab->setNavigateBarState(d->hasPrevious, d->hasNext);
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-09 07:41 -------
Thanks Marcel,

Juergen, the crash is now fixed for you using the current svn implementation ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Jürgen Flosbach dk

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From juergen.flosbach bigfoot com 2007-01-09 09:17 -------
Hallo Gilles, Marcel

Thanks to the crashfree version. I've tested it
and couldn't reproduce the crash.
And with my original whish come true I would say
let's close this bug report.

Juergen
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-2

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From caulier.gilles kdemail net 2007-01-09 09:20 -------
Juergen,

have you tested all my recents changes ? All work fine for you ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Jürgen Flosbach dk

[Digikam-devel] [Bug 139547] tag hierarchy automatic fill

In reply to this post by Jürgen Flosbach dk

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugs.kde.org/show_bug.cgi?id=139547

------- Additional Comments From juergen.flosbach bigfoot com 2007-01-09 09:44 -------
Gilles

Yes.

I tested all changes and it loks very good to me.

P.S. D&D from comments/tags tab would be nice
( Child plus parents ) but this was not what I
whished for originaly.

Thanks again to the entire digikam team.

Juergen
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Re: [Digikam-devel] [Bug 139547] tag hierarchy automatic fill

> P.S. D&D from comments/tags tab would be nice
> ( Child plus parents ) but this was not what I
> whished for originaly.

For comments/tags moving tags around used to work,
but it does not anymore.
For the Tag-Filter it would be a nice addition so
that all the three tag-views behave the same.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

12345