[Digikam-devel] [Bug 126874] New: digikam does not support <shift+del>

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         
           Summary: digikam does not support <shift+del>
           Product: digikam
           Version: 0.9.0-svn
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: thorsten.schnebeck gmx net


Version:           0.9.0-svn (using KDE 3.5.2, compiled sources)
Compiler:          gcc version 3.4.5 (Gentoo 3.4.5-r1, ssp-3.4.5-1.0, pie-8.7.9)
OS:                Linux (i686) release 2.6.16-gentoo-r6

Standard KDE behavior is
<del> moves a file into the trashbin
<shift+del> deletes a file

No need for a visual command in the edit menu but as a keyboard command it would be nice add-on in digiKams albumview.

Bye

  Thorsten
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|digikam does not support    |digikam does not support
                   |<shift+del>                 |<shift+del>



------- Additional Comments From marcel.wiesweg gmx de  2006-06-03 23:38 -------
Look at this:
http://amarok.kde.org/blog/archives/90-Concluding-the-Delete-Controversy.html
I guess with shift+del the checkbox at the bottom will be checked.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From thorsten.schnebeck gmx net  2006-06-04 00:54 -------
I am completely for supporting "delete into trash-folder" in a GUI. But there should be a shortcut for really deleting. As I said in my wishlist: No need for a visual command only the shortcut for power users.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1



------- Additional Comments From marcel.wiesweg gmx de  2006-06-04 17:55 -------
Yes, but there wont be a shortcut without GUI, its too dangerous.
If we change this and use the above GUI idea, which I like quite much (and it seems not only digikam has had a delete controversy) I'd propose

- Del shows the dialog without checkbox checked - currently, nothing
- Shift+Del shows the dialog with checkbox checked - currently, move to trash (or delete file, depending on setup option I think)
- context menu as today, not daring to touch the setup option - or remove the option.

As you point out, the current behavior differs from KDE standard, thats probably the most important point here.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         
ach mpe mpg de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ach mpe mpg de



------- Additional Comments From ach mpe mpg de  2006-06-13 13:57 -------
Yeah, standard behaviour is very important IMO.
aka <del> move to trash, shift-<del> delete.

I don't care that much if a dialog pops up AS
LANG AS there is an option 'never show this again.
(and somwhere an option reset them so all dialogs are
shown again)

Achim
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-07-12 16:02 -------
Created an attachment (id=16967)
 --> (http://bugs.kde.org/attachment.cgi?id=16967&action=view)
Suggestion for trash bin handling

The attached patch contains the proposed delete dialog, boldly copied from
Amarok, (c) Ian Monroe and Micheal Pyne.
It's not complete, deleting an album from AlbumFolderView is missing, the
delete action in the main app and IE menus is missing, and the keyboard
shortcuts are missing.

The idea is the the use-trash setup option will go away, but the delete dialog
stores the user's preference.

Once again, I think that we won't have any sort of delete action without a
confirmation dialog. But that's a difficult issue, don't know what KDE
guidelines say about this - Konqueror e.g. has the don't ask me again checkbox.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From ach mpe mpg de  2006-07-12 18:19 -------
Hi Marcel,

can you attach a screen shot.

> Marcel wrote:
>Once again, I think that we won't have any sort of delete action without a
> confirmation dialog.

Well, uhm, argl! ;) As a compromisse, a delete-with-out-bothering-me-with-dialog action should be available so one can bind shift-del to it if one wants it.  I'm no fan of either always delete or always move to trash.

OSS is about freedom, and I and maybe other want the freedom to get rid 'sometimes' of some pics quickly.  If the binding is on by default
is a topic for a future bug report ;)

Achim
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-07-12 19:17 -------
The link from #1 contains a screenshot. Currently it's exactly the same.

I like the idea of a hidden action, so power users can enable this. It must be documented somewhere. I am always favorable of allowing such choice, but I really think it won't be the default, it's so dangerous, some inaadvertent key press and your images are gone forever.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-07-15 23:42 -------
Created an attachment (id=16998)
 --> (http://bugs.kde.org/attachment.cgi?id=16998&action=view)
Next version of the patch

Here is the next version of the patch. It adds the suggested, dangerous (and
thus hidden by default) actions which can be assigned shortcuts by power users.
Del and Shift+Del are supported. Album deletion is still not integrated in the
DeleteDialog
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Usability
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-08-03 23:22 -------
Created an attachment (id=17215)
 --> (http://bugs.kde.org/attachment.cgi?id=17215&action=view)
Dialog with one image selected

Screenshot of the new delete dialog, one image was selected, <Del> was pressed
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-08-03 23:25 -------
Created an attachment (id=17216)
 --> (http://bugs.kde.org/attachment.cgi?id=17216&action=view)
Deleting albums

Screenshot of the new delete dialog.
Right-click on the albums folder view, Delete Album, the checkbox was checked
to delete permanently.

I can provide a patch if someone wants to test this.
But, unless I receive negative comments, I am going to commit this. Any
opinions?
The Delete Dialog is now used in main view (for albums and images) and in IE.
For images, hidden actions to delete without confirmation are available in IE
and main view.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From ach mpe mpg de  2006-08-04 02:12 -------
Looks fine.  I'm already curious to try it out in -beta2

Thx a lot Marcel,
Achim
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From thorsten.schnebeck gmx net  2006-08-05 00:39 -------
I would like to test a patch this weekend if you can provide one. The older one can not be applied to svn-trunk without errors. I hope, it still provides a method to configure a simple delete shortcut without anoying GUI warnings for the "power users"(?)
I think this combined mv to trash/delete GUI is confusing for the inexperienced user. I would vote for a move to trash as a save default without offering a delete option.

Thanks for your work

  Thorsten
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-08-05 14:44 -------
Created an attachment (id=17235)
 --> (http://bugs.kde.org/attachment.cgi?id=17235&action=view)
Current version of the patch

Here is a patch from the current version.

You can configure your own shortcuts for delete-without-confirmation using the
standard KDE shortcut configuration. These actions have no menu entry, toolbar
entry, shortcut assigned by default.
Default is <Del> -> Show dialog
For those who are used to <Shift+Del>, this shows the dialog with the checkbox
checked.
For those who are not used to shortcuts, and that's the main point of this idea
(Ian Monroe's), the dialog will save the user's preference. That's the
equivalent for the UseTrash setup entry.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From thorsten.schnebeck gmx net  2006-08-06 16:29 -------
Hmm, seems like uic does not generate header files:
cat del.patch | patch -p0 && cd .. && ./configure --prefix=/usr/kde/3.5 && cd digikam && make
In file included from imagewindow.cpp:91:
../../../../digikam/digikam/deletedialog.h:24:30: deletedialogbase.h: No such file or directory
In file included from imagewindow.cpp:91:
../../../../digikam/digikam/deletedialog.h:53: error: expected class-name before '{' token
../../../../digikam/digikam/deletedialog.h: In member function `bool Digikam::DeleteDialog::shouldDelete() const':
../../../../digikam/digikam/deletedialog.h:92: error: 'class Digikam::DeleteWidget' has no member named 'ddShouldDelete'
make[3]: *** [imagewindow.lo] Fehler 1
make[3]: Leaving directory `/usr/local/src/kde-svn/extragear/graphics/digikam/utilities/imageeditor/editor'

Bye

  Thorsten
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17235|0                           |1
        is obsolete|                            |



------- Additional Comments From marcel.wiesweg gmx de  2006-08-06 23:14 -------
Created an attachment (id=17250)
 --> (http://bugs.kde.org/attachment.cgi?id=17250&action=view)
Corrected version

You are right. I moved it to libs/dialogs, thats more appropriate anyway.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From thorsten.schnebeck gmx net  2006-08-07 07:56 -------
Hi Marcel,

I have still problems:

albumfolderview.cpp:59:26: deletedialog.h: No such file or directory
albumfolderview.cpp: In member function `void Digikam::AlbumFolderView::albumDelete(Digikam::AlbumFolderViewItem*)':
albumfolderview.cpp:596: error: `DeleteDialog' was not declared in this scope
albumfolderview.cpp:596: error: expected `;' before "dialog"
albumfolderview.cpp:599: error: `dialog' was not declared in this scope
albumfolderview.cpp:601: error: `DeleteDialogMode' has not been declared
albumfolderview.cpp:601: error: `Albums' was not declared in this scope
albumfolderview.cpp:601: error: `DeleteDialogMode' has not been declared
albumfolderview.cpp:601: error: `Subalbums' was not declared in this scope
albumfolderview.cpp:599: warning: unused variable 'dialog'
albumfolderview.cpp:601: warning: unused variable 'Albums'
albumfolderview.cpp:601: warning: unused variable 'Subalbums'
albumfolderview.cpp:604: error: `dialog' was not declared in this scope
albumfolderview.cpp:596: warning: unused variable 'DeleteDialog'
albumfolderview.cpp:604: warning: unused variable 'dialog'
make[1]: *** [albumfolderview.lo] Fehler 1
make[1]: Leaving directory `/usr/local/src/kde-svn/extragear/graphics/digikam/digikam'

Bye

  Thorsten
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17250|0                           |1
        is obsolete|                            |



------- Additional Comments From marcel.wiesweg gmx de  2006-08-07 23:14 -------
Created an attachment (id=17277)
 --> (http://bugs.kde.org/attachment.cgi?id=17277&action=view)
Corrected version

Ok, next try. This time I did a make clean all to test that it compiles!
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From thorsten.schnebeck gmx net  2006-08-08 00:35 -------
Hmm, I have still the same error(?)

I deleted my extragear/graphics/digikam folder,
made svn-update to recreate a fresh digikam,
applied the patch (md5sum 8e2f454068de025c0577e0d38e62229e  del.patch)
make -f Makefile.cvs
./configure
cd digikam
make
...
error

Bye

 Thorsten
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel