[Digikam-devel] [Bug 126874] New: digikam does not support <shift+del>

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-08-08 16:18 -------
That is strange. I did a fresh complete checkout, applied the patch, and it works.

The part to fix the compilation problem is:

svn diff digikam/digikam/Makefile.am

Index: digikam/digikam/Makefile.am
===================================================================
--- digikam/digikam/Makefile.am (revision 571069)
+++ digikam/digikam/Makefile.am (working copy)
 @ -14,6 +14,7  @
           -I$(top_srcdir)/digikam/libs/dmetadata \
           -I$(top_srcdir)/digikam/libs/imageproperties \
           -I$(top_srcdir)/digikam/libs/threadimageio \
+          -I$(top_srcdir)/digikam/libs/dialogs \
           -I$(top_srcdir)/digikam/utilities/cameragui \
           -I$(top_srcdir)/digikam/utilities/imageeditor/editor \
           -I$(top_srcdir)/digikam/utilities/imageeditor/canvas \
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From thorsten.schnebeck gmx net  2006-08-13 00:29 -------
(new weekend - new time for some tests)

so, I was able to apply the patch, which BTW in the meantime with one rej out of sync to SVN-trunk.
The patch gives me the same dialog for "move to trash" and "delete". There is one option allowing to switch visually between both modes with a simple mouse click.

So now, how do I comment this patch... I want to remark that I help some users that are "real users only". They dont know anything deeper about computer but they know how to work with their apps. I stipped down all advanced features and till now they like to use digikam for managing their photos. OTOH there are some power users with advanced knowledge about KDE like myself.

Of course its harder to maintain systems of the first group as things have to be easy. But this patch does not make things easier!

Everytime a window appears based on user action of unexperienced users they are afraid that they have made a mistage. Believe me, if this type of user deletes a file they really think about this action as "delete" means "its away". If this is done by mistake its normally a mouse handling error and they are happy when I magically recover the file from the trash.

We all know this kind of "warning windows" that are anyoing and noone reads it and we click "next" or "ok". A warning window with and option I think is worse.

So I suggest to add an "dont show this window again" option and leave the "del"-action as "move to trash" by default. There should be no way to make a "del" to a "shift+del"-action like the option in the dialog allows now. "shift+del" should be an advanced feature you have to know about. Having huge harddisks today there sould be no reason to make make deleting more prominent.

(I really, really suggest to ask KDEs usabillity group for their opinion for such a basic operation)

My 2Ct

  Thorsten
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-08-15 15:47 -------
My opinion on delete-without-dialog can be found in comment #3.
We use dialogs everywhere, so a fear of dialogs is not good. (and nothing I will orient my coding at)

I will definitely wait for Gilles' opinion on this.
I did not find any relevant HIG guidelines or relevant discussions on usability mailinglists.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From caulier.gilles free fr  2006-08-17 02:49 -------
Marcel,

The screenshots sound good for me. I will try your patch and give an advanced feedback when it possible.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-08-17 23:08 -------
Created an attachment (id=17406)
 --> (http://bugs.kde.org/attachment.cgi?id=17406&action=view)
Current version

Same code as before, but is tested to apply cleanly.
(One thing I noted missing: set focus to buttons in DeleteDialog)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aironmail gmail com



------- Additional Comments From marcel.wiesweg gmx de  2006-08-20 22:55 -------
*** Bug 132691 has been marked as a duplicate of this bug. ***
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Diego Moya]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From turingt gmail com  2006-08-21 08:18 -------
There's some further discussion at the usability list:
http://lists.kde.org/?l=kde-usability&m=115581518925528&w=2
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From aironmail gmail com  2006-08-21 14:13 -------
I've tested the patch. In my opinion now it works much better. Now digikam behaves in the way that I expect from an application when trying to remove files, preventing to remove files from the disk by user errors. I just wanted give some feedback.

I'm just curious about one thing. In the editor, I can use Del or Shift+Del to delete a file. In the main interface (the album browser,...) I only can use Shift+Del. After applying the patch, "Del only" has no effect. I don't know if this is intended.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         




------- Additional Comments From marcel.wiesweg gmx de  2006-08-21 22:19 -------
To sum up my current state:

- <Del> brings up the trash dialog with a "Do not show this again"
- <Shift+Del> brings up the permanently-delete dialog without an option
- we can keep the hidden action for permanently-delete without confirmation
- remove the current setup option whether to trash or permanently delete

Problems:
1) The above is for single images. What about albums? We only have the context menu in the sidebar, no shortcut. Use the dialog as it is currently for this, with the option to switch to delete permanently?
2) Add a setup option to make the dialog reachable again when "Do not show this again" has been checked?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=126874         
marcel.wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From marcel.wiesweg gmx de  2006-08-25 15:20 -------
SVN commit 577066 by mwiesweg:

File Deletion handling

After long discussion (#126874) and input from KDE usability team:
- <Del> brings up the trash dialog with a "Do not ask again"
- <Shift+Del> brings up the permanently-delete dialog without an option
- there are hidden actions for delete without confirmation to which power users can assign shortcuts
- the current setup option whether to trash or permanently delete is removed from the setup
  - it is kept internally and used for album deletion, see below
- add a new setup option which is identical to the "Do not ask again" option is the trash
  dialog, so that this setting is reversible
  - added to AlbumSettings as well
- in the AlbumFolderView, if deleting a whole album,
  only the context menu can be used to select a delete operation - Shift+Del is reserved for images.
  Here, the user can choose in the dialog whether to trash or delete permanently. This setting is stored.
  No "Do not ask again" will be available.
  - all subalbums will be included in the list in the DeleteDialog to make the user aware that
    he deletes them as well
- fix a bug in ImageWindow slotDeleteCurrent with directories that contain a "#"
- The DeleteDialog has now five modes of operation, see above. The checkboxes
  are in a widget stack, all the functionality that was there is still there for future needs.

BUG: 126874
CCMAIL: digikam-devel kde org
 



 M  +1 -0      digikam/Makefile.am  
 M  +34 -57    digikam/albumfolderview.cpp  
 M  +2 -0      digikam/albumfolderview.h  
 M  +38 -30    digikam/albumiconview.cpp  
 M  +8 -7      digikam/albumiconview.h  
 M  +14 -0     digikam/albumsettings.cpp  
 M  +3 -0      digikam/albumsettings.h  
 M  +37 -29    digikam/digikamapp.cpp  
 M  +3 -1      digikam/digikamapp.h  
 M  +16 -1     digikam/digikamview.cpp  
 M  +3 -0      digikam/digikamview.h  
 M  +5 -5      digikam/dio.cpp  
 M  +2 -2      digikam/dio.h  
 M  +5 -15     digikam/syncjob.cpp  
 M  +2 -11     digikam/syncjob.h  
 M  +1 -1      libs/dialogs/Makefile.am  
 M  +1 -0      utilities/imageeditor/editor/Makefile.am  
 M  +1 -1      utilities/imageeditor/editor/editorwindow.cpp  
 M  +75 -25    utilities/imageeditor/editor/imagewindow.cpp  
 M  +9 -0      utilities/imageeditor/editor/imagewindow.h
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel