[Bug 245380] New: improve the ergonomics of the bwsepia filter ui

https://bugs.kde.org/show_bug.cgi?id=245380

           Summary: improve the ergonomics of the bwsepia filter ui
           Product: digikam
           Version: 1.4.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=49377)
 --> (http://bugs.kde.org/attachment.cgi?id=49377)
complete new ui to the bwsepiafilter

Version:           1.4.0 (using KDE 4.3.3)
OS:                Linux

I do a lot of black and white. Digikam is great at it, with good presets, but
most of the time, I feel somewhat limited in what I really want to achieve.
This led me to look at the code, but I'm not really a programmer, and to change
the way the b&w filter works, a lot of coding is obviously needed.

On the other hand, while I looked at the code, I saw that the UI was more
immediately accessible to some coding, to improve the ergonomics and
consistency with newer filters using some widgets written specifically for
digikam (the RExpanderBox).

In the process, I noticed the histogram was somehow eating up valuable screen
space, and I tweaked the luminosity curvebox to update in real time to reflect
the preview histogram in its background.

I also changed the previewlist widget to display as a box of icons instead of a
list, again to rationalize the ui use of available space, but without
cluttering the screen with too small previews.

Screenshot of my mods :
http://picasaweb.google.com/lh/photo/gTK5ER0guRk9czU6p1xg2g?feat=directlink

I attach a patch of my attempts. This compiles against the 1.4 svn version of
digikam. I did to the best of my abilities, which doesn't means much I'm
afraid, and I'd really love to hear comments and suggestions to improve what I
did.

I can provide a diff only for the modified previewlist widget on request.

Reproducible: Didn't try

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Image Editor                |Black and White
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #1 from Manuel Viet <contact 13zenrv fr>  2010-07-23 14:00:16 ---
Created an attachment (id=49432)
 --> (http://bugs.kde.org/attachment.cgi?id=49432)
this version needs to alter the libkdcraw rexpandebox widget with the other
patch

Usability improvement. The RExpanderBox widget gains a toolbox mode, where only
one included RExpander is shown at any given time.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #2 from Manuel Viet <contact 13zenrv fr>  2010-07-23 14:02:22 ---
Created an attachment (id=49433)
 --> (http://bugs.kde.org/attachment.cgi?id=49433)
Adds an exclusive mode to RExpander.

this is a patch to libkdcraw (needs to recompile libkdcraw, kipi-plugins and
digikam for effect). adds a toolbox mode to RExpanderBox widget.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380


Manuel Viet <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49432|this version needs to alter |this version needs to alter
        description|the libkdcraw rexpandebox   |the libkdcraw rexpandebox
                   |widget with the other patch |widget with the other patch
                   |                            |below.




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380


Manuel Viet <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49432|0                           |1
        is obsolete|                            |
  Attachment #49433|0                           |1
        is obsolete|                            |




--- Comment #3 from Manuel Viet <contact 13zenrv fr>  2010-07-25 02:08:06 ---
Created an attachment (id=49468)
 --> (http://bugs.kde.org/attachment.cgi?id=49468)
rexpanderbox based ui to bw filter, only digikam modified

I wasn't happy with my changes to libkdcraw and considered my changes to
rexpanderbox too far reaching. So I thought this over and finally opted to
limit my scope to digikam itself. I therefore created a subclass of rexpander
named rexpanderexclusive (in libs/widgets/common) that belongs to the digikam
namespace and basically adds a toolbox mode to the base widget. I added my
subclass to the necessary CMakeLists. The RExpanderBoxExclusive class is just a
toolbox-mode RExpanderBox by default, and can be reverted to a classic
multi-pane behaviour at the flick of a switch with the provided
setIsToolBox(bool) method.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2010-07-26 12:29:59 ---
Manuel,

"The dynamic curvesbox replaces the non editable histogram at the top of the
toolbox"

No. the original histogram view is not static. It represent the modified image
histogram. It used to check if change provide an under/over exposed picture.
Please restore it.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #5 from Manuel Viet <contact 13zenrv fr>  2010-07-26 14:22:13 ---
(In reply to comment #4)
> Manuel,
>
> "The dynamic curvesbox replaces the non editable histogram at the top of the
> toolbox"
>
> No. the original histogram view is not static. It represent the modified image
> histogram. It used to check if change provide an under/over exposed picture.

Yes, I understood this first time we talked. That's the reason why I added a
method Curvebox::updatedData() to refresh the histogram in the background of
the curve to reflect the modified image histogram, so you know if your actions
are going to over/underexpose the modified image. The data I'm not showing is
the original image static histogram now.

> Please restore it.

No problem, I do it.

Manuel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #6 from Manuel Viet <contact 13zenrv fr>  2010-07-26 15:15:39 ---
Created an attachment (id=49490)
 --> (http://bugs.kde.org/attachment.cgi?id=49490)
bwsepiafiltertool simple UI transformation from KTabWidget to RExpanderBox

following on cg request.

Cheers,

Manuel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2010-07-26 16:05:44 ---
Some feedback after to test :

1/ in iconview, with B&W preview icons, if you select one item to render
preview, you is unable to compare preview together, because selected one is
grayed by selection mode. If fact a selected item must be grayed around the
thumbnail (text + border), but not the image as well.

2/ your expander box running in exclusive mode is very interesting. I will add
it to libkdcraw later KDE 4.5.0 release (it will still back in digiKam core for
a while, to not break binary compatibility). But there is a little problem
there : if you unexpand current item, the vertical layout is broken, an a lots
of space is added between all expander items. Sound like a stretch is not added
to the bottom of layout to move all items to the top.

3/ i don't like to see the same icon for all expander item. please set
different image for each one. It will set it more suitable for end users. look
icons installed from digiKam core to your computer

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380


Manuel Viet <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49490|0                           |1
        is obsolete|                            |




--- Comment #8 from Manuel Viet <contact 13zenrv fr>  2010-07-27 23:12:52 ---
Created an attachment (id=49552)
 --> (http://bugs.kde.org/attachment.cgi?id=49552)
corrected following cg inputs.

Thank you very much for the feedback, this is very encouraging.

> 1/ in iconview, with B&W preview icons, if you select one item to render
> preview, you is unable to compare preview together, because selected one is
> grayed by selection mode. If fact a selected item must be grayed around the
> thumbnail (text + border), but not the image as well.

Done. A combination of stylesheet and Qicon role got this one.

> 2/ your expander box running in exclusive mode is very interesting. I will add
> it to libkdcraw later KDE 4.5.0 release (it will still back in digiKam core for
> a while, to not break binary compatibility). But there is a little problem
> there : if you unexpand current item, the vertical layout is broken, an a lots
> of space is added between all expander items. Sound like a stretch is not added
> to the bottom of layout to move all items to the top.

Yes but the stretch conflict with the previewlist and I could find no
meaningful way to address this concern because until this mode can be
backported to libkdcraw, the layout of the parent RExpanderBox is opaque.

I mitigated the issue by hardcoding a larger initial size for previewlist. It's
not as clean as I wish, but I don't know how to do better.

> 3/ i don't like to see the same icon for all expander item. please set
> different image for each one. It will set it more suitable for end users. look
> icons installed from digiKam core to your computer

Done. I'm not a graphic artist, so I chose some icons I thought more or less
fitting, new icons would be a better solution, but it does look better.

Cheers, Manuel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2010-07-28 09:19:45 ---
Done. Excelent !

Just a little remark : in preview icon view, when you start tool, it do not
select the last used settings. In fact, tool apply it, but nothing is selected
to icon view.

For icons, i will review it later, after to have applied your patch on svn
trunk (digiKam 1.4.0)

Also, for digiKam 2.0.0, we use a separate branch, where i will fork from trunk
libkdcraw, and integrate your expander patch directly.

For information, code is there. Warnings, it's unstable for the moment, do not
use in production. It include all GSoC 2010 works, as Face detection, Image
versioning, and reverse geolocation :

http://websvn.kde.org/branches/extragear/graphics/

I hope that you will interested to patch more digiKam in the future. Your
implementation is very suitable, very well written, and easily reviewable.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #10 from Manuel Viet <contact 13zenrv fr>  2010-07-28 13:57:32 ---
(In reply to comment #9)

> Just a little remark : in preview icon view, when you start tool, it do not
> select the last used settings. In fact, tool apply it, but nothing is selected
> to icon view.

This most strange, and I'm completely lost here, because on my working copy the
behaviour is correct, and the preview icon is shown selected. (QT 4.5.3 & KDE
4.3.3 with updated kdegraphics.)

> For icons, i will review it later, after to have applied your patch on svn
> trunk (digiKam 1.4.0)

Thank you.

> Also, for digiKam 2.0.0, we use a separate branch, where i will fork from trunk
> libkdcraw, and integrate your expander patch directly.

That would be much more convenient. I tried to settle the geometry interactions
between my derived instance and the displayed objects from the outside, but I
realised I would need to worm a way through the QObject tree to get inside the
RExpanderBox main layout. Very bad (and bug-prone) practice, I scrapped my
attempts.

> For information, code is there. Warnings, it's unstable for the moment, do not
> use in production. It include all GSoC 2010 works, as Face detection, Image
> versioning, and reverse geolocation :
>
> http://websvn.kde.org/branches/extragear/graphics/

I'll sure peek a look as soon as I get back in mid-August.

> I hope that you will interested to patch more digiKam in the future. Your
> implementation is very suitable, very well written, and easily reviewable.

Well this is much undeserved praise, and I hope I can find new areas where
polishing efforts are needed :-)

Cheers, Manuel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2010-07-28 14:11:23 ---
>> Just a little remark : in preview icon view, when you start tool, it do not
>> select the last used settings. In fact, tool apply it, but nothing is selected
>> to icon view.

>This most strange, and I'm completely lost here, because on my working copy the
>behaviour is correct, and the preview icon is shown selected. (QT 4.5.3 & KDE
>4.3.3 with updated kdegraphics.)

I will be more precise : i i don't apply yet B&W conversion using new setting
layout (using preview as icon view), the first item from icon view is used to
render preview effect on canvas (this is correct), but the icon view item is
not selected.

I don't have tested the case of B&W tool have been already used before.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #12 from Manuel Viet <contact 13zenrv fr>  2010-07-28 14:24:58 ---
(In reply to comment #11)

> I will be more precise : i i don't apply yet B&W conversion using new setting
> layout (using preview as icon view), the first item from icon view is used to
> render preview effect on canvas (this is correct), but the icon view item is
> not selected.

I understand. I can't look at it now, but I let you know as soon as I can.

Manuel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2010-07-28 14:44:33 ---
Manual,

I can confirm that preview icon selection is not restored between tool session
(in all case)

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #14 from Manuel Viet <contact 13zenrv fr>  2010-07-28 15:00:44 ---
(In reply to comment #12)
> (In reply to comment #11)
>
> I can confirm that preview icon selection is not restored between tool session
> (in all case)

That's most annoying. I can't duplicate it here. I strongly suspect a behaviour
change in QListWidget in Icon Mode between Qt 4.5 and Qt 4.6. I need to setup
an up-to-date new development box before I can tackle this one, at the moment,
I'm blind.

Manuel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2010-07-28 15:04:37 ---
Here i use Qt 4.6.2 from Mandriva 2010.1 open source edition :

digiKam version 1.4.0 (rev.: 1152961)
Exiv2 can write to Jp2: Yes
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Pgf: Yes
Exiv2 can write to Png: Yes
Exiv2 can write to Tiff: Yes
Exiv2 supports XMP metadata: Yes
LibCImg: 130
LibExiv2: 0.20
LibJPEG: 80
LibJasper: 1.900.1
LibKDE: 4.4.3 (KDE 4.4.3)
LibKExiv2: 1.2.0
LibKdcraw: 1.1.0
LibLCMS: 119
LibPGF: 6.09.44
LibPNG: 1.2.43
LibQt: 4.6.2
LibRaw: 0.10.0-Beta2
LibTIFF: LIBTIFF, Version 3.9.2 Copyright (c) 1988-1996 Sam Leffler Copyright
(c) 1991-1996 Silicon Graphics, Inc.
Marble widget: 0.9.3
Parallelized demosaicing: Yes
Database backend: QSQLITE
LibGphoto2: 2.4.9
LibKipi: 1.2.0

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #16 from Manuel Viet <contact 13zenrv fr>  2010-07-28 15:11:37 ---
(In reply to comment #15)
Looks like I'm not up to date on several counts :-)

digiKam version 1.4.0 (rev.: 1154595)
Dématriçage parallélisé: Oui
Exiv2 peut écrire dans un fichier JP2: Oui
Exiv2 peut écrire dans un fichier JPEG: Oui
Exiv2 peut écrire dans un fichier PGF: Oui
Exiv2 peut écrire dans un fichier PNG: Oui
Exiv2 peut écrire dans un fichier TIFF: Oui
Exiv2 prend en charge les métadonnées XMP: Oui
LibCImg: 130
LibExiv2: 0.20
LibJPEG: 62
LibJasper: 1.900.1
LibKDE: 4.3.3 (KDE 4.3.3)
LibKExiv2: 1.1.0
LibKdcraw: 1.1.0
LibLCMS: 118
LibPGF: 6.09.44
LibPNG: 1.2.37
LibQt: 4.5.3
LibRaw: 0.10.0-Beta2
LibTIFF: LIBTIFF, Version 3.8.2 Copyright (c) 1988-1996 Sam Leffler Copyright
(c) 1991-1996 Silicon Graphics, Inc.
Élément graphique Marble: 0.8.1
LibGphoto2: 2.4.3
LibKipi: 1.1.0
Moteur de base de données: QSQLITE

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380


Manuel Viet <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49377|0                           |1
        is obsolete|                            |
  Attachment #49552|0                           |1
        is obsolete|                            |




--- Comment #17 from Manuel Viet <contact 13zenrv fr>  2010-07-29 13:15:22 ---
Created an attachment (id=49629)
 --> (http://bugs.kde.org/attachment.cgi?id=49629)
final bug squashing

> Manual,
>
> I can confirm that preview icon selection is not restored between tool session
> (in all case)
>
> Gilles

I finally made a quick and crude Qt 4.6.3 install, enough to confirm this bug.

It's a Qt 4.x bug. In 4.5, the calculated icons are not displayed properly over
the text in case this text is translated until the QListWidget is reset(), and
4.6 is even further broken, because QListWidget::reset() doesn't restore the
selection anymore like it used to previously.

The attached patch works around this (see
utilities/imageeditor/widgets/previewlist.cpp in void
PreviewList::slotProgressTimerDone() at line 325).

Cheers, Manuel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel