[Bug 245380] New: improve the ergonomics of the bwsepia filter ui

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #18 from Gilles Caulier <caulier gilles gmail com>  2010-07-29 13:41:47 ---
Just few remarks with rexpanderboxexclusive implementation :

- no need to include rexpanderboxexclusive.moc and rexpanderboxexclusive.h.
.moc file is enough.
- with private members, when no d private container is used, add a "m_" prefix.
- when it's possible set value returned by methods as const (ex: bool
isToolBox() const;)

For more details about coding style, take a look in digiKam HACKING file.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2010-07-29 14:12:45 ---
SVN commit 1156631 by cgilles:

apply patch #49629 from Manuel Viet to improve ergonomics of BW converter
BUGS: 245380


 M  +1 -0      CMakeLists.txt  
 M  +6 -6      imageplugins/color/autocorrectiontool.cpp  
 M  +1 -1      imageplugins/color/autocorrectiontool.h  
 M  +50 -43    libs/dimg/filters/bw/bwsepiasettings.cpp  
 M  +1 -1      libs/dimg/filters/bw/bwsepiasettings.h  
 M  +1 -0      libs/widgets/common/CMakeLists.txt  
 M  +53 -28    utilities/imageeditor/widgets/previewlist.cpp  
 M  +12 -14    utilities/imageeditor/widgets/previewlist.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1156631

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #20 from Gilles Caulier <caulier gilles gmail com>  2010-07-29 14:46:39 ---
SVN commit 1156638 by cgilles:

contrast adjustement have been dropped from the layout. Restore it in gui...
CCBUGS: 245380


 M  +6 -7      bwsepiasettings.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1156638

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #21 from Gilles Caulier <caulier gilles gmail com>  2010-07-30 10:30:00 ---
Manuel,

We have a little problem with B&W converter settings and icon-view used to host
preview. This widget is used into Batch Queue Manager, and it do not render any
preview, because we process more than one image, not only just one as in
editor.

Before, when we have used a simple listview, settings been fine. Now it's full
of empty space. It's very annoying (:=)))

The solution will to set a dummy image in Batch Queue Manager (as a photo
colors chart for ex.)

Also, i think that space between icon is very large and can be optimized. Look
space between icon item title and top of next icon on the bottom. What do you
think about ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2010-07-30 10:31:14 ---
Created an attachment (id=49666)
 --> (http://bugs.kde.org/attachment.cgi?id=49666)
BQM and B&W converter settings screen-shot

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #23 from Gilles Caulier <caulier gilles gmail com>  2010-07-30 15:56:37 ---
Created an attachment (id=49681)
 --> (http://bugs.kde.org/attachment.cgi?id=49681)
first try to patch icon view in BQM

Manuel,

This patch is supposed to render a default image icon in icon view with B&W
tool is assigned to BQM. But it crash.

Please take a look. Perhaps i'm in a wrong way to fix it.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #24 from Gilles Caulier <caulier gilles gmail com>  2010-08-09 16:43:48 ---
Manuel,

Do you take a look to my patch ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #25 from Gilles Caulier <caulier gilles gmail com>  2010-08-11 17:27:39 ---
SVN commit 1162180 by cgilles:

- B&W converter for BQM : Add preview using default image preview from Oxygen.
Fix crash due to a non initialized pointer.
Please, always set a pointer to zero : in GDB, you will see an use of null
pointer which is wrong of course. An unitialized pointer as a dumy
which is impossible to identify as wrong quickly...
- Add a new kde notifier event when editor as saved a file. This is usefull
when you review RAW files in icon view and you edit item in editor.
During a save operation, which can take a while, you can go back to icon view
to continue to sort items before to perform RAW import. The notifier
event will bring you when editor is ready to load a new item.
CCBUGS: 245380


 M  +7 -0      digikam/digikam.notifyrc  
 M  +37 -33    libs/dimg/filters/bw/bwsepiasettings.cpp  
 M  +9 -0      showfoto/showfoto.cpp  
 U             utilities/imageeditor/editor/editorwindow.h  
 M  +9 -0      utilities/imageeditor/editor/imagewindow.cpp  
 M  +2 -1      utilities/imageeditor/widgets/previewlist.cpp  
 M  +2 -0      utilities/queuemanager/basetools/color/bwconvert.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1162180

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #26 from Manuel Viet <contact 13zenrv fr>  2010-08-16 15:13:46 ---
Oups. I'm just back from 2 weeks of holidays without internet access and I
discover your messages.

I'll look into this asap.

Cheers,

Manuel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=245380

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=245380

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikamimageplugins         |digikam
          Component|Black and White             |Tool-BW

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel