[Bug 220545] New: Cannot write XMP sidecar files

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #71 from Gilles Caulier <caulier gilles gmail com>  2011-08-02 11:16:27 ---
*** Bug 279159 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vlado Plaga]

https://bugs.kde.org/show_bug.cgi?id=220545


Vlado Plaga <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #72 from Vlado Plaga <rechner vlado-do de>  2011-08-08 17:01:17 ---
(In reply to comment #68)
> For each file we'd need to check if a sidecar is available, and this can take
> a long time when many files are moved.

Is such a check really so slow? DigiKam is not quite as fast as e.g. Dolphin
(not to speak of using the command line) in moving files anyway.

I just made a quick check, trying to move 292 non-existing xmp 'files' (from a
directory with 292 jpg files) to "/tmp". It takes eleven seconds on my system,
which is a little outdated already (a 1.3 GHz PPC from 2005, but with not such
an old HDD).

Maybe there could be a database attribute like "has sidecar file" for each
image, which could be checked much faster?

With digiKam's current behaviour of neither displaying, nor automatically
moving sidecar files, this new feature is not very usable yet, in my opinion. I
often first go through new images applying tags and ratings, and only then move
them to different albums/ directories.

But XMP sidecar files would be excellent for my incremental backup system
(instead of having only the complete database, or multiple copies of images
modified from tagging).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Vlado Plaga]

https://bugs.kde.org/show_bug.cgi?id=220545


Vlado Plaga <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #73 from Vlado Plaga <rechner vlado-do de>  2011-08-08 17:02:08 ---
*** This bug has been confirmed by popular vote. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #74 from Gilles Caulier <caulier gilles gmail com>  2011-09-04 21:10:41 ---
*** Bug 281337 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #75 from Gilles Caulier <caulier gilles gmail com>  2011-09-11 08:05:57 ---
*** Bug 281784 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #76 from Gilles Caulier <caulier gilles gmail com>  2011-12-16 16:31:20 ---
*** Bug 264205 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Metadata                    |Sidecar Management




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #77 from Gilles Caulier <caulier gilles gmail com>  2011-12-26 12:41:25 ---
*** Bug 289845 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #78 from Gilles Caulier <[hidden email]> ---
Git commit 89b525576a53cf26db97e39f6730065d071ac7eb by Marcel Wiesweg.
Committed on 13/03/2012 at 18:55.
Pushed by mwiesweg into branch 'master'.

If a sidecar is read, implement merging of Xmp data to the main image's Xmp
data

M  +14   -20   libkexiv2/kexiv2.cpp
M  +18   -0    libkexiv2/kexiv2_p.cpp
M  +6    -0    libkexiv2/kexiv2_p.h

http://commits.kde.org/libkexiv2/89b525576a53cf26db97e39f6730065d071ac7eb

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #79 from Gilles Caulier <[hidden email]> ---
Git commit ffe8c36d6a4090f590cecaf0a1c6f373afc63f3c by Marcel Wiesweg.
Committed on 13/03/2012 at 18:58.
Pushed by mwiesweg into branch 'master'.

Rewrite DIO: Before starting a job, check for sidecar files which need to be
handled alongside.

The check involves disk access and can take longer, therefore it needs to be
done in a thread.
That means all the DIO methods no longer return a KIO::Job, instead the DIO
class now listens
for the result signal. This means code cleanup in the dependent classes.
DIO class has become a singleton, the thread operations are done with an
internal WorkerObject.

M  +1    -19   digikam/album/albummodificationhelper.cpp
M  +0    -4    digikam/album/albummodificationhelper.h
M  +0    -14   digikam/album/albumtreeview.cpp
M  +0    -3    digikam/album/albumtreeview.h
M  +280  -66   digikam/database/dio.cpp
M  +51   -22   digikam/database/dio.h
M  +8    -24   digikam/dragdrop/albumdragdrop.cpp
M  +19   -36   digikam/dragdrop/imagedragdrop.cpp
M  +0    -3    digikam/items/digikamimageview.cpp
M  +11   -108  digikam/items/imageviewutilities.cpp
M  +0    -9    digikam/items/imageviewutilities.h
M  +3    -15   digikam/main/digikamapp.cpp
M  +0    -1    digikam/main/digikamapp.h
M  +5    -4    utilities/advancedrename/advancedrenameprocessdialog.cpp
M  +2    -35   utilities/imageeditor/editor/imagewindow.cpp

http://commits.kde.org/digikam/ffe8c36d6a4090f590cecaf0a1c6f373afc63f3c

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #80 from Gilles Caulier <[hidden email]> ---
Marcel,

With your last 2 commits, what the status of this important file to solve ?

Especially, i would to know which points from my comment #54 need to be fixed.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #81 from Marcel Wiesweg <[hidden email]> ---
Git commit 1d46b8a6ad3dca38ca890bdb4a668e64d56b8272 by Marcel Wiesweg.
Committed on 15/03/2012 at 21:13.
Pushed by mwiesweg into branch 'master'.

Handle moving sidecar files alongside main file when renaming the temp files in
image editor

M  +45   -25   utilities/imageeditor/editor/editorwindow.cpp
M  +2    -1    utilities/imageeditor/editor/editorwindow.h

http://commits.kde.org/digikam/1d46b8a6ad3dca38ca890bdb4a668e64d56b8272

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #82 from Marcel Wiesweg <[hidden email]> ---
Git commit ff40e084119c05fe90b88cc83ed369a1e07ea17c by Marcel Wiesweg.
Committed on 15/03/2012 at 21:22.
Pushed by mwiesweg into branch 'master'.

Move sidecar file alongside main file in BQM

M  +10   -1    utilities/queuemanager/main/queuemgrwindow.cpp

http://commits.kde.org/digikam/ff40e084119c05fe90b88cc83ed369a1e07ea17c

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #83 from Marcel Wiesweg <[hidden email]> ---
Cases 1-4 in your comment #67 have been covered. Relevant places in kipi
plugins need to be identified. What remains to be done is some testing.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #84 from Gilles Caulier <[hidden email]> ---
Git commit 1140f2b3911fb8d03f2a4506a89d44b10e957c99 by Marcel Wiesweg.
Committed on 15/03/2012 at 21:33.
Pushed by mwiesweg into branch 'master'.

Move XMP sidecar file with main temp file which may have been created in
postprocessing of Camera GUI

M  +9    -1    utilities/cameragui/controller/cameracontroller.cpp

http://commits.kde.org/digikam/1140f2b3911fb8d03f2a4506a89d44b10e957c99

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #85 from Gilles Caulier <[hidden email]> ---
Ok, i will identify where kipi-plugins need to be patched, and make a proposal
to make a common technical solution into libkipiplugins...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #86 from Gilles Caulier <[hidden email]> ---
Marcel,

In kipi-plugins, i identified these block of code where we need to handle XMP
sidecar properly :

1/ BatchProcessImage :

a)
https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/entry/batchprocessimages/common/batchprocessimagesdialog.cpp#L410

This is the common code for all Batch Process Tools where target image is
managed, excepted Batch Rename Tool.where code is here :

b)
https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/entry/batchprocessimages/tools/renameimageswidget.cpp#L584

2/ DNGConverter

https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/entry/dngconverter/plugin/batchdialog.cpp#L435

3/ RawConverter

https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/entry/rawconverter/dialogs/batchdialog.cpp#L538

https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/entry/rawconverter/dialogs/singledialog.cpp#L464

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #87 from Gilles Caulier <[hidden email]> ---
Git commit 3aa21783862c87f20027e76c8103374b161e99ea by Gilles Caulier.
Committed on 19/03/2012 at 15:29.
Pushed by cgilles into branch 'master'.

manage XMP sidecar file with DNGConvert kipi-plugin

M  +68   -59   dngconverter/dngwriter/dngwriter.cpp
M  +6    -0    dngconverter/dngwriter/dngwriter.h
M  +1    -0    dngconverter/dngwriter/dngwriter_p.cpp
M  +9    -7    dngconverter/dngwriter/dngwriter_p.h
M  +1    -0    dngconverter/plugin/actionthread.cpp
M  +10   -0    dngconverter/plugin/batchdialog.cpp

http://commits.kde.org/kipi-plugins/3aa21783862c87f20027e76c8103374b161e99ea

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545

--- Comment #88 from Gilles Caulier <[hidden email]> ---
Git commit 737274918ae64067243d6778558ea6f041f2059a by Gilles Caulier.
Committed on 20/03/2012 at 11:43.
Pushed by cgilles into branch 'master'.

add XMP sidecar support to RawConverter kipi-plugin

M  +9    -0    common/libkipiplugins/tools/imageio/kpwriteimage.cpp
M  +13   -0    common/libkipiplugins/tools/kpmetadata.cpp
M  +4    -0    common/libkipiplugins/tools/kpmetadata.h
M  +10   -0    rawconverter/dialogs/batchdialog.cpp
M  +10   -0    rawconverter/dialogs/singledialog.cpp
M  +1    -2    rawconverter/manager/actionthread.cpp
M  +4    -8    rawconverter/manager/rawdecodingiface.cpp
M  +6    -2    rawconverter/manager/rawdecodingiface.h

http://commits.kde.org/kipi-plugins/737274918ae64067243d6778558ea6f041f2059a

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.0.0                       |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel