[Bug 220545] New: Cannot write XMP sidecar files

https://bugs.kde.org/show_bug.cgi?id=220545


Vincent Danjean <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #17 from Vincent Danjean <vdanjean ml free fr>  2010-05-05 11:50:46 ---
Allowing to use XMP sidecar file and to not touch the original files will also
improve backups: for now, each time I change any metadata (usually tags), the
file is backuped again and again. My backup program (backuppc) must store a
full new version of the image instead of using (hard)links to the previous
'version'. If XMP sidecar were used, the original image would not change,
avoiding similar but not exact copy in each backup. XMP files would be
duplicated but their size is a lot smaller than the original image.

A second thought: I see that you will use the same basename with the .xmp
extension. How will you deal with 'foo.jpg' and 'foo.avi' when both present ?
(ignore one ? which one in this case ?) Won't 'foo.jpg.xmp' and 'foo.avi.xmp'
be a better choice ?

A third thought: some other software (geeqie) allow to read/write xmp files in
another directory. This way, photos can be on a read-only medium (CD or ro NFS)
and xmp files (and so metadata) can still be edited and saved on the hard-disk.

I hope a support for using XMP files will soon be present. Many thanks for your
work on this part.

Regards,
  Vincent

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #18 from Jakob Malm <jakob malm gmail com>  2010-05-05 20:46:17 ---
(In reply to comment #17)
> Allowing to use XMP sidecar file and to not touch the original files will also
> improve backups: for now, each time I change any metadata (usually tags), the
> file is backuped again and again. My backup program (backuppc) must store a
> full new version of the image instead of using (hard)links to the previous
> 'version'. If XMP sidecar were used, the original image would not change,
> avoiding similar but not exact copy in each backup. XMP files would be
> duplicated but their size is a lot smaller than the original image.

Yes, this will indeed be a very nice effect. Thanks for your encouragement!

> A second thought: I see that you will use the same basename with the .xmp
> extension. How will you deal with 'foo.jpg' and 'foo.avi' when both present ?
> (ignore one ? which one in this case ?) Won't 'foo.jpg.xmp' and 'foo.avi.xmp'
> be a better choice ?

For me, personally, foo.xmp is necessary. Perhaps it should be configurable? Is
foo.xmp a convention?

> A third thought: some other software (geeqie) allow to read/write xmp files in
> another directory. This way, photos can be on a read-only medium (CD or ro NFS)
> and xmp files (and so metadata) can still be edited and saved on the hard-disk.

Hmm... Interesting idea. In principle, this should be quite easy to implement.
But I would eventually like digikam to be able to reread the XMP sidecar when
it changes, and for this, it would need to be situated in a directory which
belongs to an album, so that digikam will notice the change. This might
complicate things a little bit.

Jakob

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #19 from Jakob Malm <jakob malm gmail com>  2010-05-08 10:39:59 ---
Ok, so I tried changing the checks mentioned in comment 16, and exif data is
now also written to the XMP sidecar file. However, it seems that changing
geolocation information alone doesn't initiate a metadata save. Also, XMP
sidecar files for images without other tags set do not get written at all, even
when issuing a "Write metadata to photo". Is this really the intended
behaviour?

In practice, this means that if you want geoinformation to be written to the
file, you have to have some other tag as well, which is a bit odd in my mind.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #20 from Jakob Malm <jakob malm gmail com>  2010-05-13 22:13:52 ---
Trying to get my head around this behaviour...

Comment, DateTime, Rating, Template, Tags

From metadatahub.cpp, these appear to be the only metadata that cause any
metadata at all to actually be written to a file. Is this correct?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #21 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-05-13 22:50:09 ---
Well that depends from which place you choose to write the metadata.
Comment, DateTime, Rating, Template, Tags are currently supported by
MetadataHub, which basically handles all metadata writing for us. Digikam does
not write any other metadata (but "Template" includes a lot)
GPS metadata is not written at all by digikam currently but by the GPS
correlator Kipi plugin.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #22 from Jakob Malm <jakob malm gmail com>  2010-05-19 21:21:08 ---
Having tested my XMP sidecar fix a little bit now, I'm not sure it's the best
solution to have sidecars written automatically. I experience quite som lag
when editing the tags of several photos at once. Perhaps it would be better to
just have this functionality as two menu commands: read / write XMP sidecar...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #23 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-05-20 13:32:48 ---
Do you mean UI hangs, or just the process taking time?
In the first case it's a problem, because with MetadataManager all metadata
file writing should be done in a thread.
In the latter case I recommend benchmarking - is it a problem problem of CPU
intensive work, callgrind could tell you.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #24 from Gilles Caulier <caulier gilles gmail com>  2010-05-20 19:14:53 ---
Please, to handle XMP sidecar generation, add an option to digiKam Metadata
control panel, to provide an homogenous interface.

I'm agree to have an entry in Image/Metadata menu entry to generate XMP sidecar
with current selected album items. This entry is drived by MetadataEdit
kipi-plugin, not digiKam itself.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #25 from Jakob Malm <jakob malm gmail com>  2010-06-06 22:11:49 ---
Created an attachment (id=47754)
 --> (http://bugs.kde.org/attachment.cgi?id=47754)
patch to digikam 1.2.0

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #26 from Jakob Malm <jakob malm gmail com>  2010-06-06 22:13:12 ---
I thought I'd upload what I have so far. The code includes a Metadata setting
"Read metadata from and write metadata to XMP sidecars (experimental)" option.
It does not yet include menu items for reading / writing XMP sidecars.

One problem that needs to still be addressed is that the geolocator plugin only
seems to writes to the sidecar if it already exists. I haven't looked into this
yet.

(Oops, I thought I could attach the files together with this message...)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #27 from Jakob Malm <jakob malm gmail com>  2010-06-06 22:16:34 ---
Created an attachment (id=47755)
 --> (http://bugs.kde.org/attachment.cgi?id=47755)
patch to libkexiv2 svn revision 1111830

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2010-06-07 09:37:27 ---
*** Bug 184638 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #29 from Gilles Caulier <caulier gilles gmail com>  2010-06-07 10:03:16 ---
*** Bug 192024 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #30 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-06-24 16:00:41 ---
Patch looks fine for me so far. With KDE 4.5 in freeze, we cannot add it anyway
so far, and will need #ifdefs for the libkexiv2 versions prior to this patch.

Jakob, is this implementing all your intended behavior, I mean, is this patch
finished or do you have more plans?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0                       |1.4.0




--- Comment #31 from Gilles Caulier <caulier gilles gmail com>  2010-06-25 08:31:13 ---
Marcel,

I propose to make a copy of current libkexiv2 from trunk into digiKam GoSC
branch and to apply patch against. Also i propose to fix digiKam code from this
branch with this patch.

What do you think about ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #32 from Gilles Caulier <caulier gilles gmail com>  2010-06-25 08:33:53 ---
Marcel,

digiKam from GoSC branch need to be synchronized with trunk. I propose to only
apply small fixes in trunk and concentrate all works in GoSC branch now.

What do you think about ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #33 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-06-25 09:48:51 ---
I will in any case mostly work in the GSoc branch in the next weeks. Merge with
trunk is under way.
I agree to apply the patches in the branch.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #34 from Gilles Caulier <caulier gilles gmail com>  2010-06-25 09:56:51 ---
ok. so, i will branch libkexiv2 and apply patch

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #35 from Gilles Caulier <caulier gilles gmail com>  2010-06-25 11:05:21 ---
Jakob,

In your libkexiv2 patch, test files "usexmpsidecar.cpp" and
"readimagewritexmpsidecar.cpp" are missing.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel