[Bug 220545] New: Cannot write XMP sidecar files

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #36 from Gilles Caulier <caulier gilles gmail com>  2010-06-25 11:06:36 ---
SVN commit 1142633 by cgilles:

apply patch #1111830 from Jakob Malm
Tests files are missing in this commit
CCBUGS: 220545


 M  +16 -0     CMakeLists.txt  
 M  +42 -4     libkexiv2/kexiv2.cpp  
 M  +9 -0      libkexiv2/kexiv2.h  
 M  +2 -0      libkexiv2/kexiv2_p.h  
 M  +8 -0      test/CMakeLists.txt  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1142633

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #37 from Gilles Caulier <caulier gilles gmail com>  2010-06-25 13:31:09 ---
SVN commit 1142678 by cgilles:

apply patch #47754 from Jakob Malm


 M  +1 -0      digikam/albumiconview.cpp
 M  +16 -0     digikam/albumsettings.cpp
 M  +3 -0      digikam/albumsettings.h
 M  +3 -0      digikam/metadatahub.cpp
 M  +1 -0      digikam/metadatahub.h
 M  +1 -0      digikam/metadatamanager.cpp
 M  +4 -0      utilities/kipiiface/kipiinterface.cpp
 M  +14 -0     utilities/setup/setupmetadata.cpp

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #38 from Jakob Malm <jakob malm gmail com>  2010-06-25 23:28:33 ---
Wow! That's a lot of activity today. Great to see that the patch is getting in.
Did any of you try to use it?

Marcel: Yes, and no. Yes, this patch includes all the work that I will do in
the near future. And no, it does not include all my intended functionality. I
hope to be able to add functionality to write to / read from sidecar files from
a menu command, as a possibility for those who do not want automatic
reading/writing sidecars. But I will have to do this some other time, I think.
Preferably on an already patched version.

Gilles: I will upload the test files. But I must say, I'm not very used to
writing test files (though I really need to get into the habit of doing it), so
they may need some refinement... Would you have a look?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #39 from Jakob Malm <jakob malm gmail com>  2010-06-25 23:34:30 ---
Created an attachment (id=48334)
 --> (http://bugs.kde.org/attachment.cgi?id=48334)
Test to read and write XMP sidecar. The test is incomplete!

I didn't realize this test was far from complete...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #40 from Jakob Malm <jakob malm gmail com>  2010-06-25 23:35:32 ---
Created an attachment (id=48336)
 --> (http://bugs.kde.org/attachment.cgi?id=48336)
Test to read metadata from image and write to XMP sidecar.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #41 from Gilles Caulier <caulier gilles gmail com>  2010-06-27 00:52:49 ---
SVN commit 1143208 by cgilles:

add test pograms for XMP sidecar management
CCBUGS: 220545


 M  +6 -6      CMakeLists.txt  
 AM            readimagewritexmpsidecar.cpp   [License: GPL (v2+)]
 AM            usexmpsidecar.cpp   [License: GPL (v2+)]


WebSVN link: http://websvn.kde.org/?view=rev&revision=1143208

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #42 from Gilles Caulier <caulier gilles gmail com>  2010-06-29 23:18:27 ---
Jakob,

kipi-plugins need to be patched too, to support xmp sidecar as well. The most
important tool is metadataedit. Can you take a look ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #43 from Gilles Caulier <caulier gilles gmail com>  2010-06-30 06:22:44 ---
Jakob,

Your patches are now applied to digiKam 1.5.0 which is hosted to a dedicated
branch for Google Summer of Code 2010. It's not in trunk where you will found
digiKam 1.4.0.

digiKam 1.4.0 will be planed in one mounth, when KDE 4.5 will be out.
digiKam 1.5.0 will be planed later than september, after digiKam team reunion
at end of august in France
(http://techbase.kde.org/Projects/Digikam/CodingSprint2010).

digiKam google summer of code 2010 branches can be find there :

digikam : http://websvn.kde.org/branches/extragear/graphics/digikam/gsoc-2010/
libkipi : http://websvn.kde.org/branches/extragear/graphics/libkipi-gsoc-2010/
libkexiv2 :
http://websvn.kde.org/branches/extragear/graphics/digikam/libkexiv2/

this version of digiKam need 2 new libraries to compile (under development) :

libkface : http://websvn.kde.org/branches/extragear/graphics/digikam/libkface/
libkmap : http://websvn.kde.org/branches/extragear/graphics/digikam/libkmap/

libkface is for face detection. It require libface and openCV libraries
libkmap is a wrapper around world-map services as googlemaps and openstreetmap
using marble widget.

kipi-plugins is not yet branched there. I will do it.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #44 from Jakob Malm <jakob malm gmail com>  2010-06-30 09:34:01 ---
Gilles,

I may be able to take a look at kipi-plugins and metadataedit specifically
sometime this week, but I can't promise...

/Jakob

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #45 from Gilles Caulier <caulier gilles gmail com>  2010-06-30 12:24:09 ---
Jakob,

forget all my urls given on #43. I managed whole dirs to be at the same place.
You can now checkout all code directly using one svn call. Look there :

http://websvn.kde.org/branches/extragear/graphics/

... and take a look on README.GoSC2010

Thanks in advance for your help

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47754|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #47755|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48334|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48336|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #46 from Jakob Malm <jakob malm gmail com>  2010-07-04 23:34:44 ---
I have detected a bug in my implementation, but I'm having trouble finding the
solution, probably due to my limited knowledge of C++...

The value d->useXMPSidecar in instances of DMetadata and KExiv2 is completely
random when reading metadata. It does not seem to get set properly. This has
the effect that the boolean is almost always true, which of course is a
problem.

1.) KExiv2Priv::KExiv2Priv() should have an initialization useXMPSidecar =
false;
2.) I don't know where to set the value of useXMPSidecar correctly. It
currently gets set at the same places as writeRawFiles, but this means it is
only set correctly for writing - not reading.

If you have an idea of how to deal with this, please let me know!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #47 from Gilles Caulier <caulier gilles gmail com>  2010-07-04 23:43:07 ---
done with commit #1146000 :

http://websvn.kde.org/branches/extragear/graphics/libkexiv2/libkexiv2/kexiv2_p.cpp?revision=1146000&view=markup

It sound better ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #48 from Jakob Malm <jakob malm gmail com>  2010-07-04 23:46:57 ---
Gilles,

Yes, this solves 1). Do you have an idea for 2)?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #49 from Gilles Caulier <caulier gilles gmail com>  2010-07-04 23:49:03 ---
Why do you said that for reading this value is not set to false, as constructor
switch off it as well ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #50 from Jakob Malm <jakob malm gmail com>  2010-07-04 23:55:28 ---
Hmm, I'm not sure I understand your question... But let me try to answer.

Adding the initialization in the constructor of course solves the problem with
useXMPSidecar having just some random value. But it doesn't get set to the
value set in the settings window. So this way, instead of almost always reading
from sidecar, it _never_ reads from sidecar.

What I need to know is where the proper place to set useXMPSidecar is, for it
to be available in KExiv2IFace::KExiv2::load

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220545





--- Comment #51 from Gilles Caulier <caulier gilles gmail com>  2010-07-05 00:19:11 ---
As it is done for WriteRawFile stuff at

http://websvn.kde.org/branches/extragear/graphics/digikam/digikam/metadatahub.cpp?revision=1144518&view=markup

line 476, you need to patch void MetadataHub::load(const DMetadata& metadata)
method in the same way.

Marcel, there is another place to patch in digiKam to handle XMP sidecar with
metadata registration in DB ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel