[Bug 195050] New: Color management doesn't work in thumbnails and view mode

[Michal Thoma]

https://bugs.kde.org/show_bug.cgi?id=195050

           Summary: Color management doesn't work in thumbnails and view
                    mode
           Product: digikam
           Version: unspecified
          Platform: Debian stable
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10 (using KDE 4.2.2)
OS:                Linux
Installed from:    Debian stable Packages

I set up color management though in thumbnail and view mode there is no change,
images are still displayed as in color management unaware application. Only in
edit mode color management is employed. It's not only RAW images, but TIFFs and
JPEGs with valid profiles.

It also seems there is some confusing informations in Digikam documentation
where in the section "ICC Profiles setup"  is written: "The Use color managed
view is an alternative to using Xcalib or Argyll. Only your image will be color
managed, not your entire screen!"

Xcalib and Argyll's dyspwin are application which sets up video adapter gamma
tables and this Digikam definitely doesn't do. One would expect that it just
translate image color space to monitor color space so that will be displayed
with highest possible accuracy. This is no way altering XCalib or Dispwin.
Anyway setting up "Use color managed view" doesn't make any change to thumbnail
and view mode, only applies in edit.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195050


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Color Management
            Version|unspecified                 |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195050


Matti Rintala <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #1 from Matti Rintala <bitti cs tut fi>  2009-06-12 20:31:00 ---
The same bug/problem still exists in 1.0.0 beta 1 (tested on OpenSuse 11.1
64-bit, compiled form source). In normal viewing mode color management is not
used and color profile settings are ignored.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Milan Knizek]

https://bugs.kde.org/show_bug.cgi?id=195050


Milan Knizek <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-23 20:42:36 ---
SVN commit 1014769 by mwiesweg:

Enabling color management for previews.
The transform is applied once in the thread, so there is no speed problem
like for color managed view in the editor.
Add support to set a displaying widget for a PreviewLoadThread.

CCBUG: 195050

 M  +1 -1      loadsavetask.cpp  
 M  +11 -0     previewloadthread.cpp  
 M  +7 -0      previewloadthread.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1014769

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-23 20:42:53 ---
SVN commit 1014770 by mwiesweg:

Enable color management for thumbnails.
The transformation is done on the final scaled QImage when creating a thumbnail
if an embedded ICC profile was read before. Applying to a very small image is
is very fast.
We then store and display the thumbnails as sRGB.
There is so much quality loss already in a thumbnail that the little
imperfection of ignoring the monitor
profile should be ok.

CCBUG: 195050

 M  +25 -13    thumbnailcreator.cpp  
 M  +2 -1      thumbnailcreator.h  
 M  +12 -4     thumbnailloadthread.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1014770

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-23 20:43:17 ---
SVN commit 1014771 by mwiesweg:

Set displaying widgets to retrieve monitor profile, if set, to preview views.

BUG: 195050

 M  +2 -1      NEWS  
 M  +2 -0      digikam/imagepreviewview.cpp  
 M  +2 -1      utilities/batch/fingerprintsgenerator.cpp  
 M  +2 -0      utilities/lighttable/lighttablepreview.cpp  
 M  +2 -0      utilities/slideshow/slideshow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1014771

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #5 from Matti Rintala <bitti cs tut fi>  2009-08-24 10:56:05 ---
Thanks Marcel for working on this bug! It's much appreciatated :-)

However, I hope you could change your fix to apply the display profile to
thumbnails too, if colour management is enabled. You said "There is so much
quality loss already in a thumbnail that the little imperfection of ignoring
the monitor profile should be ok".

However, many new displays are wide gamut displays whose native colour space is
*far* from sRGB (most new 24" and larger lcds are wide gamut now, and their
prices are dropping fast). On those displays converting to sRGB and ignoring
the display profile ensures that the thumbnail looks terrible!

So, I would ask you to consider reopening this bug. Wide gamut displays are
becoming the norm with photo enthusiasts, so for thumbnails the current fix
does not solve the problems in the long run. If full color management of
thumbnails is considered too slow, I suggest either reverting the patch for
thumbnails completely, or introducing a new user preference.

Matti Rintala

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-08-24 11:20:03 ---
Marcel,

Matti reflexion is right. I vote for a user settings to turn on/off thumbnails
CM.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
                 CC|                            |[hidden email]
         Resolution|FIXED                       |




--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-24 18:49:41 ---
I will add a user preference. This adds a bit of overhead, maybe not too much,
but I'm not sure.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #8 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-24 19:40:36 ---
Matti talked about displaying, which is all right; I also talked about storage
- so do you agree that we _store_ the thumbnails files (in the thumbnail db) in
sRGB?
Converting to monitor profile is done when loading the precreated thumbnail.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #9 from Matti Rintala <bitti cs tut fi>  2009-08-24 19:53:43 ---
(In reply to comment #8)
> Matti talked about displaying, which is all right; I also talked about storage
> - so do you agree that we _store_ the thumbnails files (in the thumbnail db) in
> sRGB?
> Converting to monitor profile is done when loading the precreated thumbnail.

I think storing the thumbnails in sRGB is fine, if they are converted to
display profile when displayed. The only loss then are the occasional
out-of-gamut colors in part of the thumbnail, but as you said, thumbnails are
not meant to be critically viewed, anyway.

I understand that you don't want to store the thumbnails in their original
colour space, as that would imply storing their colour profiles as well.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michal Thoma]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #10 from Michal Thoma <michal thoma cz>  2009-08-24 19:58:59 ---
I think storing thumbnails in sRGB is smart! I suggest that conversion to sRGB
should happen even with Color Management turned off.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-26 22:18:27 ---
SVN commit 1016022 by mwiesweg:

Enable color managed display of thumbnails if color management in enabled.
Dedicated setup option comes if profiling shows it has a significant impact,
but I found some issues to sort out in the thumbnail loading before.
Allow to set displaying widget for thumbnail color management.
Extend ThumbnailTask for post processing like the other tasks
(could get some refactoring for code reuse in the future)

CCBUG: 195050

 M  +1 -0      digikam/digikamapp.cpp  
 M  +31 -12    libs/threadimageio/thumbnailloadthread.cpp  
 M  +6 -0      libs/threadimageio/thumbnailloadthread.h  
 M  +51 -15    libs/threadimageio/thumbnailtask.cpp  
 M  +5 -0      libs/threadimageio/thumbnailtask.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1016022

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #12 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-29 17:00:54 ---
SVN commit 1017009 by mwiesweg:

Put previews in color managed form into the cache so that preloading is fast.

CCBUG: 195050

 M  +6 -1      previewtask.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1017009

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #12 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-29 17:00:54 ---
SVN commit 1017009 by mwiesweg:

Put previews in color managed form into the cache so that preloading is fast.

CCBUG: 195050

 M  +6 -1      previewtask.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1017009

--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-29 17:01:09 ---
SVN commit 1017010 by mwiesweg:

Add a settings to enable color managed view for thumbnails and previews

CCBUG: 195050

 M  +3 -0      imageeditor/canvas/iccsettingscontainer.cpp  
 M  +1 -0      imageeditor/canvas/iccsettingscontainer.h  
 M  +15 -5     setup/setupicc.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1017010

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #14 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-29 17:03:20 ---
Color managed view is now fully implemented for previews and thumbnails. Please
test this functionality with the coming beta4. We can close this bug if no
problems are found.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #15 from Matti Rintala <bitti cs tut fi>  2009-08-31 14:54:50 ---
I compiled beta4 and tried color management. Mostly things seemed ok, so thanks
for this improvement!

However, there's one thing that still makes this unusable for me:

It seems Digikam doesn't recognise the (preview) profile of my Nikon NEF raw
files. Based on my screen testing it seems that it (wrongly) assumes that my
NEF previews are in sRGB profile even though they are in AdobeRGB.

I know that profile information is in the NEF file, since GQView succesfully
recognises and uses the profile.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #16 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-08-31 17:47:17 ---
Matti, can you send me a sample NEF file? (per private mail is ok)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel