[Bug 195050] New: Color management doesn't work in thumbnails and view mode

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #37 from Matti Rintala <bitti cs tut fi>  2009-09-05 22:25:58 ---
Marcel,

I'm not sure if this is connected with your recent fixes or not, but currently
when I start Digikam compiled from trunk, I notice the following error messages
(which do not prevent Digikam from starting, though).

Does this maybe happen because AdobeRGB profile is found several times from my
profile directories?

digikam(30649) Digikam::IccSettingsPriv::scanDirectories:
("/usr/share/color/icc", "/home/bitti/.local/share/color/icc/",
"/home/bitti/.color/icc/", "/home/bitti/config/color/icc")                      
digikam(30649)/digikam (core) Digikam::IccProfile::considerOriginalAdobeRGB:
The original Adobe RGB (1998) profile has been found at
"/usr/share/color/icc/Adobe ICC Profiles/RGB Profiles/AdobeRGB1998.icc"        
digikam(30649)/digikam (core) Digikam::IccProfile::considerOriginalAdobeRGB:
The original Adobe RGB (1998) profile has been found at
"/home/bitti/.color/icc/AdobeRGB1998.icc"                                      
lcms: Error #12288; Corrupted memory profile                                    
digikam(30649)/digikam (core) Digikam::IccProfile::considerOriginalAdobeRGB:
The original Adobe RGB (1998) profile has been found at
"/home/bitti/config/color/icc/AdobeRGB1998.icc"                                
lcms: Error #12288; Corrupted memory profile                                    
Starting to load Plugins.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #38 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-07 17:29:01 ---
Yes it's several times the same file. No need to worry. (We have no license to
redistribute it, but if it is found installed, it is detected by MD5 hash)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #39 from Matti Rintala <bitti cs tut fi>  2009-09-08 17:14:22 ---
Marcel,

I have been thinking about your comment about Nikon NEF files, colour profiles
and exif data. First, it's true that the embedded ICC profile in NEF files
edited with NX2 is the profile of the embedded full-res jpeg.

This is because in reality, Nikon NEF files are not just "raw sensor data
files". To my understanding, Nikon NEF file can contain a source image,
transformations applied to it, and then the resulting image (the embedded
full-res jpeg). With NEF files straight from camera, source image is the raw
sensor data, transformations consist of camera settings in the exif. When a raw
image is edited in NX2, additional edit steps are added to the metadata and the
embedded jpeg represents the final edited image.

It is even possible to edit a jpeg in Capture NX2 and store the result as a NEF
file! Then the source image is the original jpeg (stored inside the NEF file),
and file metadata contains all edit steps performed. The embedded jpeg
"preview" is the final edited jpeg.

And since you can choose the working colour space freely in NX2 (and change the
colour space as an edit step), the ICC profile in the NEF file is that of the
final image, i.e. the embedded jpeg.

For this reason the embedded jpeg is so important for Nikon NEF shooters
(especially us using Nikon software to edit it).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #40 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-12 15:54:26 ---
SVN commit 1022775 by mwiesweg:

Use PreviewThread API properly in slide show so that color management is
enabled.

CCBUG: 195050

 M  +6 -6      slideshow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022775

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #41 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-12 16:05:09 ---
SVN commit 1022778 by mwiesweg:

Read color space from RAW file Exif when extracting embedded JPEG for preview

CCBUG: 195050

 M  +14 -4     previewtask.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022778

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #42 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-12 16:05:47 ---
Anything left for this bug?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #43 from Matti Rintala <bitti cs tut fi>  2009-09-12 20:45:37 ---
Hi Marcel,

Thanks again for working on this bug, it's much appreciated!

For me, color profiles seem to work for jpegs now, but still each nef raw file
looks different depending on the colour profile used.

I tried it by using several versions of the same nef file, converted to
different profiles. I stored the files both as nef and jpeg. The files all
looked identical in GQView, so profile conversion should be ok. In Digikam
(built from trunk after your message) all jpegs look identical, but each raw
file looks different, like colour conversion was not performed (or at least the
embedded profile was not used).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #44 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-13 18:13:49 ---
SVN commit 1022958 by mwiesweg:

Restructure color space detection code (remove code duplication).
Take into account that sometimes Exif.Image.ColorSpace field is missing
altogether
when Nikon Makernote color tags are set.

CCBUG: 195050


 M  +55 -70    kexiv2image.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022958

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #45 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-13 18:20:39 ---
SVN commit 1022966 by mwiesweg:

In preview and thumbnail tasks, when loading an embedded raw preview, read the
Icc profile
from metadata if available.
Optimize DMetadata creation in ThumbnailCreator.

CCBUG: 195050

 M  +8 -11     previewtask.cpp  
 M  +8 -6      thumbnailcreator.cpp  
 M  +3 -2      thumbnailcreator.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022966

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #46 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-13 18:27:44 ---
Fortunately the ICC profile embedded in the NEF for the embedded preview, which
I had not thought of before, is available from libexiv2.

For me (with latest libkexiv2) the three NEF files from the D300 look all three
ok now, but the D40 files each look different. For each d40/d300 pair, the same
profiles are loaded (Adobe RGB (1998) for -adobergb.nef; sRGB IEC61966-2.1 for
-srgb.nef; embedded Nikon Adobe RGB 4.0.0.3000 for -srgb-to-adobergb.nef)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #47 from Matti Rintala <bitti cs tut fi>  2009-09-14 09:27:00 ---
Marcel,

After your latest commits, nef raw files with profiles work, thanks!

I'll have to check again the files stored in-camera as AdobeRGB. Especially
with D40 it is possible that the camera does its processing a little bit
differently for files stored in AdobeRGB. In addition to AdobeRGB, D40 actually
has two sRGB settings with a little colour reproduction. One sRGB setting
should produce more pleasing skin tones, the other enhances colours in nature,
if I remember properly.

However, in D300 Nikon started using Picture Controls which define colour and
tonal settings, and sRGB/AdobeRGB setting was separated from them. That's why
sRGB and AdobeRGB versions should match closely with D300.

With the files converted to AdobeRGB with Capture NX2, it's possible that there
are some minor differences compared to the original sRGB nef, since Capture NX2
might use a little bit different (better) raw-decoding algorithm than the
camera.


I'll have time to test this better tomorrow, but so far things look good! :-)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #48 from Matti Rintala <bitti cs tut fi>  2009-09-14 09:56:35 ---
Marcel,

I had a little time to do one small test now, and I'm a little bit unsure if
AdobeRGB is working properly for me (for both jpeg and raw nef).

For me, the green is paler in AdobeRGB version, which suggests that Digikam
would still be interpreting it as sRGB.

I took the photo shot with D300 and stored in-camera as AdobeRGB. I then used
ImageMagick's convert-command to convert it explicitly from AdobeRGB to sRGB.
in Digikam, the resulting image is practically identical with the image shot
in-camera as sRGB, but it does look different from the original AdobeRGB
version.

I still get the following messages:

digikam(5934)/digikam (core) Digikam::DImg::load:
"/home/bitti/local/edited-photos/nobackup/digikamtest/d300-adobergb.jpg"  :
JPEG file identified
digikam(5934)/digikam (core): No input profile: invalid Behavior flags 1048576

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050





--- Comment #49 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-14 20:11:42 ---
I have indeed fixed two or three related bugs. I can't say exactly how this
affected you, but it may. For me the d300-adobergb images look identical now.
Does it for you with latest trunk?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195050


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #50 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-25 21:17:35 ---
All remaining issues have been cleared.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel