[Bug 188959] New: On first use, digiKam should not scan for images without user confirmation

https://bugs.kde.org/show_bug.cgi?id=188959

           Summary: On first use, digiKam should not scan for images
                    without user confirmation
           Product: digikam
           Version: 0.10.0-rc1
          Platform: Fedora RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0-rc1 (using KDE 4.2.0)
OS:                Linux
Installed from:    Fedora RPMs

When I start digiKam for the first time, It asks for images and database
directories, both set to 'home' by default.
I have symbolic links to my partitions (containing lots of images) in my home
diretory.
digiKam gives no indication that it's going to scan my disks and after I click
OK, it takes forever to finish the scan - with just the splash screen being
displayed, and no (obvious) way of aborting the scan. I had to kill the
application forcefully.

What's worse is that this happens all over again the next time I start digiKam.
Since the directory info is already logged, there's no way to stop it, except
to delete the files in ~/.kde/share/config/digiKam. For an average user who
doesn't know this, digiKam is pretty hard to use.

This is what I suggest
1. After the initial directory configuration, ask the user if he/she wants to
scan the disks with warning about the time taken (this is pretty standard
everywhere, isn't it?)
2. OR - avoid the full directory scan. Ask the user to select directories to
scan later (much like adding directories to Amarok collection).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |setup




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=188959


Rex Dieter <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Rex Dieter <rdieter math unl edu>  2009-04-07 22:49:39 ---
As for default dir, should probably default to
xdg-user-dir PICTURES
(and not home), at least.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-04-11 17:26:39 ---
Rex, we are trying to retrieve standard dirs with
KGlobalSettings::picturesPath() or
QDesktopServices::storageLocation(QDesktopServices::PicturesLocation).
Unfortunately this does not work on some distros (returns HOME)

Syam: Yes our first run dialog has quite a few weaknesses. Alas, writing
dialogs is no great fun for me.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #3 from Rex Dieter <rdieter math unl edu>  2009-04-12 00:33:33 ---
Thanks for the clarification, I'll see if I can find out what's going wrong (at
least on fedora anyway).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #4 from Syam <get sonic gmail com>  2009-04-12 04:08:25 ---
Just a piece of information, I dont have a 'Pictures' folder in my home dir. I
usually delete those directories immediately after I install Fedora.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2009-05-01 15:06:41 ---
Marcel,

On new First Run Assistant, on last page, i can ask to user if he want to scan
collection now, or later using "Tool/Scan for New Items". There is something
special to do for DB viewpoint ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #6 from Andi Clemens <andi clemens gmx net>  2009-05-01 15:15:14 ---
(In reply to comment #0)
> 2. OR - avoid the full directory scan. Ask the user to select directories to
> scan later (much like adding directories to Amarok collection).

At least when digiKam is started, you can disable the scanning of the
directories in the setup dialog. But this is not what you wanted of course.

Gilles,
maybe we should disable this option per default and ask in the assistant:

1. Scan now (first initial scan)
2. Scan on startup

So you can choose between those two options.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-05-01 15:52:42 ---
I agree with Andi.
There is no sense in starting for the first time without a collection scan -
the app is empty and useless!
We should ask to scan now (with a warning that it may take a while), or offer
to quit and scan when starting again.
(I also do not like the option to disable scanning on startup as well, I dont
see any sense in that)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2009-05-01 17:02:34 ---
?? Huh? I wrote my answer two hours ago, it has been added now? Well... I guess
B.K.O. is on holiday, too :-)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-05-01 17:50:15 ---
Marcel, Andi,

At first run, there is many possible cases:

1/ Collection is new. No DB version 3 or 4. DB need to be created at least.

2/ Collection come from digiKam < 0.10 : DB need to be converted at least.

3/ Collection is already referenced with digiKam 0.10 : at least, DB is take as
well.

For case 1/, if we don't scan at first run, No item will be visible.
For case 2/, if we don't scan at first run, Only items referenced to DB version
3 will be visible.
For case 3/, if we don't scan at first run, Only items referenced to DB version
4 will be visible.

Do you see any problems with these workflow ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #10 from Syam <get sonic gmail com>  2009-05-01 18:23:05 ---
(In reply to comment #7)
> There is no sense in starting for the first time without a collection scan -
> the app is empty and useless!
It's still useless if it takes ages to scan a directory with large number of
images, and no way to stop it. Not to mention that subsequent application
startup will have the same behaviour, unless you delete the configuration
files.

> We should ask to scan now (with a warning that it may take a while), or offer
> to quit and scan when starting again.
That'd be good.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-05-01 20:03:56 ---
Gilles:

Oh yes, look at AlbumManager::changeDatabase. It's similar. Even seven
different cases to handled there :-(

For your cases:
1) Create an empty database with no album root is possible, but that's really
pretty useless. But yes you can do that if someone really wants. Hm, maybe it's
not possible because a dialog will pop up with the setupcollection page.
2) Conversion always includes a collection scan. No way around that.
Convert&Scan or dont convert. That's because there are conversion steps first,
then the scan, followed by more conversion steps, followed by dropping old
tables.
3) If there is a digikam4.db already, we really need no full collection scan.
In this case, it's not necessary to add album roots!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #12 from Arnd Baecker <arnd baecker web de>  2009-05-01 20:24:26 ---
While not directly on-topic of the original bug report:
it might generally be useful to add a  
--no-scan option and a --scan-only dir1 dir2 ....option.

Best, Arnd

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2009-05-01 20:58:47 ---
To Marcel #11

Damned, it's complex.

I can provide a bool flag if user won't to scan at first startup, and pass it
to AlbumManager::setDatabase() call from main.cpp. But, in AlbumManager, some
code need to be added to manage all possible cases to drive this flag.

I think it's dangerous to not convert DB v3 and work.

Also, What user can do if no items are displayed from iconview / folderview in
case of no scan of unregistered collection. This is a non sence for me.

The message must be clear in Assistant. No scan can give an unsuitable
interface.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2009-05-02 12:06:14 ---
Resume of IRC talk between me and Marcel yesterday evening to solve this file:

SOLUTION:
- After last page of assistant, scan is processed.
- We show progress dialog and we have a cancel button.
- User can stop scan when he want.
- DB considérations are preserved : DB conversion/creation are done just before
to show progress dialog.
- If user stop scanning, it will begin again on next startup.

PROBLEM:
- if cancel button is pressed, dialog is closed, but scan continue in
background.
- all debug message from scan process are still in the console.

TODO:
- ScanController::cancel() method is not implemented.
- Also missing to stop CollectionScanner in this case.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #15 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-05-02 15:21:02 ---
SVN commit 962420 by mwiesweg:

Allow to cancel CollectionScanner and SchemaUpdate operations.
They will now query an observer to continue or cancel.

CCBUG: 188959

 M  +53 -3     collectionscanner.cpp  
 M  +11 -101   collectionscanner.h  
 M  +11 -4     collectionscannerobserver.h  
 M  +71 -13    schemaupdater.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=962420

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #16 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-05-02 15:21:06 ---
SVN commit 962421 by mwiesweg:

Add methods to abort the schema update at first startup (includes the initial
collection
scan for images imported from older db versions)
or cancel the complete scan at normal startup (including the scan at first
startup
when starting with an empty database)

CCBUG: 188959

 M  +41 -0     scancontroller.cpp  
 M  +14 -2     scancontroller.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=962421

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2009-05-02 16:25:52 ---
SVN commit 962513 by cgilles:

more informations about first scan process, especially if user cancel this
operation at the first run
CCBUGS: 188959

 M  +4 -3      startscanpage.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=962513

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #18 from Gilles Caulier <caulier gilles gmail com>  2009-05-02 16:47:26 ---
Marcel,

Are you tried with a huge collection, without a DB 4 file ? If you press
cancel,  scan continue again in background.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel