[Bug 188959] New: On first use, digiKam should not scan for images without user confirmation

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2009-05-02 16:54:36 ---
Marcel,

If you kill digiKam during First Scan (because progress dialog Cancel button do
not stop this operation), at next session, digiKam restart again collection
scanning. But in this case, Progress dialog is not used : Splashscreen appears
instead... As there is no progress bar in splash, this can be very annoying,
especially with huge collection.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #20 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-05-03 17:11:21 ---
> Are you tried with a huge collection, without a DB 4 file ? If you press
> cancel,  scan continue again in background.

Yeah that's because the cancel button of DProgressDialog does nothing. There is
a protected slotCancel() that checks for allowCancel, which is true per
default, but then it just closes. It should emit a signal there, or how's that
supposed to work?
Btw, was this with a DB 3 file, or just starting from an empty dir?

For comment #19: You can never keep a user from killing the app ;-) Perhaps the
progress dialog should appear (and splash be hidden) after a longer amount of
time, like 15-30s?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #21 from Syam <get sonic gmail com>  2009-05-03 17:56:07 ---
(In reply to comment #20)
> Perhaps theprogress dialog should appear (and splash be hidden)
> after a longer amount of
> time, like 15-30s?

Then won't the user be completely clueless for the 15-30s?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2009-05-03 18:07:56 ---
To Marcel, #20,

Ok, a signal must be sent with Cancel button. I take a look.

From my test, DB v4 file have been removed before to restart digiKam. My
collection is huge with full of RAW files (20Gb)

>Perhaps the progress dialog should appear (and splash be hidden) after a longer >amount of time, like 15-30s?

I think the progress dalog must be displayed at startup until initial scan is
complete. I user cancel scan, at next session it must see progress dialog
again.
Why ? because this process can take a while. Splash is not adapted for that.

If scan is complete, well at next session splash can be displayed, because we
only check for new items. It's really faster.

This is want mean that a flag must be registered somewhere (rc file?) to check
if initial scan is complete or not...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #23 from Gilles Caulier <caulier gilles gmail com>  2009-05-03 20:03:11 ---
Marcel,

with my last commit #962987, now scancontroller handle cancel button, but it's
not enough : scan continue with splashscreen open...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #24 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-05-03 21:27:27 ---
SVN commit 963038 by mwiesweg:

Also try to abort initial scan on cancel (both methods are a no-op if not
running)
Show progress dialog in spite of active splash when initial scan is not marked.

CCBUG: 188959

 M  +6 -2      scancontroller.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=963038

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #25 from Gilles Caulier <caulier gilles gmail com>  2009-05-03 22:20:58 ---
Marcel,

It work better now. but it still a litlle problem.

After running assistant, initial scan start. I stay a little an press cancel.
dialog is closed and splash appears, but not alone... the progress dialog is
back again... and initial scan is back.

If i press Cancel again, initial scan is stoped and digiKam appears.

I stop digiKam and restart it. initial scan is back as espected. If i wait
until scan is complete, closing and restarting digiKam, all start speedly...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #26 from Gilles Caulier <caulier gilles gmail com>  2009-05-31 11:11:42 ---
MArcel,

Are you seen my previous message there ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #27 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-05-31 17:25:17 ---
Whenever you start digikam it will scan. If you cancel, it will scan the next
time.(*) If you cancel again, it will scan the third time. I think that's ok
because using digikam is useless without an initial scan.
The alternative is to quit if cancel is pressed in the first run assistant.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2009-05-31 18:41:38 ---
Marcel,

No, you misunderstand me. Look below:

1/ "After running assistant, initial scan start. I stay a little bit and a
press cancel. Dialog is closed and splash appears, but not alone... the
progress dialog is back again... and initial scan is back."

This is appears on the first start of digiKam, the _same_ session in fact. I do
not stop and restart yet digiKam. I think it's due of my DB path as already a
DB v4 file with more than one root album set insinde.

2/ "If i press Cancel again, initial scan is stoped and digiKam appears."

Well, here now, it look  the good behavor. the problem is why user need to
press 2 time on Cancel...

3/ "Now, I stop digiKam and restart it. initial scan is back as espected. If i
wait until scan is complete, closing and restarting digiKam, all start
speedly..."

For this one, of course all is fine...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #29 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-05-31 23:21:27 ---
Ah.
I think the first scan is done from albummanager.cpp:674, the second one is
done from digikamapp.cpp:167.
The second one is the regular call. I am thinking about removing the first
call.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=188959





--- Comment #30 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-06-04 17:29:42 ---
SVN commit 977533 by mwiesweg:

Remove call to collection scan. This branch is taken after running the first
run wizard.
A second collection scan will be triggered afterwards from DigikamApp.
User need not press Cancel twice.

CCBUG: 188959

 M  +2 -1      albummanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=977533

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #31 from Gilles Caulier <caulier gilles gmail com>  2009-06-04 17:49:43 ---
Thanks Marcel, Fixed now. I close this file...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=188959


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0-rc1                  |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel