[Bug 170364] New: Expand selection rectangle by dragging sides in imege editor

http://bugs.kde.org/show_bug.cgi?id=170364

           Summary: Expand selection rectangle by dragging sides in imege
                    editor
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 3.5.9)
OS:                Linux
Installed from:    Ubuntu Packages

When editing an image, it would also be nice to be able to expand the selection
box from the sides by dragging them.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=170364


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|general                     |Image Editor
         Resolution|                            |FIXED
            Version|unspecified                 |0.9.4




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2008-12-06 14:29:05 ---
Already implemented. Work perfectly with 0.10.0

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=170364


Mikolaj Machowski mikmach wp pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |




--- Comment #2 from Mikolaj Machowski <mikmach wp pl>  2008-12-06 21:44:25 ---
I am afraid I cannot agree.. 0.10-beta7svn

Still can change selected area by dragging corners.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #3 from Andi Clemens <andi clemens gmx net>  2008-12-06 22:03:33 ---
> I am afraid I cannot agree.. 0.10-beta7svn
> Still can change selected area by dragging corners.

Typo?

I can only say it works perfectly here...


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #4 from Mikolaj Machowski <mikmach wp pl>  2008-12-07 14:11:43 ---
For me works only in corners :(


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=170364


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Expand selection rectangle  |Expand selection rectangle
                   |by dragging sides in imege  |by dragging sides in image
                   |editor                      |editor




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2008-12-10 19:01:38 ---
ok only from the corner, not from H/V sides.

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=170364


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Johannes Wienke <languitar semipol de>  2009-10-16 13:58:50 ---
*** Bug 203843 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #7 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-17 21:49:51 ---
Created an attachment (id=37639)
 --> (http://bugs.kde.org/attachment.cgi?id=37639)
the patch allows to expand selection by dragging sides

I suggest a patch for this. The patch allows to expand selection by dragging
horizontal and vertical sides with a 10-pixel snap zone (same as corners).
Tested against trunk and it works.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.9.4                       |1.0.0
            Summary|Expand selection rectangle  |Expand selection rectangle
                   |by dragging sides in image  |by dragging sides in image
                   |editor                      |editor [patch]




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-10-17 22:33:25 ---
Thanks Ignat for the patch. It's very appreciate.

I will test your patch soon.

Just a question: Zoom in to canvas at different level, make a selection. Zoom
in or out without to deselect. Selection still here ? if yes, change it again.
Selection is not broken on screen ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #9 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-17 22:42:18 ---
Well, I zoomed into the canvas, selected a region, zoomed out, the selection
was fine. Resized it and zoomed in/out a few times - everything was fine.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2009-10-18 12:06:25 ---
Ignat,

Excelent patch. Thanks again...

To be homogeneous, can you take a look to Ratio Crop Tool which has also a
selection widget which do not have yet this feature.

http://websvn.kde.org/trunk/extragear/graphics/digikam/imageplugins/coreplugin/ratiocrop/imageselectionwidget.cpp?revision=1030990&view=markup

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2009-10-18 12:17:00 ---
SVN commit 1037030 by cgilles:

apply patch # 37639 from Ignat Semenov
CCBUGS: 170364


 M  +106 -33   canvas.cpp  
 M  +17 -17    canvas.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1037030

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #12 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-18 16:30:59 ---
After looking at the Ratio Crop Tool, I've found quite some inconsistencies
between the two widgets. The main question is: Selection Widget has an active
area of 10 pixels, 5px inside, 5px outside, while Ratio Crop Widget has an
active area of 10 pixels inside the rectangle. Which behavior is preferred for
both widgets?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2009-10-18 17:28:03 ---
Editor canvas sound better for me... But it just my viewpoint...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles,
Could you tell me what exactly does this selection widget do? I mean, what  
effects/operations does it affect? Because to me it seems that all the  
filters are applied to the whole image, not the selected region - then  
what's the aim of having a selection widget? The logic seems a bit broken  
here, it seems to me.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

On Tue, 20 Oct 2009 00:15:12 +0400, Gilles Caulier  
<[hidden email]> wrote:
> What the widget do ???
>
> Well it's simple : ratio crop tool ! do you know ? You select an area
> of full image to crop following ratio rules. You can resize from 4
> corners of retangle, but not from the sides...


Sorry, I wasn't clear which widget I meant)
I was asking about this one: when you open the image in the editor, you  
can select an area with the mouse. (not ratio crop tool, just regular  
selection widget, the one which I patched). What does it do? Only simple  
crop?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

It is used for red eye, simple crop, inpainting and restoration (I guess, have
not actually tested it now).

Andi

On Monday 19 October 2009 23:27:26 Ignat Semenov wrote:

> On Tue, 20 Oct 2009 00:15:12 +0400, Gilles Caulier
>
> <[hidden email]> wrote:
> > What the widget do ???
> >
> > Well it's simple : ratio crop tool ! do you know ? You select an area
> > of full image to crop following ratio rules. You can resize from 4
> > corners of retangle, but not from the sides...
>
> Sorry, I wasn't clear which widget I meant)
> I was asking about this one: when you open the image in the editor, you
> can select an area with the mouse. (not ratio crop tool, just regular
> selection widget, the one which I patched). What does it do? Only simple
> crop?
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

OK I see. Restoration doesn't seem to use the selection (I've
checked). Could you test the patched selection widget? For some reason
now it also expands to the right if you expand it from the bottom
side..... same if you drag the left side, the bottom expands as
well..... however top and right sides work fine. It seemed to work
yesterday.... I've done a clean checkout and it still misbehaves,
although the code looks fine (to me at least)

On Tue, Oct 20, 2009 at 1:52 AM, Andi Clemens <[hidden email]> wrote:
> It is used for red eye, simple crop, inpainting and restoration (I guess, have
> not actually tested it now).
>
> Andi
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Ok.... please post further answers in the bugreport again, it is more visible
there.

Andi

On Tuesday 20 October 2009 00:09:07 Ignat Semenov wrote:

> OK I see. Restoration doesn't seem to use the selection (I've
> checked). Could you test the patched selection widget? For some reason
> now it also expands to the right if you expand it from the bottom
> side..... same if you drag the left side, the bottom expands as
> well..... however top and right sides work fine. It seemed to work
> yesterday.... I've done a clean checkout and it still misbehaves,
> although the code looks fine (to me at least)
>
> On Tue, Oct 20, 2009 at 1:52 AM, Andi Clemens <[hidden email]> wrote:
> > It is used for red eye, simple crop, inpainting and restoration (I guess,
> > have not actually tested it now).
> >
> > Andi
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel