[Bug 170364] New: Expand selection rectangle by dragging sides in imege editor

Where is the patch? I can not find a new one here?
The bugreport only hosts the already applied one?

Andi

On Tuesday 20 October 2009 00:09:07 Ignat Semenov wrote:

> OK I see. Restoration doesn't seem to use the selection (I've
> checked). Could you test the patched selection widget? For some reason
> now it also expands to the right if you expand it from the bottom
> side..... same if you drag the left side, the bottom expands as
> well..... however top and right sides work fine. It seemed to work
> yesterday.... I've done a clean checkout and it still misbehaves,
> although the code looks fine (to me at least)
>
> On Tue, Oct 20, 2009 at 1:52 AM, Andi Clemens <[hidden email]> wrote:
> > It is used for red eye, simple crop, inpainting and restoration (I guess,
> > have not actually tested it now).
> >
> > Andi
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Yes, it's already applied. It's trunk now.

On Tue, Oct 20, 2009 at 2:15 AM, Andi Clemens <[hidden email]> wrote:
> Where is the patch? I can not find a new one here?
> The bugreport only hosts the already applied one?
>
> Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Yes I can see the dysfunction... I'll compare the patch and the final
commit...

Andi

On Tuesday 20 October 2009 00:17:52 Ignat Semenov wrote:

> Yes, it's already applied. It's trunk now.
>
> On Tue, Oct 20, 2009 at 2:15 AM, Andi Clemens <[hidden email]> wrote:
> > Where is the patch? I can not find a new one here?
> > The bugreport only hosts the already applied one?
> >
> > Andi
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Fixed in SVN!

Andi

On Tuesday 20 October 2009 00:20:55 Andi Clemens wrote:
> Yes I can see the dysfunction... I'll compare the patch and the final
> commit...
>
> Andi
>
> On Tuesday 20 October 2009 00:17:52 Ignat Semenov wrote:
> > Yes, it's already applied. It's trunk now.
> >
> > On Tue, Oct 20, 2009 at 2:15 AM, Andi Clemens <[hidden email]>
wrote:

> > > Where is the patch? I can not find a new one here?
> > > The bugreport only hosts the already applied one?
> > >
> > > Andi
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #14 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-20 12:28:16 ---
Created an attachment (id=37682)
 --> (http://bugs.kde.org/attachment.cgi?id=37682)
patch #2

Here is one more patch (against SVN trunk).
-changed selection area from 10 to 8 pixels for consistency with Ratio Crop
Tool
-nicer corner drag rectangles
-it is now possible to drag the selection around with mouse; dragging is
restricted by the picture
-it solves the problem of wrong sides expanding (my way)) the code is basically
simpler
Please test
Should the bug be closed?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #15 from Andi Clemens <andi clemens gmx net>  2009-10-20 12:41:10 ---
Why not use a const var for the selection area (8px)?
This way it can be easily changed and even set with some value from a settings
option, if we should ever provide one.

I'll test the patch...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #16 from Andi Clemens <andi clemens gmx net>  2009-10-20 12:55:41 ---
SVN commit 1037972 by aclemens:

Apply patch from Ignat Semenov

CCBUG:170364

 M  +83 -47    canvas.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1037972

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2009-10-20 13:00:59 ---
Ignat,

For consistency, Ratio crop tool selection widget, which is not canvas.cpp as i
explain in #10 must be patched in the same way to support resizement of
selection using top/bottom/right/left side (currently only by corners is
possible)...

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #18 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-21 15:44:44 ---
I've started to work on this, but there are a few more differences between the
two widgets.
1)In Ratio Crop, you click some area and it moves the selection to that point.
No such thing in Simple Crop. Should I add it or remove it? (I haven't seen
this in any other editor, it's kind of unusual - correct me if I'm wrong)
2)Ratio Crop grays out the image automatically and during resizing/dragging.
Simple crop doesn't. What's preferred for both?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #19 from Andi Clemens <andi clemens gmx net>  2009-10-21 15:52:39 ---
My suggestions:

1) Click should NOT move the selection (like in editor)
2) Always grayed out (I spent quite some time optimizing this in RatioCrop, so
I wouldn't want it to be removed again :-))
Also it is more visible, it always confuses me if you change the selection and
the grayed out background disappears, but re-appears when you stop modifying
the selection. This is too turbulent in my eyes.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #20 from Gilles Caulier <caulier gilles gmail com>  2009-10-21 16:15:53 ---
>1) Click should NOT move the selection (like in editor)

Agree...

>2) Always grayed out

Agree too...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #21 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-21 16:21:59 ---
Now, the code. These two widgets do (almost) the same. But the code for
resizing and moving in the Ratio Crop Tool is (form my POV, maybe I simply
don't get something)) quite a mess. Shouldn't the resizing/moving code be
similar to that of Simple selectio widget (except for the ratio part)? And if
yes, I'd like to bring the code of the two widgets in sync. (Apologies if I'm
wrong, I'm quite new to Digikam code you see)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2009-10-21 16:27:56 ---
It's difficult to factorize it.

Editor Canvas is based on Q3ScrollView : It's not a pure QT4 class.

Ratio Crop selection widget is not a Qt4::QScrollArea but Qt4::QWidget...

We have planed with Andi to factorize image editor tool preview widget using
QScroolArea, but it will a lots of job to do...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #23 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-21 16:45:49 ---
Ah, so that's why it always maximizes/minimizes the image and never scrolls?)
Well, anyway, I'll try to simplify the Ratio Crop selection widget resizing if
you don't mind.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #24 from Gilles Caulier <caulier gilles gmail com>  2009-10-21 17:00:18 ---
Editor Canvas can scroll
Ratio Crop tool Preview Cannot.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #25 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-21 18:43:42 ---
Got it, Ratio Crop doesn't scroll by design. Fine.
I've got a couple more questions (patches will follow, I promise :-))
1)You'd like to port Canvas class from Q3ScrollView to Qt4 QScrollArea, right?
2)What about Shift+click (resize to a given point) and Ctrl+drag (resize
symmerically) - do you want these in Simple Crop?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #26 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-22 20:06:56 ---
Ping?
Shift+click to resize seems a bit obscure feature to me, maybe remove it at
all?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #27 from Gilles Caulier <caulier gilles gmail com>  2009-10-23 10:28:37 ---
No, it's not obscur. it's used in pro imagery software and implemented by a
contributor few year ago. Please do not remove it.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2010-10-22 13:41:18 ---
Ignat,

Are you always there ?

Do you have planed a patch for Ratio Crop tool selection to be homogeneous with
editor canvas selection ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=170364





--- Comment #29 from Gilles Caulier <caulier gilles gmail com>  2011-11-24 11:11:46 ---
to Ignat, comment #25,

1/ yes, porting canvas class to qt4 is the plan. We have already a class named
GraphicsDImgView that i already use with editor Raw Import tool preview.
Creating a new Canvas class for editor based on this class can be fine.

^^^
Marcel ?

2/ Shift+click and Ctrl+drag are very important to be homogenous with gimp and
photoshop which provide this selection behavior

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel