[Bug 166472] New: Thumbnail bar gone in image editor when switching back from fullscreen

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         
           Summary: Thumbnail bar gone in image editor when switching back
                    from fullscreen
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: gandalf.lechner esi ac at


Version:           0.10.0-beta2 (rev.: 831948) (using 4.00.83 (KDE 4.0.83 (KDE 4.1 Beta2), Kubuntu packages)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-17-generic

In the image editor, switching to fullscreen turns of the thumbnail bar. But when switching off the fullscreen mode, the thumbnail bar does not reappear.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|general                     |Image Editor
      everconfirmed|0                           |1
            Version|unspecified                 |0.10.0-svn



------- Additional Comments From andi.clemens gmx net  2008-07-14 08:53 -------
I can confirm this, you have to toggle the "View->Show Thumbnails" option twice to get it back.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-14 09:06 -------
Another note: The Shortcut CTRL+T doesn't work, too.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-14 09:26 -------
This also can be confirmed for showFoto. In showFoto the code in http://lxr.kde.org/source/extragear/graphics/digikam/showfoto/showfoto.cpp#627 should do the trick, but it doesn't.
Entering this code in digiKam also doesn't bring back the thumbbar.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-14 10:12 -------
I have added this to imageeditor:

Index: utilities/imageeditor/editor/editorwindow.cpp
===================================================================
--- utilities/imageeditor/editor/editorwindow.cpp       (revision 832135)
+++ utilities/imageeditor/editor/editorwindow.cpp       (working copy)
 @ -1010,6 +1010,7  @

         menuBar()->show();
         statusBar()->show();
+        slotToggleShowBar();
         showToolBars();

         if (d->removeFullScreenButton)
 @ -1036,6 +1037,7  @
         // hide the menubar and the statusbar
         menuBar()->hide();
         statusBar()->hide();
+        thumbBar()->hide();

         if (d->fullScreenHideToolBar)
         {

But somehow it doesn't work. Right now I'm sitting here with gdb to find out what is happening. The problem is now that the thumbbar is always restored, even if the "View Thumbnails" action is turned off.
When running gdb and watching the execution of digiKam line by line, I can see that thumbBar()->hide() is called like it should be, but somehow the thumbbar is visible in the end.
I have no idea why... but this little patch fixes at least the general problem.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-14 12:23 -------
I found the problem. In http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp#1003 the virtual method toggleGUI2FullScreen() is called, which has been overwritten in ImageEditor class (without implementation), but somehow it is called anyway.
http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp#819
So disabling the method call works... showFoto also re-implements the code in  toggleGUI2FullScreen(), but never calls it. And it seems to re-implement the same code defined before in the ImageWindow class. So I think this is wrong.
Question is should this method be removed from both showFoto and EditorWindow and if not, why is showFoto implementing the same code?
And is the code in ImageWindow class really right? Why enable thumbBar if it is disabled in the ToggleAction?

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-14 12:31 -------
Created an attachment (id=26105)
 --> (http://bugs.kde.org/attachment.cgi?id=26105&action=view)
patch #1
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-14 12:37 -------
A note: CTRL+T seems to be a taken by the action "Insert text...", so this is why it doesn't work.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From caulier.gilles gmail com  2008-07-14 13:56 -------
Andi,

I have separate the way to re-implement the virtual method toggleGUI2FullScreen() in the pass because thumbbar have been used only in showfoto... (KDE3 code only).

Now, thumbbar is used in image editor too. code can be factorized as well in editorwindow.cpp.

The reason about this dysfunction is that i haven't yet tested all cases of course. it's a side effect (:=)))

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-16 13:48 -------
This error is also related to showFoto from KDE3 branch:

1. Open a folder
2. Hide the thumbbar
3. Goto fullscreen
4. Exit fullscreen

The thumbbar will be displayed. So I really guess
    // If Hide Thumbbar option is checked, restore it.
    if (!m_showBarAction->isChecked())
    d->thumbBar->show();

is wrong... or isn't it?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-16 13:52 -------
A simple

Index: showfoto/showfoto.cpp
===================================================================
--- showfoto/showfoto.cpp       (revision 831859)
+++ showfoto/showfoto.cpp       (working copy)
 @ -628,7 +628,7  @
         d->rightSidebar->restore();

         // If Hide Thumbbar option is checked, restore it.
-        if (!d->showBarAction->isChecked())
+        if (d->showBarAction->isChecked())
             d->thumbBar->show();
     }
     else

would do the trick... should I commit this?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-16 14:38 -------
The above patch can also be applied to KDE4 version, which makes patch #1 obsolete... still working fine.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From caulier.gilles gmail com  2008-07-16 15:53 -------
Andi,

Patch from comments #10 sounds logic (:=))). i cannot test here. If it fine for you, it's right for me.

Anybody else can valid this simple fix ?

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-16 16:04 -------
SVN commit 833245 by aclemens:

When leaving fullscreen mode, the thumbbar was gone. This happenend because the state of the thumbbar was always toggled.

CCBUGS:166472

 M  +1 -1      showfoto.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=833245
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-16 16:05 -------
SVN commit 833246 by aclemens:

backport commit #833245 from KDE3 branch

CCBUGS:166472

 M  +1 -1      showfoto.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=833246
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From andi.clemens gmx net  2008-07-16 16:08 -------
So this one is fixed for now, but what about the default shortcut? It collides with the "Insert Text" imageplugin.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         
gandalf.lechner esi ac at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From gandalf.lechner esi ac at  2008-07-17 09:21 -------
As of revision 833596, the thumbbar is still not working properly on my system.

Something seems to be wrong in the code, since all of the following types of behaviour occur (I assigned a different shortcut to the toggle thumbbar action, so that's not the problem):

1 - Switching back from fullscreen doesn't reactivate the thumbbar
2 - When switching to fullscreen, the thumbbar stays visible
3 - Pressing the toggle thumbbar button doesn't toggle the thumbbar (you sometimes have to press it twice)

Sometimes, however, the behaviour is just as expected, i.e. going to fullscreen hides the thumbnails and going back reactivates it; this seems to depend on the number of times you pressed the toggle thumbbar button.

Gandalf
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

Weird, can't reproduce any of the problems ...
(The only thing which is a bit annoying is the slow change
to full-screen and back: there seem to be several repaints
of the image at different sizes and this is obervable
even on a pretty fast machine.....)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From arnd.baecker web de  2008-07-17 10:15 -------
Weird, can't reproduce any of the problems ...
(The only thing which is a bit annoying is the slow change
to full-screen and back: there seem to be several repaints
of the image at different sizes and this is obervable
even on a pretty fast machine.....)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-17 10:32 -------
This is strange, it is working all the time here. Have you really compiled the
newest SVN or the final 0.9.4 release and actually installed it on your
system?

Andi

On Thursday 17 July 2008 09:21:19 you wrote:
[bugs.kde.org quoted mail]
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel