[Bug 166472] New: Thumbnail bar gone in image editor when switching back from fullscreen

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From caulier.gilles gmail com  2008-07-29 14:58 -------
Gandalf,

Please check this point : which digikamrc file is used to store all digiKam settings ?

Typically with KDE3, your ~/.kde/share/config/... file is used
with KDE4, it's your ~/.kde4/share/config/...

If you still use ~/.kde/share/config/... file with KDE4, you will see any garbage in GUI (you mix settings from KDE3 and KDE4)

Best

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From gandalf.lechner esi ac at  2008-07-29 15:08 -------
It looks as if the digikamrc within ~/.kde4/share/config is used. On the laptop I am trying this, there is no kde3-digikam any more, and I also removed its digikamrc. Then I changed some settings in kde4-digikam, and ~/.kde4/share/config/digikamrc was changed.

Gandalf
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-29 15:25 -------
If you set up a dedicated kde4 user, it will use the kde4 settings by default (if he didn't log into a KDE3 session before).

Yes I mean KDEDIR, this is the var describing the current KDE install path. KDEDIRS should work, too.

Your lsof output looks alright to me. Very strange... I don't know what is going wrong on your system.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-29 16:56 -------
AAAAAAAAAAAAAAAAAAAAAAAAAHHHHHH!!!!!!
I always checked showFoto only to test this issue because it starts faster... and somehow it worked before in digiKam as well. But now I looked at the code again. We have only corrected this bug for showFoto, not digiKam!!!

Gandalf sorry for this odyssey through your system settings! :-)

I will fix it right now!

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-29 17:07 -------
SVN commit 839225 by aclemens:

When leaving fullscreen mode, the thumbbar was not restored altough "Show Thumbbar" is checked.

CCBUGS:166472

 M  +32 -32    showfoto/showfoto.cpp  
 M  +30 -30    utilities/imageeditor/editor/imagewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=839225
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-29 17:31 -------
SVN commit 839236 by aclemens:

backport commit #839225 from KDE4 branch

CCBUGS:166472

 M  +39 -39    showfoto.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=839236
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-29 17:36 -------
It should be fixed (really :-)) now.

Gilles,

since code is the same in ShowFoto and ImageWindow we might even move the content of toggleGUI2FullScreen to EditorWindow class (and make it virtual?).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From caulier.gilles gmail com  2008-07-29 19:12 -------
Andi,

> since code is the same in ShowFoto and ImageWindow we might even move the content of toggleGUI2FullScreen to EditorWindow class (and make it virtual?).

The code is the same in showfoto and imagewindow. move the method to editorwindow which is the parent class for both. no need to make it as virtual. a virtual method is used to re-implement it to children classes. This not the case now.

In fact you will factorize, that all...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26105|0                           |1
        is obsolete|                            |



------- Additional Comments From andi.clemens gmx net  2008-07-29 20:57 -------
Created an attachment (id=26483)
 --> (http://bugs.kde.org/attachment.cgi?id=26483&action=view)
move toggleGUI2FullScreen() to EditorWindow

This patch will move toggleGUI2FullScreen() to EditorWindow and implement 2
virtual functions thumbBar() and rightSidebar() which return the appropriate
widget for the toggleGUI2FullScreen method.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From caulier.gilles gmail com  2008-07-29 21:15 -------
Andy,

Patch is fine for me...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-29 21:47 -------
SVN commit 839320 by aclemens:

Move toggleGUI2FullScreen() from ShowFoto and ImageWindow to EditorWindow and implement 2
virtual functions thumbBar() and rightSidebar() which return the appropriate
widget for the toggleGUI2FullScreen method.

CCBUGS:166472

 M  +46 -64    showfoto/showfoto.cpp  
 M  +8 -9      showfoto/showfoto.h  
 M  +101 -78   utilities/imageeditor/editor/editorwindow.cpp  
 M  +17 -14    utilities/imageeditor/editor/editorwindow.h  
 M  +61 -79    utilities/imageeditor/editor/imagewindow.cpp  
 M  +6 -6      utilities/imageeditor/editor/imagewindow.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=839320
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From andi.clemens gmx net  2008-07-29 22:03 -------
*** Bug has been marked as fixed ***.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From gandalf.lechner esi ac at  2008-07-30 11:48 -------
Hi,

since I can't start digikam at the moment because of the galleryexport crashes, I can at least tell you about the situation in showfoto: The shortcut Ctrl+T is now reserved for show thumbnails exclusively and works fine.

The thumnail bar show/hide feature works here as follows: Apparantly, the bar can be in three different stages: 1) switched off, 2) switched on and visible, and 3) switched on but hidden (retracted). Switching to fullscreen and back again results in 1)->1), 2)->3), 3)->3). The problem I have is the 2)->3) situation, i.e. when the bar is switched on and visible, going to fullscreen and back retracts it, and I have to pull it out with the mouse manually to see it again.

Gandalf
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-30 12:02 -------
This seems only to affect the sidebar if not displayed horizontal. In vertical
mode I can confirm this... damn... REOPENING again... :-(

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From andi.clemens gmx net  2008-07-30 12:03 -------
in vertical mode the thumbbar is hidden when returning from fullscreen.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From gandalf.lechner esi ac at  2008-07-30 12:08 -------
Some brave soul repaired the galleryexport, so I had the chance to check the situation in digikam. Here all works fine now :-), i.e. also 2)->2) (vertical mode). So the remaining problem is a showfoto only issue.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-30 12:17 -------
It has not been repaired, we only disable the critical part in the plugin...
some KWallet issue is killing all kipi hosting apps.

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-30 12:25 -------
I have not done anything and it is working right now. I don't understand this... will test a little further...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-30 12:27 -------
Sorry for spamming that much right now, but I found the issue: It only happens when the right sidebar is shown. Maybe it is getting too big?

Gilles,

any idea?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=166472         




------- Additional Comments From andi.clemens gmx net  2008-07-30 12:33 -------
With the right sidebar shown in imageeditor, it can also be confirmed for digiKam...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel