[Bug 115157] New: digikam useability: Image comments/tags dialog: hard to find/see all already selected tags (and to 'de'select them)

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         
           Summary: digikam useability:  Image comments/tags dialog: hard to
                    find/see all already selected tags (and to 'de'select
                    them)
           Product: digikam
           Version: 0.8.0-beta2
          Platform: unspecified
        OS/Version: Linux
            Status: NEW
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: ach mpe mpg de


Version:           0.8.0-beta2 (using KDE 3.4.3, Kubuntu Package 4:3.4.3-0ubuntu1 )
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.12-9-686

hard to find/see all already selected tags (and to 'de'select them if necessary).
Similar to #115154 with the 'Tags filter'.

to make the select tags better them visible I one
possibility maybe to show tags below the thumbnail
(and move the filename above the icon or move
icons more to the top)

Achim
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Horkan]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         
horkana maths tcd ie changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|digikam useability:  Image  |digikam usability:  Image
                   |comments/tags dialog: hard  |comments/tags dialog: hard
                   |to find/see all already     |to find/see all already
                   |selected tags (and to       |selected tags (and to
                   |'de'select them)            |'de'select them)



------- Additional Comments From horkana maths tcd ie  2006-03-22 10:58 -------
spelling mistake in summary: useability usability
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Tags
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles free fr  2006-09-03 16:49 -------
SVN commit 580439 by cgilles:

digikam from trunk : Tags Filter View : new options to

- "Select All" tags
- "Deselect" all tags
- "Invert Selection" of tags

BUG: 115154
CCBUGS: 115157

 M  +58 -7     tagfilterview.cpp  


--- trunk/extragear/graphics/digikam/digikam/tagfilterview.cpp #580438:580439
 @ -143,6 +143,8  @
     QTimer *timer;
 };
 
+// ---------------------------------------------------------------------
+
 TagFilterView::TagFilterView(QWidget* parent)
              : FolderView(parent)
 {
 @ -330,8 +332,7  @
     }
     else
     {
-        TagFilterViewItem* parent =
-            (TagFilterViewItem*)(tag->parent()->extraData(this));
+        TagFilterViewItem* parent = (TagFilterViewItem*)(tag->parent()->extraData(this));
         if (!parent)
         {
             kdWarning() << k_funcinfo << " Failed to find parent for Tag "
 @ -354,8 +355,7  @
     if (!tag)
         return;
 
-    TagFilterViewItem* item =
-            (TagFilterViewItem*)(tag->extraData(this));
+    TagFilterViewItem* item = (TagFilterViewItem*)(tag->extraData(this));
     if (item)
     {
         item->setText(0, tag->title());
 @ -507,10 +507,15  @
 
     if (item)
     {
-        popmenu.insertItem(SmallIcon("pencil"), i18n("Edit Tag Properties..."), 11);
-        popmenu.insertItem(SmallIcon("reload_page"), i18n("Reset Tag Icon"), 13);
-        popmenu.insertItem(SmallIcon("edittrash"), i18n("Delete Tag"), 12);
+        popmenu.insertItem(SmallIcon("pencil"),      i18n("Edit Tag Properties..."), 11);
+        popmenu.insertItem(SmallIcon("reload_page"), i18n("Reset Tag Icon"),         13);
+        popmenu.insertItem(SmallIcon("edittrash"),   i18n("Delete Tag"),             12);
     }
+
+    popmenu.insertSeparator();
+    popmenu.insertItem(i18n("Select All"),       14);
+    popmenu.insertItem(i18n("Deselect"),         15);
+    popmenu.insertItem(i18n("Invert Selection"), 16);
 
     int choice = popmenu.exec((QCursor::pos()));
     switch( choice )
 @ -536,6 +541,52  @
             AlbumManager::instance()->updateTAlbumIcon(item->m_tag, QString("tag"), 0, errMsg);
             break;
         }        
+        case 14:
+        {
+            QListViewItemIterator it(this, QListViewItemIterator::NotChecked);
+            while (it.current())
+            {
+                TagFilterViewItem* item = (TagFilterViewItem*)it.current();
+                item->setOn(true);
+                ++it;
+            }
+            triggerChange();
+            break;
+        }
+        case 15:
+        {
+            QListViewItemIterator it(this, QListViewItemIterator::Checked);
+            while (it.current())
+            {
+                TagFilterViewItem* item = (TagFilterViewItem*)it.current();
+                item->setOn(false);
+                ++it;
+            }
+            triggerChange();
+            break;
+        }
+        case 16:
+        {
+            QListViewItemIterator it(this);
+            while (it.current())
+            {
+                TagFilterViewItem* item = (TagFilterViewItem*)it.current();
+
+                // Toogle all root tags filter.
+                TAlbum *tag = item->m_tag;
+                if (tag)
+                    if (tag->parent()->isRoot())
+                        item->setOn(!item->isOn());
+
+                // Toogle "Not Tagged" item tag filter.
+                if (item->m_untagged)
+                    item->setOn(!item->isOn());
+
+                ++it;
+            }
+            triggerChange();
+            break;
+        }
         default:
             break;
     }
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles free fr  2006-09-03 16:52 -------
Achim,

Do you that i backport the current patch used to fix #115154 into the tag view of Comments & Tags side bar ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles free fr  2006-09-03 17:47 -------
SVN commit 580457 by cgilles:

digikam from trunk : Tags view from Comments & Tags side bar tab : new options to:

- "Select All" tags
- "Deselect" all tags
- "Invert Selection" of tags

CCBUGS: 115154, 115157

 M  +52 -6     imagedescedittab.cpp  


--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #580456:580457
 @ -508,8 +508,7  @
     QListViewItemIterator it( d->tagsView);
     while (it.current())
     {
-        TAlbumCheckListItem* tItem =
-                dynamic_cast<TAlbumCheckListItem*>(it.current());
+        TAlbumCheckListItem* tItem = dynamic_cast<TAlbumCheckListItem*>(it.current());
 
         if (tItem)
         {
 @ -569,6 +568,7  @
     QPopupMenu popmenu(this);
 
     popmenu.insertItem(SmallIcon("tag"), i18n("New Tag..."), 10);
+
     if (!album->isRoot())
     {
         popmenu.insertItem(SmallIcon("pencil"),      i18n("Edit Tag Properties..."), 11);
 @ -576,6 +576,11  @
         popmenu.insertItem(SmallIcon("edittrash"),   i18n("Delete Tag"),             12);
     }
 
+    popmenu.insertSeparator();
+    popmenu.insertItem(i18n("Select All"),       14);
+    popmenu.insertItem(i18n("Deselect"),         15);
+    popmenu.insertItem(i18n("Invert Selection"), 16);
+
     switch (popmenu.exec(QCursor::pos()))
     {
         case 10:
 @ -601,6 +606,43  @
             AlbumManager::instance()->updateTAlbumIcon(album, QString("tag"), 0, errMsg);
             break;
         }
+        case 14:
+        {
+            QListViewItemIterator it(d->tagsView, QListViewItemIterator::NotChecked);
+            while (it.current())
+            {
+                TAlbumCheckListItem* item = dynamic_cast<TAlbumCheckListItem*>(it.current());
+                item->setOn(true);
+                ++it;
+            }
+            break;
+        }
+        case 15:
+        {
+            QListViewItemIterator it(d->tagsView, QListViewItemIterator::Checked);
+            while (it.current())
+            {
+                TAlbumCheckListItem* item = dynamic_cast<TAlbumCheckListItem*>(it.current());
+                item->setOn(false);
+                ++it;
+            }
+            break;
+        }
+        case 16:
+        {
+            QListViewItemIterator it(d->tagsView);
+            while (it.current())
+            {
+                TAlbumCheckListItem* item = dynamic_cast<TAlbumCheckListItem*>(it.current());
+                TAlbum *tag = item->m_album;
+                if (tag)
+                    if (!tag->isRoot())
+                        item->setOn(!item->isOn());
+
+                ++it;
+            }
+            break;
+        }
         default:
             break;
     }
 @ -823,7 +865,8  @
 void ImageDescEditTab::slotImagesChanged(int albumId)
 {
     Album *a = AlbumManager::instance()->findAlbum(albumId);
-    if (!d->ignoreImageAttributesWatch && !d->currInfo || !a || a->isRoot() || a->type() != Album::TAG)
+    if (!d->ignoreImageAttributesWatch &&
+        !d->currInfo || !a || a->isRoot() || a->type() != Album::TAG)
         return;
 
     updateTagsView();
 @ -831,19 +874,22  @
 
 void ImageDescEditTab::slotImageRatingChanged(Q_LLONG imageId)
 {
-    if (!d->ignoreImageAttributesWatch && d->currInfo && d->currInfo->id() == imageId)
+    if (!d->ignoreImageAttributesWatch &&
+        d->currInfo && d->currInfo->id() == imageId)
         updateRating();
 }
 
 void ImageDescEditTab::slotImageCaptionChanged(Q_LLONG imageId)
 {
-    if (!d->ignoreImageAttributesWatch && d->currInfo && d->currInfo->id() == imageId)
+    if (!d->ignoreImageAttributesWatch &&
+        d->currInfo && d->currInfo->id() == imageId)
         updateComments();
 }
 
 void ImageDescEditTab::slotImageDateChanged(Q_LLONG imageId)
 {
-    if (!d->ignoreImageAttributesWatch && d->currInfo && d->currInfo->id() == imageId)
+    if (!d->ignoreImageAttributesWatch &&
+        d->currInfo && d->currInfo->id() == imageId)
         updateDate();
 }
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles free fr  2006-09-03 17:50 -------
Achim,

The option to manage tags selection from Tags Filter Side bar habe been backported to Comments & Tags side bar.

The question now is: since Comments & tags dialog have been moved to a side bar, i think this bug is invalid... right ?

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Roy-24]

On Sunday 03 September 2006 17:50, Gilles Caulier wrote:
> ------- Achim,
>
> The option to manage tags selection from Tags Filter Side bar habe been
> backported to Comments & Tags side bar.
>
> The question now is: since Comments & tags dialog have been moved to a side
> bar, i think this bug is invalid... right ?
>
> Gilles

Maybe I'm missing something but I think it's still hard to get an overview of
what tags are already assigned to an image. I've got a rather large hierarchy
of tags and hence need to scroll much until i spotted all selected tags.

It would be nice to have a summary of all selected tags.

Thank you very much for this great piece of software.

Roy
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Roy-24]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From roymen gmail com  2006-09-03 18:02 -------
On Sunday 03 September 2006 17:50, Gilles Caulier wrote:
> ------- Achim,
>
> The option to manage tags selection from Tags Filter Side bar habe been
> backported to Comments & Tags side bar.
>
> The question now is: since Comments & tags dialog have been moved to a side
> bar, i think this bug is invalid... right ?
>
> Gilles


Maybe I'm missing something but I think it's still hard to get an overview of
what tags are already assigned to an image. I've got a rather large hierarchy
of tags and hence need to scroll much until i spotted all selected tags.

It would be nice to have a summary of all selected tags.

Thank you very much for this great piece of software.

Roy
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From mikmach wp pl  2006-09-03 23:38 -------
I don't think this bug can be closed.

Still with huge structure of tags it is hard to see
what tags image has. Especially in Preview mode (F3
in album view) and in Image Editor.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles kdemail net  2006-12-18 09:32 -------
At url below, you have a patch against svn. This is a first approach to optimize free space to use on the right Comments & tags side bar :

http://digikam3rdparty.free.fr/misc.tarballs/tagsview.patch

This patch use a QToolBox to separate Comments/Date/Rating view of Tags view. You have more space to enter comments and of course more space to display all tags.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles kdemail net  2006-12-18 09:37 -------
Created an attachment (id=18966)
 --> (http://bugs.kde.org/attachment.cgi?id=18966&action=view)
screenshot 1 of new Comments & tags layout
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles kdemail net  2006-12-18 09:38 -------
Created an attachment (id=18967)
 --> (http://bugs.kde.org/attachment.cgi?id=18967&action=view)
screenshot 2 of new Comments & tags layout
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From arnd.baecker web de  2006-12-18 10:38 -------
Can one still have both "Comments/Tags/Ratings" and "Tags"
visible (e.g. by rescaling the size of the "Comments/Tags/Ratings" part)?

Further options to provide more information in the same amount of space:
- allow for free adjustment of the Fontsize of the tags
  (independent of the fonts used at other places of digikam)
- The squares+Icons also take up quite some space.
  For a really condensed view they could be reduced in size
  as well.

In general one might even think of introducing
user-definable viewing profiles for different tasks.
Each profile corresponds to a bunch of settings, e.g.
- tags with very small font visible, but no folders, large icon size
- metadata open, but smallest icon size for the images.

But (all?) this, and how to realize a smooth workflow,
would require more thought and discussion ...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles kdemail net  2006-12-18 13:45 -------
The patch is now updated to support Drag and Drop in Tags view of Comments & Tags sidebar :

http://digikam3rdparty.free.fr/misc.tarballs/tagsview.patch 

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles kdemail net  2006-12-18 18:50 -------
Patch commited to svn with commit #614702

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From mikmach wp pl  2006-12-18 20:58 -------
I have mixed feelings.

1. It is always good to have more space for comments.
2. Even full height of monitor is not enough to show complete tag tree.

   Possible solutions:

   a) don't open tree completely. IMO opening only first
      level of tree should considerably shorten tree length (for me it
      is still not enough...).
   b) use some of gained space to subwindow showing mini-tree of image
      tags

3. Subpanels. I really don't like it. Confusing. Make all panels
   horizontal (at least those on the right side). It would make right
   side unclosable though. Or make it close, only with icons visible.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From caulier.gilles kdemail net  2006-12-19 08:12 -------
SVN commit 614853 by cgilles:

digikam from trunk : Comments & Tags Sidebar tab : using KTabWidget instead QToolBox to render sidebar page content. This will homogenous than others existing sidebar tabs

CCBUGS: 115157

 M  +29 -30    imagedescedittab.cpp  


--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #614852:614853
 @ -29,7 +29,6  @
 #include <qhgroupbox.h>
 #include <qvgroupbox.h>
 #include <qheader.h>
-#include <qtoolbox.h>
 #include <qtoolbutton.h>
 #include <qiconset.h>
 #include <qwhatsthis.h>
 @ -49,6 +48,7  @
 #include <kconfig.h>
 #include <klineedit.h>
 #include <kdialogbase.h>
+#include <ktabwidget.h>
 
 // Local includes.
 
 @ -79,7 +79,7  @
 
     enum SettingsTab
     {
-        COMMENTSPAGE=0,
+        DESCRIPTIONPAGE=0,
         TAGSPAGE
     };
 
 @ -97,14 +97,12  @
         ratingWidget               = 0;
         navigateBar                = 0;
         ABCMenu                    = 0;
-        toolBox                    = 0;
+        tab                        = 0;
     }
 
     bool               modified;
     bool               ignoreImageAttributesWatch;
 
-    QToolBox          *toolBox;
-
     QToolButton       *recentTagsBtn;
     QToolButton       *tagsSearchClearBtn;
 
 @ -114,6 +112,8  @
 
     KLineEdit         *tagsSearchEdit;
 
+    KTabWidget        *tab;
+
     KDateTimeEdit     *dateTimeEdit;
 
     ImageInfo         *currInfo;
 @ -130,24 +130,29  @
 {
     d = new ImageDescEditTabPriv;
 
-    QVBoxLayout *vLayout        = new QVBoxLayout(this);
-    d->navigateBar              = new NavigateBarWidget(this, navBar);
-    d->toolBox                  = new QToolBox(this);
-    QWidget *propertiesBox      = new QWidget(d->toolBox);
-    QGridLayout *settingsLayout = new QGridLayout(propertiesBox, 2, 1,
-                                      KDialog::marginHint(), KDialog::spacingHint());
+    QVBoxLayout *vLayout = new QVBoxLayout(this);
+    d->navigateBar       = new NavigateBarWidget(this, navBar);
+    d->tab               = new KTabWidget(this);
     
+    vLayout->addWidget(d->navigateBar);
+    vLayout->addSpacing(KDialog::spacingHint());
+    vLayout->addWidget(d->tab);
+
     // Comments/Date/Rating view -----------------------------------
+
+    QWidget *descriptionPage    = new QWidget(d->tab);
+    QGridLayout *settingsLayout = new QGridLayout(descriptionPage, 2, 1,
+                                      KDialog::marginHint(), KDialog::spacingHint());
     
-    QVGroupBox* commentsBox = new QVGroupBox(i18n("&Comments"), propertiesBox);
+    QVGroupBox* commentsBox = new QVGroupBox(i18n("&Comments"), descriptionPage);
     d->commentsEdit         = new KTextEdit(commentsBox);
     d->commentsEdit->setTextFormat(QTextEdit::PlainText);
     d->commentsEdit->setCheckSpellingEnabled(true);
 
-    QHGroupBox* dateTimeBox = new QHGroupBox(i18n("&Date && Time"), propertiesBox);
+    QHGroupBox* dateTimeBox = new QHGroupBox(i18n("&Date && Time"), descriptionPage);
     d->dateTimeEdit         = new KDateTimeEdit( dateTimeBox, "datepicker");
 
-    QHGroupBox* ratingBox = new QHGroupBox(i18n("Rating"), propertiesBox);
+    QHGroupBox* ratingBox = new QHGroupBox(i18n("Rating"), descriptionPage);
     ratingBox->layout()->setAlignment(Qt::AlignCenter);
     d->ratingWidget = new RatingWidget(ratingBox);
 
 @ -156,14 +161,13  @
     settingsLayout->addMultiCellWidget(ratingBox, 2, 2, 0, 1);
     settingsLayout->setRowStretch(0, 10);
 
-    d->toolBox->insertItem(ImageDescEditTabPriv::COMMENTSPAGE, propertiesBox,
-                           SmallIconSet("imagecomment"), i18n("Comments/Date/Rating"));
+    d->tab->insertTab(descriptionPage, i18n("Description"), ImageDescEditTabPriv::DESCRIPTIONPAGE);
 
     // Tags view ---------------------------------------------------
 
-    QWidget *tagsBox      = new QWidget(d->toolBox);
-    QVBoxLayout *vLayout2 = new QVBoxLayout(tagsBox, KDialog::marginHint(), KDialog::spacingHint());
-    QHBox* tagsSearch     = new QHBox(tagsBox);
+    QWidget *tagsPage     = new QWidget(d->tab);
+    QVBoxLayout *vLayout2 = new QVBoxLayout(tagsPage, KDialog::marginHint(), KDialog::spacingHint());
+    QHBox* tagsSearch     = new QHBox(tagsPage);
     tagsSearch->setSpacing(KDialog::spacingHint());
 
     d->tagsSearchClearBtn = new QToolButton(tagsSearch);
 @ -184,7 +188,7  @
     d->recentTagsBtn->setPopup(popupMenu);
     d->recentTagsBtn->setPopupDelay(1);
 
-    d->tagsView = new TAlbumListView(tagsBox);
+    d->tagsView = new TAlbumListView(tagsPage);
     d->tagsView->addColumn(i18n("Tags"));
     d->tagsView->header()->hide();
     d->tagsView->setSelectionMode(QListView::Single);
 @ -193,19 +197,14  @
     vLayout2->addWidget(tagsSearch);
     vLayout2->addWidget(d->tagsView);
 
-    d->toolBox->insertItem(ImageDescEditTabPriv::TAGSPAGE, tagsBox,
-                           kapp->iconLoader()->loadIcon("tag", KIcon::NoGroup, KIcon::SizeSmall,
-                           KIcon::DefaultState, 0, true), i18n("Tags"));
-
+    d->tab->insertTab(tagsPage, i18n("Tags"), ImageDescEditTabPriv::TAGSPAGE);
+    
     // --------------------------------------------------
     
-    vLayout->addWidget(d->navigateBar);
-    vLayout->addWidget(d->toolBox);    
-
     KConfig* config = kapp->config();
     config->setGroup("Image Properties SideBar");
-    d->toolBox->setCurrentIndex(config->readNumEntry("Comments And Tags Tab",
-                                ImageDescEditTabPriv::COMMENTSPAGE));
+    d->tab->setCurrentPage(config->readNumEntry("Comments And Tags Tab",
+                           ImageDescEditTabPriv::DESCRIPTIONPAGE));
 
     // --------------------------------------------------
 
 @ -308,7 +307,7  @
 
     KConfig* config = kapp->config();
     config->setGroup("Image Properties SideBar");
-    config->writeEntry("Comments And Tags Tab", d->toolBox->currentIndex());
+    config->writeEntry("Comments And Tags Tab", d->tab->currentPageIndex());
     config->sync();
   
     /*
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-2]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         
caulier.gilles kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles kdemail net  2006-12-19 13:49 -------
SVN commit 614902 by cgilles:

digikam from trunk : Comments & Tags Sidebar tab : add a new small push button to only display the currently assigned tags of the image.

BUG: 115157

 M  +75 -9     imagedescedittab.cpp  
 M  +1 -0      imagedescedittab.h  


--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.cpp #614901:614902
 @ -30,6 +30,7  @
 #include <qvgroupbox.h>
 #include <qheader.h>
 #include <qtoolbutton.h>
+#include <qpushbutton.h>
 #include <qiconset.h>
 #include <qwhatsthis.h>
 #include <qtooltip.h>
 @ -98,6 +99,7  @
         navigateBar                = 0;
         ABCMenu                    = 0;
         tab                        = 0;
+        assignedTagsBtn            = 0;
     }
 
     bool               modified;
 @ -108,6 +110,8  @
 
     QPopupMenu        *ABCMenu;
 
+    QPushButton       *assignedTagsBtn;
+
     KTextEdit         *commentsEdit;
 
     KLineEdit         *tagsSearchEdit;
 @ -179,11 +183,19  @
     d->tagsSearchEdit = new KLineEdit(tagsSearch);
     d->tagsSearchEdit->setSizePolicy(QSizePolicy(QSizePolicy::Expanding, QSizePolicy::Minimum));
 
+    d->assignedTagsBtn = new QPushButton(tagsSearch);
+    QToolTip::add(d->assignedTagsBtn, i18n("Already Assigned Tags"));
+    d->assignedTagsBtn->setIconSet(kapp->iconLoader()->loadIcon("tag-assigned",
+                                   KIcon::NoGroup, KIcon::SizeSmall,
+                                   KIcon::DefaultState, 0, true));
+    d->assignedTagsBtn->setToggleButton(true);
+
     d->recentTagsBtn      = new QToolButton(tagsSearch);
     QPopupMenu *popupMenu = new QPopupMenu(d->recentTagsBtn);
     QToolTip::add(d->recentTagsBtn, i18n("Recent Tags"));
-    d->recentTagsBtn->setIconSet(kapp->iconLoader()->loadIcon("tag-recents", KIcon::NoGroup,
-                                 KIcon::SizeSmall, KIcon::DefaultState, 0, true));
+    d->recentTagsBtn->setIconSet(kapp->iconLoader()->loadIcon("tag-recents",
+                                 KIcon::NoGroup, KIcon::SizeSmall,
+                                 KIcon::DefaultState, 0, true));
     d->recentTagsBtn->setUsesBigPixmap(false);
     d->recentTagsBtn->setPopup(popupMenu);
     d->recentTagsBtn->setPopupDelay(1);
 @ -243,6 +255,9  @
             
     connect(d->tagsSearchEdit, SIGNAL(textChanged(const QString&)),
             this, SLOT(slotTagsSearchChanged()));
+
+    connect(d->assignedTagsBtn, SIGNAL(toggled(bool)),
+            this, SLOT(slotAssignedTagsToggled(bool)));
             
     // Initalize ---------------------------------------------
 
 @ -627,7 +642,8  @
             while (it.current())
             {
                 TAlbumCheckListItem* item = dynamic_cast<TAlbumCheckListItem*>(it.current());
-                item->setOn(true);
+                if (item->isVisible())
+                    item->setOn(true);
                 ++it;
             }
             break;
 @ -638,7 +654,8  @
             while (it.current())
             {
                 TAlbumCheckListItem* item = dynamic_cast<TAlbumCheckListItem*>(it.current());
-                item->setOn(false);
+                if (item->isVisible())
+                    item->setOn(false);
                 ++it;
             }
             break;
 @ -649,11 +666,13  @
             while (it.current())
             {
                 TAlbumCheckListItem* item = dynamic_cast<TAlbumCheckListItem*>(it.current());
-                TAlbum *tag = item->m_album;
-                if (tag)
-                    if (!tag->isRoot())
-                        item->setOn(!item->isOn());
-
+                if (item->isVisible())
+                {
+                    TAlbum *tag = item->m_album;
+                    if (tag)
+                        if (!tag->isRoot())
+                            item->setOn(!item->isOn());
+                }
                 ++it;
             }
             break;
 @ -1133,5 +1152,52  @
     }
 }
 
+void ImageDescEditTab::slotAssignedTagsToggled(bool t)
+{
+    QListViewItemIterator it(d->tagsView);
+    while (it.current())
+    {
+        TAlbumCheckListItem* item = dynamic_cast<TAlbumCheckListItem*>(it.current());
+        TAlbum *tag               = item->m_album;
+        if (tag)
+        {
+            if (!tag->isRoot())
+            {
+                if (t)
+                {
+                    bool isOn = item->isOn();
+                    item->setVisible(isOn);
+
+                    if (isOn)
+                    {
+                        Album* parent = tag->parent();
+                        while (parent && !parent->isRoot())
+                        {
+                            QCheckListItem *pitem = (QCheckListItem*)parent->extraData(this);
+                            pitem->setVisible(true);
+                            parent = parent->parent();
+                        }
+                    }
+                }
+                else
+                {
+                    item->setVisible(true);
+                }
+            }
+        }
+        ++it;
+    }
+
+    TAlbum *root                  = AlbumManager::instance()->findTAlbum(0);
+    TAlbumCheckListItem *rootItem = (TAlbumCheckListItem*)(root->extraData(this));
+    if (rootItem)
+    {
+        if (t)
+            rootItem->setText(0, i18n("Assigned Tags"));
+        else
+            rootItem->setText(0, root->title());
+    }
+}
+
 }  // NameSpace Digikam
 
--- trunk/extragear/graphics/digikam/libs/imageproperties/imagedescedittab.h #614901:614902
 @ -108,6 +108,7  @
     void slotImageCaptionChanged(Q_LLONG imageId);
 
     void slotRecentTagsMenuActivated(int);
+    void slotAssignedTagsToggled(bool);
 
 private:
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Fabien-5]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115157         




------- Additional Comments From fabien.ubuntu gmail com  2006-12-19 16:52 -------
Well... I must confess I don't like the new look with 2 tabs. I fully understand that one would like to have more space to display tags and/or comments.
But, I agree with Arnd, it would be great to be able to still view comments tags and rating at the same time.
I often use right/left arrow keys to browse the different pictures within an album and it's quite convenient to check comments *and* tags for each without having to go from one tab to the 2nd.

The best would be to choose between both views in an elegant way. I have no idea how to do that properly, but I hope others will have :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel