libface / libkface CMake

[Marcel Wiesweg]

See this commit by David Faure:

r1199970 | dfaure | 2010-11-23 12:45:48 +0100 (Di, 23. Nov 2010) | 4 Zeilen

Fix compilation when OpenCV isn't present --- but for this we still need
FindOpenCV!
Remove find_package(libface) since libkface is present here, and since we
don't have a FindLibFace.cmake anywhere.
Don't install FindKFace.cmake from libkface, this can't work, it has to be
present in whoever wants to use it...


It seems that "FindLibFace.cmake" must ship with lib_k_face, and
FindLibKFace.cmake must ship with digikam?

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Marcel,

I Agree. There is a confusion between libkface and libface Cmake find script.

This must be reverted. Please post a clear comment in commit... (:=)))

Gilles

2010/11/28 Marcel Wiesweg <[hidden email]>:

> See this commit by David Faure:
>
> r1199970 | dfaure | 2010-11-23 12:45:48 +0100 (Di, 23. Nov 2010) | 4 Zeilen
>
> Fix compilation when OpenCV isn't present --- but for this we still need
> FindOpenCV!
> Remove find_package(libface) since libkface is present here, and since we
> don't have a FindLibFace.cmake anywhere.
> Don't install FindKFace.cmake from libkface, this can't work, it has to be
> present in whoever wants to use it...
>
>
> It seems that "FindLibFace.cmake" must ship with lib_k_face, and
> FindLibKFace.cmake must ship with digikam?
>
> Marcel
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> I Agree. There is a confusion between libkface and libface Cmake find script.
>
> This must be reverted. Please post a clear comment in commit... (:=)))
>

Hi.

The current CMakeLists.txt for libkface does not work if external
libface is not found.

I've fixed it for myself, diff attached, but perhaps You can make a
better fix ;)

Gert

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> Hi.
>
> The current CMakeLists.txt for libkface does not work if external
> libface is not found.
>
> I've fixed it for myself, diff attached, but perhaps You can make a
> better fix ;)
>
> Gert
 
Thanks a lot, applied to SVN.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Thanks,

I had another problem also, with opencv: The FindOpenCV.cmake seems to
be unable to find OpenCV on windows machine. I deleted it, and made a
minor fix to kdereview/libkface/libkface/CMakeLists.txt (attached), so
now it compiles fine...

Gert


On 1 December 2010 11:40, Marcel Wiesweg <[hidden email]> wrote:

>
>> Hi.
>>
>> The current CMakeLists.txt for libkface does not work if external
>> libface is not found.
>>
>> I've fixed it for myself, diff attached, but perhaps You can make a
>> better fix ;)
>>
>> Gert
>
> Thanks a lot, applied to SVN.
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Right.

I apply similar patch on my Win7 computer.

It sound like a problem with OpenCV. Please report on OpenCV bugzilla.

Gilles Caulier

2010/12/1 Gert Kello <[hidden email]>:

> Thanks,
>
> I had another problem also, with opencv: The FindOpenCV.cmake seems to
> be unable to find OpenCV on windows machine. I deleted it, and made a
> minor fix to kdereview/libkface/libkface/CMakeLists.txt (attached), so
> now it compiles fine...
>
> Gert
>
>
> On 1 December 2010 11:40, Marcel Wiesweg <[hidden email]> wrote:
>>
>>> Hi.
>>>
>>> The current CMakeLists.txt for libkface does not work if external
>>> libface is not found.
>>>
>>> I've fixed it for myself, diff attached, but perhaps You can make a
>>> better fix ;)
>>>
>>> Gert
>>
>> Thanks a lot, applied to SVN.
>> _______________________________________________
>> Digikam-devel mailing list
>> [hidden email]
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

> It sound like a problem with OpenCV. Please report on OpenCV bugzilla.

What exactly is OpenCV problem? The FindOpenCV that is included with
libkface and does not come from OpenCV? Or incorrect variable used in
libkface/libkface/CMakeLists.txt?

Gert
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

> I had another problem also, with opencv: The FindOpenCV.cmake seems to
> be unable to find OpenCV on windows machine. I deleted it, and made a
> minor fix to kdereview/libkface/libkface/CMakeLists.txt (attached), so
> now it compiles fine...

I see that OpenCV itself installs a cmake file , for me it is found in
/usr/share/opencv/OpenCVConfig.cmake
Then we ship a completely different FindOpenCV.cmake with libkface.

Which one should be used?

Marcel
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

The problem is OpenCVConfig.cmake provided with openCV.

Typically, we don't need FindOpenCV.cmake. This script do not come
from OpenCV project

Gilles

2010/12/1 Gert Kello <[hidden email]>:

>> It sound like a problem with OpenCV. Please report on OpenCV bugzilla.
>
> What exactly is OpenCV problem? The FindOpenCV that is included with
> libkface and does not come from OpenCV? Or incorrect variable used in
> libkface/libkface/CMakeLists.txt?
>
> Gert
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

OpenCVConfig.cmake must be used instead.

But for obscur reasons, i think that this file is not installed with
some distro.

Also, with windows, this file as a double quote problem (formatting).
I fixed it myself. It's cleary a bug for OpenCV

Gilles

2010/12/1 Marcel Wiesweg <[hidden email]>:

>
>> I had another problem also, with opencv: The FindOpenCV.cmake seems to
>> be unable to find OpenCV on windows machine. I deleted it, and made a
>> minor fix to kdereview/libkface/libkface/CMakeLists.txt (attached), so
>> now it compiles fine...
>
> I see that OpenCV itself installs a cmake file , for me it is found in
> /usr/share/opencv/OpenCVConfig.cmake
> Then we ship a completely different FindOpenCV.cmake with libkface.
>
> Which one should be used?
>
> Marcel
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

>> I had another problem also, with opencv: The FindOpenCV.cmake seems to
>> be unable to find OpenCV on windows machine. I deleted it, and made a
>> minor fix to kdereview/libkface/libkface/CMakeLists.txt (attached), so
>> now it compiles fine...
>
> I see that OpenCV itself installs a cmake file , for me it is found in
> /usr/share/opencv/OpenCVConfig.cmake
> Then we ship a completely different FindOpenCV.cmake with libkface.
>
> Which one should be used?

Seems like OpenCV 2.1 fails to install the OpenCVConfig.cmake in
windows. It is present in OpenCv build dir, cmake seems to find it
somehow if it is under same root dev folder... (and I did not need to
change it)
OpenCV trunk seems to install it, but to a bit odd place
(E:\Kde4\OpenCVConfig.cmake in my case)

And FindOpenCV.cmake is unable to find OpenCV in my computer.

Gert
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

So what about us shipping the fixed version of OpenCV's cmake file?
Then it will always be found, and work everywhere.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

On 12/01/2010 11:59 AM, Gilles Caulier wrote:
> OpenCVConfig.cmake must be used instead.
>
> But for obscur reasons, i think that this file is not installed with
> some distro.

I can confirm that. It is not installed under debian, or at least was
not the last time I tried.

Michael
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel