getSupportedPorts

[Greg Lee-5]

There is an incompatibility with the svn version
of libgphoto2 which turns up in three places: once
in  GPCamera::getSupportedPorts in
digikam-0.9.4-beta4/digikam/utilities/cameragui/gpcamera.cpp
and in two places in kipi-plugins.

I don't know if the following patch is correct, but it
compiles:

--- gpcamera.cpp.orig   2008-05-08 10:37:20.000000000 -1000
+++ gpcamera.cpp        2008-05-08 10:42:44.000000000 -1000
@@ -1090,6 +1090,8 @@
 {
     GPPortInfoList *list;
     GPPortInfo      info;
+               char **path;
+
 
     plist.clear();
 
@@ -1109,7 +1111,9 @@
         for (int i = 0 ; i < numPorts ; i++)
         {
             gp_port_info_list_get_info( list, i, &info );
-            plist.append( info.path );
+               gp_port_info_get_path (info, path);
+            //plist.append( info.path );
+               plist.append( *path );
         }
     }

Very similar functions are in kipi-plugins/kameraklient/
in gpcamera.cpp and gpiface.cpp and have the same problem.

--
Greg

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

Greg,

Thanks for your patch.

Please make a new file in bugzilla and create a new attachement with
your patch. Posting it to mailing list will be lost because it will
processed/tested later (currently, i'm busy to LGM 2008).

Thanks in advance

Gilles Caulier

2008/5/8 Greg Lee <[hidden email]>:

>
> There is an incompatibility with the svn version
> of libgphoto2 which turns up in three places: once
> in  GPCamera::getSupportedPorts in
> digikam-0.9.4-beta4/digikam/utilities/cameragui/gpcamera.cpp
> and in two places in kipi-plugins.
>
> I don't know if the following patch is correct, but it
> compiles:
>
> --- gpcamera.cpp.orig   2008-05-08 10:37:20.000000000 -1000
> +++ gpcamera.cpp        2008-05-08 10:42:44.000000000 -1000
> @@ -1090,6 +1090,8 @@
>  {
>     GPPortInfoList *list;
>     GPPortInfo      info;
> +               char **path;
> +
>
>     plist.clear();
>
> @@ -1109,7 +1111,9 @@
>         for (int i = 0 ; i < numPorts ; i++)
>         {
>             gp_port_info_list_get_info( list, i, &info );
> -            plist.append( info.path );
> +               gp_port_info_get_path (info, path);
> +            //plist.append( info.path );
> +               plist.append( *path );
>         }
>     }
>
> Very similar functions are in kipi-plugins/kameraklient/
> in gpcamera.cpp and gpiface.cpp and have the same problem.
>
> --
> Greg
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

Hi Greg,

just to be sure that your patch does not get lost:
did you file a bug in the bug tracker with your patch attached?
(If yes, which number is it?).

Thanks a lot,

Arnd

On Thu, 8 May 2008, Greg Lee wrote:

> There is an incompatibility with the svn version
> of libgphoto2 which turns up in three places: once
> in  GPCamera::getSupportedPorts in
> digikam-0.9.4-beta4/digikam/utilities/cameragui/gpcamera.cpp
> and in two places in kipi-plugins.
>
> I don't know if the following patch is correct, but it
> compiles:
>
> --- gpcamera.cpp.orig   2008-05-08 10:37:20.000000000 -1000
> +++ gpcamera.cpp        2008-05-08 10:42:44.000000000 -1000
> @@ -1090,6 +1090,8 @@
>  {
>      GPPortInfoList *list;
>      GPPortInfo      info;
> +               char **path;
> +
>
>      plist.clear();
>
> @@ -1109,7 +1111,9 @@
>          for (int i = 0 ; i < numPorts ; i++)
>          {
>              gp_port_info_list_get_info( list, i, &info );
> -            plist.append( info.path );
> +               gp_port_info_get_path (info, path);
> +            //plist.append( info.path );
> +               plist.append( *path );
>          }
>      }
>
> Very similar functions are in kipi-plugins/kameraklient/
> in gpcamera.cpp and gpiface.cpp and have the same problem.
>
>

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel