[digikamimageplugins] [Bug 312765] New: [patch] Crop factor is being used as scale factor

[Roman I Khimov]

https://bugs.kde.org/show_bug.cgi?id=312765

            Bug ID: 312765
           Summary: [patch] Crop factor is being used as scale factor
    Classification: Unclassified
           Product: digikamimageplugins
           Version: 2.6.0
          Hardware: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Lens Distortion
          Assignee: [hidden email]
          Reporter: [hidden email]

Subject says it all, patch will be added.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Roman I Khimov]

https://bugs.kde.org/show_bug.cgi?id=312765

--- Comment #1 from Roman I Khimov <[hidden email]> ---
Created attachment 76255
  --> https://bugs.kde.org/attachment.cgi?id=76255&action=edit
Patch to fix the problem

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=312765

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|[patch] Crop factor is      |Crop factor is being used
                   |being used as scale factor  |as scale factor [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=312765

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |3.0.0
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/70cf9beaac9996c219f988d
                   |                            |8ae74d75dc253c0ad

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Git commit 70cf9beaac9996c219f988d8ae74d75dc253c0ad by Gilles Caulier.
Committed on 07/01/2013 at 11:39.
Pushed by cgilles into branch 'master'.

Apply patch #76255 from Roman I Khimov to don't pass crop factor as scale
factor to lensfun.

Sixth parameter to Initialize() is actually a scale factor which has nothing
in common with crop factor. I think it's safe to assume that we want no
scaling from lensfun and thus use the value of one.

Ref: http://lensfun.berlios.de/manual/structlfModifier.html
Related: bug 312764, bug 253941, bug 266204, bug 267613, bug 281783, bug 284708
FIXED-IN: 3.0.0
CCMAIL: [hidden email]

M  +1    -1    libs/dimg/filters/lens/lensfunfilter.cpp

http://commits.kde.org/digikam/70cf9beaac9996c219f988d8ae74d75dc253c0ad

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=312765

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Roman,

Thanks a lots for your investiguations and patches around digiKam Lensfun
interface.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Roman I Khimov]

https://bugs.kde.org/show_bug.cgi?id=312765

Roman I Khimov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Roman I Khimov <[hidden email]> ---
Patch applied, thanks, closing.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=312765

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikamimageplugins         |digikam
          Component|Lens Distortion             |Tool-LensDistortion

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel