[digikam] [Bug 381319] New: Keyboard modifier not catch when using Wacom Tablet

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381319

            Bug ID: 381319
           Summary: Keyboard modifier not catch when using Wacom Tablet
           Product: digikam
           Version: unspecified
          Platform: Kubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Usability
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Created attachment 106137
  --> https://bugs.kde.org/attachment.cgi?id=106137&action=edit
Enable keyboard modifier for tablets Wacom

When using the Wacom Tablet, the keyboard modifier is not correctly identified.

1) When face tagging a user can Press Ctrl key and press mouse left button, and
thus creating a face tag rectangle.
2) Doing the same thing using a  Wacom Tablet does not work, unless the patch
is applied.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381319

Kristian Karl <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Keyboard modifier not catch |Keyboard modifier not
                   |when using Wacom Tablet     |caught when using Wacom
                   |                            |Tablet

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381319

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Keyboard modifier not       |Keyboard modifier not
                   |caught when using Wacom     |caught when using Wacom
                   |Tablet                      |Tablet [patch]
                 CC|                            |[hidden email]

--- Comment #1 from [hidden email] ---
Thanks for your patch.

I'm not aware that we need to create this modification to take a care about
tablet. I have one Watcom device at home, but i never tried to use it with DK.

Are you sure that we need to only patch code at this place. There are no other
one to patch in this way ? This still compatible with Qt 5.6.x TLS (as we don't
need to use Qt >= 5.7.x ? This do not have some side effects with normal
keyboard support ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381319

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |5.6.0

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381319

--- Comment #2 from Kristian Karl <[hidden email]> ---
Running "git grep QApplication::keyboardModifiers" there is one more place:
libs/widgets/itemview/imagedelegateoverlay.cpp in
AbstractWidgetDelegateOverlay::checkIndexOnEnter

Maybe that should be changed as well?

There are occurrences of perhaps similar usage of QDropEvent::keyboardModifiers
in:
app/dragdrop/albumdragdrop.cpp
app/dragdrop/imagedragdrop.cpp
app/dragdrop/importdragdrop.cpp
app/dragdrop/tagdragdrop.cpp
Not sure if the behavior of QDropEvent::keyboardModifiers is the same as
QApplication::keyboardModifiers(). If it is, then that should perhaps be
changed as well?

If you'd like, I can implement the changes above and test is?


I've have been using this patch locally on my machine for 7 months. I have not
seen any keyboard side effects due to this patch (with and without the Wacom
device connected).

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381319

--- Comment #3 from [hidden email] ---
yes, you can create a new patch with these code sections modified. Modify each
section step by step and check if no regression appear with a classic keyboard.

Which Qt version do you use to compile digiKam ?

Note : patch must be created against git/master code, not against a release
tarball, to simplify integration in repository.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381319

--- Comment #4 from Kristian Karl <[hidden email]> ---
Ok, I will do that.

I'm  using qt version 5.7.1

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=381319

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Usability-Shortcuts

--
You are receiving this mail because:
You are the assignee for the bug.