[digikam] [Bug 379526] New: Inconsistent separator use in mime setup

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379526

            Bug ID: 379526
           Summary: Inconsistent separator use in mime setup
           Product: digikam
           Version: 5.6.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: setup
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Created attachment 105353
  --> https://bugs.kde.org/attachment.cgi?id=105353&action=edit
Separate extesions on both spaces and semicolons in mime setup

The test in the GUI for the mime setup says, that one should use spaces to
separate extensions. The actual parsing function accepts either semicolons or
spaces (but not both). When the input fields are populated from database, the
extensions are separated by semicolons.

This can lead to the following problem:
1. Existing extensions: "ex1;ex2"
2. Add new extension separated by space as told: "ex1;ex2 ex3"

Result:
This is parsed to the extensions "ex1" and "ex2 ex3".

Expected:
Recognise  "ex1", "ex2" and "ex3" separately.

Patch:
Separate string from user on both spaces and semicolons. Adjust the text in the
GUI to that.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379526

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from [hidden email] ---
Hi Simon,

There is extension of file with space separator ?

I never seen something as "foo.jpg tar.gz". This will not work in source code
which handle files.

I understand well your description ? In my example "jpg tar.gz" is the expected
extension. This is exactly what you want to manage with your patch ?

The scheme for multiple extension is to use dot separator. exemple :
jpg.tar.gz. This one is well supported by Qt de facto.

Gilles

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379526

--- Comment #2 from Simon <[hidden email]> ---
Hi Gilles,

There was a misunderstanding. This is not about "composed" extensions like
".jpg.tar.gz" at all.
This is about a present bug in the mime setup. When you enter "ex1;ex2 ex3" the
internal result is a list containing "ex1" and "ex2 ex3" while it should be
"ex1", "ex2" and "ex3".

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379526

--- Comment #3 from [hidden email] ---
Ah right, it's clear now.

Patch is fine well (:=)))...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379526

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.6.0
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/8a8aeacc954671fe2c52f5
                   |                            |e3672b4566a638d781
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Simon <[hidden email]> ---
Git commit 8a8aeacc954671fe2c52f5e3672b4566a638d781 by Simon Frei.
Committed on 06/05/2017 at 08:01.
Pushed by sfrei into branch 'master'.

Handle both semicolon and spaces in mime setup and use colored mime icons
FIXED-IN: 5.6.0

M  +2    -2    NEWS
M  +14   -5    libs/database/coredb/coredb.cpp
M  +7    -6    utilities/setup/album/setupmime.cpp

https://commits.kde.org/digikam/8a8aeacc954671fe2c52f5e3672b4566a638d781

--
You are receiving this mail because:
You are the assignee for the bug.