[digikam] [Bug 379402] New: Reuse filter settings after adding geolocation information [patch]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379402

            Bug ID: 379402
           Summary: Reuse filter settings after adding geolocation
                    information [patch]
           Product: digikam
           Version: 5.6.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Geolocation-Editor
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Created attachment 105295
  --> https://bugs.kde.org/attachment.cgi?id=105295&action=edit
Patch to reuse filter settings after using the geolocation editor

I'm currently adding geolocations to my complete image library using the
following workflow:

-enable filter "Images without coordinates", to see which images don't provide
geolocation information
-select images and apply Geotags using the Geolocation-Editor (Ctrl+Shift+G)

With the current version of digiKam there are some small issues with that
workflow:

1. In the Geolocation-Editor one always has to press "Apply", then wait for
completing the write process to the images, then click "Close"
-> IMHO it is more convenient if the "Apply" function does its work and then
closes the dialog to continue processing, otherwise one can press "Cancel" to
close the dialog without applying changes

2. After applying the tags to the images they are still visible, even the
filter "Images without coordinates" is set
-> the patch adds a signal/slot connection to call the refreshFilter() function
so that only the images with the current filter settings are displayed

This is my first contribution to digiKam (and to open source projects in
general too) so just tell me if there is something completely wrong :)

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379402

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from [hidden email] ---
Thanks for you patch. We will review your patch soon...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379402

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Simon <[hidden email]> ---
*** Bug 380328 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379402

--- Comment #3 from wildcowboy <[hidden email]> ---
I want this. How can I install it?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=379402

--- Comment #4 from [hidden email] ---
wildcowboy,

the patch, as all patch in fact must be applied to source code and whole
digiKam recompiled/installed.

This require a complete compilation env, including compiler, linker, and shared
libraries.

Under Linux it's not too much complicated. All digiKam dependencies will be
available de facto. The list is given here :

https://cgit.kde.org/digikam-software-compilation.git/tree/DEPENDENCIES

The basis to checkout all code is given here :

https://cgit.kde.org/digikam-software-compilation.git/tree/README

As you don't need a developer account to apply a patch (or create one), you can
use the read only git repository. So typically it will be simplified as below :

git clone git://anongit.kde.org/digikam-software-compilation.git

.. and later run "download-repos" script.

All the code will be downloaded from git server.

After that you need to configure use the "bootstrap.linux" script and fix
unresolved dependencies.

When it's done, go to "build" directory and compile whole code with "make"
If you have a multicore CPU "make -jxx" with xx the number of CPU to use will
reduce a lots the compilation time.

When it's done. apply the patch with the "patch -p1 < blabla.diff" command, in
core sub-directory.

Recompile digikam with make in build directory.

Switch as root and run "make install/fast" in "build directory. Now digiKam is
installed with patch on your system.
This will overwrite the current version. So i recommend to use a cleaned VM
dedicated for that.

Voilà

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.