[digikam] [Bug 376438] New: Several i18n and RTL-layout issues

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376438

            Bug ID: 376438
           Summary: Several i18n and RTL-layout issues
           Product: digikam
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

I found out several i18n issues, I'm not sure what is the best way to solve
them, that's why I didn't post a PR directly.
I'll keep adding issues if I found more.

1.
https://cgit.kde.org/digikam.git/tree/utilities/assistants/firstrun/welcomepage.cpp#n55
This line breaks the i18n function, as it can't get the localized version for
Linux (it does not exist!).
2. Plural:
https://cgit.kde.org/digikam.git/tree/utilities/geolocation/editor/correlator/gpscorrelatorwidget.cpp#n601
3. Plural:
https://cgit.kde.org/digikam.git/tree/utilities/geolocation/editor/reversegeocoding/rgwidget.cpp#n942
4. https://cgit.kde.org/digikam.git/tree/data/about/main.html#n55
The picture metadata are not translatable.
5. I think the order of placeholders are swapped here:
https://cgit.kde.org/digikam.git/tree/app/main/digikamapp.cpp#n1580
and maybe here as well:
https://cgit.kde.org/digikam.git/tree/utilities/importui/main/importui.cpp#n2362

Now there are several RTL layout issues:
1. The welcome page view doesn't support RTL layout. I think adding dir="%1" in
html tag of digikam/about/main.html, and then replace it with "rtl" for RTL
layouts and "ltr" for LTR layouts in
https://cgit.kde.org/digikam.git/tree/app/views/welcomepageview.cpp#n179 will
solve it.
CSS file is fine.
2. Tooltips that appears when hovering icons in views aren't in RTL layout.
Screenshot: http://i.imgur.com/v3FWGGB.png
3. LTR text in panes are left-aligned, which is not good at all. Screenshot:
http://i.imgur.com/RBZbkpS.png
The rating stars are left-aligned as well. Pure numbers are left-aligned. Same
goes for the tooltips.
4. Last for now is the splash screen. The most important problem is the
overlapping text (status and version). If the splash screen could be mirrored
it will be really good (not important for now, but should be ignored).
Screenshot: http://i.imgur.com/fx0Mi7n.png
The slogan shouldn't be right-aligned unless the whole layout is RTL, as it
will look very wired.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376438

--- Comment #1 from [hidden email] ---
Git commit 0b47db718258add4058584cbeb056bea3d0aadf6 by Gilles Caulier.
Committed on 13/02/2017 at 19:55.
Pushed by cgilles into branch 'master'.

point 1/ fixed

M  +34   -31   utilities/assistants/firstrun/welcomepage.cpp
M  +1    -1    utilities/assistants/firstrun/welcomepage.h

https://commits.kde.org/digikam/0b47db718258add4058584cbeb056bea3d0aadf6

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376438

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Usability
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376438

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Usability-i18n

--
You are receiving this mail because:
You are the assignee for the bug.