[digikam] [Bug 375408] New: Don't change context menu shortcut keys in single vs. multiple image context menus

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

            Bug ID: 375408
           Summary: Don't change context menu shortcut keys in single vs.
                    multiple image context menus
           Product: digikam
           Version: 5.5.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Usability
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Goal: tag images fast, using the keyboard

Workflow: "right click" (I actually use the keyboard combination that brings up
the context menu, Fn+Print Screen) an image or select multiple images bring up
the context menu, then continue using the keyboard to navigate in the menu and
tag.

The problem is that if one image is selected, the shortcut for "Assign Tag" is
"i". If multiple images are selected, the shortcut is "s".

Can we have the same shortcut, to help form muscle memory?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from [hidden email] ---
Not reproducible here with AppImage 5.5.0. In both cases, 'A' is always the
shortcut from context menu for this action.

Desktop : plasma5

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

Wolfgang Scheffner <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Wolfgang Scheffner <[hidden email]> ---
In Configure Shortcuts... I found Assign Tag with T as shortcut which is wrong.
T is More Tags... and opens the Tags tree in the Captions tab of the Right
Sidebar. Icon is also wrong, it is the one for Add Tag. All this is default.
Should be corrected IMHO since one cannot even correct it by himself in
Configure Shortcuts...

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

--- Comment #3 from Dan Dascalescu <[hidden email]> ---
Created attachment 103589
  --> https://bugs.kde.org/attachment.cgi?id=103589&action=edit
One image -> "i"

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

--- Comment #4 from Dan Dascalescu <[hidden email]> ---
Created attachment 103590
  --> https://bugs.kde.org/attachment.cgi?id=103590&action=edit
Two images -> "s"

KDE probably assigns shortcuts automatically, and when only one image is
selected, there's an additional menu entry, "Set as Album Thumbnail", which
takes "S", so "Assign" gets the next available letter, "i". ("A" is taken by
"Add to Light Table").

--
You are receiving this mail because:
You are the assignee for the bug.

[Simon Frei]

It is QT who does this automatically (unless specified, but I think we
don't do that). The difference between your screenshot and my context
menu is, that there is an entry called "Place onto Light Table" and in
yours it is "Add to Light Table", which takes up "A" in your case. What
kind of digikam install do you use?

On 22/01/17 19:32, Dan Dascalescu wrote:

> https://bugs.kde.org/show_bug.cgi?id=375408
>
> --- Comment #4 from Dan Dascalescu <[hidden email]> ---
> Created attachment 103590
>   --> https://bugs.kde.org/attachment.cgi?id=103590&action=edit
> Two images -> "s"
>
> KDE probably assigns shortcuts automatically, and when only one image is
> selected, there's an additional menu entry, "Set as Album Thumbnail", which
> takes "S", so "Assign" gets the next available letter, "i". ("A" is taken by
> "Add to Light Table").
>

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

--- Comment #5 from Simon <[hidden email]> ---
It is QT who does this automatically (unless specified, but I think we
don't do that). The difference between your screenshot and my context
menu is, that there is an entry called "Place onto Light Table" and in
yours it is "Add to Light Table", which takes up "A" in your case. What
kind of digikam install do you use?

On 22/01/17 19:32, Dan Dascalescu wrote:

> https://bugs.kde.org/show_bug.cgi?id=375408
>
> --- Comment #4 from Dan Dascalescu <[hidden email]> ---
> Created attachment 103590
>   --> https://bugs.kde.org/attachment.cgi?id=103590&action=edit
> Two images -> "s"
>
> KDE probably assigns shortcuts automatically, and when only one image is
> selected, there's an additional menu entry, "Set as Album Thumbnail", which
> takes "S", so "Assign" gets the next available letter, "i". ("A" is taken by
> "Add to Light Table").
>

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

--- Comment #6 from Dan Dascalescu <[hidden email]> ---
I use the 5.5.0 appimage, but if QT assigns shortcuts automatically, that is a
problem, i.e. consistent shortcuts won't be guaranteed as new menu options are
added.

Is there a way to "pin" some of the shortcuts (the most important or commonly
used ones) and let QT generate accelerators for the others?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

--- Comment #7 from [hidden email] ---
The way to assign key shorcuts in menu actions (contextual or not), is to use
'&' prefix beofre the right key.

Ex : "Add to &Light Table" ==> key is 'L'

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.5.0
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/be046aaa7769385c5c684a
                   |                            |f9aa8edc730410ddce
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from [hidden email] ---
Git commit be046aaa7769385c5c684af9aa8edc730410ddce by Gilles Caulier.
Committed on 23/01/2017 at 12:16.
Pushed by cgilles into branch 'master'.

add default key shortcuts to assign/remove labels/tags
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +3    -3    app/utils/contextmenuhelper.cpp

https://commits.kde.org/digikam/be046aaa7769385c5c684af9aa8edc730410ddce

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=375408

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Usability-Shortcuts

--
You are receiving this mail because:
You are the assignee for the bug.