[digikam] [Bug 374470] New: Deleted tags are not removed from file metadata

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374470

            Bug ID: 374470
           Summary: Deleted tags are not removed from file metadata
           Product: digikam
           Version: 5.4.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Tags
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Steps to reproduce:
1. Enable writing image tags to metadata (either with or without lazy sync).
2. Create a tag and apply it to one file.
3. Delete this tag in the right tag sidebar.
4. Confirm the prompt warning that this tag is assigned to one item.
5. Reread metadata from file.

Expected results:
The deleted tag stays deleted.

Actual results:
The deleted tag is resurrected and shown as applied to the test image.

This is not https://bugs.kde.org/show_bug.cgi?id=361378 as the tag is correctly
removed from the file when it is explicitly removed for just that file. This
only occurs on deletion of the tag itself.

The documentation states:
    You can delete a tag by right-clicking on the tag you want to delete and
    selecting Delete Tag. When you delete a tag, the photographs themselves are
    not deleted. Simply the tag is removed from those photographs.

This is currently only true for the database, not for the image metadata.

--
You are receiving this mail because:
You are the assignee for the bug.

[Simon Frei]

Can someone please confirm that the behaviour described earlier and in
documentation is indeed the intended behaviour?
I just want to make that sure before I look into it.

In short: Tags should be removed from file metadata when the tag itself
is deleted.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374470

--- Comment #1 from Simon <[hidden email]> ---
Can someone please confirm that the behaviour described earlier and in
documentation is indeed the intended behaviour?
I just want to make that sure before I look into it.

In short: Tags should be removed from file metadata when the tag itself
is deleted.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374470

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Mario Frank <[hidden email]> ---
Hey Simon,

I will take a look at the code. There are some spots in digikam where the
deletion of some structure dies not lead to the deletion of related opposing to
the intuition or documentation.

But can you first check if the tag is deletion from metadata if you sync the
metadata to file?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374470

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from [hidden email] ---
Mario, Frank,

The Metadata workflow is complex and relevant of multiple classes in digiKam,
mostly hosted in core/libs/dmetadata. The class which do the stuff to route
metadata from/to image/database is basically MetadataHub. But it's not the only
this one.

For 5.0.0 we introduce a new Advanced Settings panel written by a GoSC student.
The goal was to make a wrapper for all metadata tags to populate DB and forward
later to image file.

For this component, which goal MetadataHub workflow, the first implementation
was not enough and a second GoSC with the same student was planed, but for
personal reasons, the student was not able to work one year more.

He left a very good documentation explaining the first work completed and the
second one not yet done. I will share this doc through GDoc.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.