[digikam] [Bug 374450] New: DATA LOSS: Saving a file can overwrite other file

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

            Bug ID: 374450
           Summary: DATA LOSS: Saving a file can overwrite other file
           Product: digikam
           Version: 5.3.0
          Platform: Archlinux Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: NOR
         Component: showfoto
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

Steps to reproduce:
1. Open folder with photos using the "open folder" button.
2. Select a photo to edit by double-clicking on it in the thumbbar.
3. Make some edit to the photo.
4. Select another photo in the thumbbar, single click only.
5. Click "Save".

The problem is that the modified photo is now written to the filename of the
current selection in the thumbbar, overwriting the contents of that file. I
assume this is not the intended function, at least I found it very unexpected.
This happened to me several times, each time I noticed the data loss I restored
the overwritten photo from backup and continued editing other photos. Then it
happened again, and again. Took me a long time to understand what was going on.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Maik Qualmann <[hidden email]> ---
This problem has been fixed some time ago. I can not reproduce it.

Please check with current universal AppImage Linux bundle available here :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

--- Comment #2 from Simon Persson <[hidden email]> ---
I have now upgraded my installation to version 5.4.0 and the behaviour has not
changed, still a problem.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

--- Comment #3 from Maik Qualmann <[hidden email]> ---
Gilles,

can you reproduce this problem?

Simon,

is displayed the correct filename for saving in the dialog?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from [hidden email] ---
Maik,

It's not reproducible here. Right file name is printed in messagebox.

Note that versionning feature is disabled in this case to check this file.
Enabling versionning give another messagebox. As a new file is created the
problem do not exist in ths case.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

--- Comment #5 from [hidden email] ---
Maik,

I want to report more details : When message box appear, a confirmation appear
after to press Save button. This confirmation dialog ask if i'm sure to
overwrite the file. The file name printed is the right one also. If i confirm,
the right file is overwritten.

digiKam 5.5.0 from git/master

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #6 from [hidden email] ---
Maik,

I confirm this bug now.

Look well the report : it's about Showfoto, not DK image editor. The behavior
is completely different. Dysfunction is quickly reproducible. When switching
from on icon thumbnail to another one, no messagebox is displayed.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Yes, I know it's about showFoto. But a message box is only displayed if the
image was also changed and choose a different image in the thumbbar. It is not
reproducible here, even when changing the image with the keys. Can someone
create a screencast?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

--- Comment #8 from [hidden email] ---
Maik,

Screencast of the dysfucntion :

https://drive.google.com/open?id=0BzeiVr-byqt5ZTF2czRRRmhjQ28

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

--- Comment #9 from Maik Qualmann <[hidden email]> ---
It almost looks as if the correct image is not loaded. The error message when
trying to save the RAW is correct. But why not a messagebox??? Here's my
screencast:

https://drive.google.com/file/d/0ByXDEhL2xmagOHhfVmZIMjFBaGc/view

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

--- Comment #10 from [hidden email] ---
Maik,

Create a new fresh account and start Showfoto. It's reproducible ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374450

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.5.0
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/adef76d645d9ec1bac093f
                   |                            |e4cf46e151eeff8572
             Status|CONFIRMED                   |RESOLVED

--- Comment #11 from Maik Qualmann <[hidden email]> ---
Git commit adef76d645d9ec1bac093fe4cf46e151eeff8572 by Maik Qualmann.
Committed on 10/02/2017 at 22:26.
Pushed by mqualmann into branch 'master'.

this must fix the possible wrong save url
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +4    -7    showfoto/main/showfoto.cpp

https://commits.kde.org/digikam/adef76d645d9ec1bac093fe4cf46e151eeff8572

--
You are receiving this mail because:
You are the assignee for the bug.