[digikam] [Bug 369517] New: Digikam from 5.2.0 tarball installs libvkontakte translations even if libvkontakte is disabled

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369517

            Bug ID: 369517
           Summary: Digikam from 5.2.0 tarball installs libvkontakte
                    translations even if libvkontakte is disabled
           Product: digikam
           Version: 5.2.0
          Platform: openSUSE RPMs
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

As the summary says, this showed up during package review at openSUSE:

[  563s] -- Compilation configuration for: digikam-software-collection
[....]
[  563s] -- Local shared libkvkontakte will be compiled.... NO

But afterwards, during build stage:

[  852s] [  8%] Generating libkvkontakte.gmo
[  852s] cd /home/abuild/rpmbuild/BUILD/digikam-5.2.0/po/bs && /usr/bin/msgfmt
-o /home/abuild/rpmbuild/BUILD/digikam-5.2.0/build/po/bs/libkvkontakte.gmo
/home/abuild/rpmbuild/BUILD/digikam-5.2.0/po/bs/libkvkontakte.po

And later on:

[ 7826s] -- Installing:
/home/abuild/rpmbuild/BUILDROOT/digikam-5.2.0-157.1.x86_64/usr/share/locale/es/LC_MESSAGES/libkvkontakte.mo

(example for one file).

Translations from disabled components should not be installed, IMO. Unless of
course, they're still used somewhere else.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369517

Antonio Rojas <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Antonio Rojas <[hidden email]> ---
This is the only way to get libkvkontakte translations currently, since there
is no tarball available, so one has to compile it from git which doesn't
contain translations.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369517

--- Comment #2 from Luca Beltrame <[hidden email]> ---
The problem is not the presence of the translations, but the fact that they're
installed even if the bulding of the library is disabled. It shouldn't install
/ generate them if disabled (they are not going to be used).

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369517

--- Comment #3 from Antonio Rojas <[hidden email]> ---
(In reply to Luca Beltrame from comment #2)
> The problem is not the presence of the translations, but the fact that
> they're installed even if the bulding of the library is disabled. It
> shouldn't install / generate them if disabled (they are not going to be
> used).

Sure, I was speaking of the case where you build it against an already
installed libkvkontakte (such as for distro packaging)

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369517

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.3.0
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/scra
                   |                            |tch/mwiesweg/digikam-sc/e07
                   |                            |683db9d5aeab135970f475929af
                   |                            |d508764bfb

--- Comment #4 from [hidden email] ---
Git commit e07683db9d5aeab135970f475929afd508764bfb by Gilles Caulier.
Committed on 02/10/2016 at 19:48.
Pushed by cgilles into branch 'master'.

add new options in Ruby script to handle CMake configuration with i18n
extraction.
If digiKam, or Kipiplugins, or libkvkontake is enabled or disabled, relevant
.po
files are extracted from subversion server.
FIXED-IN: 5.3.0

M  +13   -1    CMakeLists.txt
M  +2    -2    bootstrap.linux
M  +3    -5    project/release/fetch_l10n_doc.rb
M  +91   -38   project/release/fetch_l10n_po.rb

http://commits.kde.org/scratch/mwiesweg/digikam-sc/e07683db9d5aeab135970f475929afd508764bfb

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369517

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Portability
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=369517

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Portability                 |Bundle-Tarball

--
You are receiving this mail because:
You are the assignee for the bug.