[digikam] [Bug 366558] New: Face detection does not honour album selection in options

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

            Bug ID: 366558
           Summary: Face detection does not honour album selection in
                    options
           Product: digikam
           Version: 5.0.0
          Platform: Kubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Faces-Management
          Assignee: [hidden email]
          Reporter: [hidden email]

Even if you choose the albums on which face detection should be done, it always
works on the entire collection.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Maik Qualmann <[hidden email]> ---
The problem is not to reproduce. Do you have the inclusion of keywords
disabled?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

--- Comment #2 from Stefano <[hidden email]> ---
I have the "all tags" ticked.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from [hidden email] ---
And do you use Group photos feature ? Its know that count of items is wrong
when items are grouped...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

--- Comment #4 from Stefano <[hidden email]> ---
No, I'm not using that.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

--- Comment #5 from Maik Qualmann <[hidden email]> ---
The counter differs, when more than one face is detected per image. I do not
really see it as a problem.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Oh, wrong thread of Comments 5...

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from [hidden email] ---
Thanks for reporting this, I already reported it two years ago but we did not
find a solution last time. I tried again with digikam 5.1 to reproduce:

- Clearing digikam.db and adding a rather small album with 100 images in it
selection works for face recognition without problems
- Adding a big album (i.e. my 2016) album with 5000 images in it triggers the
problem again.

Some photos in the 2016 are grouped.

Any hints where I can add some debug statements in the code or do I rather
build a complete debug version at the weekend?

One additional thing: The "Unknown" tag for unknown faces is always a sub tag
in one of my tag groups, is this a bug that should be reported? Like this:

- Family
- - Unknown
- - Person1
- - Person2

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

--- Comment #8 from [hidden email] ---
Good evening,
took me two years and I know now how to use the Qt Creator debugger, so here is
the solution at least for my problem:

I thought that selecting the "all tags" box selects which _people/faces_ should
be recognized in the images that are being searched, as in my albums all tags
belong to people. Instead, selecting tags expands the list of images that is
going to be searched. This is why it looked like digikam searched all albums
regardless of album selection on my machine, as most albums contain some tags.

The interface makes totally sense from your point of view, but I hope you
understand the problem which at least I had with the album selection.

Maybe the default for the tag list should unchecked, as selection "all albums"
automatically includes all tags.

Keep up the good work, I am going to tag some faces.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

--- Comment #9 from Stefano <[hidden email]> ---
You mean that it's an "or" selection? That's not very intuitive to me, it
should be better explained in the UI.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christian.carrouge@wanadoo.
                   |                            |fr

--- Comment #10 from [hidden email] ---
*** Bug 367844 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/42ccb101aeb7c3ed79dd41d
                   |                            |0d10a8f67a53883e2
   Version Fixed In|                            |5.2.0
         Resolution|---                         |FIXED

--- Comment #11 from [hidden email] ---
Git commit 42ccb101aeb7c3ed79dd41d0d10a8f67a53883e2 by Gilles Caulier.
Committed on 14/09/2016 at 20:23.
Pushed by cgilles into branch 'master'.

make the album selection widget exclusive with album type : PAlbum or TAlbum
(not and operator).
This will prevent to scan a selection of PAlbum when TAlbum are selected.
Related: bug 335013, bug 334183
FIXED-IN: 5.2.0

M  +3    -0    NEWS
M  +103  -29   libs/album/albumselectors.cpp
M  +9    -0    libs/album/albumselectors.h

http://commits.kde.org/digikam/42ccb101aeb7c3ed79dd41d0d10a8f67a53883e2

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=366558

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Faces-Engine                |Faces-Detection

--
You are receiving this mail because:
You are the assignee for the bug.