[digikam] [Bug 361047] New: Wishlist: make grouped images more prominently visible [MOCKUP]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

            Bug ID: 361047
           Summary: Wishlist: make grouped images more prominently visible
                    [MOCKUP]
           Product: digikam
           Version: 4.14.0
          Platform: Ubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Usability
          Assignee: [hidden email]
          Reporter: [hidden email]

Hello,

I have three requests regarding grouped images. Maybe they can make it into
5.0.

1. Display a different kind of border around grouped images so it is at once
visible that there are multiple images "behind" the displayed one. Also, when
opened, maybe the group can be visualized by using a different background
color. See attachment.
2. In a set of grouped images, make it possible to choose which image is the
visible thumbnail, i.e. "at the top".
3. When a group is closed, and the front image's properties are modified, apply
the changes to all grouped images *unless* this would overwrite previous
settings (perhaps with a confirmation dialog).
4.

What do you think?

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #1 from Jens B. Benecke <[hidden email]> ---
Created attachment 98114
  --> https://bugs.kde.org/attachment.cgi?id=98114&action=edit
mockup to better recognize groups of images

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from [hidden email] ---
This idea is EXCELENT. I search a lots a visual solution to show grouped
images. The current icon was the only way to do it, and i agree that usability
is not very good.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #3 from Jens B. Benecke <[hidden email]> ---
Thank you! :-)

I'd be happy to create a border / backdrop for grouped images, I'll be happy to
do it - just tell me what formats you need (probably SVG to zoom it, or are you
going to draw it in software?).

IMHO: The colored background for expanded groups should be very slight and
adhere to the theme that is currently set in KDE.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #4 from [hidden email] ---
Jens,

The thumb-view rendering do not use SVG like way to render thumbnail borders.
The GUI is hardcoded in source code using Qt5 API. It's not very complicated in
fact. Dolphin and Gwenview do the same as i know.

If you want to take a look in source code, the frame around thumb image for all
icon view (Album GUI, LT, Import tool) is coded here :

https://quickgit.kde.org/?p=digikam.git&a=blob&h=63042b56f064c47195074fe2b66692091a87ff27&hb=16dc3a9b055931dbb84a2d29f3a0a901bebbc812&f=libs%2Fwidgets%2Fitemview%2Fditemdelegate.cpp

Line 90, the item view delegate which render thumb in customized way , call a
method named generateFuzzyRect(), in case of the border pixamp is not yet
stored in cache mecanism, to prevent hang up while icon view rendering. This
method is available here :

https://quickgit.kde.org/?p=digikam.git&a=blob&h=21d42a66a15e53d83056de0ded70108e747ba9b4&hb=16dc3a9b055931dbb84a2d29f3a0a901bebbc812&f=libs%2Fwidgets%2Fmainview%2Fthumbbardock.cpp

... at line 239. This is the hard coded implementation to draw fuzzy border
around thumb image, for each icon view item.

A new method named generateFuzzyRectForGroup() must be written here to render a
new border in case of grouped image. The switch between generateFuzzyRect()
generateFuzzyRectForGroup() will be done on top level class if the properties
hasGroup is turn on or off accordingly with DB properties.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #5 from Jens B. Benecke <[hidden email]> ---
I have looked into the source but I'm not good enough in C++ to do the actual
programming. Sorry ... What I did in GIMP was to copy the current thumbnail
border and clone it rotated around the image center three times -10°, 5°, and
10°. Then combine the resulting images.

Of course, the perfect solution ;) would be to display the actual thumbnails of
the "other" grouped images so their borders are a little visible (much brighter
than default so the front image is still prominent) - but I don't think this is
really necessary for a start.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mohammed.ahmed.anwer@gmail.
                   |                            |com

--- Comment #6 from [hidden email] ---
Hi Mohamed and Omar,

I identify better where the code must be patched exactly :

https://quickgit.kde.org/?p=digikam.git&a=blob&h=35b917742c0a0eee08c453f0235190c87404b403&hb=f6e0fba7025fbbe5f9cd1d4fc8b16f88a5d0928e&f=libs%2Fwidgets%2Fitemview%2Fitemviewimagedelegate.cpp

In this implementation, the method ItemViewImageDelegate::drawThumbnail() from
the icon-view model is used by view class to draw the border over the
thumbnail.

The border pixmap is get through the call.

QPixmap borderPix = thumbnailBorderPixmap(actualPixmapRect.size());

This model class don't know if it's a grouped item or not. The view class know
this property. For ex, to draw the grouped icon, we call from view class the
method in the model  : ItemViewImageDelegate::drawGroupIndicator().

So i propose:

1/ to pass as argument a new bool value to
ItemViewImageDelegate::drawThumbnail() to indicate the grouped properties. This
properties will be get in view class (see how
ItemViewImageDelegate::drawGroupIndicator() is called).

2/ To implement relevant code in ItemViewImageDelegate::drawThumbnail() to draw
grouped frame over the current border pixmap. I'm not sure if additional
rotated border as proposed in this entry will be the best visual solution.
Experimentation is welcome.

Gilles Caulier

-

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #7 from Omar Amin <[hidden email]> ---
Hi Mr Gilles,


I'll look into it during this week, and will finish it by next Friday, Please
let me know if you need it finished earlier.

Regards,
Omar

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #8 from [hidden email] ---
while next week, this will be fine

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #9 from Omar Amin <[hidden email]> ---
Created attachment 98455
  --> https://bugs.kde.org/attachment.cgi?id=98455&action=edit
Group border modification patch

This patch is for grouped images border new background

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #10 from Omar Amin <[hidden email]> ---
Created attachment 98456
  --> https://bugs.kde.org/attachment.cgi?id=98456&action=edit
Screenshot of the new grouped images border

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.14.0                      |5.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Wishlist: make grouped      |Wishlist: make grouped
                   |images more prominently     |images more prominently
                   |visible [MOCKUP]            |visible [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #11 from [hidden email] ---
Thanks Omar for you patch.

1/ code cosmetic :

* Always add a space after a coma, especially  with methods arguments.
* Try to always align code with multi-lines
* Wrap code with bracket after if/else statements, especially with multi-lines.

2/ new border : why the rotated frames are not centered with thumb center ?
It's wanted ? They show more visible on the bottom side.

3/ optimization : these calls to generateFuzzyRect() are time consuming :

+QPixmap ThumbBarDock::generateFuzzyRectForGroup(const QSize& size, const
QColor& color, int radius)
+{
+    // Create two normal borders
+    QPixmap border1 = generateFuzzyRect(size,color,radius);
+    QPixmap border2 = generateFuzzyRect(size,color,radius);

For some thumbnails it's not a problem. But imagine in an album with 100
grouped items ?
Why not yo simply make deep copy of first pixmap ?

4/ Go to Setup/Album-View, and turn on huge thumbnail support for HD screen
(thumbs >256 pixels size). The grouped frame do not work.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #12 from Omar Amin <[hidden email]> ---
Thanks Mr Gilles for the feedback.

I'll make another patch taking into consideration the points you mentioned and
get back to you.

Thanks for your time.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #13 from Jens B. Benecke <[hidden email]> ---
This looks great! Thank you for implementing!

One little request .. can you make the grouped border a little darker? I think
it would be better visible. Or does it depend on the KDE theme?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #14 from [hidden email] ---
Omar,

Did you work on a new patch ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #15 from Omar Amin <[hidden email]> ---
Dear Mr Gilles,

I'm sorry for being late, I'll start today on it, and also tomorrow will be
working on it the whole day, and will send a patch tomorrow max.

Mr Jens, yes for sure i can, I'll also try to do the grouped background color
and get back to you :)

Regards,
Omar

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

Omar Amin <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98456|0                           |1
        is obsolete|                            |

--- Comment #16 from Omar Amin <[hidden email]> ---
Created attachment 98577
  --> https://bugs.kde.org/attachment.cgi?id=98577&action=edit
Thumbnail centred

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #17 from Omar Amin <[hidden email]> ---
Hello,

I've fixed the centring issue for the thumbnail and have attached a sample for
3 different groups, please let me know if you think they're still not
symmetrical.

Regarding the large thumbnail support, I've tried to reproduce this issue on my
PC but couldn't

I tried the following
From Settings->Configure-digiKam --> Album View :
I checked the option --> use large thumbnail size for high screen resolution
and restart digiKam for this option to take effect, but nothing happened

Also from Tools-> Maintenance :
I checked the rebuild thumbnails  and restarted digiKam but nothing happened.

Do I need to have an HD screen for this option to take effect?

I'll still search for the code responsible for handling this issue and get back
to you with the patch once i finish it.

Thank you :)
Omar

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel