[digikam] [Bug 361047] New: Wishlist: make grouped images more prominently visible [MOCKUP]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #18 from [hidden email] ---
HD thumbnails option permit to use largest thumbs (> 256 pixels)

Use silder on statusbar to change icon thumbs size. You can increase it over
256 until 512 .

Note : For me the screenshot look good.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #19 from Mohamed <[hidden email]> ---
Hi,

I tried to adjust the thumbnail size to 512 on my 32" screen, and I see no
problem.

Mohamed Anwer

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #20 from [hidden email] ---
So i'm waiting new patch to review...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

Omar Amin <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98455|0                           |1
        is obsolete|                            |

--- Comment #21 from Omar Amin <[hidden email]> ---
Created attachment 98630
  --> https://bugs.kde.org/attachment.cgi?id=98630&action=edit
Group border modification patch v2

Contains code for centring thumbnail inside new group borders

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #22 from Omar Amin <[hidden email]> ---
Dear Mr Gilles,

I'm sorry for being late, attached the new patch containing the modifications
needed for centring the thumbnail inside the group borders, If we have time I
can work on the other needed modifications (grouped images different background
colour and the darker group border) and get back to you as soon as I finish
them.

Omar

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #23 from [hidden email] ---
The new patch do not work better in HD thumb size.

1/ the frame go outside the icon border.
2/ with black color theme, frame is invisible.
3/ The side-effects are less visible with small thumb size, but are always here
(zoom on the screen near the border frame for ex)

Proposal :

- draw the grouped frame inside the thumbnail, not outside.
- use right color element to dram the frame.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #24 from [hidden email] ---
Screenshot :
https://www.flickr.com/photos/digikam/26086592624/in/dateposted-public/
https://www.flickr.com/photos/digikam/26086592554/in/dateposted-public/

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #25 from [hidden email] ---
Note : LightRoom groupped items is called "Image Stacked". It's explained here
:

http://valeriegoettsch.com/lightroom-grid-view-icons/

Excepted the icon+number of items in the stack, no specify frames is draw.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #26 from Omar Amin <[hidden email]> ---
(In reply to caulier.gilles from comment #25)
> Note : LightRoom groupped items is called "Image Stacked". It's explained
> here :
>
> http://valeriegoettsch.com/lightroom-grid-view-icons/
>
> Excepted the icon+number of items in the stack, no specify frames is draw.
>
> Gilles

Thanks for the feedback.

to start working i just want to make sure that i understood what's required.

In the following image
http://valeriegoettsch.com/wp-content/uploads/badges-diagram.jpg

I'll imitate the following features:
- Stack (stating 1 of 2 -- where 2 is the group images count)
- the virtual copy (do i need to draw the turned corner to indicate visually
that this is a group ?)

in the following image
https://bugs.kde.org/attachment.cgi?id=98577&action=edit
What about the icon in the bottom right on which the number of grouped images
is written ?
should it be removed?

Thank you,
Omar

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #27 from Jens B. Benecke <[hidden email]> ---
Hmmm. I still like iPhoto's visualization of an image "stack" better:
https://www.apple.com/de/mac/iphoto/ (scroll down to the screenshot labeled
"Share.")

It looks less technical, it is easy to spot among many images, and there is
nothing to translate.

Of course a number in the corner indicating the number of images in addition
(!) is also good. :-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #28 from [hidden email] ---
No. The LR screenshot is just to indicate how pro application do the job. It
just informative.

LR do no make better than us... That all.

The information in DK about grouped items is already here and at the right
place. Do not change it.

Just try to make the grouped border frame better, to render it inside the
thumbnails, not outside. The free space outside is too limited and make mistake
visually with large thumbs.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #29 from [hidden email] ---
Also take a care of color theme used with DK. Look in settings menu for
details.

If you render the border frame inside the thumbs, take a care about thumbs
color content.

I think that we must to render a smallest thumb with a largest border in case
of grouped items. This will be the right way to prevent to overload the thumbs
content.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #30 from Omar Amin <[hidden email]> ---
Created attachment 98715
  --> https://bugs.kde.org/attachment.cgi?id=98715&action=edit
stack proposal

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #31 from Omar Amin <[hidden email]> ---
Dear Mr Gilles and Mr Jens,

I made this simple stack just for confirming if that's what we need or not?, i
made it on a separate project to make the compilation quicker, that's why not
all digKam image info is shown nor the borders, it's just for confirming the
view and if that's what's required or not.

I'll still make the turned corner, or did i misunderstood the requirements?

I didn't fully understand what you mean by:

- "I think that we must to render a smallest thumb with a largest border in
case of grouped items"
do you mean that the border will be of different size for different images?
and
"Just try to make the grouped border frame better, to render it inside the
thumbnails, not outside"
how can the rotated frames fit inside the thumbnail?

if you can clarify more that would be perfect.

sorry for inconvenience.

Regards,
Omar

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #32 from Omar Amin <[hidden email]> ---
if we need to use the rotated borders, we can adjust the border for each image
at different thumbnail sizes differently that will make us able to fit the
rotated borders at different thumbnail sizes entirely inside the image
rectangle, the only withdraw for this approach would be it'll show less number
of images per row in the album grid.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #33 from [hidden email] ---
In your stack proposal has the stack icon over the thumb. This one is already
outside the thumb because it's clickable to open/close the stack. If you move
it over the thumb, as the thumb is also clickable, this will not work. So the
icon must still outside the thumb.

The large border in gray delimit a the stack in a more visible way, and it's
more suitable. But a simple large gray border is not enough. We need rotated
border pixmap inside this gray area.

Note about your last patch V2 :

1/
static const int IMAGE_BORDER_RADIUS = 3;
==
const int radius = IMAGE_BORDER_RADIUS;

...is not necessary.

2/ use more CR in you cod. no need to attach all lines together.

3/ No need a cast here :

const_cast<DItemDelegate*>(this)->d->thumbnailBorderCache.insert(cacheKey, new
QPixmap(pix));

d->thumbnailBorderCache.insert(cacheKey, new QPixmap(pix)); must be enough. Do
not try to make JAVA coding style please.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #34 from Omar Amin <[hidden email]> ---
Now i understand the requirements, i'll finish it ASAP and get back to you.

Thanks you
Omar

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #35 from [hidden email] ---
Any progress here ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #36 from Omar Amin <[hidden email]> ---
Created attachment 98937
  --> https://bugs.kde.org/attachment.cgi?id=98937&action=edit
Black background theme, group bordered is filled

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #37 from Omar Amin <[hidden email]> ---
Created attachment 98938
  --> https://bugs.kde.org/attachment.cgi?id=98938&action=edit
progress in ensure the image border doesn't go outside the thumbnail border,
temp solution

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel