[digikam] [Bug 358913] New: After returning from edit mode wrong image is selected, image itself is not updated

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

            Bug ID: 358913
           Summary: After returning from edit mode wrong image is
                    selected, image itself is not updated
           Product: digikam
           Version: 5.0.0
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

After editing image, saving it and closing editor...
1. The image shown in the main window is still the one before edits
2. The image selected on the thumbbar is the image following the edited one
The thumbnail image is actually correctly updated.

I can reproduce it consistently. Additionally, turning the thumbbar off and on
removes current selection.

This may be related to bug 326796, but my pictures are on NTFS partition.

This is on 5.0.0~beta3-wily~ppa1 from philip5's ppa, but I think I've seen it
also on 4.x

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Thumbnails

--- Comment #1 from [hidden email] ---
To identfy and trying to reproduce the problem, can you take a screencast of
you screen when problem occurs ?

Thanks in advance

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #2 from Michal Sylwester <[hidden email]> ---
Created attachment 96976
  --> https://bugs.kde.org/attachment.cgi?id=96976&action=edit
Bug screencast

Note at about 0:10 selection change in thumbbar and image not being updated.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Thumbnails                  |Preview

--- Comment #3 from [hidden email] ---
If i understand the screencast, the problem is about the image preview which is
not updated automatically when editor save changes. Right ?

Thumbnails is updated even.

Perhaps some debug statement are visible on the console during the operations.
Can you copy all console messages here please ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #4 from Michal Sylwester <[hidden email]> ---
The preview is one thing. The thumbnail is updated, but the selection moves to
the next image.
Note at the end I have to click the updated thumbnail to see the updated image.
To actually see the following image (the one selected after 0:10) I have to
first pick a different picture.

It's getting a little wicked, but take a look how the thumbnail selection
changes when I clicked save and it should be pretty obvious.

BTW: I noticed that sometimes the preview does follows the thumbnail, so I see
the correct preview of the next image. It's still the next one, not the edited
one.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #5 from Michal Sylwester <[hidden email]> ---
Created attachment 96978
  --> https://bugs.kde.org/attachment.cgi?id=96978&action=edit
Console output

Only part while saving the image, let me know if you need larger context.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #6 from [hidden email] ---
I suspect that you use versionning with editor. Right ?

If yes, this still reproducible when versionning is disabled ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #7 from Michal Sylwester <[hidden email]> ---
You're right. After disabling versioning everything works as I would expect it:
thumbbar selection does not change, preview is updated.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|After returning from edit   |Using Versionning, after
                   |mode wrong image is         |returning from edit mode
                   |selected, image itself is   |wrong image is selected,
                   |not updated                 |image itself is not updated

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Maik Qualmann <[hidden email]> ---
There is a problem with "scroll current item to center of thumbbar". This
option must be turned on so that the error occurs.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #9 from Maik Qualmann <[hidden email]> ---
Please ignore Comment 8.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #10 from Maik Qualmann <[hidden email]> ---
Created attachment 96996
  --> https://bugs.kde.org/attachment.cgi?id=96996&action=edit
ImageCategorizedView.patch

Workaround for this timing problem. The new image URL is still unknown in the
item view after saving the image.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Using Versionning, after    |Using Versionning, after
                   |returning from edit mode    |returning from edit mode
                   |wrong image is selected,    |wrong image is selected,
                   |image itself is not updated |image itself is not updated
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #11 from [hidden email] ---
Tested here.

As i can see, i cannot reproduce the problem here with this patch...

Michael, if you can confirm on your computer, this will be nice.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #12 from Michal Sylwester <[hidden email]> ---
Sure, I'll give it a try, but not before weekend.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #13 from Michal Sylwester <[hidden email]> ---
I had only time for a quick test so far, but seems to work just as I'd expect
it to work. Thanks!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

--- Comment #14 from Maik Qualmann <[hidden email]> ---
I'm technically not really happy with this workaround. I still look for a
better solution...

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=358913

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/b1319ec3b93ccdfd6a3a265
                   |                            |61a3f0f55e070997e
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |5.0.0

--- Comment #15 from Maik Qualmann <[hidden email]> ---
Git commit b1319ec3b93ccdfd6a3a26561a3f0f55e070997e by Maik Qualmann.
Committed on 08/02/2016 at 20:35.
Pushed by mqualmann into branch 'master'.

fix current item in the icon view selected by the image editor
FIXED-IN: 5.0.0

M  +2    -1    NEWS
M  +1    -1    app/items/digikamimageview.cpp
M  +35   -0    app/items/imagecategorizedview.cpp
M  +5    -0    app/items/imagecategorizedview.h

http://commits.kde.org/digikam/b1319ec3b93ccdfd6a3a26561a3f0f55e070997e

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel