[digikam] [Bug 353331] New: can’t limit fuzzy-search to albums

[sylvain.l.sauvage]

https://bugs.kde.org/show_bug.cgi?id=353331

            Bug ID: 353331
           Summary: can’t limit fuzzy-search to albums
           Product: digikam
           Version: 4.13.0
          Platform: Debian unstable
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Fuzzy Searches
          Assignee: [hidden email]
          Reporter: [hidden email]

When I select a collection to search for duplicates in Fuzzy|Duplicates,
results are limited to the images in the root album of the collection. The
pictures in the other albums of the same collection are not searched/shown.


Reproducible: Always

Steps to Reproduce:
1.Select a collection in the first drop down menu in Fuzzy|Duplicates
2.Search for duplicates
3.

Actual Results:  
Only images in the root album of the selected collection are searched/shown.

Expected Results:  
Images in the other albums of the selected collection should be searched and
shown.

It seems to be similar to https://bugs.kde.org/show_bug.cgi?id=336076 which was
closed in 4.1.0. I’m using 4.13.0 home-compiled on a Debian Sid.

Also, the first checkbox is called “Whole albums collection” but the selection
below presents my collections (not albums). So the checkbox really means “All
collections”, no?

And, yes, there are lots of duplicates in the inner albums of the collection I
select. They are shown if I check the “Whole albums collection” checkbox (I’m
then submerged with pictures of all the collections and their albums). or use
“Find similar” on one of them.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=353331

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Do you use the Maintenance tool ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[sylvain.l.sauvage]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #2 from [hidden email] ---
(In reply to Gilles Caulier from comment #1)
> Do you use the Maintenance tool ?

Not on purpose: its settings are the default ones, that is:
- under Common Options, Whole albums collection and Whole tags collection are
checked,
- every thing else is unchecked.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #3 from Gilles Caulier <[hidden email]> ---
Just to compare, Can you try to run Duplicates Finder from Maintenance tool
with same settings than Fuzzy Searches (Duplicates).

In Maintenance, we have fixed this problem. Perhaps it still present in Fuzzy
view.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[sylvain.l.sauvage]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #4 from [hidden email] ---
(In reply to Gilles Caulier from comment #3)
> Just to compare, Can you try to run Duplicates Finder from Maintenance tool
> with same settings than Fuzzy Searches (Duplicates).

Okay, it works from Maintenance tool, but I have to select each and all
sub-albums (a quick way to select all sub-albums is sorely missing).

> In Maintenance, we have fixed this problem. Perhaps it still present in
> Fuzzy view.

Well, Fuzzy doesn’t present sub-albums, only collections so there is at least
vocabulary and UI problems.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #5 from Gilles Caulier <[hidden email]> ---
To select parent/children albums recursively from somewhere in collection tree
view available in Maintenance tool, through combo box, simply use contextual
menu...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[sylvain.l.sauvage]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #6 from [hidden email] ---
(In reply to Gilles Caulier from comment #5)
> To select parent/children albums recursively from somewhere in collection
> tree view available in Maintenance tool, through combo box, simply use
> contextual menu...

Oh yes! I dumbly didn’t manage to see it. Thanks.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #7 from [hidden email] ---
Sylvain,

Can we considerate this file fixed for last digiKam 5.0.0 ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #8 from [hidden email] ---
(In reply to caulier.gilles from comment #7)
> Can we considerate this file fixed for last digiKam 5.0.0 ?

You do whatever want but if you’re asking me if it now works then the answer is
a big no!

Two local collections.
The combobox still presents them (and only them, not their sub-albums) as two
“albums.”
If I select one, only the root album is selected. And then the search is only
made in the root album.
If I use the context menu, I can add all the children of the selected
collections but I still can’t chose among my albums.
If the children are selected (“453 albums selected” shown), I can’t deselect
them easily: deselecting one collection only deselects the root album of that
collection (“452 albums selected” instead of the expected “255…”).

IOW, that UI is still a mess, nothing changed.
If the only way to search in a selected set of albums is to go through the
maintenance tool, then simply suppress that useless combobox.

To be frank, I’m disappointed with 5.0.0.
The entire UI has not improved.
Half the menus are not translated.
Dialogs are always too small, half the elements are hidden (I don’t have that
problem with my other Qt/KDE apps).
Hiding the menu bar (Ctrl+M or via the menu) doesn’t work: it’s the status bar
that disappear!

I had just compiled digikam 5 to test that bug, I’ll stay with Sid’s 4.14 for
now.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.13.0                      |5.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #9 from [hidden email] ---
Can you reproduce the problem using digiKam Linux AppImage bundle ? The last
bundle is available at this url:

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Mario Frank <[hidden email]> ---
(In reply to sylvain.l.sauvage from comment #8)

> (In reply to caulier.gilles from comment #7)
> > Can we considerate this file fixed for last digiKam 5.0.0 ?
>
> You do whatever want but if you’re asking me if it now works then the answer
> is a big no!
>
> Two local collections.
> The combobox still presents them (and only them, not their sub-albums) as
> two “albums.”
> If I select one, only the root album is selected. And then the search is
> only made in the root album.
> If I use the context menu, I can add all the children of the selected
> collections but I still can’t chose among my albums.
> If the children are selected (“453 albums selected” shown), I can’t deselect
> them easily: deselecting one collection only deselects the root album of
> that collection (“452 albums selected” instead of the expected “255…”).
>
> IOW, that UI is still a mess, nothing changed.
> If the only way to search in a selected set of albums is to go through the
> maintenance tool, then simply suppress that useless combobox.
>
> To be frank, I’m disappointed with 5.0.0.
> The entire UI has not improved.
> Half the menus are not translated.
> Dialogs are always too small, half the elements are hidden (I don’t have
> that problem with my other Qt/KDE apps).
> Hiding the menu bar (Ctrl+M or via the menu) doesn’t work: it’s the status
> bar that disappear!
>
> I had just compiled digikam 5 to test that bug, I’ll stay with Sid’s 4.14
> for now.

Sylvain,

I had the same problem as you had. But I only had one collection. I first
thought it was a bug in my database. But my database was new.
After some time of useless debugging, I found out, that I first have to
double-click on the collection. After doing that, all sub albums of this
collection were shown. So far, so good. I added another collection. In fuzzy
search, the first collection (and its sub-albums were shown). Additionally, I
now had the second collection (but no sub-albums for it). After double-klicking
on it, the sub-albums showed up.

Can you please test this with the current state of digiKam (Gilles wrote the
location)? I tested this with the current state from git.

Perhaps the missing functionality was just not shown prominently.

Cheers,
Mario

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #11 from Mario Frank <[hidden email]> ---
Git commit 5bb8e75151f1a2ca5ade6a8ea7b3c1e349996f54 by Mario Frank.
Committed on 03/04/2017 at 09:16.
Pushed by mfrank into branch 'master'.

Fix some minor glitches in fuzzy search sidebar:
1) In a fresh installation, the root albums in the album selection box in
duplicates search are not automatically expanded.
Though this is no bug (expanding is possible via double-click), we now
automatically expand the root albums to not confuse users.
if nothing was expanded, yet.
2) In duplicates search, the last similarity thresholds are saved. But after
restart, one the range of the max similarity
threshold is 90-100 until the min similarity is changed. This is an ugly
glitch. Fixed that.
3) The computation of the similar images had a glitch when max similarity = min
similarity (e.g. 50%) The results were only
the ones with exactly 50.00 % but not also results with 50.xy as it should be.
Fixed that.
4) The xml structure of the haar search queries for fuzzy and sketch search
were not wellformed (the closing "search" tag was missing)
Related: bug 372972

M  +2    -1    NEWS
M  +3    -0    app/utils/searchmodificationhelper.cpp
M  +24   -7    libs/album/albumtreeview.cpp
M  +7    -1    libs/database/haar/haariface.cpp
M  +1    -1    utilities/fuzzysearch/findduplicatesview.cpp

https://commits.kde.org/digikam/5bb8e75151f1a2ca5ade6a8ea7b3c1e349996f54

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #12 from Mario Frank <[hidden email]> ---
Created attachment 104871
  --> https://bugs.kde.org/attachment.cgi?id=104871&action=edit
New fuzzy sidebar : duplicates search

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #13 from Mario Frank <[hidden email]> ---
Created attachment 104872
  --> https://bugs.kde.org/attachment.cgi?id=104872&action=edit
New fuzzy sidebar : fuzzy image search

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #14 from Mario Frank <[hidden email]> ---
Created attachment 104873
  --> https://bugs.kde.org/attachment.cgi?id=104873&action=edit
New fuzzy sidebar : fuzzy sketch search

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #15 from Mario Frank <[hidden email]> ---
Created attachment 104874
  --> https://bugs.kde.org/attachment.cgi?id=104874&action=edit
Proposed patch for the improvements

This patch adds the following improvements to the fuzzy sidebar:

Duplicates search:
The user can select both tags and albums and apply one of 5 operations to the
selected objects:
- "One of" aka union - Search in the set of images that are either in the
selected tags or albums
- "Both" aka intersection - Search in the set of images that are both in the
selected tags and albums
- "Albums but not tags" aka difference - Search in the set of images that are
in the selected albums but not in the selected tags
- "Tags but not albums" aka difference - Search in the set of images that are
in the selected tags but not in the selected albums
- "Only selected tab" aka obvious - Search in the selected albums, if albums
tab is active and in the selected tags if tags tab is active

Fuzzy image (drop) search:
The user can now restrict the results to be in the specified albums.
Restricting to tags is technically possible but would impose complexity
problems potentially leading to a slower search - depending on the tagging
activities of the user.

Fuzzy sketch search:
The user can now restrict the results to be in the specified albums.
Restricting to tags is technically possible but would impose complexity
problems potentially leading to a slower search - depending on the tagging
activities of the user.

As I work on the current master branch, some texts are not localised.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #16 from [hidden email] ---
I don't test the p

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #17 from [hidden email] ---
I don't tested the patch yet, but the purpose of tab search restriction can be
applied to all place where search on albums/tags can be processed.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104874|0                           |1
        is obsolete|                            |

--- Comment #18 from Mario Frank <[hidden email]> ---
Created attachment 104892
  --> https://bugs.kde.org/attachment.cgi?id=104892&action=edit
Updated patch for improvements

The new patch adds patches for
https://bugs.kde.org/show_bug.cgi?id=183425
and
https://bugs.kde.org/show_bug.cgi?id=300565

--
You are receiving this mail because:
You are the assignee for the bug.