[digikam] [Bug 353331] New: can’t limit fuzzy-search to albums

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104892|0                           |1
        is obsolete|                            |

--- Comment #19 from Mario Frank <[hidden email]> ---
Created attachment 104963
  --> https://bugs.kde.org/attachment.cgi?id=104963&action=edit
Updated patch for improvements

The AlbumSelectors class is also used in face scan. Updated calls to this class
in order to prevent regression bugs in face scan.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|can’t limit fuzzy-search to |can’t limit fuzzy-search to
                   |albums                      |albums [patch]

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #20 from [hidden email] ---
writer.writeField(QLatin1String("noeffect_targetAlbums"), SearchXml::OneOf);
writer.writeValue(targetAlbums);

... why to call "noeffect_targetAlbums" a property which define the target
album to process ? It's ambiguous... Or i miss understand something in your
code ?

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #21 from Mario Frank <[hidden email]> ---
(In reply to caulier.gilles from comment #20)
> writer.writeField(QLatin1String("noeffect_targetAlbums"), SearchXml::OneOf);
> writer.writeValue(targetAlbums);
>
> ... why to call "noeffect_targetAlbums" a property which define the target
> album to process ? It's ambiguous... Or i miss understand something in your
> code ?
>
> Gilles

Hey Gilles,

The field is only set for HAAR search, i.e. fuzzy image and sketch search.
The search can be restricted to only return images if they are in one of the
target folders.
Do you have a better terminus in mind?

Cheers,
Mario

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #22 from [hidden email] ---
Not better terminology for the moment. Just put some comment to clarify it...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #23 from Mario Frank <[hidden email]> ---
(In reply to caulier.gilles from comment #22)
> Not better terminology for the moment. Just put some comment to clarify it...
>
> Gilles

Okay,

I would commit the changes with additional comments.
Is that okay for you?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #104963|0                           |1
        is obsolete|                            |

--- Comment #24 from Mario Frank <[hidden email]> ---
Created attachment 104965
  --> https://bugs.kde.org/attachment.cgi?id=104965&action=edit
Updated patch for improvements

Updated the patch to the current state of the master branch and added some
comments concerning target albums.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #25 from [hidden email] ---
yes fine for me. I test the patch and it sound working fine for me.

I will rebuild the bundles this evening. I recommend to post a message to user
ML to have some feedback with new bundles including last patches. The
possibilies to introduce a

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

--- Comment #26 from [hidden email] ---
yes fine for me. I test the patch and it sound working fine for me.

Or perhaps somebody have discovered a dysfunction with this patch. Any feedback
?

I will rebuild the bundles this evening. I recommend to post a message to user
ML to have some feedback with new bundles including last patches. The
possibilities to introduce a dysfunction is not negligible of course...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/660782be8137d8448ef10e
                   |                            |5e944a2dd213d781cc
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #27 from Mario Frank <[hidden email]> ---
Git commit 660782be8137d8448ef10e5e944a2dd213d781cc by Mario Frank.
Committed on 11/04/2017 at 17:27.
Pushed by mfrank into branch 'master'.

Added an overall improvement of fuzzy, duplicates and extended search.
1) Users can now restrict the results of fuzzy image/drop/sketch search to be
in specific albums.
2) Users can now select both tags and albums in duplicates search and restrict
the set of images in which duplicates are searched with logical operations (in
selected albums or/and tags, in selected albums but not tags and vice versa and
only in
selected objects of current tab)
3) In extended search, the tags selection can also be restricted such that
images must be either tagged with at least one of or with all selected tags.
Related: bug 300565, bug 183425

M  +7    -1    NEWS
M  +31   -3    app/utils/searchmodificationhelper.cpp
M  +11   -0    app/utils/searchmodificationhelper.h
A  +307  -0    libs/album/albumselectioncomponent.cpp     [License: UNKNOWN]  *
A  +121  -0    libs/album/albumselectioncomponent.h     [License: GPL (v2+)]
M  +248  -173  libs/album/albumselectors.cpp
M  +34   -19   libs/album/albumselectors.h
M  +7    -0    libs/database/coredb/coredbsearchxml.cpp
M  +1    -0    libs/database/coredb/coredbsearchxml.h
M  +1    -0    libs/database/dbjobs/dbjob.cpp
M  +11   -0    libs/database/dbjobs/dbjobinfo.cpp
M  +4    -0    libs/database/dbjobs/dbjobinfo.h
M  +119  -30   libs/database/haar/haariface.cpp
M  +30   -8    libs/database/haar/haariface.h
M  +32   -10   libs/database/item/imagelister.cpp
M  +44   -0    libs/database/item/imagequerybuilder.cpp
M  +6    -4    libs/settings/applicationsettings.cpp
M  +3    -0    libs/settings/applicationsettings.h
M  +11   -0    libs/settings/applicationsettings_miscs.cpp
M  +1    -0    libs/settings/applicationsettings_p.cpp
M  +2    -0    libs/settings/applicationsettings_p.h
M  +1    -1    utilities/facemanagement/facescandialog.cpp
M  +69   -22   utilities/fuzzysearch/findduplicatesview.cpp
M  +83   -21   utilities/fuzzysearch/fuzzysearchview.cpp
M  +1    -0    utilities/fuzzysearch/fuzzysearchview.h
M  +6    -1    utilities/maintenance/duplicatesfinder.cpp
M  +1    -1    utilities/maintenance/duplicatesfinder.h
M  +4    -4    utilities/maintenance/maintenancedlg.cpp
M  +2    -1    utilities/maintenance/maintenancemngr.cpp
M  +72   -27   utilities/searchwindow/searchfields.cpp
M  +18   -4    utilities/searchwindow/searchfields.h

The files marked with a * at the end have a non valid license. Please read:
http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are
listed at that page.


https://commits.kde.org/digikam/660782be8137d8448ef10e5e944a2dd213d781cc

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=353331

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.6.0

--
You are receiving this mail because:
You are the assignee for the bug.