[digikam] [Bug 351241] New: Table view shows wrong thumbnails

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=351241

            Bug ID: 351241
           Summary: Table view shows wrong thumbnails
           Product: digikam
           Version: 4.12.0
          Platform: Gentoo Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Albums View
          Assignee: [hidden email]
          Reporter: [hidden email]

Thumbnails when in table view mode are chopped into squares. Why?! Now I can't
tell landscape from portrait.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=351241

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Maik,

I identified where the problem is with this file :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/tableview/tableview_column_thumbnail.cpp#L121

Look like only landscape image sizes are supported, not portrait. Fix will be
easy to do i think...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=351241

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |CONFIRMED

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=351241

--- Comment #2 from Maik Qualmann <[hidden email]> ---
Created attachment 94109
  --> https://bugs.kde.org/attachment.cgi?id=94109&action=edit
tableview.png

I have not yet looked into the source code. But I see no error in the
representation of landscape or portrait photos. See the screenshot.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[DrSlony-4]

https://bugs.kde.org/show_bug.cgi?id=351241

--- Comment #3 from DrSlony <[hidden email]> ---
4.12.0 http://i.imgur.com/k2oo0ka.png

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=351241

--- Comment #4 from Gilles Caulier <[hidden email]> ---
Maik,

To reproduce the problem, play with thumbnail column size of table view and
change thumbnail size with status-bar slider. I can reproduce the problem
described by DrSlony.

Note : create an album with portrait AND landscape images.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=351241

--- Comment #5 from Maik Qualmann <[hidden email]> ---
Created attachment 94137
  --> https://bugs.kde.org/attachment.cgi?id=94137&action=edit
tableviewthumbs.patch

Gilles, please test this patch.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=351241

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Table view shows wrong      |Table view shows wrong
                   |thumbnails                  |thumbnails [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=351241

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Excelent. With this patch, digiKam work like a charm now... Congratulations...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=351241

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94137|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=351241

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Created attachment 94139
  --> https://bugs.kde.org/attachment.cgi?id=94139&action=edit
tableviewthumbs2.patch

Only small code optimization.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=351241

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.13.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/523b4baf62a354c06086d88
                   |                            |25940964efaea0c55
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #8 from Maik Qualmann <[hidden email]> ---
Git commit 523b4baf62a354c06086d8825940964efaea0c55 by Maik Qualmann.
Committed on 20/08/2015 at 18:46.
Pushed by mqualmann into branch 'master'.

apply patch #94139 to correct thumbnails scale in the table view
FIXED-IN: 4.13.0

M  +2    -1    NEWS
M  +6    -12   app/views/tableview/tableview_column_thumbnail.cpp

http://commits.kde.org/digikam/523b4baf62a354c06086d8825940964efaea0c55

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=351241

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Git commit 3084138b072cd51acb27edd4a70aedbeba0ffd9f by Gilles Caulier.
Committed on 20/08/2015 at 20:34.
Pushed by cgilles into branch 'frameworks'.

apply patch #523b4baf62a354c06086d8825940964efaea0c55 from git/master to
frameworks branch

M  +8    -13   app/views/tableview/tableview_column_thumbnail.cpp

http://commits.kde.org/digikam/3084138b072cd51acb27edd4a70aedbeba0ffd9f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=351241

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Albums View                 |Table View

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel