[digikam] [Bug 350541] New: PNG alpha channel is ignored

[Rafael]

https://bugs.kde.org/show_bug.cgi?id=350541

            Bug ID: 350541
           Summary: PNG alpha channel is ignored
           Product: digikam
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Thumbnails
          Assignee: [hidden email]
          Reporter: [hidden email]

When showing thumbnails of PNG with alpha channel to mask areas of picture,
digikam ignore it.

Reproducible: Always

Steps to Reproduce:
1.Create a PNG with alpha channel and save with it
2.Show that PNG thumbnail on digikam


Actual Results:  
Whole PNG picture is showed.

Expected Results:  
Do not show alpha areas from image on thumbnails, like Gwenview does.

User can't distinguish between PNG images with and w/o alpha channel, so he
need to preview it.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=350541

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Which version of digiKam do you use ?

Can you share some PNG images with Alpha ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rafael]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #2 from Rafael <[hidden email]> ---
Sorry for the delay.

digikam 4.11.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rafael]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #3 from Rafael <[hidden email]> ---
Created attachment 93810
  --> https://bugs.kde.org/attachment.cgi?id=93810&action=edit
Our friend

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rafael]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #4 from Rafael <[hidden email]> ---
Created attachment 93811
  --> https://bugs.kde.org/attachment.cgi?id=93811&action=edit
Colour dices

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rafael]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #5 from Rafael <[hidden email]> ---
Created attachment 93812
  --> https://bugs.kde.org/attachment.cgi?id=93812&action=edit
A good example with levels of opacity

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=350541

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |4.11.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=350541

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Maik Qualmann <[hidden email]> ---
Created attachment 93823
  --> https://bugs.kde.org/attachment.cgi?id=93823&action=edit
alphathumbs.png

DigiKam used as well as Dolphin a white background. Gwenview uses the
background color. I think it is not difficult to change this, but somehow I
find the white background better. What do you think Gilles?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #7 from Gilles Caulier <[hidden email]> ---
yes the code relevant is in icon-view model-view.

Internally, we use PGF to store thumbs. PGF support Alpha, so, it's not a
problem in this side. Look in core/libs/threadimageio/pgfutils.cpp to be sure.
There are code PGF <->QImage conversion. DB store PGF as RAW data.

In core/tests, there is also a CLI tool to check PGF conversion with image
samples.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rafael Linux]

https://bugs.kde.org/show_bug.cgi?id=350541

Rafael <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Rafael <[hidden email]> ---
Hi Maik

From a photographer/designer viewpoint, we need to distinguish at a glance
alpha masked images from not alpha masked (cause digikam can't distinguish one
from each other in a search).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #9 from Maik Qualmann <[hidden email]> ---
Created attachment 93881
  --> https://bugs.kde.org/attachment.cgi?id=93881&action=edit
checkerboard.png

Hi Rafael

Depending on the color scheme, we have different background colors. What do you
think over the checkerboard in the background, as in the screenshot?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rafael]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #10 from Rafael <[hidden email]> ---
I think is a perfect way to show the thumbs, cause you can see if the object is
or is not centered.

;)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #11 from Maik Qualmann <[hidden email]> ---
Created attachment 93918
  --> https://bugs.kde.org/attachment.cgi?id=93918&action=edit
checkerboard2.png

I once made a brighter checkerboard. What is better?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #12 from Maik Qualmann <[hidden email]> ---
Created attachment 93919
  --> https://bugs.kde.org/attachment.cgi?id=93919&action=edit
checkerboard.patch

Here is the patch for the checkerboard.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=350541

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|PNG alpha channel is        |PNG alpha channel is
                   |ignored                     |ignored [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rafael]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #13 from Rafael <[hidden email]> ---
I think that bright is perfect.

Thank you. Finally I will not need to open each PNG file to see how it will be
showed.

;)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=350541

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/b6ef05138531969b771bff5
                   |                            |9e750aa82340dd268
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.13.0

--- Comment #14 from Maik Qualmann <[hidden email]> ---
Git commit b6ef05138531969b771bff59e750aa82340dd268 by Maik Qualmann.
Committed on 08/08/2015 at 16:50.
Pushed by mqualmann into branch 'master'.

has the thumbnail a alpha channel, is a checkerboard background used
FIXED-IN: 4.13.0

M  +2    -1    NEWS
M  +10   -1    libs/threadimageio/thumbnailcreator.cpp

http://commits.kde.org/digikam/b6ef05138531969b771bff59e750aa82340dd268

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=350541

--- Comment #15 from Maik Qualmann <[hidden email]> ---
Git commit 80f5fa781ddcf3e9033f0ef405d0834a0b74ffe0 by Maik Qualmann.
Committed on 11/08/2015 at 06:03.
Pushed by mqualmann into branch 'frameworks'.

backport commit #b6ef05138531969b771bff59e750aa82340dd268 from git/master to
frameworks branch

M  +10   -1    libs/threadimageio/thumbnailcreator.cpp

http://commits.kde.org/digikam/80f5fa781ddcf3e9033f0ef405d0834a0b74ffe0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=350541

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Thumbs-Image                |FilesIO-PNG

--
You are receiving this mail because:
You are the assignee for the bug.