[digikam] [Bug 349925] New: Fail cmake chek if -DENABLE_KFILEMETADATASUPPORT=ON is not set (frameworks branch)

[Gustavo Alvarez]

https://bugs.kde.org/show_bug.cgi?id=349925

            Bug ID: 349925
           Summary: Fail cmake chek if -DENABLE_KFILEMETADATASUPPORT=ON is
                    not set (frameworks branch)
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

Hi

The build of the latest commit of digikam frameworks branch, fail if
-DENABLE_KFILEMETADATASUPPORT=ON is not set

this is because the path of KF5:FileMetaData target
(http://quickgit.kde.org/?p=digikam.git&a=blob&h=54ea892109720eb259c1f0f6f951b39e4df5ed88&hb=7ba11d3c599b283a81d7c1ca63ff11d26751f12d&f=CMakeLists.txt#l469)
is always set, though the filemetadata support is has enabled or disabled (by
default is disable)

Removing that line and adding it after, with selector like
http://quickgit.kde.org/?p=digikam.git&a=blob&h=54ea892109720eb259c1f0f6f951b39e4df5ed88&hb=7ba11d3c599b283a81d7c1ca63ff11d26751f12d&f=CMakeLists.txt#l484
fixes the problem

then, if set -DENABLE_KFILEMETADATASUPPORT=ON, adds the target path in
KF5_INCLUDES_ALL.  if set to OFF (or not set), then it will not add (by default
not added)

Reproducible: Always

Steps to Reproduce:
1. download the last digikam frameworks branch commit with git
2. try to build without  -DENABLE_KFILEMETADATASUPPORT=ON


Actual Results:  
cmake configure finish with error

Expected Results:  
cmake configure finish ok

the patch:

http://sl1pkn07.wtf/paste/view/raw/2989952a

(the last part if because my kate eats the "useless" spaces)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=349925

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |5.0.0
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=349925

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Fail cmake chek if          |Fail cmake chek if
                   |-DENABLE_KFILEMETADATASUPPO |-DENABLE_KFILEMETADATASUPPO
                   |RT=ON is not set            |RT=ON is not set
                   |(frameworks branch)         |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=349925

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/e583262b5175171df21739f
                   |                            |57bcc2101f986b6b9
   Version Fixed In|                            |5.0.0
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Gilles Caulier <[hidden email]> ---
Git commit e583262b5175171df21739f57bcc2101f986b6b9 by Gilles Caulier.
Committed on 05/07/2015 at 15:32.
Pushed by cgilles into branch 'frameworks'.

fix broken compilation if ENABLE_KFILEMETADATASUPPORT flag is turned on.
FIXED-IN: 5.0.0

M  +13   -7    CMakeLists.txt
M  +2    -1    NEWS

http://commits.kde.org/digikam/e583262b5175171df21739f57bcc2101f986b6b9

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=349925

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Portability

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=349925

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Portability                 |Bundle-Tarball

--
You are receiving this mail because:
You are the assignee for the bug.