[digikam] [Bug 346637] New: Missing support for Media Pro hierarchical keywords

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=346637

            Bug ID: 346637
           Summary: Missing support for Media Pro hierarchical keywords
           Product: digikam
           Version: 4.9.0
          Platform: unspecified
                OS: All
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Metadata
          Assignee: [hidden email]
          Reporter: [hidden email]

Media Pro uses the same format as Lightroom for hierarchical keywords. digikam
already supports reading and writing that format.

Media Pro has changed owners over the years, from iView, to Microsoft, to Phase
One.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=346637

--- Comment #1 from Alan Pater <[hidden email]> ---
I adapted the  LR code in dmetadata.cpp and came up with:

// Read: bool DMetadata::getImageTagsPath(QStringList& tagsPath) const

    // Try to get Tags Path list from Media Pro XMP first.
    tagsPath = getXmpTagStringBag("Xmp.mediapro.CatalogSets", false);

    // There is another Media Pro tag for hierarchical subjects.
    if (tagsPath.isEmpty())
    {
        tagsPath = getXmpTagStringSeq("Xmp.expressionmedia.CatalogSets",
false);
    }

    if (!tagsPath.isEmpty())
    {
        // Media Pro Catalog Sets use '|' as separator.
        tagsPath = tagsPath.replaceInStrings("|", "/");
        kDebug() << "Tags Path imported from Media Pro : " << tagsPath;
        return true;
    }



// Write: bool DMetadata::setImageTagsPath(const QStringList& tagsPath) const

        QStringList MediaProtagsPath = tagsPath;
        MediaProtagsPath             = MediaProtagsPath.replaceInStrings("/",
"|");

        if (!setXmpTagStringBag("Xmp.mediapro.CatalogSets", MediaProtagsPath))
        {
            return false;
        }

I have not tested this as I am still unable to build digikam.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=346637

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Please provide patch against current source code, even if it do not compile.
It's always better than to try to reproduce code as well.

If you have some test images to import/export...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=346637

--- Comment #3 from Alan Pater <[hidden email]> ---
Created attachment 92214
  --> https://bugs.kde.org/attachment.cgi?id=92214&action=edit
XMP sidecar created in Media Pro

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=346637

Alan Pater <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92214|0                           |1
        is obsolete|                            |

--- Comment #4 from Alan Pater <[hidden email]> ---
Created attachment 92215
  --> https://bugs.kde.org/attachment.cgi?id=92215&action=edit
Test image with embedded Media Pro metadata

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=346637

--- Comment #5 from Alan Pater <[hidden email]> ---
Comment on attachment 92215
  --> https://bugs.kde.org/attachment.cgi?id=92215
Test image with embedded Media Pro metadata

Non-standard properties written by Media Pro:

Xmp.mediapro.Event                           XmpText    15  Media Pro Event
Xmp.mediapro.People                          XmpBag      4  Media Pro People,
Alan Pater, Gilles Caulier, Robin Mills
Xmp.mediapro.CatalogSets                     XmpBag      3  0000|1111|2222,
aaaa|bbbb|ccc, aaaa|bbbb|cccc|dddd|eeee|fff

Xmp.expressionmedia.Event                    XmpText    15  Media Pro Event
Xmp.expressionmedia.People                   XmpBag      4  Media Pro People,
Alan Pater, Gilles Caulier, Robin Mills
Xmp.expressionmedia.CatalogSets              XmpBag      3  0000|1111|2222,
aaaa|bbbb|ccc, aaaa|bbbb|cccc|dddd|eeee|fff

Xmp.iptcExt.Event                            LangAlt     1  lang="x-default"
Media Pro Event
Xmp.iptcExt.PersonInImage                    XmpBag      4  Media Pro People,
Alan Pater, Gilles Caulier, Robin Mills

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=346637

Alan Pater <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Alan Pater <[hidden email]> ---
Created attachment 92217
  --> https://bugs.kde.org/attachment.cgi?id=92217&action=edit
get Media Pro Catalog Sets

Untested. Based on the code to get lr hierarchical keywords.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346637

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Alan,

you use in the patch:

getXmpTagStringSeq ("Xmp.expressionmedia.CatalogSets", false)

I think this is correct:

getXmpTagStringBag ("Xmp.expressionmedia.CatalogSets", false)

Yes?

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Alan Pater]

https://bugs.kde.org/show_bug.cgi?id=346637

--- Comment #8 from Alan Pater <[hidden email]> ---
Maik yes, you are correct. It should be Bag just like the mediapro example.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346637

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Missing support for Media   |Missing support for Media
                   |Pro hierarchical keywords   |Pro hierarchical keywords
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=346637

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.10.0
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/c697e630c4483833a27c96b
                   |                            |b3969c5574af01045

--- Comment #9 from Maik Qualmann <[hidden email]> ---
Git commit c697e630c4483833a27c96bb3969c5574af01045 by Maik Qualmann.
Committed on 05/05/2015 at 16:32.
Pushed by mqualmann into branch 'master'.

apply patch #92217 from Alan Pater to support Media Pro hierarchical keywords
FIXED-IN: 4.10.0

M  +2    -1    NEWS
M  +28   -2    libs/dmetadata/dmetadata.cpp

http://commits.kde.org/digikam/c697e630c4483833a27c96bb3969c5574af01045

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=346637

--- Comment #10 from Gilles Caulier <[hidden email]> ---
Git commit e22fe7e171b4c3aeb9f56b6536892edf4ffd827b by Gilles Caulier.
Committed on 05/05/2015 at 21:26.
Pushed by cgilles into branch 'frameworks'.

backport commit #c697e630c4483833a27c96bb3969c5574af01045 from git/master to
frameworks branch

M  +28   -2    libs/dmetadata/dmetadata.cpp

http://commits.kde.org/digikam/e22fe7e171b4c3aeb9f56b6536892edf4ffd827b

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel